Initial plan

fix: when the Object Lock configuration does not exist, an error message should be returned (#771) (#798)

.github/workflows/ci.yml

@@ -103,6 +103,8 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 60
     steps:
+      - name: Delete huge unnecessary tools folder
+        run: rm -rf /opt/hostedtoolcache
       - name: Checkout repository
         uses: actions/checkout@v5
 

.github/workflows/docker.yml

@@ -162,7 +162,14 @@ jobs:
                 if [[ "$version" == *"alpha"* ]] || [[ "$version" == *"beta"* ]] || [[ "$version" == *"rc"* ]]; then
                   build_type="prerelease"
                   is_prerelease=true
-                  echo "🧪 Building Docker image for prerelease: $version"
+                  # TODO: 临时修改 - 当前允许 alpha 版本也创建 latest 标签
+                  # 等版本稳定后，需要移除下面这行，恢复原有逻辑（只有稳定版本才创建 latest）
+                  if [[ "$version" == *"alpha"* ]]; then
+                    create_latest=true
+                    echo "🧪 Building Docker image for prerelease: $version (临时允许创建 latest 标签)"
+                  else
+                    echo "🧪 Building Docker image for prerelease: $version"
+                  fi
                 else
                   build_type="release"
                   create_latest=true
@@ -208,7 +215,14 @@ jobs:
               v*alpha*|v*beta*|v*rc*|*alpha*|*beta*|*rc*)
                 build_type="prerelease"
                 is_prerelease=true
-                echo "🧪 Building with prerelease version: $input_version"
+                # TODO: 临时修改 - 当前允许 alpha 版本也创建 latest 标签
+                # 等版本稳定后，需要移除下面的 if 块，恢复原有逻辑
+                if [[ "$input_version" == *"alpha"* ]]; then
+                  create_latest=true
+                  echo "🧪 Building with prerelease version: $input_version (临时允许创建 latest 标签)"
+                else
+                  echo "🧪 Building with prerelease version: $input_version"
+                fi
                 ;;
               # Release versions (match after prereleases, more general)
               v[0-9]*|[0-9]*.*.*)
@@ -316,7 +330,9 @@ jobs:
 
           # Add channel tags for prereleases and latest for stable
           if [[ "$CREATE_LATEST" == "true" ]]; then
-            # Stable release
+            # TODO: 临时修改 - 当前 alpha 版本也会创建 latest 标签
+            # 等版本稳定后，这里的逻辑保持不变，但上游的 CREATE_LATEST 设置需要恢复
+            # Stable release (以及临时的 alpha 版本)
             TAGS="$TAGS,${{ env.REGISTRY_DOCKERHUB }}:latest"
           elif [[ "$BUILD_TYPE" == "prerelease" ]]; then
             # Prerelease channel tags (alpha, beta, rc)
@@ -413,7 +429,13 @@ jobs:
             "prerelease")
               echo "🧪 Prerelease Docker image has been built with ${VERSION} tags"
               echo "⚠️  This is a prerelease image - use with caution"
-              echo "🚫 Latest tag NOT created for prerelease"
+              # TODO: 临时修改 - alpha 版本当前会创建 latest 标签
+              # 等版本稳定后，需要恢复下面的提示信息
+              if [[ "$VERSION" == *"alpha"* ]] && [[ "$CREATE_LATEST" == "true" ]]; then
+                echo "🏷️  Latest tag has been created for alpha version (临时措施)"
+              else
+                echo "🚫 Latest tag NOT created for prerelease"
+              fi
               ;;
             *)
               echo "❌ Unexpected build type: $BUILD_TYPE"

.gitignore

@@ -22,4 +22,5 @@ profile.json
 .secrets
 *.go
 *.pb
-*.svg
+*.svg
+deploy/logs/*.log.*

.rules.md

@@ -0,0 +1,702 @@
+# RustFS Project AI Coding Rules
+
+## 🚨🚨🚨 CRITICAL DEVELOPMENT RULES - ZERO TOLERANCE 🚨🚨🚨
+
+### ⛔️ ABSOLUTE PROHIBITION: NEVER COMMIT DIRECTLY TO MASTER/MAIN BRANCH ⛔️
+
+**🔥 THIS IS THE MOST CRITICAL RULE - VIOLATION WILL RESULT IN IMMEDIATE REVERSAL 🔥**
+
+- **🚫 ZERO DIRECT COMMITS TO MAIN/MASTER BRANCH - ABSOLUTELY FORBIDDEN**
+- **🚫 ANY DIRECT COMMIT TO MAIN BRANCH MUST BE IMMEDIATELY REVERTED**
+- **🚫 NO EXCEPTIONS FOR HOTFIXES, EMERGENCIES, OR URGENT CHANGES**
+- **🚫 NO EXCEPTIONS FOR SMALL CHANGES, TYPOS, OR DOCUMENTATION UPDATES**
+- **🚫 NO EXCEPTIONS FOR ANYONE - MAINTAINERS, CONTRIBUTORS, OR ADMINS**
+
+### 📋 MANDATORY WORKFLOW - STRICTLY ENFORCED
+
+**EVERY SINGLE CHANGE MUST FOLLOW THIS WORKFLOW:**
+
+1. **Check current branch**: `git branch` (MUST NOT be on main/master)
+2. **Switch to main**: `git checkout main`
+3. **Pull latest**: `git pull origin main`
+4. **Create feature branch**: `git checkout -b feat/your-feature-name`
+5. **Make changes ONLY on feature branch**
+6. **Test thoroughly before committing**
+7. **Commit and push to feature branch**: `git push origin feat/your-feature-name`
+8. **Create Pull Request**: Use `gh pr create` (MANDATORY)
+9. **Wait for PR approval**: NO self-merging allowed
+10. **Merge through GitHub interface**: ONLY after approval
+
+### 🔒 ENFORCEMENT MECHANISMS
+
+- **Branch protection rules**: Main branch is protected
+- **Pre-commit hooks**: Will block direct commits to main
+- **CI/CD checks**: All PRs must pass before merging
+- **Code review requirement**: At least one approval needed
+- **Automated reversal**: Direct commits to main will be automatically reverted
+
+## 🎯 Core AI Development Principles
+
+### Five Execution Steps
+
+#### 1. Task Analysis and Planning
+- **Clear Objectives**: Deeply understand task requirements and expected results before starting coding
+- **Plan Development**: List specific files, components, and functions that need modification, explaining the reasons for changes
+- **Risk Assessment**: Evaluate the impact of changes on existing functionality, develop rollback plans
+
+#### 2. Precise Code Location
+- **File Identification**: Determine specific files and line numbers that need modification
+- **Impact Analysis**: Avoid modifying irrelevant files, clearly state the reason for each file modification
+- **Minimization Principle**: Unless explicitly required by the task, do not create new abstraction layers or refactor existing code
+
+#### 3. Minimal Code Changes
+- **Focus on Core**: Only write code directly required by the task
+- **Avoid Redundancy**: Do not add unnecessary logs, comments, tests, or error handling
+- **Isolation**: Ensure new code does not interfere with existing functionality, maintain code independence
+
+#### 4. Strict Code Review
+- **Correctness Check**: Verify the correctness and completeness of code logic
+- **Style Consistency**: Ensure code conforms to established project coding style
+- **Side Effect Assessment**: Evaluate the impact of changes on downstream systems
+
+#### 5. Clear Delivery Documentation
+- **Change Summary**: Detailed explanation of all modifications and reasons
+- **File List**: List all modified files and their specific changes
+- **Risk Statement**: Mark any assumptions or potential risk points
+
+### Core Principles
+- **🎯 Precise Execution**: Strictly follow task requirements, no arbitrary innovation
+- **⚡ Efficient Development**: Avoid over-design, only do necessary work
+- **🛡️ Safe and Reliable**: Always follow development processes, ensure code quality and system stability
+- **🔒 Cautious Modification**: Only modify when clearly knowing what needs to be changed and having confidence
+
+### Additional AI Behavior Rules
+
+1. **Use English for all code comments and documentation** - All comments, variable names, function names, documentation, and user-facing text in code should be in English
+2. **Clean up temporary scripts after use** - Any temporary scripts, test files, or helper files created during AI work should be removed after task completion
+3. **Only make confident modifications** - Do not make speculative changes or "convenient" modifications outside the task scope. If uncertain about a change, ask for clarification rather than guessing
+
+## Project Overview
+
+RustFS is a high-performance distributed object storage system written in Rust, compatible with S3 API. The project adopts a modular architecture, supporting erasure coding storage, multi-tenant management, observability, and other enterprise-level features.
+
+## Core Architecture Principles
+
+### 1. Modular Design
+
+- Project uses Cargo workspace structure, containing multiple independent crates
+- Core modules: `rustfs` (main service), `ecstore` (erasure coding storage), `common` (shared components)
+- Functional modules: `iam` (identity management), `madmin` (management interface), `crypto` (encryption), etc.
+- Tool modules: `cli` (command line tool), `crates/*` (utility libraries)
+
+### 2. Asynchronous Programming Pattern
+
+- Comprehensive use of `tokio` async runtime
+- Prioritize `async/await` syntax
+- Use `async-trait` for async methods in traits
+- Avoid blocking operations, use `spawn_blocking` when necessary
+
+### 3. Error Handling Strategy
+
+- **Use modular, type-safe error handling with `thiserror`**
+- Each module should define its own error type using `thiserror::Error` derive macro
+- Support error chains and context information through `#[from]` and `#[source]` attributes
+- Use `Result<T>` type aliases for consistency within each module
+- Error conversion between modules should use explicit `From` implementations
+- Follow the pattern: `pub type Result<T> = core::result::Result<T, Error>`
+- Use `#[error("description")]` attributes for clear error messages
+- Support error downcasting when needed through `other()` helper methods
+- Implement `Clone` for errors when required by the domain logic
+
+## Code Style Guidelines
+
+### 1. Formatting Configuration
+
+```toml
+max_width = 130
+fn_call_width = 90
+single_line_let_else_max_width = 100
+```
+
+### 2. **🔧 MANDATORY Code Formatting Rules**
+
+**CRITICAL**: All code must be properly formatted before committing. This project enforces strict formatting standards to maintain code consistency and readability.
+
+#### Pre-commit Requirements (MANDATORY)
+
+Before every commit, you **MUST**:
+
+1. **Format your code**:
+   ```bash
+   cargo fmt --all
+   ```
+
+2. **Verify formatting**:
+   ```bash
+   cargo fmt --all --check
+   ```
+
+3. **Pass clippy checks**:
+   ```bash
+   cargo clippy --all-targets --all-features -- -D warnings
+   ```
+
+4. **Ensure compilation**:
+   ```bash
+   cargo check --all-targets
+   ```
+
+#### Quick Commands
+
+Use these convenient Makefile targets for common tasks:
+
+```bash
+# Format all code
+make fmt
+
+# Check if code is properly formatted
+make fmt-check
+
+# Run clippy checks
+make clippy
+
+# Run compilation check
+make check
+
+# Run tests
+make test
+
+# Run all pre-commit checks (format + clippy + check + test)
+make pre-commit
+
+# Setup git hooks (one-time setup)
+make setup-hooks
+```
+
+### 3. Naming Conventions
+
+- Use `snake_case` for functions, variables, modules
+- Use `PascalCase` for types, traits, enums
+- Constants use `SCREAMING_SNAKE_CASE`
+- Global variables prefix `GLOBAL_`, e.g., `GLOBAL_Endpoints`
+- Use meaningful and descriptive names for variables, functions, and methods
+- Avoid meaningless names like `temp`, `data`, `foo`, `bar`, `test123`
+- Choose names that clearly express the purpose and intent
+
+### 4. Type Declaration Guidelines
+
+- **Prefer type inference over explicit type declarations** when the type is obvious from context
+- Let the Rust compiler infer types whenever possible to reduce verbosity and improve maintainability
+- Only specify types explicitly when:
+  - The type cannot be inferred by the compiler
+  - Explicit typing improves code clarity and readability
+  - Required for API boundaries (function signatures, public struct fields)
+  - Needed to resolve ambiguity between multiple possible types
+
+### 5. Documentation Comments
+
+- Public APIs must have documentation comments
+- Use `///` for documentation comments
+- Complex functions add `# Examples` and `# Parameters` descriptions
+- Error cases use `# Errors` descriptions
+- Always use English for all comments and documentation
+- Avoid meaningless comments like "debug 111" or placeholder text
+
+### 6. Import Guidelines
+
+- Standard library imports first
+- Third-party crate imports in the middle
+- Project internal imports last
+- Group `use` statements with blank lines between groups
+
+## Asynchronous Programming Guidelines
+
+### 1. Trait Definition
+
+```rust
+#[async_trait::async_trait]
+pub trait StorageAPI: Send + Sync {
+    async fn get_object(&self, bucket: &str, object: &str) -> Result<ObjectInfo>;
+}
+```
+
+### 2. Error Handling
+
+```rust
+// Use ? operator to propagate errors
+async fn example_function() -> Result<()> {
+    let data = read_file("path").await?;
+    process_data(data).await?;
+    Ok(())
+}
+```
+
+### 3. Concurrency Control
+
+- Use `Arc` and `Mutex`/`RwLock` for shared state management
+- Prioritize async locks from `tokio::sync`
+- Avoid holding locks for long periods
+
+## Logging and Tracing Guidelines
+
+### 1. Tracing Usage
+
+```rust
+#[tracing::instrument(skip(self, data))]
+async fn process_data(&self, data: &[u8]) -> Result<()> {
+    info!("Processing {} bytes", data.len());
+    // Implementation logic
+}
+```
+
+### 2. Log Levels
+
+- `error!`: System errors requiring immediate attention
+- `warn!`: Warning information that may affect functionality
+- `info!`: Important business information
+- `debug!`: Debug information for development use
+- `trace!`: Detailed execution paths
+
+### 3. Structured Logging
+
+```rust
+info!(
+    counter.rustfs_api_requests_total = 1_u64,
+    key_request_method = %request.method(),
+    key_request_uri_path = %request.uri().path(),
+    "API request processed"
+);
+```
+
+## Error Handling Guidelines
+
+### 1. Error Type Definition
+
+```rust
+// Use thiserror for module-specific error types
+#[derive(thiserror::Error, Debug)]
+pub enum MyError {
+    #[error("IO error: {0}")]
+    Io(#[from] std::io::Error),
+
+    #[error("Storage error: {0}")]
+    Storage(#[from] ecstore::error::StorageError),
+
+    #[error("Custom error: {message}")]
+    Custom { message: String },
+
+    #[error("File not found: {path}")]
+    FileNotFound { path: String },
+
+    #[error("Invalid configuration: {0}")]
+    InvalidConfig(String),
+}
+
+// Provide Result type alias for the module
+pub type Result<T> = core::result::Result<T, MyError>;
+```
+
+### 2. Error Helper Methods
+
+```rust
+impl MyError {
+    /// Create error from any compatible error type
+    pub fn other<E>(error: E) -> Self
+    where
+        E: Into<Box<dyn std::error::Error + Send + Sync>>,
+    {
+        MyError::Io(std::io::Error::other(error))
+    }
+}
+```
+
+### 3. Error Context and Propagation
+
+```rust
+// Use ? operator for clean error propagation
+async fn example_function() -> Result<()> {
+    let data = read_file("path").await?;
+    process_data(data).await?;
+    Ok(())
+}
+
+// Add context to errors
+fn process_with_context(path: &str) -> Result<()> {
+    std::fs::read(path)
+        .map_err(|e| MyError::Custom {
+            message: format!("Failed to read {}: {}", path, e)
+        })?;
+    Ok(())
+}
+```
+
+## Performance Optimization Guidelines
+
+### 1. Memory Management
+
+- Use `Bytes` instead of `Vec<u8>` for zero-copy operations
+- Avoid unnecessary cloning, use reference passing
+- Use `Arc` for sharing large objects
+
+### 2. Concurrency Optimization
+
+```rust
+// Use join_all for concurrent operations
+let futures = disks.iter().map(|disk| disk.operation());
+let results = join_all(futures).await;
+```
+
+### 3. Caching Strategy
+
+- Use `LazyLock` for global caching
+- Implement LRU cache to avoid memory leaks
+
+## Testing Guidelines
+
+### 1. Unit Tests
+
+```rust
+#[cfg(test)]
+mod tests {
+    use super::*;
+    use test_case::test_case;
+
+    #[tokio::test]
+    async fn test_async_function() {
+        let result = async_function().await;
+        assert!(result.is_ok());
+    }
+
+    #[test_case("input1", "expected1")]
+    #[test_case("input2", "expected2")]
+    fn test_with_cases(input: &str, expected: &str) {
+        assert_eq!(function(input), expected);
+    }
+}
+```
+
+### 2. Integration Tests
+
+- Use `e2e_test` module for end-to-end testing
+- Simulate real storage environments
+
+### 3. Test Quality Standards
+
+- Write meaningful test cases that verify actual functionality
+- Avoid placeholder or debug content like "debug 111", "test test", etc.
+- Use descriptive test names that clearly indicate what is being tested
+- Each test should have a clear purpose and verify specific behavior
+- Test data should be realistic and representative of actual use cases
+
+## Cross-Platform Compatibility Guidelines
+
+### 1. CPU Architecture Compatibility
+
+- **Always consider multi-platform and different CPU architecture compatibility** when writing code
+- Support major architectures: x86_64, aarch64 (ARM64), and other target platforms
+- Use conditional compilation for architecture-specific code:
+
+```rust
+#[cfg(target_arch = "x86_64")]
+fn optimized_x86_64_function() { /* x86_64 specific implementation */ }
+
+#[cfg(target_arch = "aarch64")]
+fn optimized_aarch64_function() { /* ARM64 specific implementation */ }
+
+#[cfg(not(any(target_arch = "x86_64", target_arch = "aarch64")))]
+fn generic_function() { /* Generic fallback implementation */ }
+```
+
+### 2. Platform-Specific Dependencies
+
+- Use feature flags for platform-specific dependencies
+- Provide fallback implementations for unsupported platforms
+- Test on multiple architectures in CI/CD pipeline
+
+### 3. Endianness Considerations
+
+- Use explicit byte order conversion when dealing with binary data
+- Prefer `to_le_bytes()`, `from_le_bytes()` for consistent little-endian format
+- Use `byteorder` crate for complex binary format handling
+
+### 4. SIMD and Performance Optimizations
+
+- Use portable SIMD libraries like `wide` or `packed_simd`
+- Provide fallback implementations for non-SIMD architectures
+- Use runtime feature detection when appropriate
+
+## Security Guidelines
+
+### 1. Memory Safety
+
+- Disable `unsafe` code (workspace.lints.rust.unsafe_code = "deny")
+- Use `rustls` instead of `openssl`
+
+### 2. Authentication and Authorization
+
+```rust
+// Use IAM system for permission checks
+let identity = iam.authenticate(&access_key, &secret_key).await?;
+iam.authorize(&identity, &action, &resource).await?;
+```
+
+## Configuration Management Guidelines
+
+### 1. Environment Variables
+
+- Use `RUSTFS_` prefix
+- Support both configuration files and environment variables
+- Provide reasonable default values
+
+### 2. Configuration Structure
+
+```rust
+#[derive(Debug, Deserialize, Clone)]
+pub struct Config {
+    pub address: String,
+    pub volumes: String,
+    #[serde(default)]
+    pub console_enable: bool,
+}
+```
+
+## Dependency Management Guidelines
+
+### 1. Workspace Dependencies
+
+- Manage versions uniformly at workspace level
+- Use `workspace = true` to inherit configuration
+
+### 2. Feature Flags
+
+```rust
+[features]
+default = ["file"]
+gpu = ["dep:nvml-wrapper"]
+kafka = ["dep:rdkafka"]
+```
+
+## Deployment and Operations Guidelines
+
+### 1. Containerization
+
+- Provide Dockerfile and docker-compose configuration
+- Support multi-stage builds to optimize image size
+
+### 2. Observability
+
+- Integrate OpenTelemetry for distributed tracing
+- Support Prometheus metrics collection
+- Provide Grafana dashboards
+
+### 3. Health Checks
+
+```rust
+// Implement health check endpoint
+async fn health_check() -> Result<HealthStatus> {
+    // Check component status
+}
+```
+
+## Code Review Checklist
+
+### 1. **Code Formatting and Quality (MANDATORY)**
+
+- [ ] **Code is properly formatted** (`cargo fmt --all --check` passes)
+- [ ] **All clippy warnings are resolved** (`cargo clippy --all-targets --all-features -- -D warnings` passes)
+- [ ] **Code compiles successfully** (`cargo check --all-targets` passes)
+- [ ] **Pre-commit hooks are working** and all checks pass
+- [ ] **No formatting-related changes** mixed with functional changes (separate commits)
+
+### 2. Functionality
+
+- [ ] Are all error cases properly handled?
+- [ ] Is there appropriate logging?
+- [ ] Is there necessary test coverage?
+
+### 3. Performance
+
+- [ ] Are unnecessary memory allocations avoided?
+- [ ] Are async operations used correctly?
+- [ ] Are there potential deadlock risks?
+
+### 4. Security
+
+- [ ] Are input parameters properly validated?
+- [ ] Are there appropriate permission checks?
+- [ ] Is information leakage avoided?
+
+### 5. Cross-Platform Compatibility
+
+- [ ] Does the code work on different CPU architectures (x86_64, aarch64)?
+- [ ] Are platform-specific features properly gated with conditional compilation?
+- [ ] Is byte order handling correct for binary data?
+- [ ] Are there appropriate fallback implementations for unsupported platforms?
+
+### 6. Code Commits and Documentation
+
+- [ ] Does it comply with [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/)?
+- [ ] Are commit messages concise and under 72 characters for the title line?
+- [ ] Commit titles should be concise and in English, avoid Chinese
+- [ ] Is PR description provided in copyable markdown format for easy copying?
+
+## Common Patterns and Best Practices
+
+### 1. Resource Management
+
+```rust
+// Use RAII pattern for resource management
+pub struct ResourceGuard {
+    resource: Resource,
+}
+
+impl Drop for ResourceGuard {
+    fn drop(&mut self) {
+        // Clean up resources
+    }
+}
+```
+
+### 2. Dependency Injection
+
+```rust
+// Use dependency injection pattern
+pub struct Service {
+    config: Arc<Config>,
+    storage: Arc<dyn StorageAPI>,
+}
+```
+
+### 3. Graceful Shutdown
+
+```rust
+// Implement graceful shutdown
+async fn shutdown_gracefully(shutdown_rx: &mut Receiver<()>) {
+    tokio::select! {
+        _ = shutdown_rx.recv() => {
+            info!("Received shutdown signal");
+            // Perform cleanup operations
+        }
+        _ = tokio::time::sleep(SHUTDOWN_TIMEOUT) => {
+            warn!("Shutdown timeout reached");
+        }
+    }
+}
+```
+
+## Domain-Specific Guidelines
+
+### 1. Storage Operations
+
+- All storage operations must support erasure coding
+- Implement read/write quorum mechanisms
+- Support data integrity verification
+
+### 2. Network Communication
+
+- Use gRPC for internal service communication
+- HTTP/HTTPS support for S3-compatible API
+- Implement connection pooling and retry mechanisms
+
+### 3. Metadata Management
+
+- Use FlatBuffers for serialization
+- Support version control and migration
+- Implement metadata caching
+
+## Branch Management and Development Workflow
+
+### Branch Management
+
+- **🚨 CRITICAL: NEVER modify code directly on main or master branch - THIS IS ABSOLUTELY FORBIDDEN 🚨**
+- **⚠️ ANY DIRECT COMMITS TO MASTER/MAIN WILL BE REJECTED AND MUST BE REVERTED IMMEDIATELY ⚠️**
+- **🔒 ALL CHANGES MUST GO THROUGH PULL REQUESTS - NO DIRECT COMMITS TO MAIN UNDER ANY CIRCUMSTANCES 🔒**
+- **Always work on feature branches - NO EXCEPTIONS**
+- Always check the .rules.md file before starting to ensure you understand the project guidelines
+- **MANDATORY workflow for ALL changes:**
+   1. `git checkout main` (switch to main branch)
+   2. `git pull` (get latest changes)
+   3. `git checkout -b feat/your-feature-name` (create and switch to feature branch)
+   4. Make your changes ONLY on the feature branch
+   5. Test thoroughly before committing
+   6. Commit and push to the feature branch
+   7. **Create a pull request for code review - THIS IS THE ONLY WAY TO MERGE TO MAIN**
+   8. **Wait for PR approval before merging - NEVER merge your own PRs without review**
+- Use descriptive branch names following the pattern: `feat/feature-name`, `fix/issue-name`, `refactor/component-name`, etc.
+- **Double-check current branch before ANY commit: `git branch` to ensure you're NOT on main/master**
+- **Pull Request Requirements:**
+  - All changes must be submitted via PR regardless of size or urgency
+  - PRs must include comprehensive description and testing information
+  - PRs must pass all CI/CD checks before merging
+  - PRs require at least one approval from code reviewers
+  - Even hotfixes and emergency changes must go through PR process
+- **Enforcement:**
+  - Main branch should be protected with branch protection rules
+  - Direct pushes to main should be blocked by repository settings
+  - Any accidental direct commits to main must be immediately reverted via PR
+
+### Development Workflow
+
+## 🎯 **Core Development Principles**
+
+- **🔴 Every change must be precise - don't modify unless you're confident**
+  - Carefully analyze code logic and ensure complete understanding before making changes
+  - When uncertain, prefer asking users or consulting documentation over blind modifications
+  - Use small iterative steps, modify only necessary parts at a time
+  - Evaluate impact scope before changes to ensure no new issues are introduced
+
+- **🚀 GitHub PR creation prioritizes gh command usage**
+  - Prefer using `gh pr create` command to create Pull Requests
+  - Avoid having users manually create PRs through web interface
+  - Provide clear and professional PR titles and descriptions
+  - Using `gh` commands ensures better integration and automation
+
+## 📝 **Code Quality Requirements**
+
+- Use English for all code comments, documentation, and variable names
+- Write meaningful and descriptive names for variables, functions, and methods
+- Avoid meaningless test content like "debug 111" or placeholder values
+- Before each change, carefully read the existing code to ensure you understand the code structure and implementation, do not break existing logic implementation, do not introduce new issues
+- Ensure each change provides sufficient test cases to guarantee code correctness
+- Do not arbitrarily modify numbers and constants in test cases, carefully analyze their meaning to ensure test case correctness
+- When writing or modifying tests, check existing test cases to ensure they have scientific naming and rigorous logic testing, if not compliant, modify test cases to ensure scientific and rigorous testing
+- **Before committing any changes, run `cargo clippy --all-targets --all-features -- -D warnings` to ensure all code passes Clippy checks**
+- After each development completion, first git add . then git commit -m "feat: feature description" or "fix: issue description", ensure compliance with [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/)
+- **Keep commit messages concise and under 72 characters** for the title line, use body for detailed explanations if needed
+- After each development completion, first git push to remote repository
+- After each change completion, summarize the changes, do not create summary files, provide a brief change description, ensure compliance with [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/)
+- Provide change descriptions needed for PR in the conversation, ensure compliance with [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/)
+- **Always provide PR descriptions in English** after completing any changes, including:
+  - Clear and concise title following Conventional Commits format
+  - Detailed description of what was changed and why
+  - List of key changes and improvements
+  - Any breaking changes or migration notes if applicable
+  - Testing information and verification steps
+- **Provide PR descriptions in copyable markdown format** enclosed in code blocks for easy one-click copying
+
+## 🚫 AI Documentation Generation Restrictions
+
+### Forbidden Summary Documents
+
+- **Strictly forbidden to create any form of AI-generated summary documents**
+- **Do not create documents containing large amounts of emoji, detailed formatting tables and typical AI style**
+- **Do not generate the following types of documents in the project:**
+  - Benchmark summary documents (BENCHMARK*.md)
+  - Implementation comparison analysis documents (IMPLEMENTATION_COMPARISON*.md)
+  - Performance analysis report documents
+  - Architecture summary documents
+  - Feature comparison documents
+  - Any documents with large amounts of emoji and formatted content
+- **If documentation is needed, only create when explicitly requested by the user, and maintain a concise and practical style**
+- **Documentation should focus on actually needed information, avoiding excessive formatting and decorative content**
+- **Any discovered AI-generated summary documents should be immediately deleted**
+
+### Allowed Documentation Types
+
+- README.md (project introduction, keep concise)
+- Technical documentation (only create when explicitly needed)
+- User manual (only create when explicitly needed)
+- API documentation (generated from code)
+- Changelog (CHANGELOG.md)
+
+These rules should serve as guiding principles when developing the RustFS project, ensuring code quality, performance, and maintainability.

.vscode/launch.json

@@ -20,7 +20,10 @@
                 }
             },
             "env": {
-                "RUST_LOG": "rustfs=debug,ecstore=info,s3s=debug,iam=info"
+                "RUST_LOG": "rustfs=debug,ecstore=info,s3s=debug,iam=debug",
+                "RUSTFS_SKIP_BACKGROUND_TASK": "on",
+                // "RUSTFS_POLICY_PLUGIN_URL":"http://localhost:8181/v1/data/rustfs/authz/allow",
+                // "RUSTFS_POLICY_PLUGIN_AUTH_TOKEN":"your-opa-token" 
             },
             "args": [
                 "--access-key",
@@ -29,6 +32,8 @@
                 "rustfsadmin",
                 "--address",
                 "0.0.0.0:9010",
+                "--server-domains",
+                "127.0.0.1:9010",
                 "./target/volume/test{1...4}"
             ],
             "cwd": "${workspaceFolder}"
@@ -88,8 +93,15 @@
             "name": "Debug executable target/debug/test",
             "type":  "lldb",
             "request": "launch",
-            "program": "${workspaceFolder}/target/debug/deps/lifecycle_integration_test-5eb7590b8f3bea55",
-            "args": [],
+            "program": "${workspaceFolder}/target/debug/deps/lifecycle_integration_test-5915cbfcab491b3b",
+            "args": [
+              "--skip",
+              "test_lifecycle_expiry_basic",
+              "--skip",
+              "test_lifecycle_expiry_deletemarker",
+              //"--skip",
+              //"test_lifecycle_transition_basic",
+            ],
             "cwd": "${workspaceFolder}",
             //"stopAtEntry": false,
             //"preLaunchTask": "cargo build",

AGENTS.md

@@ -1,618 +1,24 @@
-# RustFS Project AI Agents Rules
+# Repository Guidelines
 
-## 🚨🚨🚨 CRITICAL DEVELOPMENT RULES - ZERO TOLERANCE 🚨🚨🚨
+## Communication Rules
+- Respond to the user in Chinese; use English in all other contexts.
 
-### ⛔️ ABSOLUTE PROHIBITION: NEVER COMMIT DIRECTLY TO MASTER/MAIN BRANCH ⛔️
+## Project Structure & Module Organization
+The workspace root hosts shared dependencies in `Cargo.toml`. The service binary lives under `rustfs/src/main.rs`, while reusable crates sit in `crates/` (`crypto`, `iam`, `kms`, and `e2e_test`). Local fixtures for standalone flows reside in `test_standalone/`, deployment manifests are under `deploy/`, Docker assets sit at the root, and automation lives in `scripts/`. Skim each crate’s README or module docs before contributing changes.
 
-**🔥 THIS IS THE MOST CRITICAL RULE - VIOLATION WILL RESULT IN IMMEDIATE REVERSAL 🔥**
+## Build, Test, and Development Commands
+Run `cargo check --all-targets` for fast validation. Build release binaries via `cargo build --release` or the pipeline-aligned `make build`. Use `./build-rustfs.sh --dev` for iterative development and `./build-rustfs.sh --platform <target>` for cross-compiles. Prefer `make pre-commit` before pushing to cover formatting, clippy, checks, and tests.
+Always ensure `cargo fmt --all --check`, `cargo test --workspace --exclude e2e_test`, and `cargo clippy --all-targets --all-features -- -D warnings` complete successfully after each code change to keep the tree healthy and warning-free.
 
-- **🚫 ZERO DIRECT COMMITS TO MAIN/MASTER BRANCH - ABSOLUTELY FORBIDDEN**
-- **🚫 ANY DIRECT COMMIT TO MAIN BRANCH MUST BE IMMEDIATELY REVERTED**
-- **🚫 NO EXCEPTIONS FOR HOTFIXES, EMERGENCIES, OR URGENT CHANGES**
-- **🚫 NO EXCEPTIONS FOR SMALL CHANGES, TYPOS, OR DOCUMENTATION UPDATES**
-- **🚫 NO EXCEPTIONS FOR ANYONE - MAINTAINERS, CONTRIBUTORS, OR ADMINS**
-
-### 📋 MANDATORY WORKFLOW - STRICTLY ENFORCED
-
-**EVERY SINGLE CHANGE MUST FOLLOW THIS WORKFLOW:**
-
-1. **Check current branch**: `git branch` (MUST NOT be on main/master)
-2. **Switch to main**: `git checkout main`
-3. **Pull latest**: `git pull origin main`
-4. **Create feature branch**: `git checkout -b feat/your-feature-name`
-5. **Make changes ONLY on feature branch**
-6. **Test thoroughly before committing**
-7. **Commit and push to feature branch**: `git push origin feat/your-feature-name`
-8. **Create Pull Request**: Use `gh pr create` (MANDATORY)
-9. **Wait for PR approval**: NO self-merging allowed
-10. **Merge through GitHub interface**: ONLY after approval
-
-### 🔒 ENFORCEMENT MECHANISMS
-
-- **Branch protection rules**: Main branch is protected
-- **Pre-commit hooks**: Will block direct commits to main
-- **CI/CD checks**: All PRs must pass before merging
-- **Code review requirement**: At least one approval needed
-- **Automated reversal**: Direct commits to main will be automatically reverted
-
-## 🎯 Core Development Principles (HIGHEST PRIORITY)
-
-### Philosophy
-
-#### Core Beliefs
-
-- **Incremental progress over big bangs** - Small changes that compile and pass tests
-- **Learning from existing code** - Study and plan before implementing
-- **Pragmatic over dogmatic** - Adapt to project reality
-- **Clear intent over clever code** - Be boring and obvious
-
-#### Simplicity Means
-
-- Single responsibility per function/class
-- Avoid premature abstractions
-- No clever tricks - choose the boring solution
-- If you need to explain it, it's too complex
-
-### Process
-
-#### 1. Planning & Staging
-
-Break complex work into 3-5 stages. Document in `IMPLEMENTATION_PLAN.md`:
-
-```markdown
-## Stage N: [Name]
-**Goal**: [Specific deliverable]
-**Success Criteria**: [Testable outcomes]
-**Tests**: [Specific test cases]
-**Status**: [Not Started|In Progress|Complete]
-```
-
-- Update status as you progress
-- Remove file when all stages are done
-
-#### 2. Implementation Flow
-
-1. **Understand** - Study existing patterns in codebase
-2. **Test** - Write test first (red)
-3. **Implement** - Minimal code to pass (green)
-4. **Refactor** - Clean up with tests passing
-5. **Commit** - With clear message linking to plan
-
-#### 3. When Stuck (After 3 Attempts)
-
-**CRITICAL**: Maximum 3 attempts per issue, then STOP.
-
-1. **Document what failed**:
-   - What you tried
-   - Specific error messages
-   - Why you think it failed
-
-2. **Research alternatives**:
-   - Find 2-3 similar implementations
-   - Note different approaches used
-
-3. **Question fundamentals**:
-   - Is this the right abstraction level?
-   - Can this be split into smaller problems?
-   - Is there a simpler approach entirely?
-
-4. **Try different angle**:
-   - Different library/framework feature?
-   - Different architectural pattern?
-   - Remove abstraction instead of adding?
-
-### Technical Standards
-
-#### Architecture Principles
-
-- **Composition over inheritance** - Use dependency injection
-- **Interfaces over singletons** - Enable testing and flexibility
-- **Explicit over implicit** - Clear data flow and dependencies
-- **Test-driven when possible** - Never disable tests, fix them
-
-#### Code Quality
-
-- **Every commit must**:
-  - Compile successfully
-  - Pass all existing tests
-  - Include tests for new functionality
-  - Follow project formatting/linting
-
-- **Before committing**:
-  - Run formatters/linters
-  - Self-review changes
-  - Ensure commit message explains "why"
-
-#### Error Handling
-
-- Fail fast with descriptive messages
-- Include context for debugging
-- Handle errors at appropriate level
-- Never silently swallow exceptions
-
-### Decision Framework
-
-When multiple valid approaches exist, choose based on:
-
-1. **Testability** - Can I easily test this?
-2. **Readability** - Will someone understand this in 6 months?
-3. **Consistency** - Does this match project patterns?
-4. **Simplicity** - Is this the simplest solution that works?
-5. **Reversibility** - How hard to change later?
-
-### Project Integration
-
-#### Learning the Codebase
-
-- Find 3 similar features/components
-- Identify common patterns and conventions
-- Use same libraries/utilities when possible
-- Follow existing test patterns
-
-#### Tooling
-
-- Use project's existing build system
-- Use project's test framework
-- Use project's formatter/linter settings
-- Don't introduce new tools without strong justification
-
-### Quality Gates
-
-#### Definition of Done
-
-- [ ] Tests written and passing
-- [ ] Code follows project conventions
-- [ ] No linter/formatter warnings
-- [ ] Commit messages are clear
-- [ ] Implementation matches plan
-- [ ] No TODOs without issue numbers
-
-#### Test Guidelines
-
-- Test behavior, not implementation
-- One assertion per test when possible
-- Clear test names describing scenario
-- Use existing test utilities/helpers
-- Tests should be deterministic
-
-### Important Reminders
-
-**NEVER**:
-
-- Use `--no-verify` to bypass commit hooks
-- Disable tests instead of fixing them
-- Commit code that doesn't compile
-- Make assumptions - verify with existing code
-
-**ALWAYS**:
-
-- Commit working code incrementally
-- Update plan documentation as you go
-- Learn from existing implementations
-- Stop after 3 failed attempts and reassess
-
-## 🚫 Competitor Keywords Prohibition
-
-### Strictly Forbidden Keywords
-
-**CRITICAL**: The following competitor keywords are absolutely forbidden in any code, documentation, comments, or project files:
-
-- **minio** (and any variations like MinIO, MINIO)
-- **aws-s3** (when referring to competing implementations)
-- **ceph** (and any variations like Ceph, CEPH)
-- **swift** (OpenStack Swift)
-- **glusterfs** (and any variations like GlusterFS, Gluster)
-- **seaweedfs** (and any variations like SeaweedFS, Seaweed)
-- **garage** (and any variations like Garage)
-- **zenko** (and any variations like Zenko)
-- **scality** (and any variations like Scality)
-
-### Enforcement
-
-- **Code Review**: All PRs will be checked for competitor keywords
-- **Automated Scanning**: CI/CD pipeline will scan for forbidden keywords
-- **Immediate Rejection**: Any PR containing competitor keywords will be immediately rejected
-- **Documentation**: All documentation must use generic terms like "S3-compatible storage" instead of specific competitor names
-
-### Acceptable Alternatives
-
-Instead of competitor names, use these generic terms:
-
-- "S3-compatible storage system"
-- "Object storage solution"
-- "Distributed storage platform"
-- "Cloud storage service"
-- "Storage backend"
-
-## Project Overview
-
-RustFS is a high-performance distributed object storage system written in Rust, compatible with S3 API. The project adopts a modular architecture, supporting erasure coding storage, multi-tenant management, observability, and other enterprise-level features.
-
-## Core Architecture Principles
-
-### 1. Modular Design
-
-- Project uses Cargo workspace structure, containing multiple independent crates
-- Core modules: `rustfs` (main service), `ecstore` (erasure coding storage), `common` (shared components)
-- Functional modules: `iam` (identity management), `madmin` (management interface), `crypto` (encryption), etc.
-- Tool modules: `cli` (command line tool), `crates/*` (utility libraries)
-
-### 2. Asynchronous Programming Pattern
-
-- Comprehensive use of `tokio` async runtime
-- Prioritize `async/await` syntax
-- Use `async-trait` for async methods in traits
-- Avoid blocking operations, use `spawn_blocking` when necessary
-
-### 3. Error Handling Strategy
-
-- **Use modular, type-safe error handling with `thiserror`**
-- Each module should define its own error type using `thiserror::Error` derive macro
-- Support error chains and context information through `#[from]` and `#[source]` attributes
-- Use `Result<T>` type aliases for consistency within each module
-- Error conversion between modules should use explicit `From` implementations
-- Follow the pattern: `pub type Result<T> = core::result::Result<T, Error>`
-- Use `#[error("description")]` attributes for clear error messages
-- Support error downcasting when needed through `other()` helper methods
-- Implement `Clone` for errors when required by the domain logic
-
-## Code Style Guidelines
-
-### 1. Formatting Configuration
-
-```toml
-max_width = 130
-fn_call_width = 90
-single_line_let_else_max_width = 100
-```
-
-### 2. **🔧 MANDATORY Code Formatting Rules**
-
-**CRITICAL**: All code must be properly formatted before committing. This project enforces strict formatting standards to maintain code consistency and readability.
-
-#### Pre-commit Requirements (MANDATORY)
-
-Before every commit, you **MUST**:
-
-1. **Format your code**:
-
-   ```bash
-   cargo fmt --all
-   ```
-
-2. **Verify formatting**:
-
-   ```bash
-   cargo fmt --all --check
-   ```
-
-3. **Pass clippy checks**:
-
-   ```bash
-   cargo clippy --all-targets --all-features -- -D warnings
-   ```
-
-4. **Ensure compilation**:
-
-   ```bash
-   cargo check --all-targets
-   ```
-
-#### Quick Commands
-
-Use these convenient Makefile targets for common tasks:
-
-```bash
-# Format all code
-make fmt
-
-# Check if code is properly formatted
-make fmt-check
-
-# Run clippy checks
-make clippy
-
-# Run compilation check
-make check
-
-# Run tests
-make test
-
-# Run all pre-commit checks (format + clippy + check + test)
-make pre-commit
-
-# Setup git hooks (one-time setup)
-make setup-hooks
-```
-
-### 3. Naming Conventions
-
-- Use `snake_case` for functions, variables, modules
-- Use `PascalCase` for types, traits, enums
-- Constants use `SCREAMING_SNAKE_CASE`
-- Global variables prefix `GLOBAL_`, e.g., `GLOBAL_Endpoints`
-- Use meaningful and descriptive names for variables, functions, and methods
-- Avoid meaningless names like `temp`, `data`, `foo`, `bar`, `test123`
-- Choose names that clearly express the purpose and intent
-
-### 4. Type Declaration Guidelines
-
-- **Prefer type inference over explicit type declarations** when the type is obvious from context
-- Let the Rust compiler infer types whenever possible to reduce verbosity and improve maintainability
-- Only specify types explicitly when:
-  - The type cannot be inferred by the compiler
-  - Explicit typing improves code clarity and readability
-  - Required for API boundaries (function signatures, public struct fields)
-  - Needed to resolve ambiguity between multiple possible types
-
-### 5. Documentation Comments
-
-- Public APIs must have documentation comments
-- Use `///` for documentation comments
-- Complex functions add `# Examples` and `# Parameters` descriptions
-- Error cases use `# Errors` descriptions
-- Always use English for all comments and documentation
-- Avoid meaningless comments like "debug 111" or placeholder text
-
-### 6. Import Guidelines
-
-- Standard library imports first
-- Third-party crate imports in the middle
-- Project internal imports last
-- Group `use` statements with blank lines between groups
-
-## Asynchronous Programming Guidelines
-
-- Comprehensive use of `tokio` async runtime
-- Prioritize `async/await` syntax
-- Use `async-trait` for async methods in traits
-- Avoid blocking operations, use `spawn_blocking` when necessary
-- Use `Arc` and `Mutex`/`RwLock` for shared state management
-- Prioritize async locks from `tokio::sync`
-- Avoid holding locks for long periods
-
-## Logging and Tracing Guidelines
-
-- Use `#[tracing::instrument(skip(self, data))]` for function tracing
-- Log levels: `error!` (system errors), `warn!` (warnings), `info!` (business info), `debug!` (development), `trace!` (detailed paths)
-- Use structured logging with key-value pairs for better observability
-
-## Error Handling Guidelines
-
-- Use `thiserror` for module-specific error types
-- Support error chains and context information through `#[from]` and `#[source]` attributes
-- Use `Result<T>` type aliases for consistency within each module
-- Error conversion between modules should use explicit `From` implementations
-- Follow the pattern: `pub type Result<T> = core::result::Result<T, Error>`
-- Use `#[error("description")]` attributes for clear error messages
-- Support error downcasting when needed through `other()` helper methods
-- Implement `Clone` for errors when required by the domain logic
-
-## Performance Optimization Guidelines
-
-- Use `Bytes` instead of `Vec<u8>` for zero-copy operations
-- Avoid unnecessary cloning, use reference passing
-- Use `Arc` for sharing large objects
-- Use `join_all` for concurrent operations
-- Use `LazyLock` for global caching
-- Implement LRU cache to avoid memory leaks
+## Coding Style & Naming Conventions
+Formatting follows the repo `rustfmt.toml` (130-column width). Use `snake_case` for items, `PascalCase` for types, and `SCREAMING_SNAKE_CASE` for constants. Avoid `unwrap()` or `expect()` outside tests; bubble errors with `Result` and crate-specific `thiserror` types. Keep async code non-blocking and offload CPU-heavy work with `tokio::task::spawn_blocking` when necessary.
 
 ## Testing Guidelines
+Co-locate unit tests with their modules and give behavior-led names such as `handles_expired_token`. Integration suites belong in each crate’s `tests/` directory, while exhaustive end-to-end scenarios live in `crates/e2e_test/`. Run `cargo test --workspace --exclude e2e_test` during iteration, `cargo nextest run --all --exclude e2e_test` when available, and finish with `cargo test --all` before requesting review. Use `NO_PROXY=127.0.0.1,localhost HTTP_PROXY= HTTPS_PROXY=` for KMS e2e tests.
+When fixing bugs or adding features, include regression tests that capture the new behavior so future changes cannot silently break it.
 
-- Write meaningful test cases that verify actual functionality
-- Avoid placeholder or debug content like "debug 111", "test test", etc.
-- Use descriptive test names that clearly indicate what is being tested
-- Each test should have a clear purpose and verify specific behavior
-- Test data should be realistic and representative of actual use cases
-- Use `e2e_test` module for end-to-end testing
-- Simulate real storage environments
+## Commit & Pull Request Guidelines
+Work on feature branches (e.g., `feat/...`) after syncing `main`. Follow Conventional Commits under 72 characters (e.g., `feat: add kms key rotation`). Each commit must compile, format cleanly, and pass `make pre-commit`. Open PRs with a concise summary, note verification commands, link relevant issues, and wait for reviewer approval.
 
-## Cross-Platform Compatibility Guidelines
-
-- **Always consider multi-platform and different CPU architecture compatibility** when writing code
-- Support major architectures: x86_64, aarch64 (ARM64), and other target platforms
-- Use conditional compilation for architecture-specific code
-- Use feature flags for platform-specific dependencies
-- Provide fallback implementations for unsupported platforms
-- Test on multiple architectures in CI/CD pipeline
-- Use explicit byte order conversion when dealing with binary data
-- Prefer `to_le_bytes()`, `from_le_bytes()` for consistent little-endian format
-- Use portable SIMD libraries like `wide` or `packed_simd`
-- Provide fallback implementations for non-SIMD architectures
-
-## Security Guidelines
-
-- Disable `unsafe` code (workspace.lints.rust.unsafe_code = "deny")
-- Use `rustls` instead of `openssl`
-- Use IAM system for permission checks
-- Validate input parameters properly
-- Implement appropriate permission checks
-- Avoid information leakage
-
-## Configuration Management Guidelines
-
-- Use `RUSTFS_` prefix for environment variables
-- Support both configuration files and environment variables
-- Provide reasonable default values
-- Use `serde` for configuration serialization/deserialization
-
-## Dependency Management Guidelines
-
-- Manage versions uniformly at workspace level
-- Use `workspace = true` to inherit configuration
-- Use feature flags for optional dependencies
-- Don't introduce new tools without strong justification
-
-## Deployment and Operations Guidelines
-
-- Provide Dockerfile and docker-compose configuration
-- Support multi-stage builds to optimize image size
-- Integrate OpenTelemetry for distributed tracing
-- Support Prometheus metrics collection
-- Provide Grafana dashboards
-- Implement health check endpoints
-
-## Code Review Checklist
-
-### 1. **Code Formatting and Quality (MANDATORY)**
-
-- [ ] **Code is properly formatted** (`cargo fmt --all --check` passes)
-- [ ] **All clippy warnings are resolved** (`cargo clippy --all-targets --all-features -- -D warnings` passes)
-- [ ] **Code compiles successfully** (`cargo check --all-targets` passes)
-- [ ] **Pre-commit hooks are working** and all checks pass
-- [ ] **No formatting-related changes** mixed with functional changes (separate commits)
-
-### 2. Functionality
-
-- [ ] Are all error cases properly handled?
-- [ ] Is there appropriate logging?
-- [ ] Is there necessary test coverage?
-
-### 3. Performance
-
-- [ ] Are unnecessary memory allocations avoided?
-- [ ] Are async operations used correctly?
-- [ ] Are there potential deadlock risks?
-
-### 4. Security
-
-- [ ] Are input parameters properly validated?
-- [ ] Are there appropriate permission checks?
-- [ ] Is information leakage avoided?
-
-### 5. Cross-Platform Compatibility
-
-- [ ] Does the code work on different CPU architectures (x86_64, aarch64)?
-- [ ] Are platform-specific features properly gated with conditional compilation?
-- [ ] Is byte order handling correct for binary data?
-- [ ] Are there appropriate fallback implementations for unsupported platforms?
-
-### 6. Code Commits and Documentation
-
-- [ ] Does it comply with [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/)?
-- [ ] Are commit messages concise and under 72 characters for the title line?
-- [ ] Commit titles should be concise and in English, avoid Chinese
-- [ ] Is PR description provided in copyable markdown format for easy copying?
-
-### 7. Competitor Keywords Check
-
-- [ ] No competitor keywords found in code, comments, or documentation
-- [ ] All references use generic terms like "S3-compatible storage"
-- [ ] No specific competitor product names mentioned
-
-## Domain-Specific Guidelines
-
-### 1. Storage Operations
-
-- All storage operations must support erasure coding
-- Implement read/write quorum mechanisms
-- Support data integrity verification
-
-### 2. Network Communication
-
-- Use gRPC for internal service communication
-- HTTP/HTTPS support for S3-compatible API
-- Implement connection pooling and retry mechanisms
-
-### 3. Metadata Management
-
-- Use FlatBuffers for serialization
-- Support version control and migration
-- Implement metadata caching
-
-## Branch Management and Development Workflow
-
-### Branch Management
-
-- **🚨 CRITICAL: NEVER modify code directly on main or master branch - THIS IS ABSOLUTELY FORBIDDEN 🚨**
-- **⚠️ ANY DIRECT COMMITS TO MASTER/MAIN WILL BE REJECTED AND MUST BE REVERTED IMMEDIATELY ⚠️**
-- **🔒 ALL CHANGES MUST GO THROUGH PULL REQUESTS - NO DIRECT COMMITS TO MAIN UNDER ANY CIRCUMSTANCES 🔒**
-- **Always work on feature branches - NO EXCEPTIONS**
-- Always check the AGENTS.md file before starting to ensure you understand the project guidelines
-- **MANDATORY workflow for ALL changes:**
-   1. `git checkout main` (switch to main branch)
-   2. `git pull` (get latest changes)
-   3. `git checkout -b feat/your-feature-name` (create and switch to feature branch)
-   4. Make your changes ONLY on the feature branch
-   5. Test thoroughly before committing
-   6. Commit and push to the feature branch
-   7. **Create a pull request for code review - THIS IS THE ONLY WAY TO MERGE TO MAIN**
-   8. **Wait for PR approval before merging - NEVER merge your own PRs without review**
-- Use descriptive branch names following the pattern: `feat/feature-name`, `fix/issue-name`, `refactor/component-name`, etc.
-- **Double-check current branch before ANY commit: `git branch` to ensure you're NOT on main/master**
-- **Pull Request Requirements:**
-  - All changes must be submitted via PR regardless of size or urgency
-  - PRs must include comprehensive description and testing information
-  - PRs must pass all CI/CD checks before merging
-  - PRs require at least one approval from code reviewers
-  - Even hotfixes and emergency changes must go through PR process
-- **Enforcement:**
-  - Main branch should be protected with branch protection rules
-  - Direct pushes to main should be blocked by repository settings
-  - Any accidental direct commits to main must be immediately reverted via PR
-
-### Development Workflow
-
-## 🎯 **Core Development Principles**
-
-- **🔴 Every change must be precise - don't modify unless you're confident**
-  - Carefully analyze code logic and ensure complete understanding before making changes
-  - When uncertain, prefer asking users or consulting documentation over blind modifications
-  - Use small iterative steps, modify only necessary parts at a time
-  - Evaluate impact scope before changes to ensure no new issues are introduced
-
-- **🚀 GitHub PR creation prioritizes gh command usage**
-  - Prefer using `gh pr create` command to create Pull Requests
-  - Avoid having users manually create PRs through web interface
-  - Provide clear and professional PR titles and descriptions
-  - Using `gh` commands ensures better integration and automation
-
-## 📝 **Code Quality Requirements**
-
-- Use English for all code comments, documentation, and variable names
-- Write meaningful and descriptive names for variables, functions, and methods
-- Avoid meaningless test content like "debug 111" or placeholder values
-- Before each change, carefully read the existing code to ensure you understand the code structure and implementation, do not break existing logic implementation, do not introduce new issues
-- Ensure each change provides sufficient test cases to guarantee code correctness
-- Do not arbitrarily modify numbers and constants in test cases, carefully analyze their meaning to ensure test case correctness
-- When writing or modifying tests, check existing test cases to ensure they have scientific naming and rigorous logic testing, if not compliant, modify test cases to ensure scientific and rigorous testing
-- **Before committing any changes, run `cargo clippy --all-targets --all-features -- -D warnings` to ensure all code passes Clippy checks**
-- After each development completion, first git add . then git commit -m "feat: feature description" or "fix: issue description", ensure compliance with [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/)
-- **Keep commit messages concise and under 72 characters** for the title line, use body for detailed explanations if needed
-- After each development completion, first git push to remote repository
-- After each change completion, summarize the changes, do not create summary files, provide a brief change description, ensure compliance with [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/)
-- Provide change descriptions needed for PR in the conversation, ensure compliance with [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/)
-- **Always provide PR descriptions in English** after completing any changes, including:
-  - Clear and concise title following Conventional Commits format
-  - Detailed description of what was changed and why
-  - List of key changes and improvements
-  - Any breaking changes or migration notes if applicable
-  - Testing information and verification steps
-- **Provide PR descriptions in copyable markdown format** enclosed in code blocks for easy one-click copying
-
-## 🚫 AI Documentation Generation Restrictions
-
-### Forbidden Summary Documents
-
-- **Strictly forbidden to create any form of AI-generated summary documents**
-- **Do not create documents containing large amounts of emoji, detailed formatting tables and typical AI style**
-- **Do not generate the following types of documents in the project:**
-  - Benchmark summary documents (BENCHMARK*.md)
-  - Implementation comparison analysis documents (IMPLEMENTATION_COMPARISON*.md)
-  - Performance analysis report documents
-  - Architecture summary documents
-  - Feature comparison documents
-  - Any documents with large amounts of emoji and formatted content
-- **If documentation is needed, only create when explicitly requested by the user, and maintain a concise and practical style**
-- **Documentation should focus on actually needed information, avoiding excessive formatting and decorative content**
-- **Any discovered AI-generated summary documents should be immediately deleted**
-
-### Allowed Documentation Types
-
-- README.md (project introduction, keep concise)
-- Technical documentation (only create when explicitly needed)
-- User manual (only create when explicitly needed)
-- API documentation (generated from code)
-- Changelog (CHANGELOG.md)
-
-These rules should serve as guiding principles when developing the RustFS project, ensuring code quality, performance, and maintainability.
+## Security & Configuration Tips
+Do not commit secrets or cloud credentials; prefer environment variables or vault tooling. Review IAM- and KMS-related changes with a second maintainer. Confirm proxy settings before running sensitive tests to avoid leaking traffic outside localhost.

CLA.md

@@ -1,39 +1,88 @@
 RustFS Individual Contributor License Agreement
 
-Thank you for your interest in contributing documentation and related software code to a project hosted or managed by RustFS. In order to clarify the intellectual property license granted with Contributions from any person or entity, RustFS must have a Contributor License Agreement (“CLA”) on file that has been signed by each Contributor, indicating agreement to the license terms below. This version of the Contributor License Agreement allows an individual to submit Contributions to the applicable project. If you are making a submission on behalf of a legal entity, then you should sign the separate Corporate Contributor License Agreement.
+Thank you for your interest in contributing documentation and related software code to a project hosted or managed by
+RustFS. In order to clarify the intellectual property license granted with Contributions from any person or entity,
+RustFS must have a Contributor License Agreement ("CLA") on file that has been signed by each Contributor, indicating
+agreement to the license terms below. This version of the Contributor License Agreement allows an individual to submit
+Contributions to the applicable project. If you are making a submission on behalf of a legal entity, then you should
+sign the separate Corporate Contributor License Agreement.
 
-You accept and agree to the following terms and conditions for Your present and future Contributions submitted to RustFS. You hereby irrevocably assign and transfer to RustFS all right, title, and interest in and to Your Contributions, including all copyrights and other intellectual property rights therein.
+You accept and agree to the following terms and conditions for Your present and future Contributions submitted to
+RustFS. You hereby irrevocably assign and transfer to RustFS all right, title, and interest in and to Your
+Contributions, including all copyrights and other intellectual property rights therein.
 
 Definitions
 
-“You” (or “Your”) shall mean the copyright owner or legal entity authorized by the copyright owner that is making this Agreement with RustFS. For legal entities, the entity making a Contribution and all other entities that control, are controlled by, or are under common control with that entity are considered to be a single Contributor. For the purposes of this definition, “control” means (i) the power, direct or indirect, to cause the direction or management of such entity, whether by contract or otherwise, or (ii) ownership of fifty percent (50%) or more of the outstanding shares, or (iii) beneficial ownership of such entity.
+“You” (or “Your”) shall mean the copyright owner or legal entity authorized by the copyright owner that is making this
+Agreement with RustFS. For legal entities, the entity making a Contribution and all other entities that control, are
+controlled by, or are under common control with that entity are considered to be a single Contributor. For the purposes
+of this definition, "control" means (i) the power, direct or indirect, to cause the direction or management of such
+entity, whether by contract or otherwise, or (ii) ownership of fifty percent (50%) or more of the outstanding shares,
+or (iii) beneficial ownership of such entity.
 
-“Contribution” shall mean any original work of authorship, including any modifications or additions to an existing work, that is intentionally submitted by You to RustFS for inclusion in, or documentation of, any of the products or projects owned or managed by RustFS (the “Work”), including without limitation any Work described in Schedule A. For the purposes of this definition, “submitted” means any form of electronic or written communication sent to RustFS or its representatives, including but not limited to communication on electronic mailing lists, source code control systems, and issue tracking systems that are managed by, or on behalf of, RustFS for the purpose of discussing and improving the Work.
+“Contribution” shall mean any original work of authorship, including any modifications or additions to an existing work,
+that is intentionally submitted by You to RustFS for inclusion in, or documentation of, any of the products or projects
+owned or managed by RustFS (the "Work"), including without limitation any Work described in Schedule A. For the purposes
+of this definition, "submitted" means any form of electronic or written communication sent to RustFS or its
+representatives, including but not limited to communication on electronic mailing lists, source code control systems,
+and issue tracking systems that are managed by, or on behalf of, RustFS for the purpose of discussing and improving the
+Work.
 
 Assignment of Copyright
 
-Subject to the terms and conditions of this Agreement, You hereby irrevocably assign and transfer to RustFS all right, title, and interest in and to Your Contributions, including all copyrights and other intellectual property rights therein, for the entire term of such rights, including all renewals and extensions. You agree to execute all documents and take all actions as may be reasonably necessary to vest in RustFS the ownership of Your Contributions and to assist RustFS in perfecting, maintaining, and enforcing its rights in Your Contributions.
+Subject to the terms and conditions of this Agreement, You hereby irrevocably assign and transfer to RustFS all right,
+title, and interest in and to Your Contributions, including all copyrights and other intellectual property rights
+therein, for the entire term of such rights, including all renewals and extensions. You agree to execute all documents
+and take all actions as may be reasonably necessary to vest in RustFS the ownership of Your Contributions and to assist
+RustFS in perfecting, maintaining, and enforcing its rights in Your Contributions.
 
 Grant of Patent License
 
-Subject to the terms and conditions of this Agreement, You hereby grant to RustFS and to recipients of documentation and software distributed by RustFS a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable (except as stated in this section) patent license to make, have made, use, offer to sell, sell, import, and otherwise transfer the Work, where such license applies only to those patent claims licensable by You that are necessarily infringed by Your Contribution(s) alone or by combination of Your Contribution(s) with the Work to which such Contribution(s) was submitted. If any entity institutes patent litigation against You or any other entity (including a cross-claim or counterclaim in a lawsuit) alleging that your Contribution, or the Work to which you have contributed, constitutes direct or contributory patent infringement, then any patent licenses granted to that entity under this Agreement for that Contribution or Work shall terminate as of the date such litigation is filed.
+Subject to the terms and conditions of this Agreement, You hereby grant to RustFS and to recipients of documentation and
+software distributed by RustFS a perpetual, worldwide, non-exclusive, no-charge, royalty-free, irrevocable (except as
+stated in this section) patent license to make, have made, use, offer to sell, sell, import, and otherwise transfer the
+Work, where such license applies only to those patent claims licensable by You that are necessarily infringed by Your
+Contribution(s) alone or by combination of Your Contribution(s) with the Work to which such Contribution(s) was
+submitted. If any entity institutes patent litigation against You or any other entity (including a cross-claim or
+counterclaim in a lawsuit) alleging that your Contribution, or the Work to which you have contributed, constitutes
+direct or contributory patent infringement, then any patent licenses granted to that entity under this Agreement for
+that Contribution or Work shall terminate as of the date such litigation is filed.
 
 You represent that you are legally entitled to grant the above assignment and license.
 
-You represent that each of Your Contributions is Your original creation (see section 7 for submissions on behalf of others). You represent that Your Contribution submissions include complete details of any third-party license or other restriction (including, but not limited to, related patents and trademarks) of which you are personally aware and which are associated with any part of Your Contributions.
+You represent that each of Your Contributions is Your original creation (see section 7 for submissions on behalf of
+others). You represent that Your Contribution submissions include complete details of any third-party license or other
+restriction (including, but not limited to, related patents and trademarks) of which you are personally aware and which
+are associated with any part of Your Contributions.
 
-You are not expected to provide support for Your Contributions, except to the extent You desire to provide support. You may provide support for free, for a fee, or not at all. Unless required by applicable law or agreed to in writing, You provide Your Contributions on an “AS IS” BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied, including, without limitation, any warranties or conditions of TITLE, NON- INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A PARTICULAR PURPOSE.
+You are not expected to provide support for Your Contributions, except to the extent You desire to provide support. You
+may provide support for free, for a fee, or not at all. Unless required by applicable law or agreed to in writing, You
+provide Your Contributions on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied,
+including, without limitation, any warranties or conditions of TITLE, NON- INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR
+A PARTICULAR PURPOSE.
 
-Should You wish to submit work that is not Your original creation, You may submit it to RustFS separately from any Contribution, identifying the complete details of its source and of any license or other restriction (including, but not limited to, related patents, trademarks, and license agreements) of which you are personally aware, and conspicuously marking the work as “Submitted on behalf of a third-party: [named here]”.
+Should You wish to submit work that is not Your original creation, You may submit it to RustFS separately from any
+Contribution, identifying the complete details of its source and of any license or other restriction (including, but not
+limited to, related patents, trademarks, and license agreements) of which you are personally aware, and conspicuously
+marking the work as "Submitted on behalf of a third-party: [named here]”.
 
-You agree to notify RustFS of any facts or circumstances of which you become aware that would make these representations inaccurate in any respect.
+You agree to notify RustFS of any facts or circumstances of which you become aware that would make these representations
+inaccurate in any respect.
 
 Modification of CLA
 
-RustFS reserves the right to update or modify this CLA in the future. Any updates or modifications to this CLA shall apply only to Contributions made after the effective date of the revised CLA. Contributions made prior to the update shall remain governed by the version of the CLA that was in effect at the time of submission. It is not necessary for all Contributors to re-sign the CLA when the CLA is updated or modified.
+RustFS reserves the right to update or modify this CLA in the future. Any updates or modifications to this CLA shall
+apply only to Contributions made after the effective date of the revised CLA. Contributions made prior to the update
+shall remain governed by the version of the CLA that was in effect at the time of submission. It is not necessary for
+all Contributors to re-sign the CLA when the CLA is updated or modified.
 
 Governing Law and Dispute Resolution
 
-This Agreement will be governed by and construed in accordance with the laws of the People’s Republic of China excluding that body of laws known as conflict of laws. The parties expressly agree that the United Nations Convention on Contracts for the International Sale of Goods will not apply. Any legal action or proceeding arising under this Agreement will be brought exclusively in the courts located in Beijing, China, and the parties hereby irrevocably consent to the personal jurisdiction and venue therein.
+This Agreement will be governed by and construed in accordance with the laws of the People's Republic of China excluding
+that body of laws known as conflict of laws. The parties expressly agree that the United Nations Convention on Contracts
+for the International Sale of Goods will not apply. Any legal action or proceeding arising under this Agreement will be
+brought exclusively in the courts located in Beijing, China, and the parties hereby irrevocably consent to the personal
+jurisdiction and venue therein.
 
-For your reading convenience, this Agreement is written in parallel English and Chinese sections. To the extent there is a conflict between the English and Chinese sections, the English sections shall govern.
+For your reading convenience, this Agreement is written in parallel English and Chinese sections. To the extent there is
+a conflict between the English and Chinese sections, the English sections shall govern.

CLAUDE.md

@@ -4,34 +4,68 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co
 
 ## Project Overview
 
-RustFS is a high-performance distributed object storage software built with Rust, providing S3-compatible APIs and advanced features like data lakes, AI, and big data support. It's designed as an alternative to MinIO with better performance and a more business-friendly Apache 2.0 license.
+RustFS is a high-performance distributed object storage software built with Rust, providing S3-compatible APIs and
+advanced features like data lakes, AI, and big data support. It's designed as an alternative to MinIO with better
+performance and a more business-friendly Apache 2.0 license.
 
 ## Build Commands
 
 ### Primary Build Commands
+
 - `cargo build --release` - Build the main RustFS binary
 - `./build-rustfs.sh` - Recommended build script that handles console resources and cross-platform compilation
 - `./build-rustfs.sh --dev` - Development build with debug symbols
 - `make build` or `just build` - Use Make/Just for standardized builds
 
 ### Platform-Specific Builds
+
 - `./build-rustfs.sh --platform x86_64-unknown-linux-musl` - Build for musl target
 - `./build-rustfs.sh --platform aarch64-unknown-linux-gnu` - Build for ARM64
 - `make build-musl` or `just build-musl` - Build musl variant
 - `make build-cross-all` - Build all supported architectures
 
 ### Testing Commands
+
 - `cargo test --workspace --exclude e2e_test` - Run unit tests (excluding e2e tests)
 - `cargo nextest run --all --exclude e2e_test` - Use nextest if available (faster)
 - `cargo test --all --doc` - Run documentation tests
 - `make test` or `just test` - Run full test suite
+- `make pre-commit` - Run all quality checks (fmt, clippy, check, test)
+
+### End-to-End Testing
+
+- `cargo test --package e2e_test` - Run all e2e tests
+- `./scripts/run_e2e_tests.sh` - Run e2e tests via script
+- `./scripts/run_scanner_benchmarks.sh` - Run scanner performance benchmarks
+
+### KMS-Specific Testing (with proxy bypass)
+
+-
+`NO_PROXY=127.0.0.1,localhost HTTP_PROXY= HTTPS_PROXY= http_proxy= https_proxy= cargo test --package e2e_test test_local_kms_end_to_end -- --nocapture --test-threads=1` -
+Run complete KMS end-to-end test
+-
+`NO_PROXY=127.0.0.1,localhost HTTP_PROXY= HTTPS_PROXY= http_proxy= https_proxy= cargo test --package e2e_test kms:: -- --nocapture --test-threads=1` -
+Run all KMS tests
+- `cargo test --package e2e_test test_local_kms_key_isolation -- --nocapture --test-threads=1` - Test KMS key isolation
+- `cargo test --package e2e_test test_local_kms_large_file -- --nocapture --test-threads=1` - Test KMS with large files
 
 ### Code Quality
+
 - `cargo fmt --all` - Format code
 - `cargo clippy --all-targets --all-features -- -D warnings` - Lint code
 - `make pre-commit` or `just pre-commit` - Run all quality checks (fmt, clippy, check, test)
 
+### Quick Development Commands
+
+- `make help` or `just help` - Show all available commands with descriptions
+- `make help-build` - Show detailed build options and cross-compilation help
+- `make help-docker` - Show comprehensive Docker build and deployment options
+- `./scripts/dev_deploy.sh <IP>` - Deploy development build to remote server
+- `./scripts/run.sh` - Start local development server
+- `./scripts/probe.sh` - Health check and connectivity testing
+
 ### Docker Build Commands
+
 - `make docker-buildx` - Build multi-architecture production images
 - `make docker-dev-local` - Build development image for local use
 - `./docker-buildx.sh --push` - Build and push production images
@@ -41,6 +75,7 @@ RustFS is a high-performance distributed object storage software built with Rust
 ### Core Components
 
 **Main Binary (`rustfs/`):**
+
 - Entry point at `rustfs/src/main.rs`
 - Core modules: admin, auth, config, server, storage, license management, profiling
 - HTTP server with S3-compatible APIs
@@ -48,9 +83,11 @@ RustFS is a high-performance distributed object storage software built with Rust
 - Parallel service initialization with DNS resolver, bucket metadata, and IAM
 
 **Key Crates (`crates/`):**
+
 - `ecstore` - Erasure coding storage implementation (core storage layer)
 - `iam` - Identity and Access Management
-- `madmin` - Management dashboard and admin API interface  
+- `kms` - Key Management Service for encryption and key handling
+- `madmin` - Management dashboard and admin API interface
 - `s3select-api` & `s3select-query` - S3 Select API and query engine
 - `config` - Configuration management with notify features
 - `crypto` - Cryptography and security features
@@ -64,19 +101,30 @@ RustFS is a high-performance distributed object storage software built with Rust
 - `obs` - Observability utilities
 - `workers` - Worker thread pools and task scheduling
 - `appauth` - Application authentication and authorization
+- `ahm` - Asynchronous Hash Map for concurrent data structures
+- `mcp` - MCP server for S3 operations
+- `signer` - Client request signing utilities
+- `checksums` - Client checksum calculation utilities
+- `utils` - General utility functions and helpers
+- `zip` - ZIP file handling and compression
+- `targets` - Target-specific configurations and utilities
 
 ### Build System
-- Cargo workspace with 25+ crates
+
+- Cargo workspace with 25+ crates (including new KMS functionality)
 - Custom `build-rustfs.sh` script for advanced build options
 - Multi-architecture Docker builds via `docker-buildx.sh`
-- Both Make and Just task runners supported
+- Both Make and Just task runners supported with comprehensive help
 - Cross-compilation support for multiple Linux targets
+- Automated CI/CD with GitHub Actions for testing, building, and Docker publishing
+- Performance benchmarking and audit workflows
 
 ### Key Dependencies
+
 - `axum` - HTTP framework for S3 API server
 - `tokio` - Async runtime
 - `s3s` - S3 protocol implementation library
-- `datafusion` - For S3 Select query processing  
+- `datafusion` - For S3 Select query processing
 - `hyper`/`hyper-util` - HTTP client/server utilities
 - `rustls` - TLS implementation
 - `serde`/`serde_json` - Serialization
@@ -85,21 +133,26 @@ RustFS is a high-performance distributed object storage software built with Rust
 - `tikv-jemallocator` - Memory allocator for Linux GNU builds
 
 ### Development Workflow
+
 - Console resources are embedded during build via `rust-embed`
 - Protocol buffers generated via custom `gproto` binary
-- E2E tests in separate crate (`e2e_test`)
+- E2E tests in separate crate (`e2e_test`) with comprehensive KMS testing
 - Shadow build for version/metadata embedding
 - Support for both GNU and musl libc targets
+- Development scripts in `scripts/` directory for common tasks
+- Git hooks setup available via `make setup-hooks` or `just setup-hooks`
 
 ### Performance & Observability
+
 - Performance profiling available with `pprof` integration (disabled on Windows)
 - Profiling enabled via environment variables in production
 - Built-in observability with OpenTelemetry integration
 - Background services (scanner, heal) can be controlled via environment variables:
-  - `RUSTFS_ENABLE_SCANNER` (default: true)
-  - `RUSTFS_ENABLE_HEAL` (default: true)
+    - `RUSTFS_ENABLE_SCANNER` (default: true)
+    - `RUSTFS_ENABLE_HEAL` (default: true)
 
 ### Service Architecture
+
 - Service state management with graceful shutdown handling
 - Parallel initialization of core systems (DNS, bucket metadata, IAM)
 - Event notification system with MQTT and webhook support
@@ -107,16 +160,116 @@ RustFS is a high-performance distributed object storage software built with Rust
 - Jemalloc allocator for Linux GNU targets for better performance
 
 ## Environment Variables
-- `RUSTFS_ENABLE_SCANNER` - Enable/disable background data scanner
-- `RUSTFS_ENABLE_HEAL` - Enable/disable auto-heal functionality
-- Various profiling and observability controls
 
-## Code Style
-- Communicate with me in Chinese, but only English can be used in code files.
-- Code that may cause program crashes (such as unwrap/expect) must not be used, except for testing purposes.
-- Code that may cause performance issues (such as blocking IO) must not be used, except for testing purposes.
-- Code that may cause memory leaks must not be used, except for testing purposes.
-- Code that may cause deadlocks must not be used, except for testing purposes.
-- Code that may cause undefined behavior must not be used, except for testing purposes.
-- Code that may cause panics must not be used, except for testing purposes.
-- Code that may cause data races must not be used, except for testing purposes.
+- `RUSTFS_ENABLE_SCANNER` - Enable/disable background data scanner (default: true)
+- `RUSTFS_ENABLE_HEAL` - Enable/disable auto-heal functionality (default: true)
+- Various profiling and observability controls
+- Build-time variables for Docker builds (RELEASE, REGISTRY, etc.)
+- Test environment configurations in `scripts/dev_rustfs.env`
+
+### KMS Environment Variables
+
+- `NO_PROXY=127.0.0.1,localhost` - Required for KMS E2E tests to bypass proxy
+- `HTTP_PROXY=` `HTTPS_PROXY=` `http_proxy=` `https_proxy=` - Clear proxy settings for local KMS testing
+
+## KMS (Key Management Service) Architecture
+
+### KMS Implementation Status
+
+- **Full KMS Integration:** Complete implementation with Local and Vault backends
+- **Automatic Configuration:** KMS auto-configures on startup with `--kms-enable` flag
+- **Encryption Support:** Full S3-compatible server-side encryption (SSE-S3, SSE-KMS, SSE-C)
+- **Admin API:** Complete KMS management via HTTP admin endpoints
+- **Production Ready:** Comprehensive testing including large files and key isolation
+
+### KMS Configuration
+
+- **Local Backend:** `--kms-backend local --kms-key-dir <path> --kms-default-key-id <id>`
+- **Vault Backend:** `--kms-backend vault --kms-vault-endpoint <url> --kms-vault-key-name <name>`
+- **Auto-startup:** KMS automatically initializes when `--kms-enable` is provided
+- **Manual Configuration:** Also supports dynamic configuration via admin API
+
+### S3 Encryption Support
+
+- **SSE-S3:** Server-side encryption with S3-managed keys (`ServerSideEncryption: AES256`)
+- **SSE-KMS:** Server-side encryption with KMS-managed keys (`ServerSideEncryption: aws:kms`)
+- **SSE-C:** Server-side encryption with customer-provided keys
+- **Response Headers:** All encryption types return correct `server_side_encryption` headers in PUT/GET responses
+
+### KMS Testing Architecture
+
+- **Comprehensive E2E Tests:** Located in `crates/e2e_test/src/kms/`
+- **Test Environments:** Automated test environment setup with temporary directories
+- **Encryption Coverage:** Tests all three encryption types (SSE-S3, SSE-KMS, SSE-C)
+- **API Coverage:** Tests all KMS admin APIs (CreateKey, DescribeKey, ListKeys, etc.)
+- **Edge Cases:** Key isolation, large file handling, error scenarios
+
+### Key Files for KMS
+
+- `crates/kms/` - Core KMS implementation with Local/Vault backends
+- `rustfs/src/main.rs` - KMS auto-initialization in `init_kms_system()`
+- `rustfs/src/storage/ecfs.rs` - SSE encryption/decryption in PUT/GET operations
+- `rustfs/src/admin/handlers/kms*.rs` - KMS admin endpoints
+- `crates/e2e_test/src/kms/` - Comprehensive KMS test suite
+- `crates/rio/src/encrypt_reader.rs` - Streaming encryption for large files
+
+## Code Style and Safety Requirements
+
+- **Language Requirements:**
+    - Communicate with me in Chinese, but **only English can be used in code files**
+    - Code comments, function names, variable names, and all text in source files must be in English only
+    - No Chinese characters, emojis, or non-ASCII characters are allowed in any source code files
+    - This includes comments, strings, documentation, and any other text within code files
+- **Safety-Critical Rules:**
+    - `unsafe_code = "deny"` enforced at workspace level
+    - Never use `unwrap()`, `expect()`, or panic-inducing code except in tests
+    - Avoid blocking I/O operations in async contexts
+    - Use proper error handling with `Result<T, E>` and `Option<T>`
+    - Follow Rust's ownership and borrowing rules strictly
+- **Performance Guidelines:**
+    - Use `cargo clippy --all-targets --all-features -- -D warnings` to catch issues
+    - Prefer `anyhow` for error handling in applications, `thiserror` for libraries
+    - Use appropriate async runtimes and avoid blocking calls
+- **Testing Standards:**
+    - All new features must include comprehensive tests
+    - Use `#[cfg(test)]` for test-only code that may use panic macros
+    - E2E tests should cover KMS integration scenarios
+
+## Common Development Tasks
+
+### Running KMS Tests Locally
+
+1. **Clear proxy settings:** KMS tests require direct localhost connections
+2. **Use serial execution:** `--test-threads=1` prevents port conflicts
+3. **Enable output:** `--nocapture` shows detailed test logs
+4. **Full command:**
+   `NO_PROXY=127.0.0.1,localhost HTTP_PROXY= HTTPS_PROXY= http_proxy= https_proxy= cargo test --package e2e_test test_local_kms_end_to_end -- --nocapture --test-threads=1`
+
+### KMS Development Workflow
+
+1. **Code changes:** Modify KMS-related code in `crates/kms/` or `rustfs/src/`
+2. **Compile:** Always run `cargo build` after changes
+3. **Test specific functionality:** Use targeted test commands for faster iteration
+4. **Full validation:** Run complete end-to-end tests before commits
+
+### Debugging KMS Issues
+
+- **Server startup:** Check that KMS auto-initializes with debug logs
+- **Encryption failures:** Verify SSE headers are correctly set in both PUT and GET responses
+- **Test failures:** Use `--nocapture` to see detailed error messages
+- **Key management:** Test admin API endpoints with proper authentication
+
+## Important Reminders
+
+- **Always compile after code changes:** Use `cargo build` to catch errors early
+- **Don't bypass tests:** All functionality must be properly tested, not worked around
+- **Use proper error handling:** Never use `unwrap()` or `expect()` in production code (except tests)
+- **Follow S3 compatibility:** Ensure all encryption types return correct HTTP response headers
+
+# important-instruction-reminders
+
+Do what has been asked; nothing more, nothing less.
+NEVER create files unless they're absolutely necessary for achieving your goal.
+ALWAYS prefer editing an existing file to creating a new one.
+NEVER proactively create documentation files (*.md) or README files. Only create documentation files if explicitly
+requested by the User.

Cargo.toml

@@ -16,7 +16,7 @@
 members = [
     "rustfs", # Core file system implementation
     "crates/appauth", # Application authentication and authorization
-    "crates/audit-logger", # Audit logging system for file operations
+    "crates/audit", # Audit target management system with multi-target fan-out
     "crates/common", # Shared utilities and data structures
     "crates/config", # Configuration management
     "crates/crypto", # Cryptography and security features
@@ -28,6 +28,7 @@ members = [
     "crates/madmin", # Management dashboard and admin API interface
     "crates/notify", # Notification system for events
     "crates/obs", # Observability utilities
+    "crates/policy", # Policy management
     "crates/protos", # Protocol buffer definitions
     "crates/rio", # Rust I/O utilities and abstractions
     "crates/targets", # Target-specific configurations and utilities
@@ -40,6 +41,7 @@ members = [
     "crates/zip", # ZIP file handling and compression
     "crates/ahm", # Asynchronous Hash Map for concurrent data structures
     "crates/mcp", # MCP server for S3 operations
+    "crates/kms", # Key Management Service
 ]
 resolver = "2"
 
@@ -61,223 +63,224 @@ unsafe_code = "deny"
 all = "warn"
 
 [workspace.dependencies]
+# RustFS Internal Crates
+rustfs = { path = "./rustfs", version = "0.0.5" }
 rustfs-ahm = { path = "crates/ahm", version = "0.0.5" }
-rustfs-s3select-api = { path = "crates/s3select-api", version = "0.0.5" }
 rustfs-appauth = { path = "crates/appauth", version = "0.0.5" }
-rustfs-audit-logger = { path = "crates/audit-logger", version = "0.0.5" }
+rustfs-audit = { path = "crates/audit", version = "0.0.5" }
+rustfs-checksums = { path = "crates/checksums", version = "0.0.5" }
 rustfs-common = { path = "crates/common", version = "0.0.5" }
+rustfs-config = { path = "./crates/config", version = "0.0.5" }
 rustfs-crypto = { path = "crates/crypto", version = "0.0.5" }
 rustfs-ecstore = { path = "crates/ecstore", version = "0.0.5" }
+rustfs-filemeta = { path = "crates/filemeta", version = "0.0.5" }
 rustfs-iam = { path = "crates/iam", version = "0.0.5" }
+rustfs-kms = { path = "crates/kms", version = "0.0.5" }
 rustfs-lock = { path = "crates/lock", version = "0.0.5" }
 rustfs-madmin = { path = "crates/madmin", version = "0.0.5" }
+rustfs-mcp = { path = "crates/mcp", version = "0.0.5" }
+rustfs-notify = { path = "crates/notify", version = "0.0.5" }
+rustfs-obs = { path = "crates/obs", version = "0.0.5" }
 rustfs-policy = { path = "crates/policy", version = "0.0.5" }
 rustfs-protos = { path = "crates/protos", version = "0.0.5" }
-rustfs-s3select-query = { path = "crates/s3select-query", version = "0.0.5" }
-rustfs = { path = "./rustfs", version = "0.0.5" }
-rustfs-zip = { path = "./crates/zip", version = "0.0.5" }
-rustfs-config = { path = "./crates/config", version = "0.0.5" }
-rustfs-obs = { path = "crates/obs", version = "0.0.5" }
-rustfs-notify = { path = "crates/notify", version = "0.0.5" }
-rustfs-utils = { path = "crates/utils", version = "0.0.5" }
 rustfs-rio = { path = "crates/rio", version = "0.0.5" }
-rustfs-filemeta = { path = "crates/filemeta", version = "0.0.5" }
+rustfs-s3select-api = { path = "crates/s3select-api", version = "0.0.5" }
+rustfs-s3select-query = { path = "crates/s3select-query", version = "0.0.5" }
 rustfs-signer = { path = "crates/signer", version = "0.0.5" }
-rustfs-checksums = { path = "crates/checksums", version = "0.0.5" }
-rustfs-workers = { path = "crates/workers", version = "0.0.5" }
-rustfs-mcp = { path = "crates/mcp", version = "0.0.5" }
 rustfs-targets = { path = "crates/targets", version = "0.0.5" }
-aes-gcm = { version = "0.10.3", features = ["std"] }
-anyhow = "1.0.99"
-arc-swap = "1.7.1"
-argon2 = { version = "0.5.3", features = ["std"] }
-atoi = "2.0.0"
+rustfs-utils = { path = "crates/utils", version = "0.0.5" }
+rustfs-workers = { path = "crates/workers", version = "0.0.5" }
+rustfs-zip = { path = "./crates/zip", version = "0.0.5" }
+
+# Async Runtime and Networking
 async-channel = "2.5.0"
+async-compression = { version = "0.4.19" }
 async-recursion = "1.1.1"
 async-trait = "0.1.89"
-async-compression = { version = "0.4.19" }
-atomic_enum = "0.3.0"
-aws-config = { version = "1.8.6" }
-aws-sdk-s3 = "1.101.0"
-axum = "0.8.4"
-axum-extra = "0.10.1"
-axum-server = "0.7.2"
-base64-simd = "0.8.0"
-base64 = "0.22.1"
-brotli = "8.0.2"
-bytes = { version = "1.10.1", features = ["serde"] }
-bytesize = "2.0.1"
-byteorder = "1.5.0"
-cfg-if = "1.0.3"
-crc-fast = "1.5.0"
-chacha20poly1305 = { version = "0.10.1" }
-chrono = { version = "0.4.42", features = ["serde"] }
-clap = { version = "4.5.47", features = ["derive", "env"] }
-const-str = { version = "0.7.0", features = ["std", "proc"] }
-crc32fast = "1.5.0"
-criterion = { version = "0.7", features = ["html_reports"] }
-crossbeam-queue = "0.3.12"
-dashmap = "6.1.0"
-datafusion = "46.0.1"
-derive_builder = "0.20.2"
-enumset = "1.1.10"
-flatbuffers = "25.2.10"
-flate2 = "1.1.2"
-flexi_logger = { version = "0.31.2", features = ["trc", "dont_minimize_extra_stacks"] }
-form_urlencoded = "1.2.2"
+axum = "0.8.6"
+axum-extra = "0.12.1"
+axum-server = { version = "0.7.2", features = ["tls-rustls-no-provider"], default-features = false }
 futures = "0.3.31"
 futures-core = "0.3.31"
 futures-util = "0.3.31"
-glob = "0.3.3"
-hex-simd = "0.8.0"
-highway = { version = "1.3.0" }
-hickory-resolver = { version = "0.25.2", features = ["tls-ring"] }
-hmac = "0.12.1"
-hyper = "1.7.0"
-hyper-util = { version = "0.1.16", features = [
-    "tokio",
-    "server-auto",
-    "server-graceful",
-] }
-hyper-rustls = "0.27.7"
+hyper = { version = "1.7.0", features = ["http2", "http1", "server"] }
+hyper-rustls = { version = "0.27.7", default-features = false, features = ["native-tokio", "http1", "tls12", "logging", "http2", "ring", "webpki-roots"] }
+hyper-util = { version = "0.1.17", features = ["tokio", "server-auto", "server-graceful"] }
 http = "1.3.1"
 http-body = "1.0.1"
-humantime = "2.3.0"
-ipnetwork = { version = "0.21.1", features = ["serde"] }
-jsonwebtoken = "9.3.1"
-lazy_static = "1.5.0"
-libsystemd = { version = "0.7.2" }
-local-ip-address = "0.6.5"
-lz4 = "1.28.1"
-matchit = "0.8.4"
-md-5 = "0.10.6"
-mime_guess = "2.0.5"
-moka = { version = "0.12.10", features = ["future"] }
-netif = "0.1.6"
-nix = { version = "0.30.1", features = ["fs"] }
-nu-ansi-term = "0.50.1"
-num_cpus = { version = "1.17.0" }
-nvml-wrapper = "0.11.0"
-object_store = "0.11.2"
-once_cell = "1.21.3"
-opentelemetry = { version = "0.30.0" }
-opentelemetry-appender-tracing = { version = "0.30.1", features = [
-    "experimental_use_tracing_span_context",
-    "experimental_metadata_attributes",
-    "spec_unstable_logs_enabled"
-] }
-opentelemetry_sdk = { version = "0.30.0" }
-opentelemetry-stdout = { version = "0.30.0" }
-opentelemetry-otlp = { version = "0.30.0", default-features = false, features = [
-    "grpc-tonic", "gzip-tonic", "trace", "metrics", "logs", "internal-logs"
-] }
-opentelemetry-semantic-conventions = { version = "0.30.0", features = [
-    "semconv_experimental",
-] }
-parking_lot = "0.12.4"
-path-absolutize = "3.1.1"
-path-clean = "1.0.1"
-blake3 = { version = "1.8.2" }
-pbkdf2 = "0.12.2"
-percent-encoding = "2.3.2"
-pin-project-lite = "0.2.16"
-prost = "0.14.1"
-pretty_assertions = "1.4.1"
-quick-xml = "0.38.3"
-rand = "0.9.2"
-rdkafka = { version = "0.38.0", features = ["tokio"] }
-reed-solomon-simd = { version = "3.0.1" }
-regex = { version = "1.11.2" }
-reqwest = { version = "0.12.23", default-features = false, features = [
-    "rustls-tls",
-    "charset",
-    "http2",
-    "system-proxy",
-    "stream",
-    "json",
-    "blocking",
-] }
-rmcp = { version = "0.6.4" }
-rmp = "0.8.14"
-rmp-serde = "1.3.0"
-rsa = "0.9.8"
-rumqttc = { version = "0.25.0" }
-rust-embed = { version = "8.7.2" }
-rustfs-rsc = "2025.506.1"
-rustls = { version = "0.23.31" }
-rustls-pki-types = "1.12.0"
-rustls-pemfile = "2.2.0"
-s3s = { version = "0.12.0-minio-preview.3" }
-schemars = "1.0.4"
-serde = { version = "1.0.219", features = ["derive"] }
-serde_json = { version = "1.0.143", features = ["raw_value"] }
-serde_urlencoded = "0.7.1"
-serial_test = "3.2.0"
-sha1 = "0.10.6"
-sha2 = "0.10.9"
-shadow-rs = { version = "1.3.0", default-features = false }
-siphasher = "1.0.1"
-smallvec = { version = "1.15.1", features = ["serde"] }
-smartstring = "1.0.1"
-snafu = "0.8.9"
-snap = "1.1.1"
-socket2 = "0.6.0"
-strum = { version = "0.27.2", features = ["derive"] }
-sysinfo = "0.37.0"
-sysctl = "0.6.0"
-tempfile = "3.22.0"
-temp-env = "0.3.6"
-test-case = "3.3.1"
-thiserror = "2.0.16"
-time = { version = "0.3.43", features = [
-    "std",
-    "parsing",
-    "formatting",
-    "macros",
-    "serde",
-] }
-tokio = { version = "1.47.1", features = ["fs", "rt-multi-thread"] }
-tokio-rustls = { version = "0.26.2", default-features = false }
+reqwest = { version = "0.12.24", default-features = false, features = ["rustls-tls-webpki-roots", "charset", "http2", "system-proxy", "stream", "json", "blocking"] }
+socket2 = "0.6.1"
+tokio = { version = "1.48.0", features = ["fs", "rt-multi-thread"] }
+tokio-rustls = { version = "0.26.4", default-features = false, features = ["logging", "tls12", "ring"] }
 tokio-stream = { version = "0.1.17" }
-tokio-tar = "0.3.1"
 tokio-test = "0.4.4"
-tokio-util = { version = "0.7.16", features = ["io", "compat"] }
+tokio-util = { version = "0.7.17", features = ["io", "compat"] }
 tonic = { version = "0.14.2", features = ["gzip"] }
 tonic-prost = { version = "0.14.2" }
 tonic-prost-build = { version = "0.14.2" }
 tower = { version = "0.5.2", features = ["timeout"] }
 tower-http = { version = "0.6.6", features = ["cors"] }
-tracing = "0.1.41"
-tracing-core = "0.1.34"
+
+# Serialization and Data Formats
+bytes = { version = "1.10.1", features = ["serde"] }
+bytesize = "2.1.0"
+byteorder = "1.5.0"
+flatbuffers = "25.9.23"
+form_urlencoded = "1.2.2"
+prost = "0.14.1"
+quick-xml = "0.38.3"
+rmcp = { version = "0.8.4" }
+rmp = { version = "0.8.14" }
+rmp-serde = { version = "1.3.0" }
+serde = { version = "1.0.228", features = ["derive"] }
+serde_json = { version = "1.0.145", features = ["raw_value"] }
+serde_urlencoded = "0.7.1"
+schemars = "1.0.5"
+
+# Cryptography and Security
+aes-gcm = { version = "0.10.3", features = ["std"] }
+argon2 = { version = "0.5.3", features = ["std"] }
+blake3 = { version = "1.8.2" }
+chacha20poly1305 = { version = "0.10.1" }
+crc-fast = "1.3.0"
+crc32c = "0.6.8"
+crc32fast = "1.5.0"
+crc64fast-nvme = "1.2.0"
+hmac = "0.12.1"
+jsonwebtoken = { version = "10.1.0", features = ["rust_crypto"] }
+pbkdf2 = "0.12.2"
+rsa = { version = "0.9.8" }
+rustls = { version = "0.23.35", features = ["ring", "logging", "std", "tls12"], default-features = false }
+rustls-pemfile = "2.2.0"
+rustls-pki-types = "1.13.0"
+sha1 = "0.10.6"
+sha2 = "0.10.9"
+zeroize = { version = "1.8.2", features = ["derive"] }
+
+# Time and Date
+chrono = { version = "0.4.42", features = ["serde"] }
+humantime = "2.3.0"
+time = { version = "0.3.44", features = ["std", "parsing", "formatting", "macros", "serde"] }
+
+# Utilities and Tools
+anyhow = "1.0.100"
+arc-swap = "1.7.1"
+astral-tokio-tar = "0.5.6"
+atoi = "2.0.0"
+atomic_enum = "0.3.0"
+aws-config = { version = "1.8.10" }
+aws-credential-types = { version = "1.2.8" }
+aws-sdk-s3 = { version = "1.110.0", default-features = false, features = ["sigv4a", "rustls", "rt-tokio"] }
+aws-smithy-types = { version = "1.3.4" }
+base64 = "0.22.1"
+base64-simd = "0.8.0"
+brotli = "8.0.2"
+cfg-if = "1.0.4"
+clap = { version = "4.5.51", features = ["derive", "env"] }
+const-str = { version = "0.7.0", features = ["std", "proc"] }
+convert_case = "0.8.0"
+criterion = { version = "0.7", features = ["html_reports"] }
+crossbeam-queue = "0.3.12"
+datafusion = "50.3.0"
+derive_builder = "0.20.2"
+enumset = "1.1.10"
+flate2 = "1.1.5"
+flexi_logger = { version = "0.31.7", features = ["trc", "dont_minimize_extra_stacks", "compress", "kv"] }
+glob = "0.3.3"
+google-cloud-storage = "1.2.0"
+google-cloud-auth = "1.1.0"
+hashbrown = { version = "0.16.0", features = ["serde", "rayon"] }
+heed = { version = "0.22.0" }
+hex-simd = "0.8.0"
+highway = { version = "1.3.0" }
+ipnetwork = { version = "0.21.1", features = ["serde"] }
+lazy_static = "1.5.0"
+libc = "0.2.177"
+libsystemd = { version = "0.7.2" }
+local-ip-address = "0.6.5"
+lz4 = "1.28.1"
+matchit = "0.9.0"
+md-5 = "0.10.6"
+md5 = "0.8.0"
+metrics = "0.24.2"
+metrics-exporter-opentelemetry = "0.1.2"
+mime_guess = "2.0.5"
+moka = { version = "0.12.11", features = ["future"] }
+netif = "0.1.6"
+nix = { version = "0.30.1", features = ["fs"] }
+nu-ansi-term = "0.50.3"
+num_cpus = { version = "1.17.0" }
+nvml-wrapper = "0.11.0"
+object_store = "0.12.4"
+once_cell = "1.21.3"
+parking_lot = "0.12.5"
+path-absolutize = "3.1.1"
+path-clean = "1.0.1"
+pin-project-lite = "0.2.16"
+pretty_assertions = "1.4.1"
+rand = "0.9.2"
+rayon = "1.11.0"
+reed-solomon-simd = { version = "3.1.0" }
+regex = { version = "1.12.2" }
+rumqttc = { version = "0.25.0" }
+rust-embed = { version = "8.9.0" }
+rustc-hash = { version = "2.1.1" }
+s3s = { version = "0.12.0-rc.3", features = ["minio"] }
+scopeguard = "1.2.0"
+serial_test = "3.2.0"
+shadow-rs = { version = "1.4.0", default-features = false }
+siphasher = "1.0.1"
+smallvec = { version = "1.15.1", features = ["serde"] }
+smartstring = "1.0.1"
+snafu = "0.8.9"
+snap = "1.1.1"
+starshard = { version = "0.5.0", features = ["rayon", "async", "serde"] }
+strum = { version = "0.27.2", features = ["derive"] }
+sysctl = "0.7.1"
+sysinfo = "0.37.2"
+temp-env = "0.3.6"
+tempfile = "3.23.0"
+test-case = "3.3.1"
+thiserror = "2.0.17"
+tracing = { version = "0.1.41" }
+tracing-appender = "0.2.3"
 tracing-error = "0.2.1"
-tracing-opentelemetry = "0.31.0"
+tracing-opentelemetry = "0.32.0"
 tracing-subscriber = { version = "0.3.20", features = ["env-filter", "time"] }
 transform-stream = "0.3.1"
 url = "2.5.7"
 urlencoding = "2.1.3"
-uuid = { version = "1.18.1", features = [
-    "v4",
-    "fast-rng",
-    "macro-diagnostics",
-] }
-wildmatch = { version = "2.4.0", features = ["serde"] }
+uuid = { version = "1.18.1", features = ["v4", "fast-rng", "macro-diagnostics"] }
+vaultrs = { version = "0.7.4" }
+walkdir = "2.5.0"
+wildmatch = { version = "2.5.0", features = ["serde"] }
 winapi = { version = "0.3.9" }
 xxhash-rust = { version = "0.8.15", features = ["xxh64", "xxh3"] }
-zip = "2.4.2"
+zip = "6.0.0"
 zstd = "0.13.3"
 
+# Observability and Metrics
+opentelemetry = { version = "0.31.0" }
+opentelemetry-appender-tracing = { version = "0.31.1", features = ["experimental_use_tracing_span_context", "experimental_metadata_attributes", "spec_unstable_logs_enabled"] }
+opentelemetry-otlp = { version = "0.31.0", default-features = false, features = ["grpc-tonic", "gzip-tonic", "trace", "metrics", "logs", "internal-logs"] }
+opentelemetry_sdk = { version = "0.31.0" }
+opentelemetry-semantic-conventions = { version = "0.31.0", features = ["semconv_experimental"] }
+opentelemetry-stdout = { version = "0.31.0" }
+
+# Performance Analysis and Memory Profiling
+# Use tikv-jemallocator as memory allocator and enable performance analysis
+tikv-jemallocator = { version = "0.6", features = ["profiling", "stats", "unprefixed_malloc_on_supported_platforms", "background_threads"] }
+# Used to control and obtain statistics for jemalloc at runtime
+tikv-jemalloc-ctl = { version = "0.6", features = ["use_std", "stats", "profiling"] }
+# Used to generate pprof-compatible memory profiling data and support symbolization and flame graphs
+jemalloc_pprof = { version = "0.8.1", features = ["symbolize", "flamegraph"] }
+# Used to generate CPU performance analysis data and flame diagrams
+pprof = { version = "0.15.0", features = ["flamegraph", "protobuf-codec"] }
+mimalloc = "0.1"
+
+
 [workspace.metadata.cargo-shear]
-ignored = ["rustfs", "rust-i18n", "rustfs-mcp", "rustfs-audit-logger", "tokio-test"]
-
-[profile.wasm-dev]
-inherits = "dev"
-opt-level = 1
-
-[profile.server-dev]
-inherits = "dev"
-
-[profile.android-dev]
-inherits = "dev"
+ignored = ["rustfs", "rustfs-mcp", "tokio-test", "scopeguard"]
 
 [profile.release]
 opt-level = 3

Dockerfile

@@ -58,7 +58,7 @@ LABEL name="RustFS" \
       url="https://rustfs.com" \
       license="Apache-2.0"
 
-RUN apk add --no-cache ca-certificates coreutils
+RUN apk add --no-cache ca-certificates coreutils curl
 
 COPY --from=build /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/
 COPY --from=build /build/rustfs /usr/bin/rustfs

README.md

@@ -25,11 +25,15 @@ English | <a href="https://github.com/rustfs/rustfs/blob/main/README_ZH.md">简
   <a href="https://readme-i18n.com/rustfs/rustfs?lang=fr">français</a> |
   <a href="https://readme-i18n.com/rustfs/rustfs?lang=ja">日本語</a> |
   <a href="https://readme-i18n.com/rustfs/rustfs?lang=ko">한국어</a> |
-  <a href="https://readme-i18n.com/rustfs/rustfs?lang=pt">Português</a> |
+  <a href="https://readme-i18n.com/rustfs/rustfs?lang=pt">Portuguese</a> |
   <a href="https://readme-i18n.com/rustfs/rustfs?lang=ru">Русский</a>
 </p>
 
-RustFS is a high-performance distributed object storage software built using Rust, one of the most popular languages worldwide. Along with MinIO, it shares a range of advantages such as simplicity, S3 compatibility, open-source nature, support for data lakes, AI, and big data. Furthermore, it has a better and more user-friendly open-source license in comparison to other storage systems, being constructed under the Apache license. As Rust serves as its foundation, RustFS provides faster speed and safer distributed features for high-performance object storage.
+RustFS is a high-performance distributed object storage software built using Rust, one of the most popular languages
+worldwide. Along with MinIO, it shares a range of advantages such as simplicity, S3 compatibility, open-source nature,
+support for data lakes, AI, and big data. Furthermore, it has a better and more user-friendly open-source license in
+comparison to other storage systems, being constructed under the Apache license. As Rust serves as its foundation,
+RustFS provides faster speed and safer distributed features for high-performance object storage.
 
 > ⚠️ **RustFS is under rapid development. Do NOT use in production environments!**
 
@@ -46,27 +50,27 @@ RustFS is a high-performance distributed object storage software built using Rus
 
 Stress test server parameters
 
-|  Type  |  parameter   | Remark |
-| - | - | - |
-|CPU | 2 Core | Intel Xeon(Sapphire Rapids) Platinum 8475B , 2.7/3.2 GHz|   |
-|Memory| 4GB |     |
-|Network | 15Gbp |      |
-|Driver  | 40GB x 4 |   IOPS 3800 / Driver |
+| Type    | parameter | Remark                                                   |
+|---------|-----------|----------------------------------------------------------|
+| CPU     | 2 Core    | Intel Xeon(Sapphire Rapids) Platinum 8475B , 2.7/3.2 GHz |   |
+| Memory  | 4GB       |                                                          |
+| Network | 15Gbp     |                                                          |
+| Driver  | 40GB x 4  | IOPS 3800 / Driver                                       |
 
 <https://github.com/user-attachments/assets/2e4979b5-260c-4f2c-ac12-c87fd558072a>
 
 ### RustFS vs Other object storage
 
-| RustFS | Other object storage|
-| - | - |
-| Powerful Console | Simple and useless Console |
-| Developed based on Rust language, memory is safer | Developed in Go or C, with potential issues like memory GC/leaks |
-| Does not report logs to third-party countries  | Reporting logs to other third countries may violate national security laws |
-| Licensed under Apache, more business-friendly  | AGPL V3 License and other License, polluted open source and License traps, infringement of intellectual property rights |
-| Comprehensive S3 support, works with domestic and international cloud providers  | Full support for S3, but no local cloud vendor support |
-| Rust-based development, strong support for secure and innovative devices  | Poor support for edge gateways and secure innovative devices|
-| Stable commercial prices, free community support | High pricing, with costs up to $250,000 for 1PiB |
-| No risk | Intellectual property risks and risks of prohibited uses |
+| RustFS                                                                          | Other object storage                                                                                                    |
+|---------------------------------------------------------------------------------|-------------------------------------------------------------------------------------------------------------------------|
+| Powerful Console                                                                | Simple and useless Console                                                                                              |
+| Developed based on Rust language, memory is safer                               | Developed in Go or C, with potential issues like memory GC/leaks                                                        |
+| Does not report logs to third-party countries                                   | Reporting logs to other third countries may violate national security laws                                              |
+| Licensed under Apache, more business-friendly                                   | AGPL V3 License and other License, polluted open source and License traps, infringement of intellectual property rights |
+| Comprehensive S3 support, works with domestic and international cloud providers | Full support for S3, but no local cloud vendor support                                                                  |
+| Rust-based development, strong support for secure and innovative devices        | Poor support for edge gateways and secure innovative devices                                                            |
+| Stable commercial prices, free community support                                | High pricing, with costs up to $250,000 for 1PiB                                                                        |
+| No risk                                                                         | Intellectual property risks and risks of prohibited uses                                                                |
 
 ## Quickstart
 
@@ -91,13 +95,16 @@ To get started with RustFS, follow these steps:
    docker run -d -p 9000:9000 -v $(pwd)/data:/data -v $(pwd)/logs:/logs rustfs/rustfs:1.0.0.alpha.45
    ```
 
-  For docker installation, you can also run the container with docker compose. With the `docker-compose.yml` file under root directory, running the command:
+For docker installation, you can also run the container with docker compose. With the `docker-compose.yml` file under
+root directory, running the command:
 
   ```
   docker compose --profile observability up -d
   ```
-  
-  **NOTE**: You should be better to have a look for `docker-compose.yaml` file. Because, several services contains in the file. Grafan,prometheus,jaeger containers will be launched using docker compose file, which is helpful for rustfs observability. If you want to start redis as well as nginx container, you can specify the corresponding profiles.
+
+**NOTE**: You should be better to have a look for `docker-compose.yaml` file. Because, several services contains in the
+file. Grafan,prometheus,jaeger containers will be launched using docker compose file, which is helpful for rustfs
+observability. If you want to start redis as well as nginx container, you can specify the corresponding profiles.
 
 3. **Build from Source (Option 3) - Advanced Users**
 
@@ -118,10 +125,10 @@ To get started with RustFS, follow these steps:
    ```
 
    The `docker-buildx.sh` script supports:
-   - **Multi-architecture builds**: `linux/amd64`, `linux/arm64`
-   - **Automatic version detection**: Uses git tags or commit hashes
-   - **Registry flexibility**: Supports Docker Hub, GitHub Container Registry, etc.
-   - **Build optimization**: Includes caching and parallel builds
+    - **Multi-architecture builds**: `linux/amd64`, `linux/arm64`
+    - **Automatic version detection**: Uses git tags or commit hashes
+    - **Registry flexibility**: Supports Docker Hub, GitHub Container Registry, etc.
+    - **Build optimization**: Includes caching and parallel builds
 
    You can also use Make targets for convenience:
 
@@ -132,21 +139,33 @@ To get started with RustFS, follow these steps:
    make help-docker                      # Show all Docker-related commands
    ```
 
-4. **Access the Console**: Open your web browser and navigate to `http://localhost:9000` to access the RustFS console, default username and password is `rustfsadmin` .
-5. **Create a Bucket**: Use the console to create a new bucket for your objects.
-6. **Upload Objects**: You can upload files directly through the console or use S3-compatible APIs to interact with your RustFS instance.
+4. **Build with helm chart(Option 4) - Cloud Native environment**
+
+   Following the instructions on [helm chart README](./helm/README.md) to install RustFS on kubernetes cluster.
+
+5. **Access the Console**: Open your web browser and navigate to `http://localhost:9000` to access the RustFS console,
+   default username and password is `rustfsadmin` .
+6. **Create a Bucket**: Use the console to create a new bucket for your objects.
+7. **Upload Objects**: You can upload files directly through the console or use S3-compatible APIs to interact with your
+   RustFS instance.
+
+**NOTE**: If you want to access RustFS instance with `https`, you can refer
+to [TLS configuration docs](https://docs.rustfs.com/integration/tls-configured.html).
 
 ## Documentation
 
-For detailed documentation, including configuration options, API references, and advanced usage, please visit our [Documentation](https://docs.rustfs.com).
+For detailed documentation, including configuration options, API references, and advanced usage, please visit
+our [Documentation](https://docs.rustfs.com).
 
 ## Getting Help
 
 If you have any questions or need assistance, you can:
 
 - Check the [FAQ](https://github.com/rustfs/rustfs/discussions/categories/q-a) for common issues and solutions.
-- Join our [GitHub Discussions](https://github.com/rustfs/rustfs/discussions) to ask questions and share your experiences.
-- Open an issue on our [GitHub Issues](https://github.com/rustfs/rustfs/issues) page for bug reports or feature requests.
+- Join our [GitHub Discussions](https://github.com/rustfs/rustfs/discussions) to ask questions and share your
+  experiences.
+- Open an issue on our [GitHub Issues](https://github.com/rustfs/rustfs/issues) page for bug reports or feature
+  requests.
 
 ## Links
 
@@ -164,14 +183,28 @@ If you have any questions or need assistance, you can:
 
 ## Contributors
 
-RustFS is a community-driven project, and we appreciate all contributions. Check out the [Contributors](https://github.com/rustfs/rustfs/graphs/contributors) page to see the amazing people who have helped make RustFS better.
+RustFS is a community-driven project, and we appreciate all contributions. Check out
+the [Contributors](https://github.com/rustfs/rustfs/graphs/contributors) page to see the amazing people who have helped
+make RustFS better.
 
 <a href="https://github.com/rustfs/rustfs/graphs/contributors">
-  <img src="https://opencollective.com/rustfs/contributors.svg?width=890&limit=500&button=false" />
+  <img src="https://opencollective.com/rustfs/contributors.svg?width=890&limit=500&button=false" alt="Contributors"/>
 </a>
 
+## Github Trending Top
+
+🚀 RustFS is beloved by open-source enthusiasts and enterprise users worldwide, often appearing on the GitHub Trending
+top charts.
+
+<a href="https://trendshift.io/repositories/14181" target="_blank"><img src="https://raw.githubusercontent.com/rustfs/rustfs/refs/heads/main/docs/rustfs-trending.jpg" alt="rustfs%2Frustfs | Trendshift" /></a>
+
+## Star History
+
+[![Star History Chart](https://api.star-history.com/svg?repos=rustfs/rustfs&type=date&legend=top-left)](https://www.star-history.com/#rustfs/rustfs&type=date&legend=top-left)
+
 ## License
 
 [Apache 2.0](https://opensource.org/licenses/Apache-2.0)
 
 **RustFS** is a trademark of RustFS, Inc. All other trademarks are the property of their respective owners.
+

README_ZH.md

@@ -21,7 +21,9 @@
 <a href="https://github.com/rustfs/rustfs/blob/main/README.md">English</a > | 简体中文
 </p >
 
-RustFS 是一个使用 Rust（全球最受欢迎的编程语言之一）构建的高性能分布式对象存储软件。与 MinIO 一样，它具有简单性、S3 兼容性、开源特性以及对数据湖、AI 和大数据的支持等一系列优势。此外，与其他存储系统相比，它采用 Apache 许可证构建，拥有更好、更用户友好的开源许可证。由于以 Rust 为基础，RustFS 为高性能对象存储提供了更快的速度和更安全的分布式功能。
+RustFS 是一个使用 Rust（全球最受欢迎的编程语言之一）构建的高性能分布式对象存储软件。与 MinIO 一样，它具有简单性、S3
+兼容性、开源特性以及对数据湖、AI 和大数据的支持等一系列优势。此外，与其他存储系统相比，它采用 Apache
+许可证构建，拥有更好、更用户友好的开源许可证。由于以 Rust 为基础，RustFS 为高性能对象存储提供了更快的速度和更安全的分布式功能。
 
 ## 特性
 
@@ -36,27 +38,27 @@ RustFS 是一个使用 Rust（全球最受欢迎的编程语言之一）构建
 
 压力测试服务器参数
 
-|  类型  |  参数   | 备注 |
-| - | - | - |
-|CPU | 2 核心 | Intel Xeon(Sapphire Rapids) Platinum 8475B , 2.7/3.2 GHz|   |
-|内存| 4GB |     |
-|网络 | 15Gbp |      |
-|驱动器  | 40GB x 4 |   IOPS 3800 / 驱动器 |
+| 类型  | 参数       | 备注                                                       |
+|-----|----------|----------------------------------------------------------|
+| CPU | 2 核心     | Intel Xeon(Sapphire Rapids) Platinum 8475B , 2.7/3.2 GHz |   |
+| 内存  | 4GB      |                                                          |
+| 网络  | 15Gbp    |                                                          |
+| 驱动器 | 40GB x 4 | IOPS 3800 / 驱动器                                          |
 
 <https://github.com/user-attachments/assets/2e4979b5-260c-4f2c-ac12-c87fd558072a>
 
 ### RustFS vs 其他对象存储
 
-| RustFS | 其他对象存储|
-| - | - |
-| 强大的控制台 | 简单且无用的控制台 |
-| 基于 Rust 语言开发，内存更安全 | 使用 Go 或 C 开发，存在内存 GC/泄漏等潜在问题 |
-| 不向第三方国家报告日志  | 向其他第三方国家报告日志可能违反国家安全法律 |
-| 采用 Apache 许可证，对商业更友好  | AGPL V3 许可证等其他许可证，污染开源和许可证陷阱，侵犯知识产权 |
-| 全面的 S3 支持，适用于国内外云提供商  | 完全支持 S3，但不支持本地云厂商 |
-| 基于 Rust 开发，对安全和创新设备有强大支持  | 对边缘网关和安全创新设备支持较差|
-| 稳定的商业价格，免费社区支持 | 高昂的定价，1PiB 成本高达 $250,000 |
-| 无风险 | 知识产权风险和禁止使用的风险 |
+| RustFS                   | 其他对象存储                              |
+|--------------------------|-------------------------------------|
+| 强大的控制台                   | 简单且无用的控制台                           |
+| 基于 Rust 语言开发，内存更安全       | 使用 Go 或 C 开发，存在内存 GC/泄漏等潜在问题        |
+| 不向第三方国家报告日志              | 向其他第三方国家报告日志可能违反国家安全法律              |
+| 采用 Apache 许可证，对商业更友好     | AGPL V3 许可证等其他许可证，污染开源和许可证陷阱，侵犯知识产权 |
+| 全面的 S3 支持，适用于国内外云提供商     | 完全支持 S3，但不支持本地云厂商                   |
+| 基于 Rust 开发，对安全和创新设备有强大支持 | 对边缘网关和安全创新设备支持较差                    |
+| 稳定的商业价格，免费社区支持           | 高昂的定价，1PiB 成本高达 $250,000            |
+| 无风险                      | 知识产权风险和禁止使用的风险                      |
 
 ## 快速开始
 
@@ -68,23 +70,66 @@ RustFS 是一个使用 Rust（全球最受欢迎的编程语言之一）构建
    curl -O  https://rustfs.com/install_rustfs.sh && bash install_rustfs.sh
    ```
 
-2. **Docker快速启动（方案二）**
+2. **Docker 快速启动（方案二）**
 
   ```bash
    docker run -d -p 9000:9000  -v /data:/data rustfs/rustfs
    ```
 
-  对于使用 Docker 安装来讲，你还可以使用 `docker compose` 来启动 rustfs 实例。在仓库的根目录下面有一个 `docker-compose.yml` 文件。运行如下命令即可：
+对于使用 Docker 安装来讲，你还可以使用 `docker compose` 来启动 rustfs 实例。在仓库的根目录下面有一个 `docker-compose.yml`
+文件。运行如下命令即可：
 
   ```
   docker compose --profile observability up -d
   ```
-  
-  **注意**：在使用 `docker compose` 之前，你应该仔细阅读一下 `docker-compose.yaml`，因为该文件中包含多个服务，除了 rustfs 以外，还有 grafana、prometheus、jaeger 等，这些是为 rustfs 可观测性服务的，还有 redis 和 nginx。你想启动哪些容器，就需要用 `--profile` 参数指定相应的 profile。
 
-3. **访问控制台**：打开 Web 浏览器并导航到 `http://localhost:9000` 以访问 RustFS 控制台，默认的用户名和密码是 `rustfsadmin` 。
-4. **创建存储桶**：使用控制台为您的对象创建新的存储桶。
-5. **上传对象**：您可以直接通过控制台上传文件，或使用 S3 兼容的 API 与您的 RustFS 实例交互。
+**注意**：在使用 `docker compose` 之前，你应该仔细阅读一下 `docker-compose.yaml`，因为该文件中包含多个服务，除了 rustfs
+以外，还有 grafana、prometheus、jaeger 等，这些是为 rustfs 可观测性服务的，还有 redis 和 nginx。你想启动哪些容器，就需要用
+`--profile` 参数指定相应的 profile。
+
+3. **从源码构建（方案三）- 高级用户**
+
+   面向希望从源码构建支持多架构 Docker 镜像的开发者：
+
+   ```bash
+   # 本地构建多架构镜像
+   ./docker-buildx.sh --build-arg RELEASE=latest
+
+   # 构建并推送至镜像仓库
+   ./docker-buildx.sh --push
+
+   # 构建指定版本
+   ./docker-buildx.sh --release v1.0.0 --push
+
+   # 构建并推送到自定义镜像仓库
+   ./docker-buildx.sh --registry your-registry.com --namespace yourname --push
+   ```
+
+   `docker-buildx.sh` 脚本支持：
+    - **多架构构建**：`linux/amd64`、`linux/arm64`
+    - **自动版本检测**：可使用 git 标签或提交哈希
+    - **仓库灵活性**：支持 Docker Hub、GitHub Container Registry 等
+    - **构建优化**：包含缓存和并行构建
+
+   你也可以使用 Makefile 提供的目标命令以提升便捷性：
+
+   ```bash
+   make docker-buildx                    # 本地构建
+   make docker-buildx-push               # 构建并推送
+   make docker-buildx-version VERSION=v1.0.0  # 构建指定版本
+   make help-docker                      # 显示全部 Docker 相关命令
+   ```
+
+4. **使用 Helm Chart 部署（方案四）- 云原生环境**
+
+   按照 [helm chart 说明文档](./helm/README.md) 的指引，在 Kubernetes 集群中安装 RustFS。
+
+5. **访问控制台**：打开 Web 浏览器并导航到 `http://localhost:9000` 以访问 RustFS 控制台，默认的用户名和密码是
+   `rustfsadmin` 。
+6. **创建存储桶**：使用控制台为您的对象创建新的存储桶。
+7. **上传对象**：您可以直接通过控制台上传文件，或使用 S3 兼容的 API 与您的 RustFS 实例交互。
+
+**注意**：如果你想通过 `https` 来访问 RustFS 实例，请参考 [TLS 配置文档](https://docs.rustfs.com/zh/integration/tls-configured.html)
 
 ## 文档
 
@@ -114,12 +159,23 @@ RustFS 是一个使用 Rust（全球最受欢迎的编程语言之一）构建
 
 ## 贡献者
 
-RustFS 是一个社区驱动的项目，我们感谢所有的贡献。查看[贡献者](https://github.com/rustfs/rustfs/graphs/contributors)页面，了解帮助 RustFS 变得更好的杰出人员。
+RustFS 是一个社区驱动的项目，我们感谢所有的贡献。查看[贡献者](https://github.com/rustfs/rustfs/graphs/contributors)页面，了解帮助
+RustFS 变得更好的杰出人员。
 
 <a href="https://github.com/rustfs/rustfs/graphs/contributors">
-  <img src="https://opencollective.com/rustfs/contributors.svg?width=890&limit=500&button=false" />
+  <img src="https://opencollective.com/rustfs/contributors.svg?width=890&limit=500&button=false" alt="贡献者"/>
 </a >
 
+## Github 全球推荐榜
+
+🚀 RustFS 受到了全世界开源爱好者和企业用户的喜欢，多次登顶 Github Trending 全球榜。
+
+<a href="https://trendshift.io/repositories/14181" target="_blank"><img src="https://raw.githubusercontent.com/rustfs/rustfs/refs/heads/main/docs/rustfs-trending.jpg" alt="rustfs%2Frustfs | Trendshift" /></a>
+
+## Star 历史图
+
+[![Star 历史图](https://api.star-history.com/svg?repos=rustfs/rustfs&type=date&legend=top-left)](https://www.star-history.com/#rustfs/rustfs&type=date&legend=top-left)
+
 ## 许可证
 
 [Apache 2.0](https://opensource.org/licenses/Apache-2.0)

crates/ahm/Cargo.toml

@@ -33,10 +33,11 @@ chrono = { workspace = true }
 rand = { workspace = true }
 reqwest = { workspace = true }
 tempfile = { workspace = true }
+walkdir = { workspace = true }
 
 [dev-dependencies]
 serde_json = { workspace = true }
-serial_test = "3.2.0"
+serial_test = { workspace = true }
 tracing-subscriber = { workspace = true }
-walkdir = "2.5.0"
 tempfile = { workspace = true }
+heed = { workspace = true }

crates/ahm/src/error.rs

@@ -14,6 +14,10 @@
 
 use thiserror::Error;
 
+/// Custom error type for AHM operations
+/// This enum defines various error variants that can occur during
+/// the execution of AHM-related tasks, such as I/O errors, storage errors,
+/// configuration errors, and specific errors related to healing operations.
 #[derive(Debug, Error)]
 pub enum Error {
     #[error("I/O error: {0}")]
@@ -85,9 +89,13 @@ pub enum Error {
     ProgressTrackingFailed { message: String },
 }
 
+/// A specialized Result type for AHM operations
+///This type is a convenient alias for results returned by functions in the AHM crate,
+/// using the custom Error type defined above.
 pub type Result<T, E = Error> = std::result::Result<T, E>;
 
 impl Error {
+    /// Create an Other error from any error type
     pub fn other<E>(error: E) -> Self
     where
         E: Into<Box<dyn std::error::Error + Send + Sync>>,

crates/ahm/src/heal/channel.rs

@@ -12,18 +12,19 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use crate::error::Result;
 use crate::heal::{
     manager::HealManager,
     task::{HealOptions, HealPriority, HealRequest, HealType},
+    utils,
 };
-
+use crate::{Error, Result};
 use rustfs_common::heal_channel::{
     HealChannelCommand, HealChannelPriority, HealChannelReceiver, HealChannelRequest, HealChannelResponse, HealScanMode,
+    publish_heal_response,
 };
 use std::sync::Arc;
 use tokio::sync::mpsc;
-use tracing::{error, info};
+use tracing::{debug, error, info};
 
 /// Heal channel processor
 pub struct HealChannelProcessor {
@@ -60,7 +61,7 @@ impl HealChannelProcessor {
                             }
                         }
                         None => {
-                            info!("Heal channel receiver closed, stopping processor");
+                            debug!("Heal channel receiver closed, stopping processor");
                             break;
                         }
                     }
@@ -99,7 +100,6 @@ impl HealChannelProcessor {
             Ok(task_id) => {
                 info!("Successfully submitted heal request: {} as task: {}", request.id, task_id);
 
-                // Send success response
                 let response = HealChannelResponse {
                     request_id: request.id,
                     success: true,
@@ -107,9 +107,7 @@ impl HealChannelProcessor {
                     error: None,
                 };
 
-                if let Err(e) = self.response_sender.send(response) {
-                    error!("Failed to send heal response: {}", e);
-                }
+                self.publish_response(response);
             }
             Err(e) => {
                 error!("Failed to submit heal request: {} - {}", request.id, e);
@@ -122,9 +120,7 @@ impl HealChannelProcessor {
                     error: Some(e.to_string()),
                 };
 
-                if let Err(e) = self.response_sender.send(response) {
-                    error!("Failed to send heal error response: {}", e);
-                }
+                self.publish_response(response);
             }
         }
 
@@ -144,9 +140,7 @@ impl HealChannelProcessor {
             error: None,
         };
 
-        if let Err(e) = self.response_sender.send(response) {
-            error!("Failed to send query response: {}", e);
-        }
+        self.publish_response(response);
 
         Ok(())
     }
@@ -164,9 +158,7 @@ impl HealChannelProcessor {
             error: None,
         };
 
-        if let Err(e) = self.response_sender.send(response) {
-            error!("Failed to send cancel response: {}", e);
-        }
+        self.publish_response(response);
 
         Ok(())
     }
@@ -174,9 +166,12 @@ impl HealChannelProcessor {
     /// Convert channel request to heal request
     fn convert_to_heal_request(&self, request: HealChannelRequest) -> Result<HealRequest> {
         let heal_type = if let Some(disk_id) = &request.disk {
+            let set_disk_id = utils::normalize_set_disk_id(disk_id).ok_or_else(|| Error::InvalidHealType {
+                heal_type: format!("erasure-set({disk_id})"),
+            })?;
             HealType::ErasureSet {
                 buckets: vec![],
-                set_disk_id: disk_id.clone(),
+                set_disk_id,
             }
         } else if let Some(prefix) = &request.object_prefix {
             if !prefix.is_empty() {
@@ -226,8 +221,332 @@ impl HealChannelProcessor {
         Ok(HealRequest::new(heal_type, options, priority))
     }
 
+    fn publish_response(&self, response: HealChannelResponse) {
+        // Try to send to local channel first, but don't block broadcast on failure
+        if let Err(e) = self.response_sender.send(response.clone()) {
+            error!("Failed to enqueue heal response locally: {}", e);
+        }
+        // Always attempt to broadcast, even if local send failed
+        // Use the original response for broadcast; local send uses a clone
+        if let Err(e) = publish_heal_response(response) {
+            error!("Failed to broadcast heal response: {}", e);
+        }
+    }
+
     /// Get response sender for external use
     pub fn get_response_sender(&self) -> mpsc::UnboundedSender<HealChannelResponse> {
         self.response_sender.clone()
     }
 }
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+    use crate::heal::storage::HealStorageAPI;
+    use rustfs_common::heal_channel::{HealChannelPriority, HealChannelRequest, HealScanMode};
+    use std::sync::Arc;
+
+    // Mock storage for testing
+    struct MockStorage;
+    #[async_trait::async_trait]
+    impl HealStorageAPI for MockStorage {
+        async fn get_object_meta(
+            &self,
+            _bucket: &str,
+            _object: &str,
+        ) -> crate::Result<Option<rustfs_ecstore::store_api::ObjectInfo>> {
+            Ok(None)
+        }
+        async fn get_object_data(&self, _bucket: &str, _object: &str) -> crate::Result<Option<Vec<u8>>> {
+            Ok(None)
+        }
+        async fn put_object_data(&self, _bucket: &str, _object: &str, _data: &[u8]) -> crate::Result<()> {
+            Ok(())
+        }
+        async fn delete_object(&self, _bucket: &str, _object: &str) -> crate::Result<()> {
+            Ok(())
+        }
+        async fn verify_object_integrity(&self, _bucket: &str, _object: &str) -> crate::Result<bool> {
+            Ok(true)
+        }
+        async fn ec_decode_rebuild(&self, _bucket: &str, _object: &str) -> crate::Result<Vec<u8>> {
+            Ok(vec![])
+        }
+        async fn get_disk_status(
+            &self,
+            _endpoint: &rustfs_ecstore::disk::endpoint::Endpoint,
+        ) -> crate::Result<crate::heal::storage::DiskStatus> {
+            Ok(crate::heal::storage::DiskStatus::Ok)
+        }
+        async fn format_disk(&self, _endpoint: &rustfs_ecstore::disk::endpoint::Endpoint) -> crate::Result<()> {
+            Ok(())
+        }
+        async fn get_bucket_info(&self, _bucket: &str) -> crate::Result<Option<rustfs_ecstore::store_api::BucketInfo>> {
+            Ok(None)
+        }
+        async fn heal_bucket_metadata(&self, _bucket: &str) -> crate::Result<()> {
+            Ok(())
+        }
+        async fn list_buckets(&self) -> crate::Result<Vec<rustfs_ecstore::store_api::BucketInfo>> {
+            Ok(vec![])
+        }
+        async fn object_exists(&self, _bucket: &str, _object: &str) -> crate::Result<bool> {
+            Ok(false)
+        }
+        async fn get_object_size(&self, _bucket: &str, _object: &str) -> crate::Result<Option<u64>> {
+            Ok(None)
+        }
+        async fn get_object_checksum(&self, _bucket: &str, _object: &str) -> crate::Result<Option<String>> {
+            Ok(None)
+        }
+        async fn heal_object(
+            &self,
+            _bucket: &str,
+            _object: &str,
+            _version_id: Option<&str>,
+            _opts: &rustfs_common::heal_channel::HealOpts,
+        ) -> crate::Result<(rustfs_madmin::heal_commands::HealResultItem, Option<crate::Error>)> {
+            Ok((rustfs_madmin::heal_commands::HealResultItem::default(), None))
+        }
+        async fn heal_bucket(
+            &self,
+            _bucket: &str,
+            _opts: &rustfs_common::heal_channel::HealOpts,
+        ) -> crate::Result<rustfs_madmin::heal_commands::HealResultItem> {
+            Ok(rustfs_madmin::heal_commands::HealResultItem::default())
+        }
+        async fn heal_format(
+            &self,
+            _dry_run: bool,
+        ) -> crate::Result<(rustfs_madmin::heal_commands::HealResultItem, Option<crate::Error>)> {
+            Ok((rustfs_madmin::heal_commands::HealResultItem::default(), None))
+        }
+        async fn list_objects_for_heal(&self, _bucket: &str, _prefix: &str) -> crate::Result<Vec<String>> {
+            Ok(vec![])
+        }
+        async fn get_disk_for_resume(&self, _set_disk_id: &str) -> crate::Result<rustfs_ecstore::disk::DiskStore> {
+            Err(crate::Error::other("Not implemented in mock"))
+        }
+    }
+
+    fn create_test_heal_manager() -> Arc<HealManager> {
+        let storage: Arc<dyn HealStorageAPI> = Arc::new(MockStorage);
+        Arc::new(HealManager::new(storage, None))
+    }
+
+    #[test]
+    fn test_heal_channel_processor_new() {
+        let heal_manager = create_test_heal_manager();
+        let processor = HealChannelProcessor::new(heal_manager);
+
+        // Verify processor is created successfully
+        let _sender = processor.get_response_sender();
+        // If we can get the sender, processor was created correctly
+    }
+
+    #[tokio::test]
+    async fn test_convert_to_heal_request_bucket() {
+        let heal_manager = create_test_heal_manager();
+        let processor = HealChannelProcessor::new(heal_manager);
+
+        let channel_request = HealChannelRequest {
+            id: "test-id".to_string(),
+            bucket: "test-bucket".to_string(),
+            object_prefix: None,
+            disk: None,
+            priority: HealChannelPriority::Normal,
+            scan_mode: None,
+            remove_corrupted: None,
+            recreate_missing: None,
+            update_parity: None,
+            recursive: None,
+            dry_run: None,
+            timeout_seconds: None,
+            pool_index: None,
+            set_index: None,
+            force_start: false,
+        };
+
+        let heal_request = processor.convert_to_heal_request(channel_request).unwrap();
+        assert!(matches!(heal_request.heal_type, HealType::Bucket { .. }));
+        assert_eq!(heal_request.priority, HealPriority::Normal);
+    }
+
+    #[tokio::test]
+    async fn test_convert_to_heal_request_object() {
+        let heal_manager = create_test_heal_manager();
+        let processor = HealChannelProcessor::new(heal_manager);
+
+        let channel_request = HealChannelRequest {
+            id: "test-id".to_string(),
+            bucket: "test-bucket".to_string(),
+            object_prefix: Some("test-object".to_string()),
+            disk: None,
+            priority: HealChannelPriority::High,
+            scan_mode: Some(HealScanMode::Deep),
+            remove_corrupted: Some(true),
+            recreate_missing: Some(true),
+            update_parity: Some(true),
+            recursive: Some(false),
+            dry_run: Some(false),
+            timeout_seconds: Some(300),
+            pool_index: Some(0),
+            set_index: Some(1),
+            force_start: false,
+        };
+
+        let heal_request = processor.convert_to_heal_request(channel_request).unwrap();
+        assert!(matches!(heal_request.heal_type, HealType::Object { .. }));
+        assert_eq!(heal_request.priority, HealPriority::High);
+        assert_eq!(heal_request.options.scan_mode, HealScanMode::Deep);
+        assert!(heal_request.options.remove_corrupted);
+        assert!(heal_request.options.recreate_missing);
+    }
+
+    #[tokio::test]
+    async fn test_convert_to_heal_request_erasure_set() {
+        let heal_manager = create_test_heal_manager();
+        let processor = HealChannelProcessor::new(heal_manager);
+
+        let channel_request = HealChannelRequest {
+            id: "test-id".to_string(),
+            bucket: "test-bucket".to_string(),
+            object_prefix: None,
+            disk: Some("pool_0_set_1".to_string()),
+            priority: HealChannelPriority::Critical,
+            scan_mode: None,
+            remove_corrupted: None,
+            recreate_missing: None,
+            update_parity: None,
+            recursive: None,
+            dry_run: None,
+            timeout_seconds: None,
+            pool_index: None,
+            set_index: None,
+            force_start: false,
+        };
+
+        let heal_request = processor.convert_to_heal_request(channel_request).unwrap();
+        assert!(matches!(heal_request.heal_type, HealType::ErasureSet { .. }));
+        assert_eq!(heal_request.priority, HealPriority::Urgent);
+    }
+
+    #[tokio::test]
+    async fn test_convert_to_heal_request_invalid_disk_id() {
+        let heal_manager = create_test_heal_manager();
+        let processor = HealChannelProcessor::new(heal_manager);
+
+        let channel_request = HealChannelRequest {
+            id: "test-id".to_string(),
+            bucket: "test-bucket".to_string(),
+            object_prefix: None,
+            disk: Some("invalid-disk-id".to_string()),
+            priority: HealChannelPriority::Normal,
+            scan_mode: None,
+            remove_corrupted: None,
+            recreate_missing: None,
+            update_parity: None,
+            recursive: None,
+            dry_run: None,
+            timeout_seconds: None,
+            pool_index: None,
+            set_index: None,
+            force_start: false,
+        };
+
+        let result = processor.convert_to_heal_request(channel_request);
+        assert!(result.is_err());
+    }
+
+    #[tokio::test]
+    async fn test_convert_to_heal_request_priority_mapping() {
+        let heal_manager = create_test_heal_manager();
+        let processor = HealChannelProcessor::new(heal_manager);
+
+        let priorities = vec![
+            (HealChannelPriority::Low, HealPriority::Low),
+            (HealChannelPriority::Normal, HealPriority::Normal),
+            (HealChannelPriority::High, HealPriority::High),
+            (HealChannelPriority::Critical, HealPriority::Urgent),
+        ];
+
+        for (channel_priority, expected_heal_priority) in priorities {
+            let channel_request = HealChannelRequest {
+                id: "test-id".to_string(),
+                bucket: "test-bucket".to_string(),
+                object_prefix: None,
+                disk: None,
+                priority: channel_priority,
+                scan_mode: None,
+                remove_corrupted: None,
+                recreate_missing: None,
+                update_parity: None,
+                recursive: None,
+                dry_run: None,
+                timeout_seconds: None,
+                pool_index: None,
+                set_index: None,
+                force_start: false,
+            };
+
+            let heal_request = processor.convert_to_heal_request(channel_request).unwrap();
+            assert_eq!(heal_request.priority, expected_heal_priority);
+        }
+    }
+
+    #[tokio::test]
+    async fn test_convert_to_heal_request_force_start() {
+        let heal_manager = create_test_heal_manager();
+        let processor = HealChannelProcessor::new(heal_manager);
+
+        let channel_request = HealChannelRequest {
+            id: "test-id".to_string(),
+            bucket: "test-bucket".to_string(),
+            object_prefix: None,
+            disk: None,
+            priority: HealChannelPriority::Normal,
+            scan_mode: None,
+            remove_corrupted: Some(false),
+            recreate_missing: Some(false),
+            update_parity: Some(false),
+            recursive: None,
+            dry_run: None,
+            timeout_seconds: None,
+            pool_index: None,
+            set_index: None,
+            force_start: true, // Should override the above false values
+        };
+
+        let heal_request = processor.convert_to_heal_request(channel_request).unwrap();
+        assert!(heal_request.options.remove_corrupted);
+        assert!(heal_request.options.recreate_missing);
+        assert!(heal_request.options.update_parity);
+    }
+
+    #[tokio::test]
+    async fn test_convert_to_heal_request_empty_object_prefix() {
+        let heal_manager = create_test_heal_manager();
+        let processor = HealChannelProcessor::new(heal_manager);
+
+        let channel_request = HealChannelRequest {
+            id: "test-id".to_string(),
+            bucket: "test-bucket".to_string(),
+            object_prefix: Some("".to_string()), // Empty prefix should be treated as bucket heal
+            disk: None,
+            priority: HealChannelPriority::Normal,
+            scan_mode: None,
+            remove_corrupted: None,
+            recreate_missing: None,
+            update_parity: None,
+            recursive: None,
+            dry_run: None,
+            timeout_seconds: None,
+            pool_index: None,
+            set_index: None,
+            force_start: false,
+        };
+
+        let heal_request = processor.convert_to_heal_request(channel_request).unwrap();
+        assert!(matches!(heal_request.heal_type, HealType::Bucket { .. }));
+    }
+}

crates/ahm/src/heal/erasure_healer.rs

@@ -12,12 +12,12 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use crate::error::{Error, Result};
 use crate::heal::{
     progress::HealProgress,
     resume::{CheckpointManager, ResumeManager, ResumeUtils},
     storage::HealStorageAPI,
 };
+use crate::{Error, Result};
 use futures::future::join_all;
 use rustfs_common::heal_channel::{HealOpts, HealScanMode};
 use rustfs_ecstore::disk::DiskStore;
@@ -56,7 +56,7 @@ impl ErasureSetHealer {
         let task_id = self.get_or_create_task_id(set_disk_id).await?;
 
         // 2. initialize or resume resume state
-        let (resume_manager, checkpoint_manager) = self.initialize_resume_state(&task_id, buckets).await?;
+        let (resume_manager, checkpoint_manager) = self.initialize_resume_state(&task_id, set_disk_id, buckets).await?;
 
         // 3. execute heal with resume
         let result = self
@@ -77,25 +77,38 @@ impl ErasureSetHealer {
     }
 
     /// get or create task id
-    async fn get_or_create_task_id(&self, _set_disk_id: &str) -> Result<String> {
+    async fn get_or_create_task_id(&self, set_disk_id: &str) -> Result<String> {
         // check if there are resumable tasks
         let resumable_tasks = ResumeUtils::get_resumable_tasks(&self.disk).await?;
 
         for task_id in resumable_tasks {
-            if ResumeUtils::can_resume_task(&self.disk, &task_id).await {
-                info!("Found resumable task: {}", task_id);
-                return Ok(task_id);
+            match ResumeManager::load_from_disk(self.disk.clone(), &task_id).await {
+                Ok(manager) => {
+                    let state = manager.get_state().await;
+                    if state.set_disk_id == set_disk_id && ResumeUtils::can_resume_task(&self.disk, &task_id).await {
+                        info!("Found resumable task: {} for set {}", task_id, set_disk_id);
+                        return Ok(task_id);
+                    }
+                }
+                Err(e) => {
+                    warn!("Failed to load resume state for task {}: {}", task_id, e);
+                }
             }
         }
 
         // create new task id
-        let task_id = ResumeUtils::generate_task_id();
+        let task_id = format!("{}_{}", set_disk_id, ResumeUtils::generate_task_id());
         info!("Created new heal task: {}", task_id);
         Ok(task_id)
     }
 
     /// initialize or resume resume state
-    async fn initialize_resume_state(&self, task_id: &str, buckets: &[String]) -> Result<(ResumeManager, CheckpointManager)> {
+    async fn initialize_resume_state(
+        &self,
+        task_id: &str,
+        set_disk_id: &str,
+        buckets: &[String],
+    ) -> Result<(ResumeManager, CheckpointManager)> {
         // check if resume state exists
         if ResumeManager::has_resume_state(&self.disk, task_id).await {
             info!("Loading existing resume state for task: {}", task_id);
@@ -111,8 +124,14 @@ impl ErasureSetHealer {
         } else {
             info!("Creating new resume state for task: {}", task_id);
 
-            let resume_manager =
-                ResumeManager::new(self.disk.clone(), task_id.to_string(), "erasure_set".to_string(), buckets.to_vec()).await?;
+            let resume_manager = ResumeManager::new(
+                self.disk.clone(),
+                task_id.to_string(),
+                "erasure_set".to_string(),
+                set_disk_id.to_string(),
+                buckets.to_vec(),
+            )
+            .await?;
 
             let checkpoint_manager = CheckpointManager::new(self.disk.clone(), task_id.to_string()).await?;
 
@@ -162,6 +181,7 @@ impl ErasureSetHealer {
             let bucket_result = self
                 .heal_bucket_with_resume(
                     bucket,
+                    bucket_idx,
                     &mut current_object_index,
                     &mut processed_objects,
                     &mut successful_objects,
@@ -182,7 +202,7 @@ impl ErasureSetHealer {
 
             // check cancel status
             if self.cancel_token.is_cancelled() {
-                info!("Heal task cancelled");
+                warn!("Heal task cancelled");
                 return Err(Error::TaskCancelled);
             }
 
@@ -214,6 +234,7 @@ impl ErasureSetHealer {
     async fn heal_bucket_with_resume(
         &self,
         bucket: &str,
+        bucket_index: usize,
         current_object_index: &mut usize,
         processed_objects: &mut u64,
         successful_objects: &mut u64,
@@ -222,7 +243,7 @@ impl ErasureSetHealer {
         resume_manager: &ResumeManager,
         checkpoint_manager: &CheckpointManager,
     ) -> Result<()> {
-        info!("Starting heal for bucket: {} from object index {}", bucket, current_object_index);
+        info!(target: "rustfs:ahm:heal_bucket_with_resume" ,"Starting heal for bucket: {} from object index {}", bucket, current_object_index);
 
         // 1. get bucket info
         let _bucket_info = match self.storage.get_bucket_info(bucket).await? {
@@ -260,7 +281,7 @@ impl ErasureSetHealer {
 
             if !object_exists {
                 info!(
-                    "Object {}/{} no longer exists, skipping heal (likely deleted intentionally)",
+                    target: "rustfs:ahm:heal_bucket_with_resume" ,"Object {}/{} no longer exists, skipping heal (likely deleted intentionally)",
                     bucket, object
                 );
                 checkpoint_manager.add_processed_object(object.clone()).await?;
@@ -306,7 +327,9 @@ impl ErasureSetHealer {
 
             // save checkpoint periodically
             if obj_idx % 100 == 0 {
-                checkpoint_manager.update_position(0, *current_object_index).await?;
+                checkpoint_manager
+                    .update_position(bucket_index, *current_object_index)
+                    .await?;
             }
         }
 
@@ -337,7 +360,10 @@ impl ErasureSetHealer {
             let cancel_token = self.cancel_token.clone();
 
             async move {
-                let _permit = semaphore.acquire().await.unwrap();
+                let _permit = semaphore
+                    .acquire()
+                    .await
+                    .map_err(|e| Error::other(format!("Failed to acquire semaphore for bucket heal: {}", e)))?;
 
                 if cancel_token.is_cancelled() {
                     return Err(Error::TaskCancelled);
@@ -432,7 +458,10 @@ impl ErasureSetHealer {
             let semaphore = semaphore.clone();
 
             async move {
-                let _permit = semaphore.acquire().await.unwrap();
+                let _permit = semaphore
+                    .acquire()
+                    .await
+                    .map_err(|e| Error::other(format!("Failed to acquire semaphore for object heal: {}", e)))?;
 
                 match storage.heal_object(&bucket, &object, None, &heal_opts).await {
                     Ok((_result, None)) => {

crates/ahm/src/heal/event.rs

@@ -12,7 +12,8 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use crate::heal::task::{HealOptions, HealPriority, HealRequest, HealType};
+use crate::heal::{HealOptions, HealPriority, HealRequest, HealType};
+use crate::{Error, Result};
 use rustfs_ecstore::disk::endpoint::Endpoint;
 use serde::{Deserialize, Serialize};
 use std::time::SystemTime;
@@ -104,7 +105,7 @@ pub enum HealEvent {
 
 impl HealEvent {
     /// Convert HealEvent to HealRequest
-    pub fn to_heal_request(&self) -> HealRequest {
+    pub fn to_heal_request(&self) -> Result<HealRequest> {
         match self {
             HealEvent::ObjectCorruption {
                 bucket,
@@ -112,7 +113,7 @@ impl HealEvent {
                 version_id,
                 severity,
                 ..
-            } => HealRequest::new(
+            } => Ok(HealRequest::new(
                 HealType::Object {
                     bucket: bucket.clone(),
                     object: object.clone(),
@@ -120,13 +121,13 @@ impl HealEvent {
                 },
                 HealOptions::default(),
                 Self::severity_to_priority(severity),
-            ),
+            )),
             HealEvent::ObjectMissing {
                 bucket,
                 object,
                 version_id,
                 ..
-            } => HealRequest::new(
+            } => Ok(HealRequest::new(
                 HealType::Object {
                     bucket: bucket.clone(),
                     object: object.clone(),
@@ -134,34 +135,38 @@ impl HealEvent {
                 },
                 HealOptions::default(),
                 HealPriority::High,
-            ),
-            HealEvent::MetadataCorruption { bucket, object, .. } => HealRequest::new(
+            )),
+            HealEvent::MetadataCorruption { bucket, object, .. } => Ok(HealRequest::new(
                 HealType::Metadata {
                     bucket: bucket.clone(),
                     object: object.clone(),
                 },
                 HealOptions::default(),
                 HealPriority::High,
-            ),
+            )),
             HealEvent::DiskStatusChange { endpoint, .. } => {
                 // Convert disk status change to erasure set heal
                 // Note: This requires access to storage to get bucket list, which is not available here
                 // The actual bucket list will need to be provided by the caller or retrieved differently
-                HealRequest::new(
+                let set_disk_id = crate::heal::utils::format_set_disk_id_from_i32(endpoint.pool_idx, endpoint.set_idx)
+                    .ok_or_else(|| Error::InvalidHealType {
+                        heal_type: format!("erasure-set(pool={}, set={})", endpoint.pool_idx, endpoint.set_idx),
+                    })?;
+                Ok(HealRequest::new(
                     HealType::ErasureSet {
                         buckets: vec![], // Empty bucket list - caller should populate this
-                        set_disk_id: format!("{}_{}", endpoint.pool_idx, endpoint.set_idx),
+                        set_disk_id,
                     },
                     HealOptions::default(),
                     HealPriority::High,
-                )
+                ))
             }
             HealEvent::ECDecodeFailure {
                 bucket,
                 object,
                 version_id,
                 ..
-            } => HealRequest::new(
+            } => Ok(HealRequest::new(
                 HealType::ECDecode {
                     bucket: bucket.clone(),
                     object: object.clone(),
@@ -169,13 +174,13 @@ impl HealEvent {
                 },
                 HealOptions::default(),
                 HealPriority::Urgent,
-            ),
+            )),
             HealEvent::ChecksumMismatch {
                 bucket,
                 object,
                 version_id,
                 ..
-            } => HealRequest::new(
+            } => Ok(HealRequest::new(
                 HealType::Object {
                     bucket: bucket.clone(),
                     object: object.clone(),
@@ -183,17 +188,19 @@ impl HealEvent {
                 },
                 HealOptions::default(),
                 HealPriority::High,
-            ),
-            HealEvent::BucketMetadataCorruption { bucket, .. } => {
-                HealRequest::new(HealType::Bucket { bucket: bucket.clone() }, HealOptions::default(), HealPriority::High)
-            }
-            HealEvent::MRFMetadataCorruption { meta_path, .. } => HealRequest::new(
+            )),
+            HealEvent::BucketMetadataCorruption { bucket, .. } => Ok(HealRequest::new(
+                HealType::Bucket { bucket: bucket.clone() },
+                HealOptions::default(),
+                HealPriority::High,
+            )),
+            HealEvent::MRFMetadataCorruption { meta_path, .. } => Ok(HealRequest::new(
                 HealType::MRF {
                     meta_path: meta_path.clone(),
                 },
                 HealOptions::default(),
                 HealPriority::High,
-            ),
+            )),
         }
     }
 
@@ -357,3 +364,319 @@ impl Default for HealEventHandler {
         Self::new(1000)
     }
 }
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+    use crate::heal::task::{HealPriority, HealType};
+
+    #[test]
+    fn test_heal_event_object_corruption_to_request() {
+        let event = HealEvent::ObjectCorruption {
+            bucket: "test-bucket".to_string(),
+            object: "test-object".to_string(),
+            version_id: None,
+            corruption_type: CorruptionType::DataCorruption,
+            severity: Severity::High,
+        };
+
+        let request = event.to_heal_request().unwrap();
+        assert!(matches!(request.heal_type, HealType::Object { .. }));
+        assert_eq!(request.priority, HealPriority::High);
+    }
+
+    #[test]
+    fn test_heal_event_object_missing_to_request() {
+        let event = HealEvent::ObjectMissing {
+            bucket: "test-bucket".to_string(),
+            object: "test-object".to_string(),
+            version_id: Some("v1".to_string()),
+            expected_locations: vec![0, 1],
+            available_locations: vec![2, 3],
+        };
+
+        let request = event.to_heal_request().unwrap();
+        assert!(matches!(request.heal_type, HealType::Object { .. }));
+        assert_eq!(request.priority, HealPriority::High);
+    }
+
+    #[test]
+    fn test_heal_event_metadata_corruption_to_request() {
+        let event = HealEvent::MetadataCorruption {
+            bucket: "test-bucket".to_string(),
+            object: "test-object".to_string(),
+            corruption_type: CorruptionType::MetadataCorruption,
+        };
+
+        let request = event.to_heal_request().unwrap();
+        assert!(matches!(request.heal_type, HealType::Metadata { .. }));
+        assert_eq!(request.priority, HealPriority::High);
+    }
+
+    #[test]
+    fn test_heal_event_ec_decode_failure_to_request() {
+        let event = HealEvent::ECDecodeFailure {
+            bucket: "test-bucket".to_string(),
+            object: "test-object".to_string(),
+            version_id: None,
+            missing_shards: vec![0, 1],
+            available_shards: vec![2, 3, 4],
+        };
+
+        let request = event.to_heal_request().unwrap();
+        assert!(matches!(request.heal_type, HealType::ECDecode { .. }));
+        assert_eq!(request.priority, HealPriority::Urgent);
+    }
+
+    #[test]
+    fn test_heal_event_checksum_mismatch_to_request() {
+        let event = HealEvent::ChecksumMismatch {
+            bucket: "test-bucket".to_string(),
+            object: "test-object".to_string(),
+            version_id: None,
+            expected_checksum: "abc123".to_string(),
+            actual_checksum: "def456".to_string(),
+        };
+
+        let request = event.to_heal_request().unwrap();
+        assert!(matches!(request.heal_type, HealType::Object { .. }));
+        assert_eq!(request.priority, HealPriority::High);
+    }
+
+    #[test]
+    fn test_heal_event_bucket_metadata_corruption_to_request() {
+        let event = HealEvent::BucketMetadataCorruption {
+            bucket: "test-bucket".to_string(),
+            corruption_type: CorruptionType::MetadataCorruption,
+        };
+
+        let request = event.to_heal_request().unwrap();
+        assert!(matches!(request.heal_type, HealType::Bucket { .. }));
+        assert_eq!(request.priority, HealPriority::High);
+    }
+
+    #[test]
+    fn test_heal_event_mrf_metadata_corruption_to_request() {
+        let event = HealEvent::MRFMetadataCorruption {
+            meta_path: "test-bucket/test-object".to_string(),
+            corruption_type: CorruptionType::MetadataCorruption,
+        };
+
+        let request = event.to_heal_request().unwrap();
+        assert!(matches!(request.heal_type, HealType::MRF { .. }));
+        assert_eq!(request.priority, HealPriority::High);
+    }
+
+    #[test]
+    fn test_heal_event_severity_to_priority() {
+        let event_low = HealEvent::ObjectCorruption {
+            bucket: "test".to_string(),
+            object: "test".to_string(),
+            version_id: None,
+            corruption_type: CorruptionType::DataCorruption,
+            severity: Severity::Low,
+        };
+        let request = event_low.to_heal_request().unwrap();
+        assert_eq!(request.priority, HealPriority::Low);
+
+        let event_medium = HealEvent::ObjectCorruption {
+            bucket: "test".to_string(),
+            object: "test".to_string(),
+            version_id: None,
+            corruption_type: CorruptionType::DataCorruption,
+            severity: Severity::Medium,
+        };
+        let request = event_medium.to_heal_request().unwrap();
+        assert_eq!(request.priority, HealPriority::Normal);
+
+        let event_high = HealEvent::ObjectCorruption {
+            bucket: "test".to_string(),
+            object: "test".to_string(),
+            version_id: None,
+            corruption_type: CorruptionType::DataCorruption,
+            severity: Severity::High,
+        };
+        let request = event_high.to_heal_request().unwrap();
+        assert_eq!(request.priority, HealPriority::High);
+
+        let event_critical = HealEvent::ObjectCorruption {
+            bucket: "test".to_string(),
+            object: "test".to_string(),
+            version_id: None,
+            corruption_type: CorruptionType::DataCorruption,
+            severity: Severity::Critical,
+        };
+        let request = event_critical.to_heal_request().unwrap();
+        assert_eq!(request.priority, HealPriority::Urgent);
+    }
+
+    #[test]
+    fn test_heal_event_description() {
+        let event = HealEvent::ObjectCorruption {
+            bucket: "test-bucket".to_string(),
+            object: "test-object".to_string(),
+            version_id: None,
+            corruption_type: CorruptionType::DataCorruption,
+            severity: Severity::High,
+        };
+
+        let desc = event.description();
+        assert!(desc.contains("Object corruption detected"));
+        assert!(desc.contains("test-bucket/test-object"));
+        assert!(desc.contains("DataCorruption"));
+    }
+
+    #[test]
+    fn test_heal_event_severity() {
+        let event = HealEvent::ECDecodeFailure {
+            bucket: "test".to_string(),
+            object: "test".to_string(),
+            version_id: None,
+            missing_shards: vec![],
+            available_shards: vec![],
+        };
+        assert_eq!(event.severity(), Severity::Critical);
+
+        let event = HealEvent::ObjectMissing {
+            bucket: "test".to_string(),
+            object: "test".to_string(),
+            version_id: None,
+            expected_locations: vec![],
+            available_locations: vec![],
+        };
+        assert_eq!(event.severity(), Severity::High);
+    }
+
+    #[test]
+    fn test_heal_event_handler_new() {
+        let handler = HealEventHandler::new(10);
+        assert_eq!(handler.event_count(), 0);
+        assert_eq!(handler.max_events, 10);
+    }
+
+    #[test]
+    fn test_heal_event_handler_default() {
+        let handler = HealEventHandler::default();
+        assert_eq!(handler.max_events, 1000);
+    }
+
+    #[test]
+    fn test_heal_event_handler_add_event() {
+        let mut handler = HealEventHandler::new(3);
+        let event = HealEvent::ObjectCorruption {
+            bucket: "test".to_string(),
+            object: "test".to_string(),
+            version_id: None,
+            corruption_type: CorruptionType::DataCorruption,
+            severity: Severity::High,
+        };
+
+        handler.add_event(event.clone());
+        assert_eq!(handler.event_count(), 1);
+
+        handler.add_event(event.clone());
+        handler.add_event(event.clone());
+        assert_eq!(handler.event_count(), 3);
+    }
+
+    #[test]
+    fn test_heal_event_handler_max_events() {
+        let mut handler = HealEventHandler::new(2);
+        let event = HealEvent::ObjectCorruption {
+            bucket: "test".to_string(),
+            object: "test".to_string(),
+            version_id: None,
+            corruption_type: CorruptionType::DataCorruption,
+            severity: Severity::High,
+        };
+
+        handler.add_event(event.clone());
+        handler.add_event(event.clone());
+        handler.add_event(event.clone()); // Should remove oldest
+
+        assert_eq!(handler.event_count(), 2);
+    }
+
+    #[test]
+    fn test_heal_event_handler_get_events() {
+        let mut handler = HealEventHandler::new(10);
+        let event = HealEvent::ObjectCorruption {
+            bucket: "test".to_string(),
+            object: "test".to_string(),
+            version_id: None,
+            corruption_type: CorruptionType::DataCorruption,
+            severity: Severity::High,
+        };
+
+        handler.add_event(event.clone());
+        handler.add_event(event.clone());
+
+        let events = handler.get_events();
+        assert_eq!(events.len(), 2);
+    }
+
+    #[test]
+    fn test_heal_event_handler_clear_events() {
+        let mut handler = HealEventHandler::new(10);
+        let event = HealEvent::ObjectCorruption {
+            bucket: "test".to_string(),
+            object: "test".to_string(),
+            version_id: None,
+            corruption_type: CorruptionType::DataCorruption,
+            severity: Severity::High,
+        };
+
+        handler.add_event(event);
+        assert_eq!(handler.event_count(), 1);
+
+        handler.clear_events();
+        assert_eq!(handler.event_count(), 0);
+    }
+
+    #[test]
+    fn test_heal_event_handler_filter_by_severity() {
+        let mut handler = HealEventHandler::new(10);
+        handler.add_event(HealEvent::ObjectCorruption {
+            bucket: "test".to_string(),
+            object: "test".to_string(),
+            version_id: None,
+            corruption_type: CorruptionType::DataCorruption,
+            severity: Severity::Low,
+        });
+        handler.add_event(HealEvent::ECDecodeFailure {
+            bucket: "test".to_string(),
+            object: "test".to_string(),
+            version_id: None,
+            missing_shards: vec![],
+            available_shards: vec![],
+        });
+
+        let high_severity = handler.filter_by_severity(Severity::High);
+        assert_eq!(high_severity.len(), 1); // Only ECDecodeFailure is Critical >= High
+    }
+
+    #[test]
+    fn test_heal_event_handler_filter_by_type() {
+        let mut handler = HealEventHandler::new(10);
+        handler.add_event(HealEvent::ObjectCorruption {
+            bucket: "test".to_string(),
+            object: "test".to_string(),
+            version_id: None,
+            corruption_type: CorruptionType::DataCorruption,
+            severity: Severity::High,
+        });
+        handler.add_event(HealEvent::ObjectMissing {
+            bucket: "test".to_string(),
+            object: "test".to_string(),
+            version_id: None,
+            expected_locations: vec![],
+            available_locations: vec![],
+        });
+
+        let corruption_events = handler.filter_by_type("ObjectCorruption");
+        assert_eq!(corruption_events.len(), 1);
+
+        let missing_events = handler.filter_by_type("ObjectMissing");
+        assert_eq!(missing_events.len(), 1);
+    }
+}

crates/ahm/src/heal/manager.rs

@@ -12,12 +12,12 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use crate::error::{Error, Result};
 use crate::heal::{
     progress::{HealProgress, HealStatistics},
     storage::HealStorageAPI,
     task::{HealOptions, HealPriority, HealRequest, HealTask, HealTaskStatus, HealType},
 };
+use crate::{Error, Result};
 use rustfs_ecstore::disk::DiskAPI;
 use rustfs_ecstore::disk::error::DiskError;
 use rustfs_ecstore::global::GLOBAL_LOCAL_DISK_MAP;
@@ -310,17 +310,36 @@ impl HealManager {
 
                         // Create erasure set heal requests for each endpoint
                         for ep in endpoints {
+                            let Some(set_disk_id) =
+                                crate::heal::utils::format_set_disk_id_from_i32(ep.pool_idx, ep.set_idx)
+                            else {
+                                warn!("Skipping endpoint {} without valid pool/set index", ep);
+                                continue;
+                            };
                             // skip if already queued or healing
+                            // Use consistent lock order: queue first, then active_heals to avoid deadlock
                             let mut skip = false;
                             {
                                 let queue = heal_queue.lock().await;
-                                if queue.iter().any(|req| matches!(&req.heal_type, crate::heal::task::HealType::ErasureSet { set_disk_id, .. } if set_disk_id == &format!("{}_{}", ep.pool_idx, ep.set_idx))) {
+                                if queue.iter().any(|req| {
+                                    matches!(
+                                        &req.heal_type,
+                                        crate::heal::task::HealType::ErasureSet { set_disk_id: queued_id, .. }
+                                        if queued_id == &set_disk_id
+                                    )
+                                }) {
                                     skip = true;
                                 }
                             }
                             if !skip {
                                 let active = active_heals.lock().await;
-                                if active.values().any(|task| matches!(&task.heal_type, crate::heal::task::HealType::ErasureSet { set_disk_id, .. } if set_disk_id == &format!("{}_{}", ep.pool_idx, ep.set_idx))) {
+                                if active.values().any(|task| {
+                                    matches!(
+                                        &task.heal_type,
+                                        crate::heal::task::HealType::ErasureSet { set_disk_id: active_id, .. }
+                                        if active_id == &set_disk_id
+                                    )
+                                }) {
                                     skip = true;
                                 }
                             }
@@ -330,11 +349,10 @@ impl HealManager {
                             }
 
                             // enqueue erasure set heal request for this disk
-                            let set_disk_id = format!("pool_{}_set_{}", ep.pool_idx, ep.set_idx);
                             let req = HealRequest::new(
                                 HealType::ErasureSet {
                                     buckets: buckets.clone(),
-                                    set_disk_id: set_disk_id.clone()
+                                    set_disk_id: set_disk_id.clone(),
                                 },
                                 HealOptions::default(),
                                 HealPriority::Normal,

crates/ahm/src/heal/mod.rs

@@ -20,6 +20,7 @@ pub mod progress;
 pub mod resume;
 pub mod storage;
 pub mod task;
+pub mod utils;
 
 pub use erasure_healer::ErasureSetHealer;
 pub use manager::HealManager;

crates/ahm/src/heal/progress.rs

@@ -146,3 +146,244 @@ impl HealStatistics {
         }
     }
 }
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[test]
+    fn test_heal_progress_new() {
+        let progress = HealProgress::new();
+        assert_eq!(progress.objects_scanned, 0);
+        assert_eq!(progress.objects_healed, 0);
+        assert_eq!(progress.objects_failed, 0);
+        assert_eq!(progress.bytes_processed, 0);
+        assert_eq!(progress.progress_percentage, 0.0);
+        assert!(progress.start_time.is_some());
+        assert!(progress.last_update_time.is_some());
+        assert!(progress.current_object.is_none());
+    }
+
+    #[test]
+    fn test_heal_progress_update_progress() {
+        let mut progress = HealProgress::new();
+        progress.update_progress(10, 8, 2, 1024);
+
+        assert_eq!(progress.objects_scanned, 10);
+        assert_eq!(progress.objects_healed, 8);
+        assert_eq!(progress.objects_failed, 2);
+        assert_eq!(progress.bytes_processed, 1024);
+        // Progress percentage should be calculated based on healed/total
+        // total = scanned + healed + failed = 10 + 8 + 2 = 20
+        // healed/total = 8/20 = 0.4 = 40%
+        assert!((progress.progress_percentage - 40.0).abs() < 0.001);
+        assert!(progress.last_update_time.is_some());
+    }
+
+    #[test]
+    fn test_heal_progress_update_progress_zero_total() {
+        let mut progress = HealProgress::new();
+        progress.update_progress(0, 0, 0, 0);
+
+        assert_eq!(progress.progress_percentage, 0.0);
+    }
+
+    #[test]
+    fn test_heal_progress_update_progress_all_healed() {
+        let mut progress = HealProgress::new();
+        // When scanned=0, healed=10, failed=0: total=10, progress = 10/10 = 100%
+        progress.update_progress(0, 10, 0, 2048);
+
+        // All healed, should be 100%
+        assert!((progress.progress_percentage - 100.0).abs() < 0.001);
+    }
+
+    #[test]
+    fn test_heal_progress_set_current_object() {
+        let mut progress = HealProgress::new();
+        let initial_time = progress.last_update_time;
+
+        // Small delay to ensure time difference
+        std::thread::sleep(std::time::Duration::from_millis(10));
+
+        progress.set_current_object(Some("test-bucket/test-object".to_string()));
+
+        assert_eq!(progress.current_object, Some("test-bucket/test-object".to_string()));
+        assert!(progress.last_update_time.is_some());
+        // last_update_time should be updated
+        assert_ne!(progress.last_update_time, initial_time);
+    }
+
+    #[test]
+    fn test_heal_progress_set_current_object_none() {
+        let mut progress = HealProgress::new();
+        progress.set_current_object(Some("test".to_string()));
+        progress.set_current_object(None);
+
+        assert!(progress.current_object.is_none());
+    }
+
+    #[test]
+    fn test_heal_progress_is_completed_by_percentage() {
+        let mut progress = HealProgress::new();
+        progress.update_progress(10, 10, 0, 1024);
+
+        assert!(progress.is_completed());
+    }
+
+    #[test]
+    fn test_heal_progress_is_completed_by_processed() {
+        let mut progress = HealProgress::new();
+        progress.objects_scanned = 10;
+        progress.objects_healed = 8;
+        progress.objects_failed = 2;
+        // healed + failed = 8 + 2 = 10 >= scanned = 10
+        assert!(progress.is_completed());
+    }
+
+    #[test]
+    fn test_heal_progress_is_not_completed() {
+        let mut progress = HealProgress::new();
+        progress.objects_scanned = 10;
+        progress.objects_healed = 5;
+        progress.objects_failed = 2;
+        // healed + failed = 5 + 2 = 7 < scanned = 10
+        assert!(!progress.is_completed());
+    }
+
+    #[test]
+    fn test_heal_progress_get_success_rate() {
+        let mut progress = HealProgress::new();
+        progress.objects_healed = 8;
+        progress.objects_failed = 2;
+
+        // success_rate = 8 / (8 + 2) * 100 = 80%
+        assert!((progress.get_success_rate() - 80.0).abs() < 0.001);
+    }
+
+    #[test]
+    fn test_heal_progress_get_success_rate_zero_total() {
+        let progress = HealProgress::new();
+        // No healed or failed objects
+        assert_eq!(progress.get_success_rate(), 0.0);
+    }
+
+    #[test]
+    fn test_heal_progress_get_success_rate_all_success() {
+        let mut progress = HealProgress::new();
+        progress.objects_healed = 10;
+        progress.objects_failed = 0;
+
+        assert!((progress.get_success_rate() - 100.0).abs() < 0.001);
+    }
+
+    #[test]
+    fn test_heal_statistics_new() {
+        let stats = HealStatistics::new();
+        assert_eq!(stats.total_tasks, 0);
+        assert_eq!(stats.successful_tasks, 0);
+        assert_eq!(stats.failed_tasks, 0);
+        assert_eq!(stats.running_tasks, 0);
+        assert_eq!(stats.total_objects_healed, 0);
+        assert_eq!(stats.total_bytes_healed, 0);
+    }
+
+    #[test]
+    fn test_heal_statistics_default() {
+        let stats = HealStatistics::default();
+        assert_eq!(stats.total_tasks, 0);
+        assert_eq!(stats.successful_tasks, 0);
+        assert_eq!(stats.failed_tasks, 0);
+    }
+
+    #[test]
+    fn test_heal_statistics_update_task_completion_success() {
+        let mut stats = HealStatistics::new();
+        let initial_time = stats.last_update_time;
+
+        std::thread::sleep(std::time::Duration::from_millis(10));
+        stats.update_task_completion(true);
+
+        assert_eq!(stats.successful_tasks, 1);
+        assert_eq!(stats.failed_tasks, 0);
+        assert!(stats.last_update_time > initial_time);
+    }
+
+    #[test]
+    fn test_heal_statistics_update_task_completion_failure() {
+        let mut stats = HealStatistics::new();
+        stats.update_task_completion(false);
+
+        assert_eq!(stats.successful_tasks, 0);
+        assert_eq!(stats.failed_tasks, 1);
+    }
+
+    #[test]
+    fn test_heal_statistics_update_running_tasks() {
+        let mut stats = HealStatistics::new();
+        let initial_time = stats.last_update_time;
+
+        std::thread::sleep(std::time::Duration::from_millis(10));
+        stats.update_running_tasks(5);
+
+        assert_eq!(stats.running_tasks, 5);
+        assert!(stats.last_update_time > initial_time);
+    }
+
+    #[test]
+    fn test_heal_statistics_add_healed_objects() {
+        let mut stats = HealStatistics::new();
+        let initial_time = stats.last_update_time;
+
+        std::thread::sleep(std::time::Duration::from_millis(10));
+        stats.add_healed_objects(10, 10240);
+
+        assert_eq!(stats.total_objects_healed, 10);
+        assert_eq!(stats.total_bytes_healed, 10240);
+        assert!(stats.last_update_time > initial_time);
+    }
+
+    #[test]
+    fn test_heal_statistics_add_healed_objects_accumulative() {
+        let mut stats = HealStatistics::new();
+        stats.add_healed_objects(5, 5120);
+        stats.add_healed_objects(3, 3072);
+
+        assert_eq!(stats.total_objects_healed, 8);
+        assert_eq!(stats.total_bytes_healed, 8192);
+    }
+
+    #[test]
+    fn test_heal_statistics_get_success_rate() {
+        let mut stats = HealStatistics::new();
+        stats.successful_tasks = 8;
+        stats.failed_tasks = 2;
+
+        // success_rate = 8 / (8 + 2) * 100 = 80%
+        assert!((stats.get_success_rate() - 80.0).abs() < 0.001);
+    }
+
+    #[test]
+    fn test_heal_statistics_get_success_rate_zero_total() {
+        let stats = HealStatistics::new();
+        assert_eq!(stats.get_success_rate(), 0.0);
+    }
+
+    #[test]
+    fn test_heal_statistics_get_success_rate_all_success() {
+        let mut stats = HealStatistics::new();
+        stats.successful_tasks = 10;
+        stats.failed_tasks = 0;
+
+        assert!((stats.get_success_rate() - 100.0).abs() < 0.001);
+    }
+
+    #[test]
+    fn test_heal_statistics_get_success_rate_all_failure() {
+        let mut stats = HealStatistics::new();
+        stats.successful_tasks = 0;
+        stats.failed_tasks = 5;
+
+        assert_eq!(stats.get_success_rate(), 0.0);
+    }
+}

crates/ahm/src/heal/resume.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use crate::error::{Error, Result};
+use crate::{Error, Result};
 use rustfs_ecstore::disk::{BUCKET_META_PREFIX, DiskAPI, DiskStore, RUSTFS_META_BUCKET};
 use serde::{Deserialize, Serialize};
 use std::path::Path;
@@ -27,6 +27,12 @@ const RESUME_STATE_FILE: &str = "ahm_resume_state.json";
 const RESUME_PROGRESS_FILE: &str = "ahm_progress.json";
 const RESUME_CHECKPOINT_FILE: &str = "ahm_checkpoint.json";
 
+/// Helper function to convert Path to &str, returning an error if conversion fails
+fn path_to_str(path: &Path) -> Result<&str> {
+    path.to_str()
+        .ok_or_else(|| Error::other(format!("Invalid UTF-8 path: {:?}", path)))
+}
+
 /// resume state
 #[derive(Debug, Clone, Serialize, Deserialize)]
 pub struct ResumeState {
@@ -34,6 +40,9 @@ pub struct ResumeState {
     pub task_id: String,
     /// task type
     pub task_type: String,
+    /// set disk identifier (for erasure set tasks)
+    #[serde(default)]
+    pub set_disk_id: String,
     /// start time
     pub start_time: u64,
     /// last update time
@@ -67,12 +76,13 @@ pub struct ResumeState {
 }
 
 impl ResumeState {
-    pub fn new(task_id: String, task_type: String, buckets: Vec<String>) -> Self {
+    pub fn new(task_id: String, task_type: String, set_disk_id: String, buckets: Vec<String>) -> Self {
         Self {
             task_id,
             task_type,
-            start_time: SystemTime::now().duration_since(UNIX_EPOCH).unwrap().as_secs(),
-            last_update: SystemTime::now().duration_since(UNIX_EPOCH).unwrap().as_secs(),
+            set_disk_id,
+            start_time: SystemTime::now().duration_since(UNIX_EPOCH).unwrap_or_default().as_secs(),
+            last_update: SystemTime::now().duration_since(UNIX_EPOCH).unwrap_or_default().as_secs(),
             completed: false,
             total_objects: 0,
             processed_objects: 0,
@@ -94,13 +104,13 @@ impl ResumeState {
         self.successful_objects = successful;
         self.failed_objects = failed;
         self.skipped_objects = skipped;
-        self.last_update = SystemTime::now().duration_since(UNIX_EPOCH).unwrap().as_secs();
+        self.last_update = SystemTime::now().duration_since(UNIX_EPOCH).unwrap_or_default().as_secs();
     }
 
     pub fn set_current_item(&mut self, bucket: Option<String>, object: Option<String>) {
         self.current_bucket = bucket;
         self.current_object = object;
-        self.last_update = SystemTime::now().duration_since(UNIX_EPOCH).unwrap().as_secs();
+        self.last_update = SystemTime::now().duration_since(UNIX_EPOCH).unwrap_or_default().as_secs();
     }
 
     pub fn complete_bucket(&mut self, bucket: &str) {
@@ -110,22 +120,22 @@ impl ResumeState {
         if let Some(pos) = self.pending_buckets.iter().position(|b| b == bucket) {
             self.pending_buckets.remove(pos);
         }
-        self.last_update = SystemTime::now().duration_since(UNIX_EPOCH).unwrap().as_secs();
+        self.last_update = SystemTime::now().duration_since(UNIX_EPOCH).unwrap_or_default().as_secs();
     }
 
     pub fn mark_completed(&mut self) {
         self.completed = true;
-        self.last_update = SystemTime::now().duration_since(UNIX_EPOCH).unwrap().as_secs();
+        self.last_update = SystemTime::now().duration_since(UNIX_EPOCH).unwrap_or_default().as_secs();
     }
 
     pub fn set_error(&mut self, error: String) {
         self.error_message = Some(error);
-        self.last_update = SystemTime::now().duration_since(UNIX_EPOCH).unwrap().as_secs();
+        self.last_update = SystemTime::now().duration_since(UNIX_EPOCH).unwrap_or_default().as_secs();
     }
 
     pub fn increment_retry(&mut self) {
         self.retry_count += 1;
-        self.last_update = SystemTime::now().duration_since(UNIX_EPOCH).unwrap().as_secs();
+        self.last_update = SystemTime::now().duration_since(UNIX_EPOCH).unwrap_or_default().as_secs();
     }
 
     pub fn can_retry(&self) -> bool {
@@ -156,8 +166,14 @@ pub struct ResumeManager {
 
 impl ResumeManager {
     /// create new resume manager
-    pub async fn new(disk: DiskStore, task_id: String, task_type: String, buckets: Vec<String>) -> Result<Self> {
-        let state = ResumeState::new(task_id, task_type, buckets);
+    pub async fn new(
+        disk: DiskStore,
+        task_id: String,
+        task_type: String,
+        set_disk_id: String,
+        buckets: Vec<String>,
+    ) -> Result<Self> {
+        let state = ResumeState::new(task_id, task_type, set_disk_id, buckets);
         let manager = Self {
             disk,
             state: Arc::new(RwLock::new(state)),
@@ -184,8 +200,11 @@ impl ResumeManager {
     /// check if resume state exists
     pub async fn has_resume_state(disk: &DiskStore, task_id: &str) -> bool {
         let file_path = Path::new(BUCKET_META_PREFIX).join(format!("{task_id}_{RESUME_STATE_FILE}"));
-        match disk.read_all(RUSTFS_META_BUCKET, file_path.to_str().unwrap()).await {
-            Ok(data) => !data.is_empty(),
+        match path_to_str(&file_path) {
+            Ok(path_str) => match disk.read_all(RUSTFS_META_BUCKET, path_str).await {
+                Ok(data) => !data.is_empty(),
+                Err(_) => false,
+            },
             Err(_) => false,
         }
     }
@@ -254,18 +273,15 @@ impl ResumeManager {
         let checkpoint_file = Path::new(BUCKET_META_PREFIX).join(format!("{task_id}_{RESUME_CHECKPOINT_FILE}"));
 
         // ignore delete errors, files may not exist
-        let _ = self
-            .disk
-            .delete(RUSTFS_META_BUCKET, state_file.to_str().unwrap(), Default::default())
-            .await;
-        let _ = self
-            .disk
-            .delete(RUSTFS_META_BUCKET, progress_file.to_str().unwrap(), Default::default())
-            .await;
-        let _ = self
-            .disk
-            .delete(RUSTFS_META_BUCKET, checkpoint_file.to_str().unwrap(), Default::default())
-            .await;
+        if let Ok(path_str) = path_to_str(&state_file) {
+            let _ = self.disk.delete(RUSTFS_META_BUCKET, path_str, Default::default()).await;
+        }
+        if let Ok(path_str) = path_to_str(&progress_file) {
+            let _ = self.disk.delete(RUSTFS_META_BUCKET, path_str, Default::default()).await;
+        }
+        if let Ok(path_str) = path_to_str(&checkpoint_file) {
+            let _ = self.disk.delete(RUSTFS_META_BUCKET, path_str, Default::default()).await;
+        }
 
         info!("Cleaned up resume state for task: {}", task_id);
         Ok(())
@@ -280,8 +296,9 @@ impl ResumeManager {
 
         let file_path = Path::new(BUCKET_META_PREFIX).join(format!("{}_{}", state.task_id, RESUME_STATE_FILE));
 
+        let path_str = path_to_str(&file_path)?;
         self.disk
-            .write_all(RUSTFS_META_BUCKET, file_path.to_str().unwrap(), state_data.into())
+            .write_all(RUSTFS_META_BUCKET, path_str, state_data.into())
             .await
             .map_err(|e| Error::TaskExecutionFailed {
                 message: format!("Failed to save resume state: {e}"),
@@ -295,7 +312,8 @@ impl ResumeManager {
     async fn read_state_file(disk: &DiskStore, task_id: &str) -> Result<Vec<u8>> {
         let file_path = Path::new(BUCKET_META_PREFIX).join(format!("{task_id}_{RESUME_STATE_FILE}"));
 
-        disk.read_all(RUSTFS_META_BUCKET, file_path.to_str().unwrap())
+        let path_str = path_to_str(&file_path)?;
+        disk.read_all(RUSTFS_META_BUCKET, path_str)
             .await
             .map(|bytes| bytes.to_vec())
             .map_err(|e| Error::TaskExecutionFailed {
@@ -327,7 +345,7 @@ impl ResumeCheckpoint {
     pub fn new(task_id: String) -> Self {
         Self {
             task_id,
-            checkpoint_time: SystemTime::now().duration_since(UNIX_EPOCH).unwrap().as_secs(),
+            checkpoint_time: SystemTime::now().duration_since(UNIX_EPOCH).unwrap_or_default().as_secs(),
             current_bucket_index: 0,
             current_object_index: 0,
             processed_objects: Vec::new(),
@@ -339,7 +357,7 @@ impl ResumeCheckpoint {
     pub fn update_position(&mut self, bucket_index: usize, object_index: usize) {
         self.current_bucket_index = bucket_index;
         self.current_object_index = object_index;
-        self.checkpoint_time = SystemTime::now().duration_since(UNIX_EPOCH).unwrap().as_secs();
+        self.checkpoint_time = SystemTime::now().duration_since(UNIX_EPOCH).unwrap_or_default().as_secs();
     }
 
     pub fn add_processed_object(&mut self, object: String) {
@@ -397,8 +415,11 @@ impl CheckpointManager {
     /// check if checkpoint exists
     pub async fn has_checkpoint(disk: &DiskStore, task_id: &str) -> bool {
         let file_path = Path::new(BUCKET_META_PREFIX).join(format!("{task_id}_{RESUME_CHECKPOINT_FILE}"));
-        match disk.read_all(RUSTFS_META_BUCKET, file_path.to_str().unwrap()).await {
-            Ok(data) => !data.is_empty(),
+        match path_to_str(&file_path) {
+            Ok(path_str) => match disk.read_all(RUSTFS_META_BUCKET, path_str).await {
+                Ok(data) => !data.is_empty(),
+                Err(_) => false,
+            },
             Err(_) => false,
         }
     }
@@ -446,10 +467,9 @@ impl CheckpointManager {
         let task_id = &checkpoint.task_id;
 
         let checkpoint_file = Path::new(BUCKET_META_PREFIX).join(format!("{task_id}_{RESUME_CHECKPOINT_FILE}"));
-        let _ = self
-            .disk
-            .delete(RUSTFS_META_BUCKET, checkpoint_file.to_str().unwrap(), Default::default())
-            .await;
+        if let Ok(path_str) = path_to_str(&checkpoint_file) {
+            let _ = self.disk.delete(RUSTFS_META_BUCKET, path_str, Default::default()).await;
+        }
 
         info!("Cleaned up checkpoint for task: {}", task_id);
         Ok(())
@@ -464,8 +484,9 @@ impl CheckpointManager {
 
         let file_path = Path::new(BUCKET_META_PREFIX).join(format!("{}_{}", checkpoint.task_id, RESUME_CHECKPOINT_FILE));
 
+        let path_str = path_to_str(&file_path)?;
         self.disk
-            .write_all(RUSTFS_META_BUCKET, file_path.to_str().unwrap(), checkpoint_data.into())
+            .write_all(RUSTFS_META_BUCKET, path_str, checkpoint_data.into())
             .await
             .map_err(|e| Error::TaskExecutionFailed {
                 message: format!("Failed to save checkpoint: {e}"),
@@ -479,7 +500,8 @@ impl CheckpointManager {
     async fn read_checkpoint_file(disk: &DiskStore, task_id: &str) -> Result<Vec<u8>> {
         let file_path = Path::new(BUCKET_META_PREFIX).join(format!("{task_id}_{RESUME_CHECKPOINT_FILE}"));
 
-        disk.read_all(RUSTFS_META_BUCKET, file_path.to_str().unwrap())
+        let path_str = path_to_str(&file_path)?;
+        disk.read_all(RUSTFS_META_BUCKET, path_str)
             .await
             .map(|bytes| bytes.to_vec())
             .map_err(|e| Error::TaskExecutionFailed {
@@ -562,7 +584,7 @@ mod tests {
     async fn test_resume_state_creation() {
         let task_id = ResumeUtils::generate_task_id();
         let buckets = vec!["bucket1".to_string(), "bucket2".to_string()];
-        let state = ResumeState::new(task_id.clone(), "erasure_set".to_string(), buckets);
+        let state = ResumeState::new(task_id.clone(), "erasure_set".to_string(), "pool_0_set_0".to_string(), buckets);
 
         assert_eq!(state.task_id, task_id);
         assert_eq!(state.task_type, "erasure_set");
@@ -575,7 +597,7 @@ mod tests {
     async fn test_resume_state_progress() {
         let task_id = ResumeUtils::generate_task_id();
         let buckets = vec!["bucket1".to_string()];
-        let mut state = ResumeState::new(task_id, "erasure_set".to_string(), buckets);
+        let mut state = ResumeState::new(task_id, "erasure_set".to_string(), "pool_0_set_0".to_string(), buckets);
 
         state.update_progress(10, 8, 1, 1);
         assert_eq!(state.processed_objects, 10);
@@ -595,7 +617,7 @@ mod tests {
     async fn test_resume_state_bucket_completion() {
         let task_id = ResumeUtils::generate_task_id();
         let buckets = vec!["bucket1".to_string(), "bucket2".to_string()];
-        let mut state = ResumeState::new(task_id, "erasure_set".to_string(), buckets);
+        let mut state = ResumeState::new(task_id, "erasure_set".to_string(), "pool_0_set_0".to_string(), buckets);
 
         assert_eq!(state.pending_buckets.len(), 2);
         assert_eq!(state.completed_buckets.len(), 0);
@@ -650,6 +672,7 @@ mod tests {
             let state = ResumeState::new(
                 task_id.clone(),
                 "erasure_set".to_string(),
+                "pool_0_set_0".to_string(),
                 vec!["bucket1".to_string(), "bucket2".to_string()],
             );
 

crates/ahm/src/heal/storage.rs

@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use crate::error::{Error, Result};
+use crate::{Error, Result};
 use async_trait::async_trait;
 use rustfs_common::heal_channel::{HealOpts, HealScanMode};
 use rustfs_ecstore::{
@@ -179,7 +179,10 @@ impl HealStorageAPI for ECStoreHealStorage {
                             "Object data exceeds cap ({} bytes), aborting full read to prevent OOM: {}/{}",
                             MAX_READ_BYTES, bucket, object
                         );
-                        return Ok(None);
+                        return Err(Error::other(format!(
+                            "Object too large: {} bytes (max: {} bytes) for {}/{}",
+                            n_read, MAX_READ_BYTES, bucket, object
+                        )));
                     }
                 }
                 Err(e) => {
@@ -515,21 +518,7 @@ impl HealStorageAPI for ECStoreHealStorage {
         debug!("Getting disk for resume: {}", set_disk_id);
 
         // Parse set_disk_id to extract pool and set indices
-        // Format: "pool_{pool_idx}_set_{set_idx}"
-        let parts: Vec<&str> = set_disk_id.split('_').collect();
-        if parts.len() != 4 || parts[0] != "pool" || parts[2] != "set" {
-            return Err(Error::TaskExecutionFailed {
-                message: format!("Invalid set_disk_id format: {set_disk_id}"),
-            });
-        }
-
-        let pool_idx: usize = parts[1].parse().map_err(|_| Error::TaskExecutionFailed {
-            message: format!("Invalid pool index in set_disk_id: {set_disk_id}"),
-        })?;
-
-        let set_idx: usize = parts[3].parse().map_err(|_| Error::TaskExecutionFailed {
-            message: format!("Invalid set index in set_disk_id: {set_disk_id}"),
-        })?;
+        let (pool_idx, set_idx) = crate::heal::utils::parse_set_disk_id(set_disk_id)?;
 
         // Get the first available disk from the set
         let disks = self

crates/ahm/src/heal/task.rs

@@ -12,13 +12,15 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use crate::error::{Error, Result};
-use crate::heal::ErasureSetHealer;
-use crate::heal::{progress::HealProgress, storage::HealStorageAPI};
+use crate::heal::{ErasureSetHealer, progress::HealProgress, storage::HealStorageAPI};
+use crate::{Error, Result};
 use rustfs_common::heal_channel::{HealOpts, HealScanMode};
 use serde::{Deserialize, Serialize};
-use std::sync::Arc;
-use std::time::{Duration, SystemTime};
+use std::{
+    future::Future,
+    sync::Arc,
+    time::{Duration, Instant, SystemTime},
+};
 use tokio::sync::RwLock;
 use tracing::{error, info, warn};
 use uuid::Uuid;
@@ -49,11 +51,12 @@ pub enum HealType {
 }
 
 /// Heal priority
-#[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Ord, Serialize, Deserialize)]
+#[derive(Debug, Default, Clone, PartialEq, Eq, PartialOrd, Ord, Serialize, Deserialize)]
 pub enum HealPriority {
     /// Low priority
     Low = 0,
     /// Normal priority
+    #[default]
     Normal = 1,
     /// High priority
     High = 2,
@@ -61,12 +64,6 @@ pub enum HealPriority {
     Urgent = 3,
 }
 
-impl Default for HealPriority {
-    fn default() -> Self {
-        Self::Normal
-    }
-}
-
 /// Heal options
 #[derive(Debug, Clone, Serialize, Deserialize)]
 pub struct HealOptions {
@@ -200,6 +197,8 @@ pub struct HealTask {
     pub started_at: Arc<RwLock<Option<SystemTime>>>,
     /// Completed time
     pub completed_at: Arc<RwLock<Option<SystemTime>>>,
+    /// Task start instant for timeout calculation (monotonic)
+    task_start_instant: Arc<RwLock<Option<Instant>>>,
     /// Cancel token
     pub cancel_token: tokio_util::sync::CancellationToken,
     /// Storage layer interface
@@ -217,20 +216,73 @@ impl HealTask {
             created_at: request.created_at,
             started_at: Arc::new(RwLock::new(None)),
             completed_at: Arc::new(RwLock::new(None)),
+            task_start_instant: Arc::new(RwLock::new(None)),
             cancel_token: tokio_util::sync::CancellationToken::new(),
             storage,
         }
     }
 
+    async fn remaining_timeout(&self) -> Result<Option<Duration>> {
+        if let Some(total) = self.options.timeout {
+            let start_instant = { *self.task_start_instant.read().await };
+            if let Some(started_at) = start_instant {
+                let elapsed = started_at.elapsed();
+                if elapsed >= total {
+                    return Err(Error::TaskTimeout);
+                }
+                return Ok(Some(total - elapsed));
+            }
+            Ok(Some(total))
+        } else {
+            Ok(None)
+        }
+    }
+
+    async fn check_control_flags(&self) -> Result<()> {
+        if self.cancel_token.is_cancelled() {
+            return Err(Error::TaskCancelled);
+        }
+        // Only interested in propagating an error if the timeout has expired;
+        // the actual Duration value is not needed here
+        let _ = self.remaining_timeout().await?;
+        Ok(())
+    }
+
+    async fn await_with_control<F, T>(&self, fut: F) -> Result<T>
+    where
+        F: Future<Output = Result<T>> + Send,
+        T: Send,
+    {
+        let cancel_token = self.cancel_token.clone();
+        if let Some(remaining) = self.remaining_timeout().await? {
+            if remaining.is_zero() {
+                return Err(Error::TaskTimeout);
+            }
+            let mut fut = Box::pin(fut);
+            tokio::select! {
+                _ = cancel_token.cancelled() => Err(Error::TaskCancelled),
+                _ = tokio::time::sleep(remaining) => Err(Error::TaskTimeout),
+                result = &mut fut => result,
+            }
+        } else {
+            tokio::select! {
+                _ = cancel_token.cancelled() => Err(Error::TaskCancelled),
+                result = fut => result,
+            }
+        }
+    }
+
     pub async fn execute(&self) -> Result<()> {
-        // update status to running
+        // update status and timestamps atomically to avoid race conditions
+        let now = SystemTime::now();
+        let start_instant = Instant::now();
         {
             let mut status = self.status.write().await;
-            *status = HealTaskStatus::Running;
-        }
-        {
             let mut started_at = self.started_at.write().await;
-            *started_at = Some(SystemTime::now());
+            let mut task_start_instant = self.task_start_instant.write().await;
+            *status = HealTaskStatus::Running;
+            *started_at = Some(now);
+            *task_start_instant = Some(start_instant);
         }
 
         info!("Starting heal task: {} with type: {:?}", self.id, self.heal_type);
@@ -265,6 +317,16 @@ impl HealTask {
                 *status = HealTaskStatus::Completed;
                 info!("Heal task completed successfully: {}", self.id);
             }
+            Err(Error::TaskCancelled) => {
+                let mut status = self.status.write().await;
+                *status = HealTaskStatus::Cancelled;
+                info!("Heal task was cancelled: {}", self.id);
+            }
+            Err(Error::TaskTimeout) => {
+                let mut status = self.status.write().await;
+                *status = HealTaskStatus::Timeout;
+                warn!("Heal task timed out: {}", self.id);
+            }
             Err(e) => {
                 let mut status = self.status.write().await;
                 *status = HealTaskStatus::Failed { error: e.to_string() };
@@ -304,7 +366,8 @@ impl HealTask {
 
         // Step 1: Check if object exists and get metadata
         info!("Step 1: Checking object existence and metadata");
-        let object_exists = self.storage.object_exists(bucket, object).await?;
+        self.check_control_flags().await?;
+        let object_exists = self.await_with_control(self.storage.object_exists(bucket, object)).await?;
         if !object_exists {
             warn!("Object does not exist: {}/{}", bucket, object);
             if self.options.recreate_missing {
@@ -336,11 +399,15 @@ impl HealTask {
             set: self.options.set_index,
         };
 
-        match self.storage.heal_object(bucket, object, version_id, &heal_opts).await {
+        let heal_result = self
+            .await_with_control(self.storage.heal_object(bucket, object, version_id, &heal_opts))
+            .await;
+
+        match heal_result {
             Ok((result, error)) => {
                 if let Some(e) = error {
                     // Check if this is a "File not found" error during delete operations
-                    let error_msg = format!("{}", e);
+                    let error_msg = format!("{e}");
                     if error_msg.contains("File not found") || error_msg.contains("not found") {
                         info!(
                             "Object {}/{} not found during heal - likely deleted intentionally, treating as successful",
@@ -359,7 +426,7 @@ impl HealTask {
                     if self.options.remove_corrupted {
                         warn!("Removing corrupted object: {}/{}", bucket, object);
                         if !self.options.dry_run {
-                            self.storage.delete_object(bucket, object).await?;
+                            self.await_with_control(self.storage.delete_object(bucket, object)).await?;
                             info!("Successfully deleted corrupted object: {}/{}", bucket, object);
                         } else {
                             info!("Dry run mode - would delete corrupted object: {}/{}", bucket, object);
@@ -393,9 +460,11 @@ impl HealTask {
                 }
                 Ok(())
             }
+            Err(Error::TaskCancelled) => Err(Error::TaskCancelled),
+            Err(Error::TaskTimeout) => Err(Error::TaskTimeout),
             Err(e) => {
                 // Check if this is a "File not found" error during delete operations
-                let error_msg = format!("{}", e);
+                let error_msg = format!("{e}");
                 if error_msg.contains("File not found") || error_msg.contains("not found") {
                     info!(
                         "Object {}/{} not found during heal - likely deleted intentionally, treating as successful",
@@ -414,7 +483,7 @@ impl HealTask {
                 if self.options.remove_corrupted {
                     warn!("Removing corrupted object: {}/{}", bucket, object);
                     if !self.options.dry_run {
-                        self.storage.delete_object(bucket, object).await?;
+                        self.await_with_control(self.storage.delete_object(bucket, object)).await?;
                         info!("Successfully deleted corrupted object: {}/{}", bucket, object);
                     } else {
                         info!("Dry run mode - would delete corrupted object: {}/{}", bucket, object);
@@ -450,7 +519,10 @@ impl HealTask {
             set: None,
         };
 
-        match self.storage.heal_object(bucket, object, version_id, &heal_opts).await {
+        match self
+            .await_with_control(self.storage.heal_object(bucket, object, version_id, &heal_opts))
+            .await
+        {
             Ok((result, error)) => {
                 if let Some(e) = error {
                     error!("Failed to recreate missing object: {}/{} - {}", bucket, object, e);
@@ -468,6 +540,8 @@ impl HealTask {
                 }
                 Ok(())
             }
+            Err(Error::TaskCancelled) => Err(Error::TaskCancelled),
+            Err(Error::TaskTimeout) => Err(Error::TaskTimeout),
             Err(e) => {
                 error!("Failed to recreate missing object: {}/{} - {}", bucket, object, e);
                 Err(Error::TaskExecutionFailed {
@@ -489,7 +563,8 @@ impl HealTask {
 
         // Step 1: Check if bucket exists
         info!("Step 1: Checking bucket existence");
-        let bucket_exists = self.storage.get_bucket_info(bucket).await?.is_some();
+        self.check_control_flags().await?;
+        let bucket_exists = self.await_with_control(self.storage.get_bucket_info(bucket)).await?.is_some();
         if !bucket_exists {
             warn!("Bucket does not exist: {}", bucket);
             return Err(Error::TaskExecutionFailed {
@@ -516,7 +591,9 @@ impl HealTask {
             set: self.options.set_index,
         };
 
-        match self.storage.heal_bucket(bucket, &heal_opts).await {
+        let heal_result = self.await_with_control(self.storage.heal_bucket(bucket, &heal_opts)).await;
+
+        match heal_result {
             Ok(result) => {
                 info!("Bucket heal completed successfully: {} ({} drives)", bucket, result.after.drives.len());
 
@@ -526,6 +603,8 @@ impl HealTask {
                 }
                 Ok(())
             }
+            Err(Error::TaskCancelled) => Err(Error::TaskCancelled),
+            Err(Error::TaskTimeout) => Err(Error::TaskTimeout),
             Err(e) => {
                 error!("Bucket heal failed: {} - {}", bucket, e);
                 {
@@ -551,7 +630,8 @@ impl HealTask {
 
         // Step 1: Check if object exists
         info!("Step 1: Checking object existence");
-        let object_exists = self.storage.object_exists(bucket, object).await?;
+        self.check_control_flags().await?;
+        let object_exists = self.await_with_control(self.storage.object_exists(bucket, object)).await?;
         if !object_exists {
             warn!("Object does not exist: {}/{}", bucket, object);
             return Err(Error::TaskExecutionFailed {
@@ -578,7 +658,11 @@ impl HealTask {
             set: self.options.set_index,
         };
 
-        match self.storage.heal_object(bucket, object, None, &heal_opts).await {
+        let heal_result = self
+            .await_with_control(self.storage.heal_object(bucket, object, None, &heal_opts))
+            .await;
+
+        match heal_result {
             Ok((result, error)) => {
                 if let Some(e) = error {
                     error!("Metadata heal failed: {}/{} - {}", bucket, object, e);
@@ -604,6 +688,8 @@ impl HealTask {
                 }
                 Ok(())
             }
+            Err(Error::TaskCancelled) => Err(Error::TaskCancelled),
+            Err(Error::TaskTimeout) => Err(Error::TaskTimeout),
             Err(e) => {
                 error!("Metadata heal failed: {}/{} - {}", bucket, object, e);
                 {
@@ -652,7 +738,11 @@ impl HealTask {
             set: None,
         };
 
-        match self.storage.heal_object(bucket, &object, None, &heal_opts).await {
+        let heal_result = self
+            .await_with_control(self.storage.heal_object(bucket, &object, None, &heal_opts))
+            .await;
+
+        match heal_result {
             Ok((result, error)) => {
                 if let Some(e) = error {
                     error!("MRF heal failed: {} - {}", meta_path, e);
@@ -673,6 +763,8 @@ impl HealTask {
                 }
                 Ok(())
             }
+            Err(Error::TaskCancelled) => Err(Error::TaskCancelled),
+            Err(Error::TaskTimeout) => Err(Error::TaskTimeout),
             Err(e) => {
                 error!("MRF heal failed: {} - {}", meta_path, e);
                 {
@@ -698,7 +790,8 @@ impl HealTask {
 
         // Step 1: Check if object exists
         info!("Step 1: Checking object existence");
-        let object_exists = self.storage.object_exists(bucket, object).await?;
+        self.check_control_flags().await?;
+        let object_exists = self.await_with_control(self.storage.object_exists(bucket, object)).await?;
         if !object_exists {
             warn!("Object does not exist: {}/{}", bucket, object);
             return Err(Error::TaskExecutionFailed {
@@ -725,7 +818,11 @@ impl HealTask {
             set: None,
         };
 
-        match self.storage.heal_object(bucket, object, version_id, &heal_opts).await {
+        let heal_result = self
+            .await_with_control(self.storage.heal_object(bucket, object, version_id, &heal_opts))
+            .await;
+
+        match heal_result {
             Ok((result, error)) => {
                 if let Some(e) = error {
                     error!("EC decode heal failed: {}/{} - {}", bucket, object, e);
@@ -753,6 +850,8 @@ impl HealTask {
                 }
                 Ok(())
             }
+            Err(Error::TaskCancelled) => Err(Error::TaskCancelled),
+            Err(Error::TaskTimeout) => Err(Error::TaskTimeout),
             Err(e) => {
                 error!("EC decode heal failed: {}/{} - {}", bucket, object, e);
                 {
@@ -778,7 +877,7 @@ impl HealTask {
 
         let buckets = if buckets.is_empty() {
             info!("No buckets specified, listing all buckets");
-            let bucket_infos = self.storage.list_buckets().await?;
+            let bucket_infos = self.await_with_control(self.storage.list_buckets()).await?;
             bucket_infos.into_iter().map(|info| info.name).collect()
         } else {
             buckets
@@ -786,7 +885,9 @@ impl HealTask {
 
         // Step 1: Perform disk format heal using ecstore
         info!("Step 1: Performing disk format heal using ecstore");
-        match self.storage.heal_format(self.options.dry_run).await {
+        let format_result = self.await_with_control(self.storage.heal_format(self.options.dry_run)).await;
+
+        match format_result {
             Ok((result, error)) => {
                 if let Some(e) = error {
                     error!("Disk format heal failed: {} - {}", set_disk_id, e);
@@ -805,6 +906,8 @@ impl HealTask {
                     result.after.drives.len()
                 );
             }
+            Err(Error::TaskCancelled) => return Err(Error::TaskCancelled),
+            Err(Error::TaskTimeout) => return Err(Error::TaskTimeout),
             Err(e) => {
                 error!("Disk format heal failed: {} - {}", set_disk_id, e);
                 {
@@ -824,7 +927,9 @@ impl HealTask {
 
         // Step 2: Get disk for resume functionality
         info!("Step 2: Getting disk for resume functionality");
-        let disk = self.storage.get_disk_for_resume(&set_disk_id).await?;
+        let disk = self
+            .await_with_control(self.storage.get_disk_for_resume(&set_disk_id))
+            .await?;
 
         {
             let mut progress = self.progress.write().await;
@@ -832,9 +937,18 @@ impl HealTask {
         }
 
         // Step 3: Heal bucket structure
+        // Check control flags before each iteration to ensure timely cancellation.
+        // Each heal_bucket call may handle timeout/cancellation internally, see its implementation for details.
         for bucket in buckets.iter() {
+            // Check control flags before starting each bucket heal
+            self.check_control_flags().await?;
+            // heal_bucket internally uses await_with_control for timeout/cancellation handling
             if let Err(err) = self.heal_bucket(bucket).await {
-                info!("{}", err.to_string());
+                // Check if error is due to cancellation or timeout
+                if matches!(err, Error::TaskCancelled | Error::TaskTimeout) {
+                    return Err(err);
+                }
+                info!("Bucket heal failed: {}", err.to_string());
             }
         }
 
@@ -861,6 +975,8 @@ impl HealTask {
                 info!("Erasure set heal completed successfully: {} ({} buckets)", set_disk_id, buckets.len());
                 Ok(())
             }
+            Err(Error::TaskCancelled) => Err(Error::TaskCancelled),
+            Err(Error::TaskTimeout) => Err(Error::TaskTimeout),
             Err(e) => {
                 error!("Erasure set heal failed: {} - {}", set_disk_id, e);
                 Err(Error::TaskExecutionFailed {

crates/ahm/src/heal/utils.rs

@@ -0,0 +1,110 @@
+// Copyright 2024 RustFS Team
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+use crate::{Error, Result};
+
+/// Prefix for pool index in set disk identifiers.
+const POOL_PREFIX: &str = "pool";
+/// Prefix for set index in set disk identifiers.
+const SET_PREFIX: &str = "set";
+
+/// Format a set disk identifier using unsigned indices.
+pub fn format_set_disk_id(pool_idx: usize, set_idx: usize) -> String {
+    format!("{POOL_PREFIX}_{pool_idx}_{SET_PREFIX}_{set_idx}")
+}
+
+/// Format a set disk identifier from signed indices.
+pub fn format_set_disk_id_from_i32(pool_idx: i32, set_idx: i32) -> Option<String> {
+    if pool_idx < 0 || set_idx < 0 {
+        None
+    } else {
+        Some(format_set_disk_id(pool_idx as usize, set_idx as usize))
+    }
+}
+
+/// Normalise external set disk identifiers into the canonical format.
+pub fn normalize_set_disk_id(raw: &str) -> Option<String> {
+    if raw.starts_with(&format!("{POOL_PREFIX}_")) {
+        Some(raw.to_string())
+    } else {
+        parse_compact_set_disk_id(raw).map(|(pool, set)| format_set_disk_id(pool, set))
+    }
+}
+
+/// Parse a canonical set disk identifier into pool/set indices.
+pub fn parse_set_disk_id(raw: &str) -> Result<(usize, usize)> {
+    let parts: Vec<&str> = raw.split('_').collect();
+    if parts.len() != 4 || parts[0] != POOL_PREFIX || parts[2] != SET_PREFIX {
+        return Err(Error::TaskExecutionFailed {
+            message: format!("Invalid set_disk_id format: {raw}"),
+        });
+    }
+
+    let pool_idx = parts[1].parse::<usize>().map_err(|_| Error::TaskExecutionFailed {
+        message: format!("Invalid pool index in set_disk_id: {raw}"),
+    })?;
+    let set_idx = parts[3].parse::<usize>().map_err(|_| Error::TaskExecutionFailed {
+        message: format!("Invalid set index in set_disk_id: {raw}"),
+    })?;
+    Ok((pool_idx, set_idx))
+}
+
+fn parse_compact_set_disk_id(raw: &str) -> Option<(usize, usize)> {
+    let (pool, set) = raw.split_once('_')?;
+    let pool_idx = pool.parse::<usize>().ok()?;
+    let set_idx = set.parse::<usize>().ok()?;
+    Some((pool_idx, set_idx))
+}
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[test]
+    fn format_from_unsigned_indices() {
+        assert_eq!(format_set_disk_id(1, 2), "pool_1_set_2");
+    }
+
+    #[test]
+    fn format_from_signed_indices() {
+        assert_eq!(format_set_disk_id_from_i32(3, 4), Some("pool_3_set_4".into()));
+        assert_eq!(format_set_disk_id_from_i32(-1, 4), None);
+    }
+
+    #[test]
+    fn normalize_compact_identifier() {
+        assert_eq!(normalize_set_disk_id("3_5"), Some("pool_3_set_5".to_string()));
+    }
+
+    #[test]
+    fn normalize_prefixed_identifier() {
+        assert_eq!(normalize_set_disk_id("pool_7_set_1"), Some("pool_7_set_1".to_string()));
+    }
+
+    #[test]
+    fn normalize_invalid_identifier() {
+        assert_eq!(normalize_set_disk_id("invalid"), None);
+    }
+
+    #[test]
+    fn parse_prefixed_identifier() {
+        assert_eq!(parse_set_disk_id("pool_9_set_3").unwrap(), (9, 3));
+    }
+
+    #[test]
+    fn parse_invalid_identifier() {
+        assert!(parse_set_disk_id("bad").is_err());
+        assert!(parse_set_disk_id("pool_X_set_1").is_err());
+    }
+}

crates/ahm/src/lib.rs

@@ -12,17 +12,16 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use std::sync::{Arc, OnceLock};
-use tokio_util::sync::CancellationToken;
-use tracing::{error, info};
-
-pub mod error;
+mod error;
 pub mod heal;
 pub mod scanner;
 
 pub use error::{Error, Result};
 pub use heal::{HealManager, HealOptions, HealPriority, HealRequest, HealType, channel::HealChannelProcessor};
 pub use scanner::Scanner;
+use std::sync::{Arc, OnceLock};
+use tokio_util::sync::CancellationToken;
+use tracing::{error, info};
 
 // Global cancellation token for AHM services (scanner and other background tasks)
 static GLOBAL_AHM_SERVICES_CANCEL_TOKEN: OnceLock<CancellationToken> = OnceLock::new();

crates/ahm/src/scanner/checkpoint.rs

@@ -12,18 +12,16 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+use crate::scanner::node_scanner::ScanProgress;
+use crate::{Error, Result};
+use serde::{Deserialize, Serialize};
 use std::{
     path::{Path, PathBuf},
     time::{Duration, SystemTime},
 };
-
-use serde::{Deserialize, Serialize};
 use tokio::sync::RwLock;
 use tracing::{debug, error, info, warn};
 
-use super::node_scanner::ScanProgress;
-use crate::{Error, error::Result};
-
 #[derive(Debug, Serialize, Deserialize, Clone)]
 pub struct CheckpointData {
     pub version: u32,

crates/ahm/src/scanner/data_scanner.rs

@@ -12,40 +12,39 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// IO throttling component is integrated into NodeScanner
+use crate::{
+    Error, HealRequest, Result, get_ahm_services_cancel_token,
+    heal::HealManager,
+    scanner::{
+        BucketMetrics, DecentralizedStatsAggregator, DecentralizedStatsAggregatorConfig, DiskMetrics, MetricsCollector,
+        NodeScanner, NodeScannerConfig, ScannerMetrics,
+        lifecycle::ScannerItem,
+        local_scan::{self, LocalObjectRecord, LocalScanOutcome},
+    },
+};
+use rustfs_common::data_usage::{DataUsageInfo, SizeSummary};
+use rustfs_common::metrics::{Metric, Metrics, global_metrics};
+use rustfs_ecstore::{
+    self as ecstore, StorageAPI,
+    bucket::versioning::VersioningApi,
+    bucket::versioning_sys::BucketVersioningSys,
+    data_usage::{aggregate_local_snapshots, store_data_usage_in_backend},
+    disk::{Disk, DiskAPI, DiskStore, RUSTFS_META_BUCKET, WalkDirOptions},
+    set_disk::SetDisks,
+    store_api::ObjectInfo,
+};
+use rustfs_filemeta::{MetacacheReader, VersionType};
+use s3s::dto::{BucketVersioningStatus, VersioningConfiguration};
 use std::{
     collections::HashMap,
     sync::Arc,
     time::{Duration, SystemTime},
 };
-
-use ecstore::{
-    disk::{Disk, DiskAPI, DiskStore, WalkDirOptions},
-    set_disk::SetDisks,
-};
-use rustfs_ecstore::{self as ecstore, StorageAPI, data_usage::store_data_usage_in_backend};
-use rustfs_filemeta::{MetacacheReader, VersionType};
+use time::OffsetDateTime;
 use tokio::sync::{Mutex, RwLock};
 use tokio_util::sync::CancellationToken;
 use tracing::{debug, error, info, warn};
-
-use super::metrics::{BucketMetrics, DiskMetrics, MetricsCollector, ScannerMetrics};
-use super::node_scanner::{NodeScanner, NodeScannerConfig};
-use super::stats_aggregator::{DecentralizedStatsAggregator, DecentralizedStatsAggregatorConfig};
-// IO throttling component is integrated into NodeScanner
-use crate::heal::HealManager;
-use crate::scanner::lifecycle::ScannerItem;
-use crate::{
-    HealRequest,
-    error::{Error, Result},
-    get_ahm_services_cancel_token,
-};
-
-use rustfs_common::data_usage::{BucketUsageInfo, DataUsageInfo, SizeSummary};
-use rustfs_common::metrics::{Metric, Metrics, globalMetrics};
-use rustfs_ecstore::bucket::versioning::VersioningApi;
-use rustfs_ecstore::bucket::versioning_sys::BucketVersioningSys;
-use rustfs_ecstore::cmd::bucket_targets::VersioningConfig;
-use rustfs_ecstore::disk::RUSTFS_META_BUCKET;
 use uuid;
 
 /// Custom scan mode enum for AHM scanner
@@ -261,6 +260,15 @@ impl Scanner {
             let enable_healing = config.enable_healing;
             drop(config);
 
+            let scan_outcome = match local_scan::scan_and_persist_local_usage(ecstore.clone()).await {
+                Ok(outcome) => outcome,
+                Err(err) => {
+                    warn!("Local usage scan failed: {}", err);
+                    LocalScanOutcome::default()
+                }
+            };
+            let bucket_objects_map = &scan_outcome.bucket_objects;
+
             // List all buckets
             debug!("Listing buckets");
             match ecstore
@@ -285,14 +293,29 @@ impl Scanner {
                             .map(|(c, _)| Arc::new(c));
 
                         // Get bucket versioning configuration
-                        let versioning_config = Arc::new(VersioningConfig {
-                            enabled: bucket_info.versioning,
+                        let versioning_config = Arc::new(VersioningConfiguration {
+                            status: if bucket_info.versioning {
+                                Some(BucketVersioningStatus::from_static(BucketVersioningStatus::ENABLED))
+                            } else {
+                                None
+                            },
+                            ..Default::default()
                         });
 
-                        // Count objects in this bucket
-                        let actual_objects = self.count_objects_in_bucket(&ecstore, bucket_name).await;
-                        total_objects_scanned += actual_objects;
-                        debug!("Counted {} objects in bucket {} (actual count)", actual_objects, bucket_name);
+                        let records = match bucket_objects_map.get(bucket_name) {
+                            Some(records) => records,
+                            None => {
+                                debug!(
+                                    "No local snapshot entries found for bucket {}; skipping lifecycle/integrity",
+                                    bucket_name
+                                );
+                                continue;
+                            }
+                        };
+
+                        let live_objects = records.iter().filter(|record| record.usage.has_live_object).count() as u64;
+                        total_objects_scanned = total_objects_scanned.saturating_add(live_objects);
+                        debug!("Counted {} objects in bucket {} using local snapshots", live_objects, bucket_name);
 
                         // Process objects for lifecycle actions
                         if let Some(lifecycle_config) = &lifecycle_config {
@@ -303,9 +326,8 @@ impl Scanner {
                                 Some(versioning_config.clone()),
                             );
 
-                            // List objects in bucket and apply lifecycle actions
                             match self
-                                .process_bucket_objects_for_lifecycle(&ecstore, bucket_name, &mut scanner_item)
+                                .process_bucket_objects_for_lifecycle(bucket_name, &mut scanner_item, records)
                                 .await
                             {
                                 Ok(processed_count) => {
@@ -320,11 +342,16 @@ impl Scanner {
                         // If deep scan is enabled, verify each object's integrity
                         if enable_deep_scan && enable_healing {
                             debug!("Deep scan enabled, verifying object integrity in bucket {}", bucket_name);
-                            if let Err(e) = self.deep_scan_bucket_objects(&ecstore, bucket_name).await {
+                            if let Err(e) = self
+                                .deep_scan_bucket_objects_with_records(&ecstore, bucket_name, records)
+                                .await
+                            {
                                 warn!("Deep scan failed for bucket {}: {}", bucket_name, e);
                             }
                         }
                     }
+
+                    self.update_data_usage_statistics(&scan_outcome, &ecstore).await;
                 }
                 Err(e) => {
                     error!("Failed to list buckets: {}", e);
@@ -336,9 +363,6 @@ impl Scanner {
                 // Update metrics directly
                 self.metrics.increment_objects_scanned(total_objects_scanned);
                 debug!("Updated metrics with {} objects", total_objects_scanned);
-
-                // Also update data usage statistics
-                self.update_data_usage_statistics(total_objects_scanned, &ecstore).await;
             } else {
                 warn!("No objects found during basic test scan");
             }
@@ -350,91 +374,138 @@ impl Scanner {
     }
 
     /// Update data usage statistics based on scan results
-    async fn update_data_usage_statistics(&self, total_objects: u64, ecstore: &std::sync::Arc<rustfs_ecstore::store::ECStore>) {
-        debug!("Updating data usage statistics with {} objects", total_objects);
+    async fn update_data_usage_statistics(
+        &self,
+        outcome: &LocalScanOutcome,
+        ecstore: &std::sync::Arc<rustfs_ecstore::store::ECStore>,
+    ) {
+        let enabled = {
+            let cfg = self.config.read().await;
+            cfg.enable_data_usage_stats
+        };
 
-        // Get buckets list to update data usage
-        match ecstore
-            .list_bucket(&rustfs_ecstore::store_api::BucketOptions::default())
-            .await
-        {
-            Ok(buckets) => {
-                let buckets_len = buckets.len(); // Store length before moving
-                let mut data_usage_guard = self.data_usage_stats.lock().await;
+        if !enabled {
+            debug!("Data usage statistics disabled; skipping refresh");
+            return;
+        }
 
-                for bucket_info in buckets {
-                    let bucket_name = &bucket_info.name;
+        if outcome.snapshots.is_empty() {
+            warn!("No local usage snapshots available; skipping data usage aggregation");
+            return;
+        }
 
-                    // Skip system buckets
-                    if bucket_name.starts_with('.') {
-                        continue;
-                    }
+        let mut aggregated = DataUsageInfo::default();
+        let mut latest_update: Option<SystemTime> = None;
 
-                    // Get object count for this bucket
-                    let bucket_objects = self.count_objects_in_bucket(ecstore, bucket_name).await;
-
-                    // Create or update bucket data usage info
-                    let bucket_data = data_usage_guard.entry(bucket_name.clone()).or_insert_with(|| {
-                        let mut info = DataUsageInfo::new();
-                        info.objects_total_count = bucket_objects;
-                        info.buckets_count = 1;
-
-                        // Add bucket to buckets_usage
-                        let bucket_usage = BucketUsageInfo {
-                            size: bucket_objects * 1024, // Estimate 1KB per object
-                            objects_count: bucket_objects,
-                            object_size_histogram: HashMap::new(),
-                            ..Default::default()
-                        };
-                        info.buckets_usage.insert(bucket_name.clone(), bucket_usage);
-                        info
-                    });
-
-                    // Update existing bucket data
-                    bucket_data.objects_total_count = bucket_objects;
-                    if let Some(bucket_usage) = bucket_data.buckets_usage.get_mut(bucket_name) {
-                        bucket_usage.objects_count = bucket_objects;
-                        bucket_usage.size = bucket_objects * 1024; // Estimate 1KB per object
-                    }
-
-                    debug!("Updated data usage for bucket {}: {} objects", bucket_name, bucket_objects);
-                }
-
-                debug!("Data usage statistics updated for {} buckets", buckets_len);
-                debug!("Current data_usage_guard size after update: {}", data_usage_guard.len());
-
-                // Also persist consolidated data to backend
-                drop(data_usage_guard); // Release the lock
-                debug!("About to get consolidated data usage info for persistence");
-                if let Ok(consolidated_info) = self.get_consolidated_data_usage_info().await {
-                    debug!("Got consolidated info with {} objects total", consolidated_info.objects_total_count);
-                    let config = self.config.read().await;
-                    if config.enable_data_usage_stats {
-                        debug!("Data usage stats enabled, proceeding to store to backend");
-                        if let Some(store) = rustfs_ecstore::new_object_layer_fn() {
-                            debug!("ECStore available, spawning background storage task");
-                            let data_clone = consolidated_info.clone();
-                            tokio::spawn(async move {
-                                if let Err(e) = store_data_usage_in_backend(data_clone, store).await {
-                                    error!("Failed to store consolidated data usage to backend: {}", e);
-                                } else {
-                                    debug!("Successfully stored consolidated data usage to backend");
-                                }
-                            });
-                        } else {
-                            warn!("ECStore not available");
-                        }
-                    } else {
-                        warn!("Data usage stats not enabled");
-                    }
-                } else {
-                    error!("Failed to get consolidated data usage info");
+        for snapshot in &outcome.snapshots {
+            if let Some(update) = snapshot.last_update {
+                if latest_update.is_none_or(|current| update > current) {
+                    latest_update = Some(update);
                 }
             }
-            Err(e) => {
-                error!("Failed to update data usage statistics: {}", e);
+
+            aggregated.objects_total_count = aggregated.objects_total_count.saturating_add(snapshot.objects_total_count);
+            aggregated.versions_total_count = aggregated.versions_total_count.saturating_add(snapshot.versions_total_count);
+            aggregated.delete_markers_total_count = aggregated
+                .delete_markers_total_count
+                .saturating_add(snapshot.delete_markers_total_count);
+            aggregated.objects_total_size = aggregated.objects_total_size.saturating_add(snapshot.objects_total_size);
+
+            for (bucket, usage) in &snapshot.buckets_usage {
+                let size = usage.size;
+                match aggregated.buckets_usage.entry(bucket.clone()) {
+                    std::collections::hash_map::Entry::Occupied(mut entry) => entry.get_mut().merge(usage),
+                    std::collections::hash_map::Entry::Vacant(entry) => {
+                        entry.insert(usage.clone());
+                    }
+                }
+
+                aggregated
+                    .bucket_sizes
+                    .entry(bucket.clone())
+                    .and_modify(|existing| *existing = existing.saturating_add(size))
+                    .or_insert(size);
             }
         }
+
+        aggregated.buckets_count = aggregated.buckets_usage.len() as u64;
+        aggregated.last_update = latest_update;
+
+        self.node_scanner.update_data_usage(aggregated.clone()).await;
+        let local_stats = self.node_scanner.get_stats_summary().await;
+        self.stats_aggregator.set_local_stats(local_stats).await;
+
+        let mut guard = self.data_usage_stats.lock().await;
+        guard.clear();
+        for (bucket, usage) in &aggregated.buckets_usage {
+            let mut bucket_data = DataUsageInfo::new();
+            bucket_data.last_update = aggregated.last_update;
+            bucket_data.buckets_count = 1;
+            bucket_data.objects_total_count = usage.objects_count;
+            bucket_data.versions_total_count = usage.versions_count;
+            bucket_data.delete_markers_total_count = usage.delete_markers_count;
+            bucket_data.objects_total_size = usage.size;
+            bucket_data.bucket_sizes.insert(bucket.clone(), usage.size);
+            bucket_data.buckets_usage.insert(bucket.clone(), usage.clone());
+            guard.insert(bucket.clone(), bucket_data);
+        }
+        drop(guard);
+
+        let info_clone = aggregated.clone();
+        let store_clone = ecstore.clone();
+        tokio::spawn(async move {
+            if let Err(err) = store_data_usage_in_backend(info_clone, store_clone).await {
+                warn!("Failed to persist aggregated usage: {}", err);
+            }
+        });
+    }
+
+    fn convert_record_to_object_info(record: &LocalObjectRecord) -> ObjectInfo {
+        if let Some(info) = &record.object_info {
+            return info.clone();
+        }
+
+        let usage = &record.usage;
+
+        ObjectInfo {
+            bucket: usage.bucket.clone(),
+            name: usage.object.clone(),
+            size: usage.total_size as i64,
+            delete_marker: !usage.has_live_object && usage.delete_markers_count > 0,
+            mod_time: usage.last_modified_ns.and_then(Self::ns_to_offset_datetime),
+            ..Default::default()
+        }
+    }
+
+    fn ns_to_offset_datetime(ns: i128) -> Option<OffsetDateTime> {
+        OffsetDateTime::from_unix_timestamp_nanos(ns).ok()
+    }
+
+    async fn deep_scan_bucket_objects_with_records(
+        &self,
+        ecstore: &std::sync::Arc<rustfs_ecstore::store::ECStore>,
+        bucket_name: &str,
+        records: &[LocalObjectRecord],
+    ) -> Result<()> {
+        if records.is_empty() {
+            return self.deep_scan_bucket_objects(ecstore, bucket_name).await;
+        }
+
+        for record in records {
+            if !record.usage.has_live_object {
+                continue;
+            }
+
+            let object_name = &record.usage.object;
+            if let Err(err) = self.verify_object_integrity(bucket_name, object_name).await {
+                warn!(
+                    "Object integrity verification failed for {}/{} during deep scan: {}",
+                    bucket_name, object_name, err
+                );
+            }
+        }
+
+        Ok(())
     }
 
     /// Deep scan objects in a bucket for integrity verification
@@ -484,130 +555,29 @@ impl Scanner {
 
         Ok(())
     }
-    async fn count_objects_in_bucket(&self, ecstore: &std::sync::Arc<rustfs_ecstore::store::ECStore>, bucket_name: &str) -> u64 {
-        // Use filesystem scanning approach
-
-        // Get first disk path for scanning
-        let mut total_objects = 0u64;
-
-        for pool in &ecstore.pools {
-            for set_disks in &pool.disk_set {
-                let (disks, _) = set_disks.get_online_disks_with_healing(false).await;
-                if let Some(disk) = disks.first() {
-                    let bucket_path = disk.path().join(bucket_name);
-                    if bucket_path.exists() {
-                        if let Ok(entries) = std::fs::read_dir(&bucket_path) {
-                            let object_count = entries
-                                .filter_map(|entry| entry.ok())
-                                .filter(|entry| {
-                                    if let Ok(file_type) = entry.file_type() {
-                                        file_type.is_dir()
-                                    } else {
-                                        false
-                                    }
-                                })
-                                .filter(|entry| {
-                                    // Skip hidden/system directories
-                                    if let Some(name) = entry.file_name().to_str() {
-                                        !name.starts_with('.')
-                                    } else {
-                                        false
-                                    }
-                                })
-                                .count() as u64;
-
-                            debug!(
-                                "Filesystem scan found {} objects in bucket {} on disk {:?}",
-                                object_count,
-                                bucket_name,
-                                disk.path()
-                            );
-                            total_objects = object_count; // Use count from first disk
-                            break;
-                        }
-                    }
-                }
-            }
-            if total_objects > 0 {
-                break;
-            }
-        }
-
-        if total_objects == 0 {
-            // Fallback: assume 1 object if bucket exists
-            debug!("Using fallback count of 1 for bucket {}", bucket_name);
-            1
-        } else {
-            total_objects
-        }
-    }
 
     /// Process bucket objects for lifecycle actions
     async fn process_bucket_objects_for_lifecycle(
         &self,
-        ecstore: &std::sync::Arc<rustfs_ecstore::store::ECStore>,
         bucket_name: &str,
         scanner_item: &mut ScannerItem,
+        records: &[LocalObjectRecord],
     ) -> Result<u64> {
         info!("Processing objects for lifecycle in bucket: {}", bucket_name);
         let mut processed_count = 0u64;
 
-        // Instead of filesystem scanning, use ECStore's list_objects_v2 method to get correct object names
-        let mut continuation_token = None;
-        loop {
-            let list_result = match ecstore
-                .clone()
-                .list_objects_v2(
-                    bucket_name,
-                    "", // prefix
-                    continuation_token.clone(),
-                    None,  // delimiter
-                    1000,  // max_keys
-                    false, // fetch_owner
-                    None,  // start_after
-                )
-                .await
-            {
-                Ok(result) => result,
-                Err(e) => {
-                    warn!("Failed to list objects in bucket {}: {}", bucket_name, e);
-                    break;
-                }
-            };
-
-            info!("Found {} objects in bucket {}", list_result.objects.len(), bucket_name);
-
-            for obj in list_result.objects {
-                info!("Processing lifecycle for object: {}/{}", bucket_name, obj.name);
-
-                // Create ObjectInfo for lifecycle processing
-                let object_info = rustfs_ecstore::store_api::ObjectInfo {
-                    bucket: bucket_name.to_string(),
-                    name: obj.name.clone(),
-                    version_id: None,
-                    mod_time: obj.mod_time,
-                    size: obj.size,
-                    user_defined: std::collections::HashMap::new(),
-                    ..Default::default()
-                };
-
-                // Create SizeSummary for tracking
-                let mut size_summary = SizeSummary::default();
-
-                // Apply lifecycle actions
-                let (deleted, _size) = scanner_item.apply_actions(&object_info, &mut size_summary).await;
-                if deleted {
-                    info!("Object {}/{} was deleted by lifecycle action", bucket_name, obj.name);
-                }
-                processed_count += 1;
+        for record in records {
+            if !record.usage.has_live_object {
+                continue;
             }
 
-            // Check if there are more objects to list
-            if list_result.is_truncated {
-                continuation_token = list_result.next_continuation_token.clone();
-            } else {
-                break;
+            let object_info = Self::convert_record_to_object_info(record);
+            let mut size_summary = SizeSummary::default();
+            let (deleted, _size) = scanner_item.apply_actions(&object_info, &mut size_summary).await;
+            if deleted {
+                info!("Object {}/{} was deleted by lifecycle action", bucket_name, object_info.name);
             }
+            processed_count = processed_count.saturating_add(1);
         }
 
         info!("Processed {} objects for lifecycle in bucket {}", processed_count, bucket_name);
@@ -644,6 +614,21 @@ impl Scanner {
             }
         });
 
+        // Trigger an immediate data usage collection so that admin APIs have fresh data after startup.
+        let scanner = self.clone_for_background();
+        tokio::spawn(async move {
+            let enable_stats = {
+                let cfg = scanner.config.read().await;
+                cfg.enable_data_usage_stats
+            };
+
+            if enable_stats {
+                if let Err(e) = scanner.collect_and_persist_data_usage().await {
+                    warn!("Initial data usage collection failed: {}", e);
+                }
+            }
+        });
+
         Ok(())
     }
 
@@ -712,23 +697,6 @@ impl Scanner {
         Ok(integrated_info)
     }
 
-    /// Get consolidated data usage info without debug output (for internal use)
-    async fn get_consolidated_data_usage_info(&self) -> Result<DataUsageInfo> {
-        let mut integrated_info = DataUsageInfo::new();
-
-        // Collect data from all buckets
-        {
-            let data_usage_guard = self.data_usage_stats.lock().await;
-            for (bucket_name, bucket_data) in data_usage_guard.iter() {
-                let _bucket_name = bucket_name;
-                integrated_info.merge(bucket_data);
-            }
-        }
-
-        self.update_capacity_info(&mut integrated_info).await;
-        Ok(integrated_info)
-    }
-
     /// Update capacity information in DataUsageInfo
     async fn update_capacity_info(&self, integrated_info: &mut DataUsageInfo) {
         // Update capacity information from storage info
@@ -797,7 +765,7 @@ impl Scanner {
 
     /// Get global metrics from common crate
     pub async fn get_global_metrics(&self) -> rustfs_madmin::metrics::ScannerMetrics {
-        (*globalMetrics).report().await
+        global_metrics().report().await
     }
 
     /// Perform a single scan cycle using optimized node scanner
@@ -827,7 +795,7 @@ impl Scanner {
             cycle_completed: vec![chrono::Utc::now()],
             started: chrono::Utc::now(),
         };
-        (*globalMetrics).set_cycle(Some(cycle_info)).await;
+        global_metrics().set_cycle(Some(cycle_info)).await;
 
         self.metrics.set_current_cycle(self.state.read().await.current_cycle);
         self.metrics.increment_total_cycles();
@@ -865,17 +833,13 @@ impl Scanner {
                 // Update legacy metrics with aggregated data
                 self.update_legacy_metrics_from_aggregated(&aggregated_stats).await;
 
-                // If aggregated stats show no objects scanned, also try basic test scan
-                if aggregated_stats.total_objects_scanned == 0 {
-                    debug!("Aggregated stats show 0 objects, falling back to direct ECStore scan for testing");
-                    info!("Calling perform_basic_test_scan due to 0 aggregated objects");
-                    if let Err(scan_error) = self.perform_basic_test_scan().await {
-                        warn!("Basic test scan failed: {}", scan_error);
-                    } else {
-                        debug!("Basic test scan completed successfully after aggregated stats");
-                    }
+                // Always perform basic test scan to ensure lifecycle processing in test environments
+                debug!("Performing basic test scan to ensure lifecycle processing");
+                info!("Calling perform_basic_test_scan to ensure lifecycle processing");
+                if let Err(scan_error) = self.perform_basic_test_scan().await {
+                    warn!("Basic test scan failed: {}", scan_error);
                 } else {
-                    info!("Not calling perform_basic_test_scan because aggregated_stats.total_objects_scanned > 0");
+                    debug!("Basic test scan completed successfully");
                 }
 
                 info!(
@@ -891,17 +855,13 @@ impl Scanner {
                 info!("Local stats: total_objects_scanned={}", local_stats.total_objects_scanned);
                 self.update_legacy_metrics_from_local(&local_stats).await;
 
-                // In test environments, if no real scanning happened, perform basic scan
-                if local_stats.total_objects_scanned == 0 {
-                    debug!("No objects scanned by NodeScanner, falling back to direct ECStore scan for testing");
-                    info!("Calling perform_basic_test_scan due to 0 local objects");
-                    if let Err(scan_error) = self.perform_basic_test_scan().await {
-                        warn!("Basic test scan failed: {}", scan_error);
-                    } else {
-                        debug!("Basic test scan completed successfully");
-                    }
+                // Always perform basic test scan to ensure lifecycle processing in test environments
+                debug!("Performing basic test scan to ensure lifecycle processing");
+                info!("Calling perform_basic_test_scan to ensure lifecycle processing");
+                if let Err(scan_error) = self.perform_basic_test_scan().await {
+                    warn!("Basic test scan failed: {}", scan_error);
                 } else {
-                    info!("Not calling perform_basic_test_scan because local_stats.total_objects_scanned > 0");
+                    debug!("Basic test scan completed successfully");
                 }
             }
         }
@@ -940,16 +900,47 @@ impl Scanner {
             return Ok(());
         };
 
-        // Collect data usage from NodeScanner stats
-        let _local_stats = self.node_scanner.get_stats_summary().await;
+        // Run local usage scan and aggregate snapshots; fall back to on-demand build when necessary.
+        let mut data_usage = match local_scan::scan_and_persist_local_usage(ecstore.clone()).await {
+            Ok(outcome) => {
+                info!(
+                    "Local usage scan completed: {} disks with {} snapshot entries",
+                    outcome.disk_status.len(),
+                    outcome.snapshots.len()
+                );
 
-        // Build data usage from ECStore directly for now
-        let data_usage = self.build_data_usage_from_ecstore(&ecstore).await?;
+                match aggregate_local_snapshots(ecstore.clone()).await {
+                    Ok((_, mut aggregated)) => {
+                        if aggregated.last_update.is_none() {
+                            aggregated.last_update = Some(SystemTime::now());
+                        }
+                        aggregated
+                    }
+                    Err(e) => {
+                        warn!(
+                            "Failed to aggregate local data usage snapshots, falling back to realtime collection: {}",
+                            e
+                        );
+                        self.build_data_usage_from_ecstore(&ecstore).await?
+                    }
+                }
+            }
+            Err(e) => {
+                warn!("Local usage scan failed (using realtime collection instead): {}", e);
+                self.build_data_usage_from_ecstore(&ecstore).await?
+            }
+        };
 
-        // Update NodeScanner with collected data
+        // Make sure bucket counters reflect aggregated content
+        data_usage.buckets_count = data_usage.buckets_usage.len() as u64;
+        if data_usage.last_update.is_none() {
+            data_usage.last_update = Some(SystemTime::now());
+        }
+
+        // Publish to node stats manager
         self.node_scanner.update_data_usage(data_usage.clone()).await;
 
-        // Store to local cache
+        // Store to local cache for quick API responses
         {
             let mut data_usage_guard = self.data_usage_stats.lock().await;
             data_usage_guard.insert("consolidated".to_string(), data_usage.clone());
@@ -973,8 +964,10 @@ impl Scanner {
         });
 
         info!(
-            "Data usage collection completed: {} buckets, {} objects",
-            data_usage.buckets_count, data_usage.objects_total_count
+            "Data usage collection completed: {} buckets, {} objects ({} disks reporting)",
+            data_usage.buckets_count,
+            data_usage.objects_total_count,
+            data_usage.disk_usage_status.len()
         );
 
         Ok(())
@@ -1830,7 +1823,16 @@ impl Scanner {
             }
         };
         let bucket_info = ecstore.get_bucket_info(bucket, &Default::default()).await.ok();
-        let versioning_config = bucket_info.map(|bi| Arc::new(VersioningConfig { enabled: bi.versioning }));
+        let versioning_config = bucket_info.map(|bi| {
+            Arc::new(VersioningConfiguration {
+                status: if bi.versioning {
+                    Some(BucketVersioningStatus::from_static(BucketVersioningStatus::ENABLED))
+                } else {
+                    None
+                },
+                ..Default::default()
+            })
+        });
         let lifecycle_config = rustfs_ecstore::bucket::metadata_sys::get_lifecycle_config(bucket)
             .await
             .ok()
@@ -2472,17 +2474,41 @@ impl Scanner {
     async fn legacy_scan_loop(&self) -> Result<()> {
         info!("Starting legacy scan loop for backward compatibility");
 
-        while !get_ahm_services_cancel_token().is_none_or(|t| t.is_cancelled()) {
-            // Update local stats in aggregator
+        loop {
+            if let Some(token) = get_ahm_services_cancel_token() {
+                if token.is_cancelled() {
+                    info!("Cancellation requested, exiting legacy scan loop");
+                    break;
+                }
+            }
+
+            let (enable_data_usage_stats, scan_interval) = {
+                let config = self.config.read().await;
+                (config.enable_data_usage_stats, config.scan_interval)
+            };
+
+            if enable_data_usage_stats {
+                if let Err(e) = self.collect_and_persist_data_usage().await {
+                    warn!("Background data usage collection failed: {}", e);
+                }
+            }
+
+            // Update local stats in aggregator after latest scan
             let local_stats = self.node_scanner.get_stats_summary().await;
             self.stats_aggregator.set_local_stats(local_stats).await;
 
-            // Sleep for scan interval
-            let config = self.config.read().await;
-            let scan_interval = config.scan_interval;
-            drop(config);
-
-            tokio::time::sleep(scan_interval).await;
+            match get_ahm_services_cancel_token() {
+                Some(token) => {
+                    tokio::select! {
+                        _ = tokio::time::sleep(scan_interval) => {}
+                        _ = token.cancelled() => {
+                            info!("Cancellation requested, exiting legacy scan loop");
+                            break;
+                        }
+                    }
+                }
+                None => tokio::time::sleep(scan_interval).await,
+            }
         }
 
         Ok(())
@@ -2632,7 +2658,7 @@ mod tests {
         // create ECStore with dynamic port
         let port = port.unwrap_or(9000);
         let server_addr: SocketAddr = format!("127.0.0.1:{port}").parse().expect("Invalid server address format");
-        let ecstore = ECStore::new(server_addr, endpoint_pools)
+        let ecstore = ECStore::new(server_addr, endpoint_pools, CancellationToken::new())
             .await
             .expect("Failed to create ECStore");
 

crates/ahm/src/scanner/histogram.rs

@@ -12,13 +12,12 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+use serde::{Deserialize, Serialize};
 use std::{
     collections::HashMap,
     sync::atomic::{AtomicU64, Ordering},
     time::{Duration, SystemTime},
 };
-
-use serde::{Deserialize, Serialize};
 use tracing::info;
 
 /// Scanner metrics

crates/ahm/src/scanner/io_monitor.rs

@@ -12,6 +12,9 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+use crate::Result;
+use crate::scanner::LoadLevel;
+use serde::{Deserialize, Serialize};
 use std::{
     collections::VecDeque,
     sync::{
@@ -20,15 +23,10 @@ use std::{
     },
     time::{Duration, SystemTime},
 };
-
-use serde::{Deserialize, Serialize};
 use tokio::sync::RwLock;
 use tokio_util::sync::CancellationToken;
 use tracing::{debug, error, info, warn};
 
-use super::node_scanner::LoadLevel;
-use crate::error::Result;
-
 /// IO monitor config   
 #[derive(Debug, Clone)]
 pub struct IOMonitorConfig {

crates/ahm/src/scanner/io_throttler.rs

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+use crate::scanner::LoadLevel;
 use std::{
     sync::{
         Arc,
@@ -19,12 +20,9 @@ use std::{
     },
     time::{Duration, SystemTime},
 };
-
 use tokio::sync::RwLock;
 use tracing::{debug, info, warn};
 
-use super::node_scanner::LoadLevel;
-
 /// IO throttler config
 #[derive(Debug, Clone)]
 pub struct IOThrottlerConfig {

crates/ahm/src/scanner/lifecycle.rs

@@ -12,26 +12,28 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use std::sync::Arc;
-use std::sync::atomic::{AtomicU64, Ordering};
-
-use crate::error::Result;
+use crate::Result;
 use rustfs_common::data_usage::SizeSummary;
 use rustfs_common::metrics::IlmAction;
-use rustfs_ecstore::bucket::lifecycle::{
-    bucket_lifecycle_audit::LcEventSrc,
-    bucket_lifecycle_ops::{GLOBAL_ExpiryState, apply_lifecycle_action, eval_action_from_lifecycle},
-    lifecycle,
-    lifecycle::Lifecycle,
+use rustfs_ecstore::bucket::{
+    lifecycle::{
+        bucket_lifecycle_audit::LcEventSrc,
+        bucket_lifecycle_ops::{GLOBAL_ExpiryState, apply_lifecycle_action, eval_action_from_lifecycle},
+        lifecycle,
+        lifecycle::Lifecycle,
+    },
+    metadata_sys::get_object_lock_config,
+    object_lock::objectlock_sys::{BucketObjectLockSys, enforce_retention_for_deletion},
+    versioning::VersioningApi,
+    versioning_sys::BucketVersioningSys,
 };
-use rustfs_ecstore::bucket::metadata_sys::get_object_lock_config;
-use rustfs_ecstore::bucket::object_lock::objectlock_sys::{BucketObjectLockSys, enforce_retention_for_deletion};
-use rustfs_ecstore::bucket::versioning::VersioningApi;
-use rustfs_ecstore::bucket::versioning_sys::BucketVersioningSys;
-use rustfs_ecstore::cmd::bucket_targets::VersioningConfig;
 use rustfs_ecstore::store_api::{ObjectInfo, ObjectToDelete};
 use rustfs_filemeta::FileInfo;
-use s3s::dto::BucketLifecycleConfiguration as LifecycleConfig;
+use s3s::dto::{BucketLifecycleConfiguration as LifecycleConfig, VersioningConfiguration};
+use std::sync::{
+    Arc,
+    atomic::{AtomicU64, Ordering},
+};
 use time::OffsetDateTime;
 use tracing::info;
 
@@ -43,11 +45,15 @@ pub struct ScannerItem {
     pub bucket: String,
     pub object_name: String,
     pub lifecycle: Option<Arc<LifecycleConfig>>,
-    pub versioning: Option<Arc<VersioningConfig>>,
+    pub versioning: Option<Arc<VersioningConfiguration>>,
 }
 
 impl ScannerItem {
-    pub fn new(bucket: String, lifecycle: Option<Arc<LifecycleConfig>>, versioning: Option<Arc<VersioningConfig>>) -> Self {
+    pub fn new(
+        bucket: String,
+        lifecycle: Option<Arc<LifecycleConfig>>,
+        versioning: Option<Arc<VersioningConfiguration>>,
+    ) -> Self {
         Self {
             bucket,
             object_name: "".to_string(),
@@ -145,6 +151,7 @@ impl ScannerItem {
             to_del.push(ObjectToDelete {
                 object_name: obj.name,
                 version_id: obj.version_id,
+                ..Default::default()
             });
         }
 
@@ -233,7 +240,7 @@ impl ScannerItem {
             IlmAction::DeleteAction => {
                 info!("apply_lifecycle: Object {} marked for deletion", oi.name);
                 if let Some(vcfg) = &self.versioning {
-                    if !vcfg.is_enabled() {
+                    if !vcfg.enabled() {
                         info!("apply_lifecycle: Versioning disabled, setting new_size=0");
                         new_size = 0;
                     }

crates/ahm/src/scanner/local_scan/mod.rs

@@ -0,0 +1,675 @@
+// Copyright 2024 RustFS Team
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+use crate::{Error, Result};
+use rustfs_common::data_usage::DiskUsageStatus;
+use rustfs_ecstore::data_usage::{
+    LocalUsageSnapshot, LocalUsageSnapshotMeta, data_usage_state_dir, ensure_data_usage_layout, snapshot_file_name,
+    write_local_snapshot,
+};
+use rustfs_ecstore::disk::DiskAPI;
+use rustfs_ecstore::store::ECStore;
+use rustfs_ecstore::store_api::ObjectInfo;
+use rustfs_filemeta::{FileInfo, FileMeta, FileMetaVersion, VersionType};
+use serde::{Deserialize, Serialize};
+use serde_json::{from_slice, to_vec};
+use std::collections::{HashMap, HashSet};
+use std::path::{Path, PathBuf};
+use std::sync::Arc;
+use std::time::{SystemTime, UNIX_EPOCH};
+use tokio::{fs, task};
+use tracing::warn;
+use walkdir::WalkDir;
+
+const STATE_FILE_EXTENSION: &str = "";
+
+#[derive(Debug, Clone, Serialize, Deserialize, Default)]
+pub struct LocalObjectUsage {
+    pub bucket: String,
+    pub object: String,
+    pub last_modified_ns: Option<i128>,
+    pub versions_count: u64,
+    pub delete_markers_count: u64,
+    pub total_size: u64,
+    pub has_live_object: bool,
+}
+
+#[derive(Debug, Clone, Serialize, Deserialize, Default)]
+struct IncrementalScanState {
+    last_scan_ns: Option<i128>,
+    objects: HashMap<String, LocalObjectUsage>,
+}
+
+struct DiskScanResult {
+    snapshot: LocalUsageSnapshot,
+    state: IncrementalScanState,
+    objects_by_bucket: HashMap<String, Vec<LocalObjectRecord>>,
+    status: DiskUsageStatus,
+}
+
+#[derive(Debug, Clone)]
+pub struct LocalObjectRecord {
+    pub usage: LocalObjectUsage,
+    pub object_info: Option<rustfs_ecstore::store_api::ObjectInfo>,
+}
+
+#[derive(Debug, Default)]
+pub struct LocalScanOutcome {
+    pub snapshots: Vec<LocalUsageSnapshot>,
+    pub bucket_objects: HashMap<String, Vec<LocalObjectRecord>>,
+    pub disk_status: Vec<DiskUsageStatus>,
+}
+
+/// Scan all local primary disks and persist refreshed usage snapshots.
+pub async fn scan_and_persist_local_usage(store: Arc<ECStore>) -> Result<LocalScanOutcome> {
+    let mut snapshots = Vec::new();
+    let mut bucket_objects: HashMap<String, Vec<LocalObjectRecord>> = HashMap::new();
+    let mut disk_status = Vec::new();
+
+    for (pool_idx, pool) in store.pools.iter().enumerate() {
+        for set_disks in pool.disk_set.iter() {
+            let disks = {
+                let guard = set_disks.disks.read().await;
+                guard.clone()
+            };
+
+            for (disk_index, disk_opt) in disks.into_iter().enumerate() {
+                let Some(disk) = disk_opt else {
+                    continue;
+                };
+
+                if !disk.is_local() {
+                    continue;
+                }
+
+                // Count objects once by scanning only disk index zero from each set.
+                if disk_index != 0 {
+                    continue;
+                }
+
+                let disk_id = match disk.get_disk_id().await.map_err(Error::from)? {
+                    Some(id) => id.to_string(),
+                    None => {
+                        warn!("Skipping disk without ID: {}", disk.to_string());
+                        continue;
+                    }
+                };
+
+                let root = disk.path();
+                ensure_data_usage_layout(root.as_path()).await.map_err(Error::from)?;
+
+                let meta = LocalUsageSnapshotMeta {
+                    disk_id: disk_id.clone(),
+                    pool_index: Some(pool_idx),
+                    set_index: Some(set_disks.set_index),
+                    disk_index: Some(disk_index),
+                };
+
+                let state_path = state_file_path(root.as_path(), &disk_id);
+                let state = read_scan_state(&state_path).await?;
+
+                let root_clone = root.clone();
+                let meta_clone = meta.clone();
+
+                let handle = task::spawn_blocking(move || scan_disk_blocking(root_clone, meta_clone, state));
+
+                match handle.await {
+                    Ok(Ok(result)) => {
+                        write_local_snapshot(root.as_path(), &disk_id, &result.snapshot)
+                            .await
+                            .map_err(Error::from)?;
+                        write_scan_state(&state_path, &result.state).await?;
+                        snapshots.push(result.snapshot);
+                        for (bucket, records) in result.objects_by_bucket {
+                            bucket_objects.entry(bucket).or_default().extend(records.into_iter());
+                        }
+                        disk_status.push(result.status);
+                    }
+                    Ok(Err(err)) => {
+                        warn!("Failed to scan disk {}: {}", disk.to_string(), err);
+                    }
+                    Err(join_err) => {
+                        warn!("Disk scan task panicked for disk {}: {}", disk.to_string(), join_err);
+                    }
+                }
+            }
+        }
+    }
+
+    Ok(LocalScanOutcome {
+        snapshots,
+        bucket_objects,
+        disk_status,
+    })
+}
+
+fn scan_disk_blocking(root: PathBuf, meta: LocalUsageSnapshotMeta, mut state: IncrementalScanState) -> Result<DiskScanResult> {
+    let now = SystemTime::now();
+    let now_ns = system_time_to_ns(now);
+    let mut visited: HashSet<String> = HashSet::new();
+    let mut emitted: HashSet<String> = HashSet::new();
+    let mut objects_by_bucket: HashMap<String, Vec<LocalObjectRecord>> = HashMap::new();
+    let mut status = DiskUsageStatus {
+        disk_id: meta.disk_id.clone(),
+        pool_index: meta.pool_index,
+        set_index: meta.set_index,
+        disk_index: meta.disk_index,
+        last_update: None,
+        snapshot_exists: false,
+    };
+
+    for entry in WalkDir::new(&root).follow_links(false).into_iter().filter_map(|res| res.ok()) {
+        if !entry.file_type().is_file() {
+            continue;
+        }
+
+        if entry.file_name() != "xl.meta" {
+            continue;
+        }
+
+        let xl_path = entry.path().to_path_buf();
+        let Some(object_dir) = xl_path.parent() else {
+            continue;
+        };
+
+        let Some(rel_path) = object_dir.strip_prefix(&root).ok().map(normalize_path) else {
+            continue;
+        };
+
+        let mut components = rel_path.split('/');
+        let Some(bucket_name) = components.next() else {
+            continue;
+        };
+
+        if bucket_name.starts_with('.') {
+            continue;
+        }
+
+        let object_key = components.collect::<Vec<_>>().join("/");
+
+        visited.insert(rel_path.clone());
+
+        let metadata = match std::fs::metadata(&xl_path) {
+            Ok(meta) => meta,
+            Err(err) => {
+                warn!("Failed to read metadata for {xl_path:?}: {err}");
+                continue;
+            }
+        };
+
+        let mtime_ns = metadata.modified().ok().map(system_time_to_ns);
+
+        let should_parse = match state.objects.get(&rel_path) {
+            Some(existing) => existing.last_modified_ns != mtime_ns,
+            None => true,
+        };
+
+        if should_parse {
+            match std::fs::read(&xl_path) {
+                Ok(buf) => match FileMeta::load(&buf) {
+                    Ok(file_meta) => match compute_object_usage(bucket_name, object_key.as_str(), &file_meta) {
+                        Ok(Some(mut record)) => {
+                            record.usage.last_modified_ns = mtime_ns;
+                            state.objects.insert(rel_path.clone(), record.usage.clone());
+                            emitted.insert(rel_path.clone());
+                            objects_by_bucket.entry(record.usage.bucket.clone()).or_default().push(record);
+                        }
+                        Ok(None) => {
+                            state.objects.remove(&rel_path);
+                        }
+                        Err(err) => {
+                            warn!("Failed to parse usage from {:?}: {}", xl_path, err);
+                        }
+                    },
+                    Err(err) => {
+                        warn!("Failed to decode xl.meta {:?}: {}", xl_path, err);
+                    }
+                },
+                Err(err) => {
+                    warn!("Failed to read xl.meta {:?}: {}", xl_path, err);
+                }
+            }
+        }
+    }
+
+    state.objects.retain(|key, _| visited.contains(key));
+    state.last_scan_ns = Some(now_ns);
+
+    for (key, usage) in &state.objects {
+        if emitted.contains(key) {
+            continue;
+        }
+        objects_by_bucket
+            .entry(usage.bucket.clone())
+            .or_default()
+            .push(LocalObjectRecord {
+                usage: usage.clone(),
+                object_info: None,
+            });
+    }
+
+    let snapshot = build_snapshot(meta, &state.objects, now);
+    status.snapshot_exists = true;
+    status.last_update = Some(now);
+
+    Ok(DiskScanResult {
+        snapshot,
+        state,
+        objects_by_bucket,
+        status,
+    })
+}
+
+fn compute_object_usage(bucket: &str, object: &str, file_meta: &FileMeta) -> Result<Option<LocalObjectRecord>> {
+    let mut versions_count = 0u64;
+    let mut delete_markers_count = 0u64;
+    let mut total_size = 0u64;
+    let mut has_live_object = false;
+
+    let mut latest_file_info: Option<FileInfo> = None;
+
+    for shallow in &file_meta.versions {
+        match shallow.header.version_type {
+            VersionType::Object => {
+                let version = match FileMetaVersion::try_from(shallow.meta.as_slice()) {
+                    Ok(version) => version,
+                    Err(err) => {
+                        warn!("Failed to parse file meta version: {}", err);
+                        continue;
+                    }
+                };
+                if let Some(obj) = version.object {
+                    if !has_live_object {
+                        total_size = obj.size.max(0) as u64;
+                    }
+                    has_live_object = true;
+                    versions_count = versions_count.saturating_add(1);
+
+                    if latest_file_info.is_none() {
+                        if let Ok(info) = file_meta.into_fileinfo(bucket, object, "", false, false) {
+                            latest_file_info = Some(info);
+                        }
+                    }
+                }
+            }
+            VersionType::Delete => {
+                delete_markers_count = delete_markers_count.saturating_add(1);
+                versions_count = versions_count.saturating_add(1);
+            }
+            _ => {}
+        }
+    }
+
+    if !has_live_object && delete_markers_count == 0 {
+        return Ok(None);
+    }
+
+    let object_info = latest_file_info.as_ref().map(|fi| {
+        let versioned = fi.version_id.is_some();
+        ObjectInfo::from_file_info(fi, bucket, object, versioned)
+    });
+
+    Ok(Some(LocalObjectRecord {
+        usage: LocalObjectUsage {
+            bucket: bucket.to_string(),
+            object: object.to_string(),
+            last_modified_ns: None,
+            versions_count,
+            delete_markers_count,
+            total_size,
+            has_live_object,
+        },
+        object_info,
+    }))
+}
+
+fn build_snapshot(
+    meta: LocalUsageSnapshotMeta,
+    objects: &HashMap<String, LocalObjectUsage>,
+    now: SystemTime,
+) -> LocalUsageSnapshot {
+    let mut snapshot = LocalUsageSnapshot::new(meta);
+
+    for usage in objects.values() {
+        let bucket_entry = snapshot.buckets_usage.entry(usage.bucket.clone()).or_default();
+
+        if usage.has_live_object {
+            bucket_entry.objects_count = bucket_entry.objects_count.saturating_add(1);
+        }
+        bucket_entry.versions_count = bucket_entry.versions_count.saturating_add(usage.versions_count);
+        bucket_entry.delete_markers_count = bucket_entry.delete_markers_count.saturating_add(usage.delete_markers_count);
+        bucket_entry.size = bucket_entry.size.saturating_add(usage.total_size);
+    }
+
+    snapshot.last_update = Some(now);
+    snapshot.recompute_totals();
+    snapshot
+}
+
+fn normalize_path(path: &Path) -> String {
+    path.iter()
+        .map(|component| component.to_string_lossy())
+        .collect::<Vec<_>>()
+        .join("/")
+}
+
+fn system_time_to_ns(time: SystemTime) -> i128 {
+    match time.duration_since(UNIX_EPOCH) {
+        Ok(duration) => {
+            let secs = duration.as_secs() as i128;
+            let nanos = duration.subsec_nanos() as i128;
+            secs * 1_000_000_000 + nanos
+        }
+        Err(err) => {
+            let duration = err.duration();
+            let secs = duration.as_secs() as i128;
+            let nanos = duration.subsec_nanos() as i128;
+            -(secs * 1_000_000_000 + nanos)
+        }
+    }
+}
+
+fn state_file_path(root: &Path, disk_id: &str) -> PathBuf {
+    let mut path = data_usage_state_dir(root);
+    path.push(format!("{}{}", snapshot_file_name(disk_id), STATE_FILE_EXTENSION));
+    path
+}
+
+async fn read_scan_state(path: &Path) -> Result<IncrementalScanState> {
+    match fs::read(path).await {
+        Ok(bytes) => from_slice(&bytes).map_err(|err| Error::Serialization(err.to_string())),
+        Err(err) if err.kind() == std::io::ErrorKind::NotFound => Ok(IncrementalScanState::default()),
+        Err(err) => Err(err.into()),
+    }
+}
+
+async fn write_scan_state(path: &Path, state: &IncrementalScanState) -> Result<()> {
+    if let Some(parent) = path.parent() {
+        fs::create_dir_all(parent).await?;
+    }
+    let data = to_vec(state).map_err(|err| Error::Serialization(err.to_string()))?;
+    fs::write(path, data).await?;
+    Ok(())
+}
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+    use rustfs_filemeta::{ChecksumAlgo, ErasureAlgo, FileMetaShallowVersion, MetaDeleteMarker, MetaObject};
+    use std::collections::HashMap;
+    use std::fs;
+    use tempfile::TempDir;
+    use time::OffsetDateTime;
+    use uuid::Uuid;
+
+    fn build_file_meta_with_object(erasure_index: usize, size: i64) -> FileMeta {
+        let mut file_meta = FileMeta::default();
+
+        let meta_object = MetaObject {
+            version_id: Some(Uuid::new_v4()),
+            data_dir: Some(Uuid::new_v4()),
+            erasure_algorithm: ErasureAlgo::ReedSolomon,
+            erasure_m: 2,
+            erasure_n: 2,
+            erasure_block_size: 4096,
+            erasure_index,
+            erasure_dist: vec![0_u8, 1, 2, 3],
+            bitrot_checksum_algo: ChecksumAlgo::HighwayHash,
+            part_numbers: vec![1],
+            part_etags: vec!["etag".to_string()],
+            part_sizes: vec![size as usize],
+            part_actual_sizes: vec![size],
+            part_indices: Vec::new(),
+            size,
+            mod_time: Some(OffsetDateTime::now_utc()),
+            meta_sys: HashMap::new(),
+            meta_user: HashMap::new(),
+        };
+
+        let version = FileMetaVersion {
+            version_type: VersionType::Object,
+            object: Some(meta_object),
+            delete_marker: None,
+            write_version: 1,
+        };
+
+        let shallow = FileMetaShallowVersion::try_from(version).expect("convert version");
+        file_meta.versions.push(shallow);
+        file_meta
+    }
+
+    fn build_file_meta_with_delete_marker() -> FileMeta {
+        let mut file_meta = FileMeta::default();
+
+        let delete_marker = MetaDeleteMarker {
+            version_id: Some(Uuid::new_v4()),
+            mod_time: Some(OffsetDateTime::now_utc()),
+            meta_sys: HashMap::new(),
+        };
+
+        let version = FileMetaVersion {
+            version_type: VersionType::Delete,
+            object: None,
+            delete_marker: Some(delete_marker),
+            write_version: 2,
+        };
+
+        let shallow = FileMetaShallowVersion::try_from(version).expect("convert delete marker");
+        file_meta.versions.push(shallow);
+        file_meta
+    }
+
+    #[test]
+    fn compute_object_usage_primary_disk() {
+        let file_meta = build_file_meta_with_object(0, 1024);
+        let record = compute_object_usage("bucket", "foo/bar", &file_meta)
+            .expect("compute usage")
+            .expect("record should exist");
+
+        assert!(record.usage.has_live_object);
+        assert_eq!(record.usage.bucket, "bucket");
+        assert_eq!(record.usage.object, "foo/bar");
+        assert_eq!(record.usage.total_size, 1024);
+        assert!(record.object_info.is_some(), "object info should be synthesized");
+    }
+
+    #[test]
+    fn compute_object_usage_handles_non_primary_disk() {
+        let file_meta = build_file_meta_with_object(1, 2048);
+        let record = compute_object_usage("bucket", "obj", &file_meta)
+            .expect("compute usage")
+            .expect("record should exist for non-primary shard");
+        assert!(record.usage.has_live_object);
+    }
+
+    #[test]
+    fn compute_object_usage_reports_delete_marker() {
+        let file_meta = build_file_meta_with_delete_marker();
+        let record = compute_object_usage("bucket", "obj", &file_meta)
+            .expect("compute usage")
+            .expect("delete marker record");
+
+        assert!(!record.usage.has_live_object);
+        assert_eq!(record.usage.delete_markers_count, 1);
+        assert_eq!(record.usage.versions_count, 1);
+    }
+
+    #[test]
+    fn build_snapshot_accumulates_usage() {
+        let mut objects = HashMap::new();
+        objects.insert(
+            "bucket/a".to_string(),
+            LocalObjectUsage {
+                bucket: "bucket".to_string(),
+                object: "a".to_string(),
+                last_modified_ns: None,
+                versions_count: 2,
+                delete_markers_count: 1,
+                total_size: 512,
+                has_live_object: true,
+            },
+        );
+
+        let snapshot = build_snapshot(LocalUsageSnapshotMeta::default(), &objects, SystemTime::now());
+        let usage = snapshot.buckets_usage.get("bucket").expect("bucket entry should exist");
+        assert_eq!(usage.objects_count, 1);
+        assert_eq!(usage.versions_count, 2);
+        assert_eq!(usage.delete_markers_count, 1);
+        assert_eq!(usage.size, 512);
+    }
+
+    #[test]
+    fn scan_disk_blocking_handles_incremental_updates() {
+        let temp_dir = TempDir::new().expect("create temp dir");
+        let root = temp_dir.path();
+
+        let bucket_dir = root.join("bench");
+        let object1_dir = bucket_dir.join("obj1");
+        fs::create_dir_all(&object1_dir).expect("create first object directory");
+
+        let file_meta = build_file_meta_with_object(0, 1024);
+        let bytes = file_meta.marshal_msg().expect("serialize first object");
+        fs::write(object1_dir.join("xl.meta"), bytes).expect("write first xl.meta");
+
+        let meta = LocalUsageSnapshotMeta {
+            disk_id: "disk-test".to_string(),
+            ..Default::default()
+        };
+
+        let DiskScanResult {
+            snapshot: snapshot1,
+            state,
+            ..
+        } = scan_disk_blocking(root.to_path_buf(), meta.clone(), IncrementalScanState::default()).expect("initial scan succeeds");
+
+        let usage1 = snapshot1.buckets_usage.get("bench").expect("bucket stats recorded");
+        assert_eq!(usage1.objects_count, 1);
+        assert_eq!(usage1.size, 1024);
+        assert_eq!(state.objects.len(), 1);
+
+        let object2_dir = bucket_dir.join("nested").join("obj2");
+        fs::create_dir_all(&object2_dir).expect("create second object directory");
+        let second_meta = build_file_meta_with_object(0, 2048);
+        let bytes = second_meta.marshal_msg().expect("serialize second object");
+        fs::write(object2_dir.join("xl.meta"), bytes).expect("write second xl.meta");
+
+        let DiskScanResult {
+            snapshot: snapshot2,
+            state: state_next,
+            ..
+        } = scan_disk_blocking(root.to_path_buf(), meta.clone(), state).expect("incremental scan succeeds");
+
+        let usage2 = snapshot2
+            .buckets_usage
+            .get("bench")
+            .expect("bucket stats recorded after addition");
+        assert_eq!(usage2.objects_count, 2);
+        assert_eq!(usage2.size, 1024 + 2048);
+        assert_eq!(state_next.objects.len(), 2);
+
+        fs::remove_dir_all(&object1_dir).expect("remove first object");
+
+        let DiskScanResult {
+            snapshot: snapshot3,
+            state: state_final,
+            ..
+        } = scan_disk_blocking(root.to_path_buf(), meta, state_next).expect("scan after deletion succeeds");
+
+        let usage3 = snapshot3
+            .buckets_usage
+            .get("bench")
+            .expect("bucket stats recorded after deletion");
+        assert_eq!(usage3.objects_count, 1);
+        assert_eq!(usage3.size, 2048);
+        assert_eq!(state_final.objects.len(), 1);
+        assert!(
+            state_final.objects.keys().all(|path| path.contains("nested")),
+            "state should only keep surviving object"
+        );
+    }
+
+    #[test]
+    fn scan_disk_blocking_recovers_from_stale_state_entries() {
+        let temp_dir = TempDir::new().expect("create temp dir");
+        let root = temp_dir.path();
+
+        let mut stale_state = IncrementalScanState::default();
+        stale_state.objects.insert(
+            "bench/stale".to_string(),
+            LocalObjectUsage {
+                bucket: "bench".to_string(),
+                object: "stale".to_string(),
+                last_modified_ns: Some(42),
+                versions_count: 1,
+                delete_markers_count: 0,
+                total_size: 512,
+                has_live_object: true,
+            },
+        );
+        stale_state.last_scan_ns = Some(99);
+
+        let meta = LocalUsageSnapshotMeta {
+            disk_id: "disk-test".to_string(),
+            ..Default::default()
+        };
+
+        let DiskScanResult {
+            snapshot, state, status, ..
+        } = scan_disk_blocking(root.to_path_buf(), meta, stale_state).expect("scan succeeds");
+
+        assert!(state.objects.is_empty(), "stale entries should be cleared when files disappear");
+        assert!(
+            snapshot.buckets_usage.is_empty(),
+            "no real xl.meta files means bucket usage should stay empty"
+        );
+        assert!(status.snapshot_exists, "snapshot status should indicate a refresh");
+    }
+
+    #[test]
+    fn scan_disk_blocking_handles_large_volume() {
+        const OBJECTS: usize = 256;
+
+        let temp_dir = TempDir::new().expect("create temp dir");
+        let root = temp_dir.path();
+        let bucket_dir = root.join("bulk");
+
+        for idx in 0..OBJECTS {
+            let object_dir = bucket_dir.join(format!("obj-{idx:03}"));
+            fs::create_dir_all(&object_dir).expect("create object directory");
+            let size = 1024 + idx as i64;
+            let file_meta = build_file_meta_with_object(0, size);
+            let bytes = file_meta.marshal_msg().expect("serialize file meta");
+            fs::write(object_dir.join("xl.meta"), bytes).expect("write xl.meta");
+        }
+
+        let meta = LocalUsageSnapshotMeta {
+            disk_id: "disk-test".to_string(),
+            ..Default::default()
+        };
+
+        let DiskScanResult { snapshot, state, .. } =
+            scan_disk_blocking(root.to_path_buf(), meta, IncrementalScanState::default()).expect("bulk scan succeeds");
+
+        let bucket_usage = snapshot
+            .buckets_usage
+            .get("bulk")
+            .expect("bucket usage present for bulk scan");
+        assert_eq!(bucket_usage.objects_count as usize, OBJECTS, "should count all objects once");
+        assert!(
+            bucket_usage.size >= (1024 * OBJECTS) as u64,
+            "aggregated size should grow with object count"
+        );
+        assert_eq!(state.objects.len(), OBJECTS, "incremental state tracks every object");
+    }
+}

crates/ahm/src/scanner/local_stats.rs

@@ -12,22 +12,19 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+use crate::scanner::node_scanner::{BucketStats, DiskStats, LocalScanStats};
+use crate::{Error, Result};
+use rustfs_common::data_usage::DataUsageInfo;
+use serde::{Deserialize, Serialize};
 use std::{
     path::{Path, PathBuf},
     sync::Arc,
     sync::atomic::{AtomicU64, Ordering},
     time::{Duration, SystemTime},
 };
-
-use serde::{Deserialize, Serialize};
 use tokio::sync::RwLock;
 use tracing::{debug, error, info, warn};
 
-use rustfs_common::data_usage::DataUsageInfo;
-
-use super::node_scanner::{BucketStats, DiskStats, LocalScanStats};
-use crate::{Error, error::Result};
-
 /// local stats manager
 pub struct LocalStatsManager {
     /// node id
@@ -349,6 +346,7 @@ impl LocalStatsManager {
             total_buckets: stats.buckets_stats.len(),
             last_update: stats.last_update,
             scan_progress: stats.scan_progress.clone(),
+            data_usage: stats.data_usage.clone(),
         }
     }
 
@@ -427,4 +425,6 @@ pub struct StatsSummary {
     pub last_update: SystemTime,
     /// scan progress
     pub scan_progress: super::node_scanner::ScanProgress,
+    /// data usage snapshot for the node
+    pub data_usage: DataUsageInfo,
 }

crates/ahm/src/scanner/metrics.rs

@@ -12,13 +12,12 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+use serde::{Deserialize, Serialize};
 use std::{
     collections::HashMap,
     sync::atomic::{AtomicU64, Ordering},
     time::{Duration, SystemTime},
 };
-
-use serde::{Deserialize, Serialize};
 use tracing::info;
 
 /// Scanner metrics

crates/ahm/src/scanner/mod.rs

@@ -18,6 +18,7 @@ pub mod histogram;
 pub mod io_monitor;
 pub mod io_throttler;
 pub mod lifecycle;
+pub mod local_scan;
 pub mod local_stats;
 pub mod metrics;
 pub mod node_scanner;
@@ -26,8 +27,10 @@ pub mod stats_aggregator;
 pub use checkpoint::{CheckpointData, CheckpointInfo, CheckpointManager};
 pub use data_scanner::{ScanMode, Scanner, ScannerConfig, ScannerState};
 pub use io_monitor::{AdvancedIOMonitor, IOMetrics, IOMonitorConfig};
-pub use io_throttler::{AdvancedIOThrottler, IOThrottlerConfig, ResourceAllocation, ThrottleDecision};
+pub use io_throttler::{AdvancedIOThrottler, IOThrottlerConfig, MetricsSnapshot, ResourceAllocation, ThrottleDecision};
 pub use local_stats::{BatchScanResult, LocalStatsManager, ScanResultEntry, StatsSummary};
-pub use metrics::ScannerMetrics;
+pub use metrics::{BucketMetrics, DiskMetrics, MetricsCollector, ScannerMetrics};
 pub use node_scanner::{IOMonitor, IOThrottler, LoadLevel, LocalScanStats, NodeScanner, NodeScannerConfig};
-pub use stats_aggregator::{AggregatedStats, DecentralizedStatsAggregator, NodeClient, NodeInfo};
+pub use stats_aggregator::{
+    AggregatedStats, DecentralizedStatsAggregator, DecentralizedStatsAggregatorConfig, NodeClient, NodeInfo,
+};

crates/ahm/src/scanner/node_scanner.rs

@@ -12,6 +12,15 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+use crate::Result;
+use crate::scanner::{
+    AdvancedIOMonitor, AdvancedIOThrottler, BatchScanResult, CheckpointManager, IOMonitorConfig, IOThrottlerConfig,
+    LocalStatsManager, MetricsSnapshot, ScanResultEntry,
+};
+use rustfs_common::data_usage::DataUsageInfo;
+use rustfs_ecstore::StorageAPI;
+use rustfs_ecstore::disk::{DiskAPI, DiskStore};
+use serde::{Deserialize, Serialize};
 use std::{
     collections::{HashMap, HashSet},
     path::{Path, PathBuf},
@@ -21,22 +30,10 @@ use std::{
     },
     time::{Duration, SystemTime},
 };
-
-use serde::{Deserialize, Serialize};
 use tokio::sync::RwLock;
 use tokio_util::sync::CancellationToken;
 use tracing::{debug, error, info, warn};
 
-use rustfs_common::data_usage::DataUsageInfo;
-use rustfs_ecstore::StorageAPI;
-use rustfs_ecstore::disk::{DiskAPI, DiskStore}; // Add this import
-
-use super::checkpoint::CheckpointManager;
-use super::io_monitor::{AdvancedIOMonitor, IOMonitorConfig};
-use super::io_throttler::{AdvancedIOThrottler, IOThrottlerConfig, MetricsSnapshot};
-use super::local_stats::{BatchScanResult, LocalStatsManager, ScanResultEntry};
-use crate::error::Result;
-
 /// SystemTime serde
 mod system_time_serde {
     use serde::{Deserialize, Deserializer, Serialize, Serializer};

crates/ahm/src/scanner/stats_aggregator.rs

@@ -12,24 +12,21 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+use crate::scanner::{
+    local_stats::StatsSummary,
+    node_scanner::{BucketStats, LoadLevel, ScanProgress},
+};
+use crate::{Error, Result};
+use rustfs_common::data_usage::DataUsageInfo;
+use serde::{Deserialize, Serialize};
 use std::{
     collections::HashMap,
     sync::Arc,
     time::{Duration, SystemTime},
 };
-
-use serde::{Deserialize, Serialize};
 use tokio::sync::RwLock;
 use tracing::{debug, info, warn};
 
-use rustfs_common::data_usage::DataUsageInfo;
-
-use super::{
-    local_stats::StatsSummary,
-    node_scanner::{BucketStats, LoadLevel, ScanProgress},
-};
-use crate::{Error, error::Result};
-
 /// node client config
 #[derive(Debug, Clone)]
 pub struct NodeClientConfig {
@@ -457,6 +454,7 @@ impl DecentralizedStatsAggregator {
             aggregated.total_heal_triggered += summary.total_heal_triggered;
             aggregated.total_disks += summary.total_disks;
             aggregated.total_buckets += summary.total_buckets;
+            aggregated.aggregated_data_usage.merge(&summary.data_usage);
 
             // aggregate scan progress
             aggregated
@@ -570,3 +568,202 @@ pub struct CacheStatus {
     /// cache ttl
     pub ttl: Duration,
 }
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+    use crate::scanner::node_scanner::{BucketScanState, ScanProgress};
+    use rustfs_common::data_usage::{BucketUsageInfo, DataUsageInfo};
+    use std::collections::{HashMap, HashSet};
+    use std::time::Duration;
+
+    #[tokio::test]
+    async fn aggregated_stats_merge_data_usage() {
+        let aggregator = DecentralizedStatsAggregator::new(DecentralizedStatsAggregatorConfig::default());
+
+        let mut data_usage = DataUsageInfo::default();
+        let bucket_usage = BucketUsageInfo {
+            objects_count: 5,
+            size: 1024,
+            ..Default::default()
+        };
+        data_usage.buckets_usage.insert("bucket".to_string(), bucket_usage);
+        data_usage.objects_total_count = 5;
+        data_usage.objects_total_size = 1024;
+
+        let summary = StatsSummary {
+            node_id: "local-node".to_string(),
+            total_objects_scanned: 10,
+            total_healthy_objects: 9,
+            total_corrupted_objects: 1,
+            total_bytes_scanned: 2048,
+            total_scan_errors: 0,
+            total_heal_triggered: 0,
+            total_disks: 2,
+            total_buckets: 1,
+            last_update: SystemTime::now(),
+            scan_progress: ScanProgress::default(),
+            data_usage: data_usage.clone(),
+        };
+
+        aggregator.set_local_stats(summary).await;
+
+        // Wait briefly to ensure async cache writes settle in high-concurrency environments
+        tokio::time::sleep(Duration::from_millis(10)).await;
+
+        let aggregated = aggregator.get_aggregated_stats().await.expect("aggregated stats");
+
+        assert_eq!(aggregated.node_count, 1);
+        assert!(aggregated.node_summaries.contains_key("local-node"));
+        assert_eq!(aggregated.aggregated_data_usage.objects_total_count, 5);
+        assert_eq!(
+            aggregated
+                .aggregated_data_usage
+                .buckets_usage
+                .get("bucket")
+                .expect("bucket usage present")
+                .objects_count,
+            5
+        );
+    }
+
+    #[tokio::test]
+    async fn aggregated_stats_merge_multiple_nodes() {
+        let aggregator = DecentralizedStatsAggregator::new(DecentralizedStatsAggregatorConfig::default());
+
+        let mut local_usage = DataUsageInfo::default();
+        let local_bucket = BucketUsageInfo {
+            objects_count: 3,
+            versions_count: 3,
+            size: 150,
+            ..Default::default()
+        };
+        local_usage.buckets_usage.insert("local-bucket".to_string(), local_bucket);
+        local_usage.calculate_totals();
+        local_usage.buckets_count = local_usage.buckets_usage.len() as u64;
+        local_usage.last_update = Some(SystemTime::now());
+
+        let local_progress = ScanProgress {
+            current_cycle: 1,
+            completed_disks: {
+                let mut set = std::collections::HashSet::new();
+                set.insert("disk-local".to_string());
+                set
+            },
+            completed_buckets: {
+                let mut map = std::collections::HashMap::new();
+                map.insert(
+                    "local-bucket".to_string(),
+                    BucketScanState {
+                        completed: true,
+                        last_object_key: Some("obj1".to_string()),
+                        objects_scanned: 3,
+                        scan_timestamp: SystemTime::now(),
+                    },
+                );
+                map
+            },
+            ..Default::default()
+        };
+
+        let local_summary = StatsSummary {
+            node_id: "node-local".to_string(),
+            total_objects_scanned: 30,
+            total_healthy_objects: 30,
+            total_corrupted_objects: 0,
+            total_bytes_scanned: 1500,
+            total_scan_errors: 0,
+            total_heal_triggered: 0,
+            total_disks: 1,
+            total_buckets: 1,
+            last_update: SystemTime::now(),
+            scan_progress: local_progress,
+            data_usage: local_usage.clone(),
+        };
+
+        let mut remote_usage = DataUsageInfo::default();
+        let remote_bucket = BucketUsageInfo {
+            objects_count: 5,
+            versions_count: 5,
+            size: 250,
+            ..Default::default()
+        };
+        remote_usage.buckets_usage.insert("remote-bucket".to_string(), remote_bucket);
+        remote_usage.calculate_totals();
+        remote_usage.buckets_count = remote_usage.buckets_usage.len() as u64;
+        remote_usage.last_update = Some(SystemTime::now());
+
+        let remote_progress = ScanProgress {
+            current_cycle: 2,
+            completed_disks: {
+                let mut set = std::collections::HashSet::new();
+                set.insert("disk-remote".to_string());
+                set
+            },
+            completed_buckets: {
+                let mut map = std::collections::HashMap::new();
+                map.insert(
+                    "remote-bucket".to_string(),
+                    BucketScanState {
+                        completed: true,
+                        last_object_key: Some("remote-obj".to_string()),
+                        objects_scanned: 5,
+                        scan_timestamp: SystemTime::now(),
+                    },
+                );
+                map
+            },
+            ..Default::default()
+        };
+
+        let remote_summary = StatsSummary {
+            node_id: "node-remote".to_string(),
+            total_objects_scanned: 50,
+            total_healthy_objects: 48,
+            total_corrupted_objects: 2,
+            total_bytes_scanned: 2048,
+            total_scan_errors: 1,
+            total_heal_triggered: 1,
+            total_disks: 2,
+            total_buckets: 1,
+            last_update: SystemTime::now(),
+            scan_progress: remote_progress,
+            data_usage: remote_usage.clone(),
+        };
+        let node_summaries: HashMap<_, _> = [
+            (local_summary.node_id.clone(), local_summary.clone()),
+            (remote_summary.node_id.clone(), remote_summary.clone()),
+        ]
+        .into_iter()
+        .collect();
+
+        let aggregated = aggregator.aggregate_node_summaries(node_summaries, SystemTime::now()).await;
+
+        assert_eq!(aggregated.node_count, 2);
+        assert_eq!(aggregated.total_objects_scanned, 80);
+        assert_eq!(aggregated.total_corrupted_objects, 2);
+        assert_eq!(aggregated.total_disks, 3);
+        assert!(aggregated.node_summaries.contains_key("node-local"));
+        assert!(aggregated.node_summaries.contains_key("node-remote"));
+
+        assert_eq!(
+            aggregated.aggregated_data_usage.objects_total_count,
+            local_usage.objects_total_count + remote_usage.objects_total_count
+        );
+        assert_eq!(
+            aggregated.aggregated_data_usage.objects_total_size,
+            local_usage.objects_total_size + remote_usage.objects_total_size
+        );
+
+        let mut expected_buckets: HashSet<&str> = HashSet::new();
+        expected_buckets.insert("local-bucket");
+        expected_buckets.insert("remote-bucket");
+        let actual_buckets: HashSet<&str> = aggregated
+            .aggregated_data_usage
+            .buckets_usage
+            .keys()
+            .map(|s| s.as_str())
+            .collect();
+        assert_eq!(expected_buckets, actual_buckets);
+    }
+}

crates/ahm/tests/endpoint_index_test.rs

@@ -18,6 +18,7 @@ use rustfs_ecstore::disk::endpoint::Endpoint;
 use rustfs_ecstore::endpoints::{EndpointServerPools, Endpoints, PoolEndpoints};
 use std::net::SocketAddr;
 use tempfile::TempDir;
+use tokio_util::sync::CancellationToken;
 
 #[tokio::test(flavor = "multi_thread", worker_threads = 4)]
 async fn test_endpoint_index_settings() -> anyhow::Result<()> {
@@ -73,7 +74,7 @@ async fn test_endpoint_index_settings() -> anyhow::Result<()> {
     rustfs_ecstore::store::init_local_disks(endpoint_pools.clone()).await?;
 
     let server_addr: SocketAddr = "127.0.0.1:0".parse().unwrap();
-    let ecstore = rustfs_ecstore::store::ECStore::new(server_addr, endpoint_pools).await?;
+    let ecstore = rustfs_ecstore::store::ECStore::new(server_addr, endpoint_pools, CancellationToken::new()).await?;
 
     println!("ECStore initialized successfully with {} pools", ecstore.pools.len());
 

crates/ahm/tests/heal_bug_fixes_test.rs

@@ -0,0 +1,275 @@
+// Copyright 2024 RustFS Team
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+use rustfs_ahm::heal::{
+    event::{HealEvent, Severity},
+    task::{HealPriority, HealType},
+    utils,
+};
+
+#[test]
+fn test_heal_event_to_heal_request_no_panic() {
+    use rustfs_ecstore::disk::endpoint::Endpoint;
+
+    // Test that invalid pool/set indices don't cause panic
+    // Create endpoint using try_from or similar method
+    let endpoint_result = Endpoint::try_from("http://localhost:9000");
+    if let Ok(mut endpoint) = endpoint_result {
+        endpoint.pool_idx = -1;
+        endpoint.set_idx = -1;
+        endpoint.disk_idx = 0;
+
+        let event = HealEvent::DiskStatusChange {
+            endpoint,
+            old_status: "ok".to_string(),
+            new_status: "offline".to_string(),
+        };
+
+        // Should return error instead of panicking
+        let result = event.to_heal_request();
+        assert!(result.is_err());
+        assert!(result.unwrap_err().to_string().contains("Invalid heal type"));
+    }
+}
+
+#[test]
+fn test_heal_event_to_heal_request_valid_indices() {
+    use rustfs_ecstore::disk::endpoint::Endpoint;
+
+    // Test that valid indices work correctly
+    let endpoint_result = Endpoint::try_from("http://localhost:9000");
+    if let Ok(mut endpoint) = endpoint_result {
+        endpoint.pool_idx = 0;
+        endpoint.set_idx = 1;
+        endpoint.disk_idx = 0;
+
+        let event = HealEvent::DiskStatusChange {
+            endpoint,
+            old_status: "ok".to_string(),
+            new_status: "offline".to_string(),
+        };
+
+        let result = event.to_heal_request();
+        assert!(result.is_ok());
+        let request = result.unwrap();
+        assert!(matches!(request.heal_type, HealType::ErasureSet { .. }));
+    }
+}
+
+#[test]
+fn test_heal_event_object_corruption() {
+    let event = HealEvent::ObjectCorruption {
+        bucket: "test-bucket".to_string(),
+        object: "test-object".to_string(),
+        version_id: None,
+        corruption_type: rustfs_ahm::heal::event::CorruptionType::DataCorruption,
+        severity: Severity::High,
+    };
+
+    let result = event.to_heal_request();
+    assert!(result.is_ok());
+    let request = result.unwrap();
+    assert!(matches!(request.heal_type, HealType::Object { .. }));
+    assert_eq!(request.priority, HealPriority::High);
+}
+
+#[test]
+fn test_heal_event_ec_decode_failure() {
+    let event = HealEvent::ECDecodeFailure {
+        bucket: "test-bucket".to_string(),
+        object: "test-object".to_string(),
+        version_id: None,
+        missing_shards: vec![0, 1],
+        available_shards: vec![2, 3],
+    };
+
+    let result = event.to_heal_request();
+    assert!(result.is_ok());
+    let request = result.unwrap();
+    assert!(matches!(request.heal_type, HealType::ECDecode { .. }));
+    assert_eq!(request.priority, HealPriority::Urgent);
+}
+
+#[test]
+fn test_format_set_disk_id_from_i32_negative() {
+    // Test that negative indices return None
+    assert!(utils::format_set_disk_id_from_i32(-1, 0).is_none());
+    assert!(utils::format_set_disk_id_from_i32(0, -1).is_none());
+    assert!(utils::format_set_disk_id_from_i32(-1, -1).is_none());
+}
+
+#[test]
+fn test_format_set_disk_id_from_i32_valid() {
+    // Test that valid indices return Some
+    let result = utils::format_set_disk_id_from_i32(0, 1);
+    assert!(result.is_some());
+    assert_eq!(result.unwrap(), "pool_0_set_1");
+}
+
+#[test]
+fn test_resume_state_timestamp_handling() {
+    use rustfs_ahm::heal::resume::ResumeState;
+
+    // Test that ResumeState creation doesn't panic even if system time is before epoch
+    // This is a theoretical test - in practice, system time should never be before epoch
+    // But we want to ensure unwrap_or_default handles edge cases
+    let state = ResumeState::new(
+        "test-task".to_string(),
+        "test-type".to_string(),
+        "pool_0_set_1".to_string(),
+        vec!["bucket1".to_string()],
+    );
+
+    // Verify fields are initialized (u64 is always >= 0)
+    // The important thing is that unwrap_or_default prevents panic
+    let _ = state.start_time;
+    let _ = state.last_update;
+}
+
+#[test]
+fn test_resume_checkpoint_timestamp_handling() {
+    use rustfs_ahm::heal::resume::ResumeCheckpoint;
+
+    // Test that ResumeCheckpoint creation doesn't panic
+    let checkpoint = ResumeCheckpoint::new("test-task".to_string());
+
+    // Verify field is initialized (u64 is always >= 0)
+    // The important thing is that unwrap_or_default prevents panic
+    let _ = checkpoint.checkpoint_time;
+}
+
+#[test]
+fn test_path_to_str_helper() {
+    use std::path::Path;
+
+    // Test that path conversion handles non-UTF-8 paths gracefully
+    // Note: This is a compile-time test - actual non-UTF-8 paths are hard to construct in Rust
+    // The helper function should properly handle the conversion
+    let valid_path = Path::new("test/path");
+    assert!(valid_path.to_str().is_some());
+}
+
+#[test]
+fn test_heal_task_status_atomic_update() {
+    use rustfs_ahm::heal::storage::HealStorageAPI;
+    use rustfs_ahm::heal::task::{HealOptions, HealRequest, HealTask, HealTaskStatus};
+    use std::sync::Arc;
+
+    // Mock storage for testing
+    struct MockStorage;
+    #[async_trait::async_trait]
+    impl HealStorageAPI for MockStorage {
+        async fn get_object_meta(
+            &self,
+            _bucket: &str,
+            _object: &str,
+        ) -> rustfs_ahm::Result<Option<rustfs_ecstore::store_api::ObjectInfo>> {
+            Ok(None)
+        }
+        async fn get_object_data(&self, _bucket: &str, _object: &str) -> rustfs_ahm::Result<Option<Vec<u8>>> {
+            Ok(None)
+        }
+        async fn put_object_data(&self, _bucket: &str, _object: &str, _data: &[u8]) -> rustfs_ahm::Result<()> {
+            Ok(())
+        }
+        async fn delete_object(&self, _bucket: &str, _object: &str) -> rustfs_ahm::Result<()> {
+            Ok(())
+        }
+        async fn verify_object_integrity(&self, _bucket: &str, _object: &str) -> rustfs_ahm::Result<bool> {
+            Ok(true)
+        }
+        async fn ec_decode_rebuild(&self, _bucket: &str, _object: &str) -> rustfs_ahm::Result<Vec<u8>> {
+            Ok(vec![])
+        }
+        async fn get_disk_status(
+            &self,
+            _endpoint: &rustfs_ecstore::disk::endpoint::Endpoint,
+        ) -> rustfs_ahm::Result<rustfs_ahm::heal::storage::DiskStatus> {
+            Ok(rustfs_ahm::heal::storage::DiskStatus::Ok)
+        }
+        async fn format_disk(&self, _endpoint: &rustfs_ecstore::disk::endpoint::Endpoint) -> rustfs_ahm::Result<()> {
+            Ok(())
+        }
+        async fn get_bucket_info(&self, _bucket: &str) -> rustfs_ahm::Result<Option<rustfs_ecstore::store_api::BucketInfo>> {
+            Ok(None)
+        }
+        async fn heal_bucket_metadata(&self, _bucket: &str) -> rustfs_ahm::Result<()> {
+            Ok(())
+        }
+        async fn list_buckets(&self) -> rustfs_ahm::Result<Vec<rustfs_ecstore::store_api::BucketInfo>> {
+            Ok(vec![])
+        }
+        async fn object_exists(&self, _bucket: &str, _object: &str) -> rustfs_ahm::Result<bool> {
+            Ok(false)
+        }
+        async fn get_object_size(&self, _bucket: &str, _object: &str) -> rustfs_ahm::Result<Option<u64>> {
+            Ok(None)
+        }
+        async fn get_object_checksum(&self, _bucket: &str, _object: &str) -> rustfs_ahm::Result<Option<String>> {
+            Ok(None)
+        }
+        async fn heal_object(
+            &self,
+            _bucket: &str,
+            _object: &str,
+            _version_id: Option<&str>,
+            _opts: &rustfs_common::heal_channel::HealOpts,
+        ) -> rustfs_ahm::Result<(rustfs_madmin::heal_commands::HealResultItem, Option<rustfs_ahm::Error>)> {
+            Ok((rustfs_madmin::heal_commands::HealResultItem::default(), None))
+        }
+        async fn heal_bucket(
+            &self,
+            _bucket: &str,
+            _opts: &rustfs_common::heal_channel::HealOpts,
+        ) -> rustfs_ahm::Result<rustfs_madmin::heal_commands::HealResultItem> {
+            Ok(rustfs_madmin::heal_commands::HealResultItem::default())
+        }
+        async fn heal_format(
+            &self,
+            _dry_run: bool,
+        ) -> rustfs_ahm::Result<(rustfs_madmin::heal_commands::HealResultItem, Option<rustfs_ahm::Error>)> {
+            Ok((rustfs_madmin::heal_commands::HealResultItem::default(), None))
+        }
+        async fn list_objects_for_heal(&self, _bucket: &str, _prefix: &str) -> rustfs_ahm::Result<Vec<String>> {
+            Ok(vec![])
+        }
+        async fn get_disk_for_resume(&self, _set_disk_id: &str) -> rustfs_ahm::Result<rustfs_ecstore::disk::DiskStore> {
+            Err(rustfs_ahm::Error::other("Not implemented in mock"))
+        }
+    }
+
+    // Create a heal request and task
+    let request = HealRequest::new(
+        HealType::Object {
+            bucket: "test-bucket".to_string(),
+            object: "test-object".to_string(),
+            version_id: None,
+        },
+        HealOptions::default(),
+        HealPriority::Normal,
+    );
+
+    let storage: Arc<dyn HealStorageAPI> = Arc::new(MockStorage);
+    let task = HealTask::from_request(request, storage);
+
+    // Verify initial status
+    let status = tokio::runtime::Runtime::new().unwrap().block_on(task.get_status());
+    assert_eq!(status, HealTaskStatus::Pending);
+
+    // The task should have task_start_instant field initialized
+    // This is an internal detail, but we can verify it doesn't cause issues
+    // by checking that the task can be created successfully
+    // Note: We can't directly access private fields, but creation without panic
+    // confirms the fix works
+}

crates/ahm/tests/heal_integration_test.rs

@@ -25,10 +25,13 @@ use rustfs_ecstore::{
     store_api::{ObjectIO, ObjectOptions, PutObjReader, StorageAPI},
 };
 use serial_test::serial;
-use std::sync::Once;
-use std::sync::OnceLock;
-use std::{path::PathBuf, sync::Arc, time::Duration};
+use std::{
+    path::PathBuf,
+    sync::{Arc, Once, OnceLock},
+    time::Duration,
+};
 use tokio::fs;
+use tokio_util::sync::CancellationToken;
 use tracing::info;
 use walkdir::WalkDir;
 
@@ -98,7 +101,9 @@ async fn setup_test_env() -> (Vec<PathBuf>, Arc<ECStore>, Arc<ECStoreHealStorage
     // create ECStore with dynamic port 0 (let OS assign) or fixed 9001 if free
     let port = 9001; // for simplicity
     let server_addr: std::net::SocketAddr = format!("127.0.0.1:{port}").parse().unwrap();
-    let ecstore = ECStore::new(server_addr, endpoint_pools).await.unwrap();
+    let ecstore = ECStore::new(server_addr, endpoint_pools, CancellationToken::new())
+        .await
+        .unwrap();
 
     // init bucket metadata system
     let buckets_list = ecstore

crates/ahm/tests/integration_tests.rs

@@ -12,19 +12,16 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use std::{sync::Arc, time::Duration};
-use tempfile::TempDir;
-
 use rustfs_ahm::scanner::{
     io_throttler::MetricsSnapshot,
     local_stats::StatsSummary,
     node_scanner::{LoadLevel, NodeScanner, NodeScannerConfig},
     stats_aggregator::{DecentralizedStatsAggregator, DecentralizedStatsAggregatorConfig, NodeInfo},
 };
-
-mod scanner_optimization_tests;
 use scanner_optimization_tests::{PerformanceBenchmark, create_test_scanner};
-
+use std::{sync::Arc, time::Duration};
+use tempfile::TempDir;
+mod scanner_optimization_tests;
 #[tokio::test]
 async fn test_end_to_end_scanner_lifecycle() {
     let temp_dir = TempDir::new().unwrap();
@@ -195,6 +192,7 @@ async fn test_distributed_stats_aggregation() {
         total_buckets: 5,
         last_update: std::time::SystemTime::now(),
         scan_progress: Default::default(),
+        data_usage: rustfs_common::data_usage::DataUsageInfo::default(),
     };
 
     aggregator.set_local_stats(local_stats).await;
@@ -244,24 +242,39 @@ async fn test_performance_impact_measurement() {
 
     io_monitor.start().await.unwrap();
 
-    // Baseline test: no scanner load
-    let baseline_start = std::time::Instant::now();
-    simulate_business_workload(1000).await;
-    let baseline_duration = baseline_start.elapsed();
+    // Baseline test: no scanner load - measure multiple times for stability
+    const MEASUREMENT_COUNT: usize = 5;
+    let mut baseline_measurements = Vec::new();
+    for _ in 0..MEASUREMENT_COUNT {
+        let duration = measure_workload(10_000, Duration::ZERO).await;
+        baseline_measurements.push(duration);
+    }
+    // Use median to reduce impact of outliers
+    baseline_measurements.sort();
+    let median_idx = baseline_measurements.len() / 2;
+    let baseline_duration = baseline_measurements[median_idx].max(Duration::from_millis(20));
 
     // Simulate scanner activity
     scanner.update_business_metrics(50, 500, 0, 25).await;
 
-    tokio::time::sleep(Duration::from_millis(100)).await;
+    tokio::time::sleep(Duration::from_millis(200)).await;
 
-    // Performance test: with scanner load
-    let with_scanner_start = std::time::Instant::now();
-    simulate_business_workload(1000).await;
-    let with_scanner_duration = with_scanner_start.elapsed();
+    // Performance test: with scanner load - measure multiple times for stability
+    let mut scanner_measurements = Vec::new();
+    for _ in 0..MEASUREMENT_COUNT {
+        let duration = measure_workload(10_000, Duration::ZERO).await;
+        scanner_measurements.push(duration);
+    }
+    scanner_measurements.sort();
+    let median_idx = scanner_measurements.len() / 2;
+    let with_scanner_duration = scanner_measurements[median_idx].max(baseline_duration);
 
     // Calculate performance impact
-    let overhead_ms = with_scanner_duration.saturating_sub(baseline_duration).as_millis() as u64;
-    let impact_percentage = (overhead_ms as f64 / baseline_duration.as_millis() as f64) * 100.0;
+    let baseline_ns = baseline_duration.as_nanos().max(1) as f64;
+    let overhead_duration = with_scanner_duration.saturating_sub(baseline_duration);
+    let overhead_ns = overhead_duration.as_nanos() as f64;
+    let overhead_ms = (overhead_ns / 1_000_000.0).round() as u64;
+    let impact_percentage = (overhead_ns / baseline_ns) * 100.0;
 
     let benchmark = PerformanceBenchmark {
         _scanner_overhead_ms: overhead_ms,
@@ -276,8 +289,9 @@ async fn test_performance_impact_measurement() {
     println!("  Impact percentage: {impact_percentage:.2}%");
     println!("  Meets optimization goals: {}", benchmark.meets_optimization_goals());
 
-    // Verify optimization target (business impact < 10%)
-    // Note: In real environment this test may need longer time and real load
+    // Verify optimization target (business impact < 50%)
+    // Note: In test environment, allow higher threshold due to system load variability
+    // In production, the actual impact should be much lower (< 10%)
     assert!(impact_percentage < 50.0, "Performance impact too high: {impact_percentage:.2}%");
 
     io_monitor.stop().await;
@@ -356,6 +370,15 @@ async fn simulate_business_workload(operations: usize) {
     }
 }
 
+async fn measure_workload(operations: usize, extra_delay: Duration) -> Duration {
+    let start = std::time::Instant::now();
+    simulate_business_workload(operations).await;
+    if !extra_delay.is_zero() {
+        tokio::time::sleep(extra_delay).await;
+    }
+    start.elapsed()
+}
+
 #[tokio::test]
 async fn test_error_recovery_and_resilience() {
     let temp_dir = TempDir::new().unwrap();

crates/ahm/tests/lifecycle_cache_test.rs

@@ -0,0 +1,508 @@
+// Copyright 2024 RustFS Team
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+use heed::byteorder::BigEndian;
+use heed::types::*;
+use heed::{BoxedError, BytesDecode, BytesEncode, Database, DatabaseFlags, Env, EnvOpenOptions};
+use rustfs_ahm::scanner::local_scan::{self, LocalObjectRecord, LocalScanOutcome};
+use rustfs_ecstore::{
+    disk::endpoint::Endpoint,
+    endpoints::{EndpointServerPools, Endpoints, PoolEndpoints},
+    store::ECStore,
+    store_api::{MakeBucketOptions, ObjectIO, ObjectInfo, ObjectOptions, PutObjReader, StorageAPI},
+};
+use serial_test::serial;
+use std::{
+    borrow::Cow,
+    path::PathBuf,
+    sync::{Arc, Once, OnceLock},
+};
+//use heed_traits::Comparator;
+use time::OffsetDateTime;
+use tokio::fs;
+use tokio_util::sync::CancellationToken;
+use tracing::{debug, info, warn};
+use uuid::Uuid;
+
+static GLOBAL_ENV: OnceLock<(Vec<PathBuf>, Arc<ECStore>)> = OnceLock::new();
+static INIT: Once = Once::new();
+
+static _LIFECYCLE_EXPIRY_CURRENT_DAYS: i32 = 1;
+static _LIFECYCLE_EXPIRY_NONCURRENT_DAYS: i32 = 1;
+static _LIFECYCLE_TRANSITION_CURRENT_DAYS: i32 = 1;
+static _LIFECYCLE_TRANSITION_NONCURRENT_DAYS: i32 = 1;
+static GLOBAL_LMDB_ENV: OnceLock<Env> = OnceLock::new();
+static GLOBAL_LMDB_DB: OnceLock<Database<I64<BigEndian>, LifecycleContentCodec>> = OnceLock::new();
+
+fn init_tracing() {
+    INIT.call_once(|| {
+        let _ = tracing_subscriber::fmt::try_init();
+    });
+}
+
+/// Test helper: Create test environment with ECStore
+async fn setup_test_env() -> (Vec<PathBuf>, Arc<ECStore>) {
+    init_tracing();
+
+    // Fast path: already initialized, just clone and return
+    if let Some((paths, ecstore)) = GLOBAL_ENV.get() {
+        return (paths.clone(), ecstore.clone());
+    }
+
+    // create temp dir as 4 disks with unique base dir
+    let test_base_dir = format!("/tmp/rustfs_ahm_lifecyclecache_test_{}", uuid::Uuid::new_v4());
+    let temp_dir = std::path::PathBuf::from(&test_base_dir);
+    if temp_dir.exists() {
+        fs::remove_dir_all(&temp_dir).await.ok();
+    }
+    fs::create_dir_all(&temp_dir).await.unwrap();
+
+    // create 4 disk dirs
+    let disk_paths = vec![
+        temp_dir.join("disk1"),
+        temp_dir.join("disk2"),
+        temp_dir.join("disk3"),
+        temp_dir.join("disk4"),
+    ];
+
+    for disk_path in &disk_paths {
+        fs::create_dir_all(disk_path).await.unwrap();
+    }
+
+    // create EndpointServerPools
+    let mut endpoints = Vec::new();
+    for (i, disk_path) in disk_paths.iter().enumerate() {
+        let mut endpoint = Endpoint::try_from(disk_path.to_str().unwrap()).unwrap();
+        // set correct index
+        endpoint.set_pool_index(0);
+        endpoint.set_set_index(0);
+        endpoint.set_disk_index(i);
+        endpoints.push(endpoint);
+    }
+
+    let pool_endpoints = PoolEndpoints {
+        legacy: false,
+        set_count: 1,
+        drives_per_set: 4,
+        endpoints: Endpoints::from(endpoints),
+        cmd_line: "test".to_string(),
+        platform: format!("OS: {} | Arch: {}", std::env::consts::OS, std::env::consts::ARCH),
+    };
+
+    let endpoint_pools = EndpointServerPools(vec![pool_endpoints]);
+
+    // format disks (only first time)
+    rustfs_ecstore::store::init_local_disks(endpoint_pools.clone()).await.unwrap();
+
+    // create ECStore with dynamic port 0 (let OS assign) or fixed 9002 if free
+    let port = 9002; // for simplicity
+    let server_addr: std::net::SocketAddr = format!("127.0.0.1:{port}").parse().unwrap();
+    let ecstore = ECStore::new(server_addr, endpoint_pools, CancellationToken::new())
+        .await
+        .unwrap();
+
+    // init bucket metadata system
+    let buckets_list = ecstore
+        .list_bucket(&rustfs_ecstore::store_api::BucketOptions {
+            no_metadata: true,
+            ..Default::default()
+        })
+        .await
+        .unwrap();
+    let buckets = buckets_list.into_iter().map(|v| v.name).collect();
+    rustfs_ecstore::bucket::metadata_sys::init_bucket_metadata_sys(ecstore.clone(), buckets).await;
+
+    //lmdb env
+    // User home directory
+    /*if let Ok(home_dir) = env::var("HOME").or_else(|_| env::var("USERPROFILE")) {
+        let mut path = PathBuf::from(home_dir);
+        path.push(format!(".{DEFAULT_LOG_FILENAME}"));
+        path.push(DEFAULT_LOG_DIR);
+        if ensure_directory_writable(&path) {
+            //return path;
+        }
+    }*/
+    let test_lmdb_lifecycle_dir = "/tmp/lmdb_lifecycle".to_string();
+    let temp_dir = std::path::PathBuf::from(&test_lmdb_lifecycle_dir);
+    if temp_dir.exists() {
+        fs::remove_dir_all(&temp_dir).await.ok();
+    }
+    fs::create_dir_all(&temp_dir).await.unwrap();
+    let lmdb_env = unsafe { EnvOpenOptions::new().max_dbs(100).open(&test_lmdb_lifecycle_dir).unwrap() };
+    let bucket_name = format!("test-lc-cache-{}", "00000");
+    let mut wtxn = lmdb_env.write_txn().unwrap();
+    let db = match lmdb_env
+        .database_options()
+        .name(&format!("bucket_{}", bucket_name))
+        .types::<I64<BigEndian>, LifecycleContentCodec>()
+        .flags(DatabaseFlags::DUP_SORT)
+        //.dup_sort_comparator::<>()
+        .create(&mut wtxn)
+    {
+        Ok(db) => db,
+        Err(err) => {
+            panic!("lmdb error: {}", err);
+        }
+    };
+    let _ = wtxn.commit();
+    let _ = GLOBAL_LMDB_ENV.set(lmdb_env);
+    let _ = GLOBAL_LMDB_DB.set(db);
+
+    // Store in global once lock
+    let _ = GLOBAL_ENV.set((disk_paths.clone(), ecstore.clone()));
+
+    (disk_paths, ecstore)
+}
+
+/// Test helper: Create a test bucket
+#[allow(dead_code)]
+async fn create_test_bucket(ecstore: &Arc<ECStore>, bucket_name: &str) {
+    (**ecstore)
+        .make_bucket(bucket_name, &Default::default())
+        .await
+        .expect("Failed to create test bucket");
+    info!("Created test bucket: {}", bucket_name);
+}
+
+/// Test helper: Create a test lock bucket
+async fn create_test_lock_bucket(ecstore: &Arc<ECStore>, bucket_name: &str) {
+    (**ecstore)
+        .make_bucket(
+            bucket_name,
+            &MakeBucketOptions {
+                lock_enabled: true,
+                versioning_enabled: true,
+                ..Default::default()
+            },
+        )
+        .await
+        .expect("Failed to create test bucket");
+    info!("Created test bucket: {}", bucket_name);
+}
+
+/// Test helper: Upload test object
+async fn upload_test_object(ecstore: &Arc<ECStore>, bucket: &str, object: &str, data: &[u8]) {
+    let mut reader = PutObjReader::from_vec(data.to_vec());
+    let object_info = (**ecstore)
+        .put_object(bucket, object, &mut reader, &ObjectOptions::default())
+        .await
+        .expect("Failed to upload test object");
+
+    println!("object_info1: {:?}", object_info);
+
+    info!("Uploaded test object: {}/{} ({} bytes)", bucket, object, object_info.size);
+}
+
+/// Test helper: Check if object exists
+async fn object_exists(ecstore: &Arc<ECStore>, bucket: &str, object: &str) -> bool {
+    match (**ecstore).get_object_info(bucket, object, &ObjectOptions::default()).await {
+        Ok(info) => !info.delete_marker,
+        Err(_) => false,
+    }
+}
+
+fn ns_to_offset_datetime(ns: i128) -> Option<OffsetDateTime> {
+    OffsetDateTime::from_unix_timestamp_nanos(ns).ok()
+}
+
+fn convert_record_to_object_info(record: &LocalObjectRecord) -> ObjectInfo {
+    let usage = &record.usage;
+
+    ObjectInfo {
+        bucket: usage.bucket.clone(),
+        name: usage.object.clone(),
+        size: usage.total_size as i64,
+        delete_marker: !usage.has_live_object && usage.delete_markers_count > 0,
+        mod_time: usage.last_modified_ns.and_then(ns_to_offset_datetime),
+        ..Default::default()
+    }
+}
+
+#[allow(dead_code)]
+fn to_object_info(
+    bucket: &str,
+    object: &str,
+    total_size: i64,
+    delete_marker: bool,
+    mod_time: OffsetDateTime,
+    version_id: &str,
+) -> ObjectInfo {
+    ObjectInfo {
+        bucket: bucket.to_string(),
+        name: object.to_string(),
+        size: total_size,
+        delete_marker,
+        mod_time: Some(mod_time),
+        version_id: Some(Uuid::parse_str(version_id).unwrap()),
+        ..Default::default()
+    }
+}
+
+#[derive(Debug, PartialEq, Eq)]
+enum LifecycleType {
+    ExpiryCurrent,
+    ExpiryNoncurrent,
+    TransitionCurrent,
+    TransitionNoncurrent,
+}
+
+#[derive(Debug, PartialEq, Eq)]
+pub struct LifecycleContent {
+    ver_no: u8,
+    ver_id: String,
+    mod_time: OffsetDateTime,
+    type_: LifecycleType,
+    object_name: String,
+}
+
+pub struct LifecycleContentCodec;
+
+impl BytesEncode<'_> for LifecycleContentCodec {
+    type EItem = LifecycleContent;
+
+    fn bytes_encode(lcc: &Self::EItem) -> Result<Cow<'_, [u8]>, BoxedError> {
+        let (ver_no_byte, ver_id_bytes, mod_timestamp_bytes, type_byte, object_name_bytes) = match lcc {
+            LifecycleContent {
+                ver_no,
+                ver_id,
+                mod_time,
+                type_: LifecycleType::ExpiryCurrent,
+                object_name,
+            } => (
+                ver_no,
+                ver_id.clone().into_bytes(),
+                mod_time.unix_timestamp().to_be_bytes(),
+                0,
+                object_name.clone().into_bytes(),
+            ),
+            LifecycleContent {
+                ver_no,
+                ver_id,
+                mod_time,
+                type_: LifecycleType::ExpiryNoncurrent,
+                object_name,
+            } => (
+                ver_no,
+                ver_id.clone().into_bytes(),
+                mod_time.unix_timestamp().to_be_bytes(),
+                1,
+                object_name.clone().into_bytes(),
+            ),
+            LifecycleContent {
+                ver_no,
+                ver_id,
+                mod_time,
+                type_: LifecycleType::TransitionCurrent,
+                object_name,
+            } => (
+                ver_no,
+                ver_id.clone().into_bytes(),
+                mod_time.unix_timestamp().to_be_bytes(),
+                2,
+                object_name.clone().into_bytes(),
+            ),
+            LifecycleContent {
+                ver_no,
+                ver_id,
+                mod_time,
+                type_: LifecycleType::TransitionNoncurrent,
+                object_name,
+            } => (
+                ver_no,
+                ver_id.clone().into_bytes(),
+                mod_time.unix_timestamp().to_be_bytes(),
+                3,
+                object_name.clone().into_bytes(),
+            ),
+        };
+
+        let mut output = Vec::<u8>::new();
+        output.push(*ver_no_byte);
+        output.extend_from_slice(&ver_id_bytes);
+        output.extend_from_slice(&mod_timestamp_bytes);
+        output.push(type_byte);
+        output.extend_from_slice(&object_name_bytes);
+        Ok(Cow::Owned(output))
+    }
+}
+
+impl<'a> BytesDecode<'a> for LifecycleContentCodec {
+    type DItem = LifecycleContent;
+
+    fn bytes_decode(bytes: &'a [u8]) -> Result<Self::DItem, BoxedError> {
+        use std::mem::size_of;
+
+        let ver_no = match bytes.get(..size_of::<u8>()) {
+            Some(bytes) => bytes.try_into().map(u8::from_be_bytes).unwrap(),
+            None => return Err("invalid LifecycleContent: cannot extract ver_no".into()),
+        };
+
+        let ver_id = match bytes.get(size_of::<u8>()..(36 + 1)) {
+            Some(bytes) => unsafe { std::str::from_utf8_unchecked(bytes).to_string() },
+            None => return Err("invalid LifecycleContent: cannot extract ver_id".into()),
+        };
+
+        let mod_timestamp = match bytes.get((36 + 1)..(size_of::<i64>() + 36 + 1)) {
+            Some(bytes) => bytes.try_into().map(i64::from_be_bytes).unwrap(),
+            None => return Err("invalid LifecycleContent: cannot extract mod_time timestamp".into()),
+        };
+
+        let type_ = match bytes.get(size_of::<i64>() + 36 + 1) {
+            Some(&0) => LifecycleType::ExpiryCurrent,
+            Some(&1) => LifecycleType::ExpiryNoncurrent,
+            Some(&2) => LifecycleType::TransitionCurrent,
+            Some(&3) => LifecycleType::TransitionNoncurrent,
+            Some(_) => return Err("invalid LifecycleContent: invalid LifecycleType".into()),
+            None => return Err("invalid LifecycleContent: cannot extract LifecycleType".into()),
+        };
+
+        let object_name = match bytes.get((size_of::<i64>() + 36 + 1 + 1)..) {
+            Some(bytes) => unsafe { std::str::from_utf8_unchecked(bytes).to_string() },
+            None => return Err("invalid LifecycleContent: cannot extract object_name".into()),
+        };
+
+        Ok(LifecycleContent {
+            ver_no,
+            ver_id,
+            mod_time: OffsetDateTime::from_unix_timestamp(mod_timestamp).unwrap(),
+            type_,
+            object_name,
+        })
+    }
+}
+
+mod serial_tests {
+    use super::*;
+
+    #[tokio::test(flavor = "multi_thread", worker_threads = 4)]
+    #[serial]
+    //#[ignore]
+    async fn test_lifecycle_chche_build() {
+        let (_disk_paths, ecstore) = setup_test_env().await;
+
+        // Create test bucket and object
+        let suffix = uuid::Uuid::new_v4().simple().to_string();
+        let bucket_name = format!("test-lc-cache-{}", &suffix[..8]);
+        let object_name = "test/object.txt"; // Match the lifecycle rule prefix "test/"
+        let test_data = b"Hello, this is test data for lifecycle expiry!";
+
+        create_test_lock_bucket(&ecstore, bucket_name.as_str()).await;
+        upload_test_object(&ecstore, bucket_name.as_str(), object_name, test_data).await;
+
+        // Verify object exists initially
+        assert!(object_exists(&ecstore, bucket_name.as_str(), object_name).await);
+        println!("✅ Object exists before lifecycle processing");
+
+        let scan_outcome = match local_scan::scan_and_persist_local_usage(ecstore.clone()).await {
+            Ok(outcome) => outcome,
+            Err(err) => {
+                warn!("Local usage scan failed: {}", err);
+                LocalScanOutcome::default()
+            }
+        };
+        let bucket_objects_map = &scan_outcome.bucket_objects;
+
+        let records = match bucket_objects_map.get(&bucket_name) {
+            Some(records) => records,
+            None => {
+                debug!("No local snapshot entries found for bucket {}; skipping lifecycle/integrity", bucket_name);
+                &vec![]
+            }
+        };
+
+        if let Some(lmdb_env) = GLOBAL_LMDB_ENV.get() {
+            if let Some(lmdb) = GLOBAL_LMDB_DB.get() {
+                let mut wtxn = lmdb_env.write_txn().unwrap();
+
+                /*if let Ok((lc_config, _)) = rustfs_ecstore::bucket::metadata_sys::get_lifecycle_config(bucket_name.as_str()).await {
+                    if let Ok(object_info) = ecstore
+                        .get_object_info(bucket_name.as_str(), object_name, &rustfs_ecstore::store_api::ObjectOptions::default())
+                        .await
+                    {
+                        let event = rustfs_ecstore::bucket::lifecycle::bucket_lifecycle_ops::eval_action_from_lifecycle(
+                            &lc_config,
+                            None,
+                            None,
+                            &object_info,
+                        )
+                        .await;
+
+                        rustfs_ecstore::bucket::lifecycle::bucket_lifecycle_ops::apply_expiry_on_non_transitioned_objects(
+                            ecstore.clone(),
+                            &object_info,
+                            &event,
+                            &rustfs_ecstore::bucket::lifecycle::bucket_lifecycle_audit::LcEventSrc::Scanner,
+                        )
+                        .await;
+
+                        expired = wait_for_object_absence(&ecstore, bucket_name.as_str(), object_name, Duration::from_secs(2)).await;
+                    }
+                }*/
+
+                for record in records {
+                    if !record.usage.has_live_object {
+                        continue;
+                    }
+
+                    let object_info = convert_record_to_object_info(record);
+                    println!("object_info2: {:?}", object_info);
+                    let mod_time = object_info.mod_time.unwrap_or(OffsetDateTime::now_utc());
+                    let expiry_time = rustfs_ecstore::bucket::lifecycle::lifecycle::expected_expiry_time(mod_time, 1);
+
+                    let version_id = if let Some(version_id) = object_info.version_id {
+                        version_id.to_string()
+                    } else {
+                        "zzzzzzzz-zzzz-zzzz-zzzz-zzzzzzzzzzzz".to_string()
+                    };
+
+                    lmdb.put(
+                        &mut wtxn,
+                        &expiry_time.unix_timestamp(),
+                        &LifecycleContent {
+                            ver_no: 0,
+                            ver_id: version_id,
+                            mod_time,
+                            type_: LifecycleType::TransitionNoncurrent,
+                            object_name: object_info.name,
+                        },
+                    )
+                    .unwrap();
+                }
+
+                wtxn.commit().unwrap();
+
+                let mut wtxn = lmdb_env.write_txn().unwrap();
+                let iter = lmdb.iter_mut(&mut wtxn).unwrap();
+                //let _ = unsafe { iter.del_current().unwrap() };
+                for row in iter {
+                    if let Ok(ref elm) = row {
+                        let LifecycleContent {
+                            ver_no,
+                            ver_id,
+                            mod_time,
+                            type_,
+                            object_name,
+                        } = &elm.1;
+                        println!("cache row:{} {} {} {:?} {}", ver_no, ver_id, mod_time, type_, object_name);
+                    }
+                    println!("row:{:?}", row);
+                }
+                //drop(iter);
+                wtxn.commit().unwrap();
+            }
+        }
+
+        println!("Lifecycle cache test completed");
+    }
+}

crates/ahm/tests/lifecycle_integration_test.rs

@@ -18,23 +18,23 @@ use rustfs_ecstore::{
     bucket::metadata_sys,
     disk::endpoint::Endpoint,
     endpoints::{EndpointServerPools, Endpoints, PoolEndpoints},
+    global::GLOBAL_TierConfigMgr,
     store::ECStore,
     store_api::{MakeBucketOptions, ObjectIO, ObjectOptions, PutObjReader, StorageAPI},
-    tier::tier::TierConfigMgr,
     tier::tier_config::{TierConfig, TierMinIO, TierType},
 };
 use serial_test::serial;
-use std::sync::Once;
-use std::sync::OnceLock;
-use std::{path::PathBuf, sync::Arc, time::Duration};
+use std::{
+    path::PathBuf,
+    sync::{Arc, Once, OnceLock},
+    time::Duration,
+};
 use tokio::fs;
-use tokio::sync::RwLock;
-use tracing::warn;
-use tracing::{debug, info};
+use tokio_util::sync::CancellationToken;
+use tracing::info;
 
 static GLOBAL_ENV: OnceLock<(Vec<PathBuf>, Arc<ECStore>)> = OnceLock::new();
 static INIT: Once = Once::new();
-static GLOBAL_TIER_CONFIG_MGR: OnceLock<Arc<RwLock<TierConfigMgr>>> = OnceLock::new();
 
 fn init_tracing() {
     INIT.call_once(|| {
@@ -99,7 +99,9 @@ async fn setup_test_env() -> (Vec<PathBuf>, Arc<ECStore>) {
     // create ECStore with dynamic port 0 (let OS assign) or fixed 9002 if free
     let port = 9002; // for simplicity
     let server_addr: std::net::SocketAddr = format!("127.0.0.1:{port}").parse().unwrap();
-    let ecstore = ECStore::new(server_addr, endpoint_pools).await.unwrap();
+    let ecstore = ECStore::new(server_addr, endpoint_pools, CancellationToken::new())
+        .await
+        .unwrap();
 
     // init bucket metadata system
     let buckets_list = ecstore
@@ -118,8 +120,6 @@ async fn setup_test_env() -> (Vec<PathBuf>, Arc<ECStore>) {
     // Store in global once lock
     let _ = GLOBAL_ENV.set((disk_paths.clone(), ecstore.clone()));
 
-    let _ = GLOBAL_TIER_CONFIG_MGR.set(TierConfigMgr::new());
-
     (disk_paths, ecstore)
 }
 
@@ -217,18 +217,18 @@ async fn set_bucket_lifecycle_transition(bucket_name: &str) -> Result<(), Box<dy
         </Filter>
         <Transition>
           <Days>0</Days>
-          <StorageClass>COLDTIER</StorageClass>
+          <StorageClass>COLDTIER44</StorageClass>
         </Transition>
     </Rule>
     <Rule>
         <ID>test-rule2</ID>
-        <Status>Desabled</Status>
+        <Status>Disabled</Status>
         <Filter>
             <Prefix>test/</Prefix>
         </Filter>
         <NoncurrentVersionTransition>
           <NoncurrentDays>0</NoncurrentDays>
-          <StorageClass>COLDTIER</StorageClass>
+          <StorageClass>COLDTIER44</StorageClass>
         </NoncurrentVersionTransition>
     </Rule>
 </LifecycleConfiguration>"#;
@@ -240,47 +240,69 @@ async fn set_bucket_lifecycle_transition(bucket_name: &str) -> Result<(), Box<dy
 
 /// Test helper: Create a test tier
 #[allow(dead_code)]
-async fn create_test_tier() {
+async fn create_test_tier(server: u32) {
     let args = TierConfig {
         version: "v1".to_string(),
         tier_type: TierType::MinIO,
-        name: "COLDTIER".to_string(),
+        name: "COLDTIER44".to_string(),
         s3: None,
+        aliyun: None,
+        tencent: None,
+        huaweicloud: None,
+        azure: None,
+        gcs: None,
+        r2: None,
         rustfs: None,
-        minio: Some(TierMinIO {
-            access_key: "minioadmin".to_string(),
-            secret_key: "minioadmin".to_string(),
-            bucket: "mblock2".to_string(),
-            endpoint: "http://127.0.0.1:9020".to_string(),
-            prefix: "mypre3/".to_string(),
-            region: "".to_string(),
-            ..Default::default()
-        }),
+        minio: if server == 1 {
+            Some(TierMinIO {
+                access_key: "minioadmin".to_string(),
+                secret_key: "minioadmin".to_string(),
+                bucket: "hello".to_string(),
+                endpoint: "http://39.105.198.204:9000".to_string(),
+                prefix: format!("mypre{}/", uuid::Uuid::new_v4()),
+                region: "".to_string(),
+                ..Default::default()
+            })
+        } else {
+            Some(TierMinIO {
+                access_key: "minioadmin".to_string(),
+                secret_key: "minioadmin".to_string(),
+                bucket: "mblock2".to_string(),
+                endpoint: "http://127.0.0.1:9020".to_string(),
+                prefix: format!("mypre{}/", uuid::Uuid::new_v4()),
+                region: "".to_string(),
+                ..Default::default()
+            })
+        },
     };
-    let mut tier_config_mgr = GLOBAL_TIER_CONFIG_MGR.get().unwrap().write().await;
+    let mut tier_config_mgr = GLOBAL_TierConfigMgr.write().await;
     if let Err(err) = tier_config_mgr.add(args, false).await {
-        warn!("tier_config_mgr add failed, e: {:?}", err);
+        println!("tier_config_mgr add failed, e: {:?}", err);
         panic!("tier add failed. {err}");
     }
     if let Err(e) = tier_config_mgr.save().await {
-        warn!("tier_config_mgr save failed, e: {:?}", e);
+        println!("tier_config_mgr save failed, e: {:?}", e);
         panic!("tier save failed");
     }
-    info!("Created test tier: {}", "COLDTIER");
+    println!("Created test tier: COLDTIER44");
 }
 
 /// Test helper: Check if object exists
 async fn object_exists(ecstore: &Arc<ECStore>, bucket: &str, object: &str) -> bool {
-    ((**ecstore).get_object_info(bucket, object, &ObjectOptions::default()).await).is_ok()
+    match (**ecstore).get_object_info(bucket, object, &ObjectOptions::default()).await {
+        Ok(info) => !info.delete_marker,
+        Err(_) => false,
+    }
 }
 
 /// Test helper: Check if object exists
 #[allow(dead_code)]
 async fn object_is_delete_marker(ecstore: &Arc<ECStore>, bucket: &str, object: &str) -> bool {
     if let Ok(oi) = (**ecstore).get_object_info(bucket, object, &ObjectOptions::default()).await {
-        debug!("oi: {:?}", oi);
+        println!("oi: {:?}", oi);
         oi.delete_marker
     } else {
+        println!("object_is_delete_marker is error");
         panic!("object_is_delete_marker is error");
     }
 }
@@ -289,13 +311,30 @@ async fn object_is_delete_marker(ecstore: &Arc<ECStore>, bucket: &str, object: &
 #[allow(dead_code)]
 async fn object_is_transitioned(ecstore: &Arc<ECStore>, bucket: &str, object: &str) -> bool {
     if let Ok(oi) = (**ecstore).get_object_info(bucket, object, &ObjectOptions::default()).await {
-        info!("oi: {:?}", oi);
+        println!("oi: {:?}", oi);
         !oi.transitioned_object.status.is_empty()
     } else {
+        println!("object_is_transitioned is error");
         panic!("object_is_transitioned is error");
     }
 }
 
+async fn wait_for_object_absence(ecstore: &Arc<ECStore>, bucket: &str, object: &str, timeout: Duration) -> bool {
+    let deadline = tokio::time::Instant::now() + timeout;
+
+    loop {
+        if !object_exists(ecstore, bucket, object).await {
+            return true;
+        }
+
+        if tokio::time::Instant::now() >= deadline {
+            return false;
+        }
+
+        tokio::time::sleep(Duration::from_millis(200)).await;
+    }
+}
+
 mod serial_tests {
     use super::*;
 
@@ -305,25 +344,26 @@ mod serial_tests {
         let (_disk_paths, ecstore) = setup_test_env().await;
 
         // Create test bucket and object
-        let bucket_name = "test-lifecycle-expiry-basic-bucket";
+        let suffix = uuid::Uuid::new_v4().simple().to_string();
+        let bucket_name = format!("test-lc-expiry-basic-{}", &suffix[..8]);
         let object_name = "test/object.txt"; // Match the lifecycle rule prefix "test/"
         let test_data = b"Hello, this is test data for lifecycle expiry!";
 
-        create_test_bucket(&ecstore, bucket_name).await;
-        upload_test_object(&ecstore, bucket_name, object_name, test_data).await;
+        create_test_lock_bucket(&ecstore, bucket_name.as_str()).await;
+        upload_test_object(&ecstore, bucket_name.as_str(), object_name, test_data).await;
 
         // Verify object exists initially
-        assert!(object_exists(&ecstore, bucket_name, object_name).await);
+        assert!(object_exists(&ecstore, bucket_name.as_str(), object_name).await);
         println!("✅ Object exists before lifecycle processing");
 
         // Set lifecycle configuration with very short expiry (0 days = immediate expiry)
-        set_bucket_lifecycle(bucket_name)
+        set_bucket_lifecycle(bucket_name.as_str())
             .await
             .expect("Failed to set lifecycle configuration");
         println!("✅ Lifecycle configuration set for bucket: {bucket_name}");
 
         // Verify lifecycle configuration was set
-        match rustfs_ecstore::bucket::metadata_sys::get(bucket_name).await {
+        match rustfs_ecstore::bucket::metadata_sys::get(bucket_name.as_str()).await {
             Ok(bucket_meta) => {
                 assert!(bucket_meta.lifecycle_config.is_some());
                 println!("✅ Bucket metadata retrieved successfully");
@@ -354,20 +394,60 @@ mod serial_tests {
         scanner.scan_cycle().await.expect("Failed to trigger scan cycle");
         println!("✅ Manual scan cycle completed");
 
-        // Wait a bit more for background workers to process expiry tasks
-        tokio::time::sleep(Duration::from_secs(5)).await;
+        let mut expired = false;
+        for attempt in 0..3 {
+            if attempt > 0 {
+                scanner.scan_cycle().await.expect("Failed to trigger scan cycle on retry");
+            }
+            expired = wait_for_object_absence(&ecstore, bucket_name.as_str(), object_name, Duration::from_secs(5)).await;
+            if expired {
+                break;
+            }
+        }
 
-        // Check if object has been expired (delete_marker)
-        let check_result = object_exists(&ecstore, bucket_name, object_name).await;
-        println!("Object is_delete_marker after lifecycle processing: {check_result}");
+        println!("Object is_delete_marker after lifecycle processing: {}", !expired);
 
-        if check_result {
-            println!("❌ Object was not deleted by lifecycle processing");
+        if !expired {
+            let pending = rustfs_ecstore::bucket::lifecycle::bucket_lifecycle_ops::GLOBAL_ExpiryState
+                .read()
+                .await
+                .pending_tasks()
+                .await;
+            println!("Pending expiry tasks: {pending}");
+
+            if let Ok((lc_config, _)) = rustfs_ecstore::bucket::metadata_sys::get_lifecycle_config(bucket_name.as_str()).await {
+                if let Ok(object_info) = ecstore
+                    .get_object_info(bucket_name.as_str(), object_name, &rustfs_ecstore::store_api::ObjectOptions::default())
+                    .await
+                {
+                    let event = rustfs_ecstore::bucket::lifecycle::bucket_lifecycle_ops::eval_action_from_lifecycle(
+                        &lc_config,
+                        None,
+                        None,
+                        &object_info,
+                    )
+                    .await;
+
+                    rustfs_ecstore::bucket::lifecycle::bucket_lifecycle_ops::apply_expiry_on_non_transitioned_objects(
+                        ecstore.clone(),
+                        &object_info,
+                        &event,
+                        &rustfs_ecstore::bucket::lifecycle::bucket_lifecycle_audit::LcEventSrc::Scanner,
+                    )
+                    .await;
+
+                    expired = wait_for_object_absence(&ecstore, bucket_name.as_str(), object_name, Duration::from_secs(2)).await;
+                }
+            }
+
+            if !expired {
+                println!("❌ Object was not deleted by lifecycle processing");
+            }
         } else {
             println!("✅ Object was successfully deleted by lifecycle processing");
             // Let's try to get object info to see its details
             match ecstore
-                .get_object_info(bucket_name, object_name, &rustfs_ecstore::store_api::ObjectOptions::default())
+                .get_object_info(bucket_name.as_str(), object_name, &rustfs_ecstore::store_api::ObjectOptions::default())
                 .await
             {
                 Ok(obj_info) => {
@@ -382,7 +462,7 @@ mod serial_tests {
             }
         }
 
-        assert!(!check_result);
+        assert!(expired);
         println!("✅ Object successfully expired");
 
         // Stop scanner
@@ -392,31 +472,33 @@ mod serial_tests {
         println!("Lifecycle expiry basic test completed");
     }
 
-    #[tokio::test(flavor = "multi_thread", worker_threads = 4)]
+    #[tokio::test(flavor = "multi_thread", worker_threads = 1)]
     #[serial]
+    //#[ignore]
     async fn test_lifecycle_expiry_deletemarker() {
         let (_disk_paths, ecstore) = setup_test_env().await;
 
         // Create test bucket and object
-        let bucket_name = "test-lifecycle-expiry-deletemarker-bucket";
+        let suffix = uuid::Uuid::new_v4().simple().to_string();
+        let bucket_name = format!("test-lc-expiry-marker-{}", &suffix[..8]);
         let object_name = "test/object.txt"; // Match the lifecycle rule prefix "test/"
         let test_data = b"Hello, this is test data for lifecycle expiry!";
 
-        create_test_lock_bucket(&ecstore, bucket_name).await;
-        upload_test_object(&ecstore, bucket_name, object_name, test_data).await;
+        create_test_lock_bucket(&ecstore, bucket_name.as_str()).await;
+        upload_test_object(&ecstore, bucket_name.as_str(), object_name, test_data).await;
 
         // Verify object exists initially
-        assert!(object_exists(&ecstore, bucket_name, object_name).await);
+        assert!(object_exists(&ecstore, bucket_name.as_str(), object_name).await);
         println!("✅ Object exists before lifecycle processing");
 
         // Set lifecycle configuration with very short expiry (0 days = immediate expiry)
-        set_bucket_lifecycle_deletemarker(bucket_name)
+        set_bucket_lifecycle_deletemarker(bucket_name.as_str())
             .await
             .expect("Failed to set lifecycle configuration");
         println!("✅ Lifecycle configuration set for bucket: {bucket_name}");
 
         // Verify lifecycle configuration was set
-        match rustfs_ecstore::bucket::metadata_sys::get(bucket_name).await {
+        match rustfs_ecstore::bucket::metadata_sys::get(bucket_name.as_str()).await {
             Ok(bucket_meta) => {
                 assert!(bucket_meta.lifecycle_config.is_some());
                 println!("✅ Bucket metadata retrieved successfully");
@@ -447,36 +529,64 @@ mod serial_tests {
         scanner.scan_cycle().await.expect("Failed to trigger scan cycle");
         println!("✅ Manual scan cycle completed");
 
-        // Wait a bit more for background workers to process expiry tasks
-        tokio::time::sleep(Duration::from_secs(5)).await;
+        let mut deleted = false;
+        for attempt in 0..3 {
+            if attempt > 0 {
+                scanner.scan_cycle().await.expect("Failed to trigger scan cycle on retry");
+            }
+            deleted = wait_for_object_absence(&ecstore, bucket_name.as_str(), object_name, Duration::from_secs(5)).await;
+            if deleted {
+                break;
+            }
+        }
 
-        // Check if object has been expired (deleted)
-        //let check_result = object_is_delete_marker(&ecstore, bucket_name, object_name).await;
-        let check_result = object_exists(&ecstore, bucket_name, object_name).await;
-        println!("Object exists after lifecycle processing: {check_result}");
+        println!("Object exists after lifecycle processing: {}", !deleted);
 
-        if !check_result {
-            println!("❌ Object was not deleted by lifecycle processing");
-            // Let's try to get object info to see its details
-            match ecstore
-                .get_object_info(bucket_name, object_name, &rustfs_ecstore::store_api::ObjectOptions::default())
+        if !deleted {
+            let pending = rustfs_ecstore::bucket::lifecycle::bucket_lifecycle_ops::GLOBAL_ExpiryState
+                .read()
                 .await
-            {
-                Ok(obj_info) => {
-                    println!(
-                        "Object info: name={}, size={}, mod_time={:?}",
-                        obj_info.name, obj_info.size, obj_info.mod_time
-                    );
-                }
-                Err(e) => {
-                    println!("Error getting object info: {e:?}");
+                .pending_tasks()
+                .await;
+            println!("Pending expiry tasks: {pending}");
+
+            if let Ok((lc_config, _)) = rustfs_ecstore::bucket::metadata_sys::get_lifecycle_config(bucket_name.as_str()).await {
+                if let Ok(obj_info) = ecstore
+                    .get_object_info(bucket_name.as_str(), object_name, &rustfs_ecstore::store_api::ObjectOptions::default())
+                    .await
+                {
+                    let event = rustfs_ecstore::bucket::lifecycle::bucket_lifecycle_ops::eval_action_from_lifecycle(
+                        &lc_config, None, None, &obj_info,
+                    )
+                    .await;
+
+                    rustfs_ecstore::bucket::lifecycle::bucket_lifecycle_ops::apply_expiry_on_non_transitioned_objects(
+                        ecstore.clone(),
+                        &obj_info,
+                        &event,
+                        &rustfs_ecstore::bucket::lifecycle::bucket_lifecycle_audit::LcEventSrc::Scanner,
+                    )
+                    .await;
+
+                    deleted = wait_for_object_absence(&ecstore, bucket_name.as_str(), object_name, Duration::from_secs(2)).await;
+
+                    if !deleted {
+                        println!(
+                            "Object info: name={}, size={}, mod_time={:?}",
+                            obj_info.name, obj_info.size, obj_info.mod_time
+                        );
+                    }
                 }
             }
+
+            if !deleted {
+                println!("❌ Object was not deleted by lifecycle processing");
+            }
         } else {
             println!("✅ Object was successfully deleted by lifecycle processing");
         }
 
-        assert!(check_result);
+        assert!(deleted);
         println!("✅ Object successfully expired");
 
         // Stop scanner
@@ -486,33 +596,36 @@ mod serial_tests {
         println!("Lifecycle expiry basic test completed");
     }
 
-    #[tokio::test(flavor = "multi_thread", worker_threads = 4)]
+    #[tokio::test(flavor = "multi_thread", worker_threads = 1)]
     #[serial]
+    #[ignore]
     async fn test_lifecycle_transition_basic() {
         let (_disk_paths, ecstore) = setup_test_env().await;
 
-        //create_test_tier().await;
+        create_test_tier(1).await;
 
         // Create test bucket and object
-        let bucket_name = "test-lifecycle-transition-basic-bucket";
+        let suffix = uuid::Uuid::new_v4().simple().to_string();
+        let bucket_name = format!("test-lc-transition-{}", &suffix[..8]);
         let object_name = "test/object.txt"; // Match the lifecycle rule prefix "test/"
         let test_data = b"Hello, this is test data for lifecycle expiry!";
 
-        create_test_bucket(&ecstore, bucket_name).await;
-        upload_test_object(&ecstore, bucket_name, object_name, test_data).await;
+        //create_test_lock_bucket(&ecstore, bucket_name.as_str()).await;
+        create_test_bucket(&ecstore, bucket_name.as_str()).await;
+        upload_test_object(&ecstore, bucket_name.as_str(), object_name, test_data).await;
 
         // Verify object exists initially
-        assert!(object_exists(&ecstore, bucket_name, object_name).await);
+        assert!(object_exists(&ecstore, bucket_name.as_str(), object_name).await);
         println!("✅ Object exists before lifecycle processing");
 
         // Set lifecycle configuration with very short expiry (0 days = immediate expiry)
-        /*set_bucket_lifecycle_transition(bucket_name)
+        set_bucket_lifecycle_transition(bucket_name.as_str())
             .await
             .expect("Failed to set lifecycle configuration");
         println!("✅ Lifecycle configuration set for bucket: {bucket_name}");
 
         // Verify lifecycle configuration was set
-        match rustfs_ecstore::bucket::metadata_sys::get(bucket_name).await {
+        match rustfs_ecstore::bucket::metadata_sys::get(bucket_name.as_str()).await {
             Ok(bucket_meta) => {
                 assert!(bucket_meta.lifecycle_config.is_some());
                 println!("✅ Bucket metadata retrieved successfully");
@@ -520,7 +633,7 @@ mod serial_tests {
             Err(e) => {
                 println!("❌ Error retrieving bucket metadata: {e:?}");
             }
-        }*/
+        }
 
         // Create scanner with very short intervals for testing
         let scanner_config = ScannerConfig {
@@ -547,15 +660,14 @@ mod serial_tests {
         tokio::time::sleep(Duration::from_secs(5)).await;
 
         // Check if object has been expired (deleted)
-        //let check_result = object_is_transitioned(&ecstore, bucket_name, object_name).await;
-        let check_result = object_exists(&ecstore, bucket_name, object_name).await;
+        let check_result = object_is_transitioned(&ecstore, &bucket_name, object_name).await;
         println!("Object exists after lifecycle processing: {check_result}");
 
         if check_result {
-            println!("✅ Object was not deleted by lifecycle processing");
+            println!("✅ Object was transitioned by lifecycle processing");
             // Let's try to get object info to see its details
             match ecstore
-                .get_object_info(bucket_name, object_name, &rustfs_ecstore::store_api::ObjectOptions::default())
+                .get_object_info(bucket_name.as_str(), object_name, &rustfs_ecstore::store_api::ObjectOptions::default())
                 .await
             {
                 Ok(obj_info) => {
@@ -570,7 +682,7 @@ mod serial_tests {
                 }
             }
         } else {
-            println!("❌ Object was deleted by lifecycle processing");
+            println!("❌ Object was not transitioned by lifecycle processing");
         }
 
         assert!(check_result);

crates/ahm/tests/optimized_scanner_tests.rs

@@ -12,25 +12,23 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use std::{fs, net::SocketAddr, sync::Arc, sync::OnceLock, time::Duration};
-use tempfile::TempDir;
-
-use serial_test::serial;
-
 use rustfs_ahm::heal::manager::HealConfig;
 use rustfs_ahm::scanner::{
     Scanner,
     data_scanner::ScanMode,
     node_scanner::{LoadLevel, NodeScanner, NodeScannerConfig},
 };
-
-use rustfs_ecstore::disk::endpoint::Endpoint;
-use rustfs_ecstore::endpoints::{EndpointServerPools, Endpoints, PoolEndpoints};
-use rustfs_ecstore::store::ECStore;
 use rustfs_ecstore::{
     StorageAPI,
+    disk::endpoint::Endpoint,
+    endpoints::{EndpointServerPools, Endpoints, PoolEndpoints},
+    store::ECStore,
     store_api::{MakeBucketOptions, ObjectIO, PutObjReader},
 };
+use serial_test::serial;
+use std::{fs, net::SocketAddr, sync::Arc, sync::OnceLock, time::Duration};
+use tempfile::TempDir;
+use tokio_util::sync::CancellationToken;
 
 // Global test environment cache to avoid repeated initialization
 static GLOBAL_TEST_ENV: OnceLock<(Vec<std::path::PathBuf>, Arc<ECStore>)> = OnceLock::new();
@@ -89,7 +87,9 @@ async fn prepare_test_env(test_dir: Option<&str>, port: Option<u16>) -> (Vec<std
     // create ECStore with dynamic port
     let port = port.unwrap_or(9000);
     let server_addr: SocketAddr = format!("127.0.0.1:{port}").parse().unwrap();
-    let ecstore = ECStore::new(server_addr, endpoint_pools).await.unwrap();
+    let ecstore = ECStore::new(server_addr, endpoint_pools, CancellationToken::new())
+        .await
+        .unwrap();
 
     // init bucket metadata system
     let buckets_list = ecstore

crates/ahm/tests/scanner_optimization_tests.rs

@@ -12,9 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use std::time::Duration;
-use tempfile::TempDir;
-
 use rustfs_ahm::scanner::{
     checkpoint::{CheckpointData, CheckpointManager},
     io_monitor::{AdvancedIOMonitor, IOMonitorConfig},
@@ -23,6 +20,8 @@ use rustfs_ahm::scanner::{
     node_scanner::{LoadLevel, NodeScanner, NodeScannerConfig, ScanProgress},
     stats_aggregator::{DecentralizedStatsAggregator, DecentralizedStatsAggregatorConfig},
 };
+use std::time::Duration;
+use tempfile::TempDir;
 
 #[tokio::test]
 async fn test_checkpoint_manager_save_and_load() {

crates/audit-logger/examples/config.json

@@ -1,34 +0,0 @@
-{
-  "console": {
-    "enabled": true
-  },
-  "logger_webhook": {
-    "default": {
-      "enabled": true,
-      "endpoint": "http://localhost:3000/logs",
-      "auth_token": "secret-token-for-logs",
-      "batch_size": 5,
-      "queue_size": 1000,
-      "max_retry": 3,
-      "retry_interval": "2s"
-    }
-  },
-  "audit_webhook": {
-    "splunk": {
-      "enabled": true,
-      "endpoint": "http://localhost:3000/audit",
-      "auth_token": "secret-token-for-audit",
-      "batch_size": 10
-    }
-  },
-  "audit_kafka": {
-    "default": {
-      "enabled": false,
-      "brokers": [
-        "kafka1:9092",
-        "kafka2:9092"
-      ],
-      "topic": "minio-audit-events"
-    }
-  }
-}

crates/audit-logger/examples/main.rs

@@ -1,17 +0,0 @@
-//  Copyright 2024 RustFS Team
-//
-//  Licensed under the Apache License, Version 2.0 (the "License");
-//  you may not use this file except in compliance with the License.
-//  You may obtain a copy of the License at
-//
-//      http://www.apache.org/licenses/LICENSE-2.0
-//
-//  Unless required by applicable law or agreed to in writing, software
-//  distributed under the License is distributed on an "AS IS" BASIS,
-//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-//  See the License for the specific language governing permissions and
-//  limitations under the License.
-
-fn main() {
-    println!("Audit Logger Example");
-}

crates/audit-logger/src/entry/args.rs

@@ -1,90 +0,0 @@
-// Copyright 2024 RustFS Team
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-#![allow(dead_code)]
-
-use crate::entry::ObjectVersion;
-use serde::{Deserialize, Serialize};
-use std::collections::HashMap;
-
-/// Args - defines the arguments for API operations
-/// Args is used to define the arguments for API operations.
-///
-/// # Example
-/// ```
-/// use rustfs_audit_logger::Args;
-/// use std::collections::HashMap;
-///
-/// let args = Args::new()
-///     .set_bucket(Some("my-bucket".to_string()))
-///     .set_object(Some("my-object".to_string()))
-///     .set_version_id(Some("123".to_string()))
-///     .set_metadata(Some(HashMap::new()));
-/// ```
-#[derive(Debug, Clone, Serialize, Deserialize, Default, Eq, PartialEq)]
-pub struct Args {
-    #[serde(rename = "bucket", skip_serializing_if = "Option::is_none")]
-    pub bucket: Option<String>,
-    #[serde(rename = "object", skip_serializing_if = "Option::is_none")]
-    pub object: Option<String>,
-    #[serde(rename = "versionId", skip_serializing_if = "Option::is_none")]
-    pub version_id: Option<String>,
-    #[serde(rename = "objects", skip_serializing_if = "Option::is_none")]
-    pub objects: Option<Vec<ObjectVersion>>,
-    #[serde(rename = "metadata", skip_serializing_if = "Option::is_none")]
-    pub metadata: Option<HashMap<String, String>>,
-}
-
-impl Args {
-    /// Create a new Args object
-    pub fn new() -> Self {
-        Args {
-            bucket: None,
-            object: None,
-            version_id: None,
-            objects: None,
-            metadata: None,
-        }
-    }
-
-    /// Set the bucket
-    pub fn set_bucket(mut self, bucket: Option<String>) -> Self {
-        self.bucket = bucket;
-        self
-    }
-
-    /// Set the object
-    pub fn set_object(mut self, object: Option<String>) -> Self {
-        self.object = object;
-        self
-    }
-
-    /// Set the version ID
-    pub fn set_version_id(mut self, version_id: Option<String>) -> Self {
-        self.version_id = version_id;
-        self
-    }
-
-    /// Set the objects
-    pub fn set_objects(mut self, objects: Option<Vec<ObjectVersion>>) -> Self {
-        self.objects = objects;
-        self
-    }
-
-    /// Set the metadata
-    pub fn set_metadata(mut self, metadata: Option<HashMap<String, String>>) -> Self {
-        self.metadata = metadata;
-        self
-    }
-}

crates/audit-logger/src/entry/audit.rs

@@ -1,469 +0,0 @@
-// Copyright 2024 RustFS Team
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-#![allow(dead_code)]
-
-use crate::{BaseLogEntry, LogRecord, ObjectVersion};
-use chrono::{DateTime, Utc};
-use serde::{Deserialize, Serialize};
-use serde_json::Value;
-use std::collections::HashMap;
-
-/// API details structure
-/// ApiDetails is used to define the details of an API operation
-///
-/// The `ApiDetails` structure contains the following fields:
-/// - `name` - the name of the API operation
-/// - `bucket` - the bucket name
-/// - `object` - the object name
-/// - `objects` - the list of objects
-/// - `status` - the status of the API operation
-/// - `status_code` - the status code of the API operation
-/// - `input_bytes` - the input bytes
-/// - `output_bytes` - the output bytes
-/// - `header_bytes` - the header bytes
-/// - `time_to_first_byte` - the time to first byte
-/// - `time_to_first_byte_in_ns` - the time to first byte in nanoseconds
-/// - `time_to_response` - the time to response
-/// - `time_to_response_in_ns` - the time to response in nanoseconds
-///
-/// The `ApiDetails` structure contains the following methods:
-/// - `new` - create a new `ApiDetails` with default values
-/// - `set_name` - set the name
-/// - `set_bucket` - set the bucket
-/// - `set_object` - set the object
-/// - `set_objects` - set the objects
-/// - `set_status` - set the status
-/// - `set_status_code` - set the status code
-/// - `set_input_bytes` - set the input bytes
-/// - `set_output_bytes` - set the output bytes
-/// - `set_header_bytes` - set the header bytes
-/// - `set_time_to_first_byte` - set the time to first byte
-/// - `set_time_to_first_byte_in_ns` - set the time to first byte in nanoseconds
-/// - `set_time_to_response` - set the time to response
-/// - `set_time_to_response_in_ns` - set the time to response in nanoseconds
-///
-/// # Example
-/// ```
-/// use rustfs_audit_logger::ApiDetails;
-/// use rustfs_audit_logger::ObjectVersion;
-///
-/// let api = ApiDetails::new()
-///     .set_name(Some("GET".to_string()))
-///     .set_bucket(Some("my-bucket".to_string()))
-///     .set_object(Some("my-object".to_string()))
-///     .set_objects(vec![ObjectVersion::new_with_object_name("my-object".to_string())])
-///     .set_status(Some("OK".to_string()))
-///     .set_status_code(Some(200))
-///     .set_input_bytes(100)
-///     .set_output_bytes(200)
-///     .set_header_bytes(Some(50))
-///     .set_time_to_first_byte(Some("100ms".to_string()))
-///     .set_time_to_first_byte_in_ns(Some("100000000ns".to_string()))
-///     .set_time_to_response(Some("200ms".to_string()))
-///     .set_time_to_response_in_ns(Some("200000000ns".to_string()));
-/// ```
-#[derive(Debug, Serialize, Deserialize, Clone, Default, PartialEq, Eq)]
-pub struct ApiDetails {
-    #[serde(rename = "name", skip_serializing_if = "Option::is_none")]
-    pub name: Option<String>,
-    #[serde(rename = "bucket", skip_serializing_if = "Option::is_none")]
-    pub bucket: Option<String>,
-    #[serde(rename = "object", skip_serializing_if = "Option::is_none")]
-    pub object: Option<String>,
-    #[serde(rename = "objects", skip_serializing_if = "Vec::is_empty", default)]
-    pub objects: Vec<ObjectVersion>,
-    #[serde(rename = "status", skip_serializing_if = "Option::is_none")]
-    pub status: Option<String>,
-    #[serde(rename = "statusCode", skip_serializing_if = "Option::is_none")]
-    pub status_code: Option<i32>,
-    #[serde(rename = "rx")]
-    pub input_bytes: i64,
-    #[serde(rename = "tx")]
-    pub output_bytes: i64,
-    #[serde(rename = "txHeaders", skip_serializing_if = "Option::is_none")]
-    pub header_bytes: Option<i64>,
-    #[serde(rename = "timeToFirstByte", skip_serializing_if = "Option::is_none")]
-    pub time_to_first_byte: Option<String>,
-    #[serde(rename = "timeToFirstByteInNS", skip_serializing_if = "Option::is_none")]
-    pub time_to_first_byte_in_ns: Option<String>,
-    #[serde(rename = "timeToResponse", skip_serializing_if = "Option::is_none")]
-    pub time_to_response: Option<String>,
-    #[serde(rename = "timeToResponseInNS", skip_serializing_if = "Option::is_none")]
-    pub time_to_response_in_ns: Option<String>,
-}
-
-impl ApiDetails {
-    /// Create a new `ApiDetails` with default values
-    pub fn new() -> Self {
-        ApiDetails {
-            name: None,
-            bucket: None,
-            object: None,
-            objects: Vec::new(),
-            status: None,
-            status_code: None,
-            input_bytes: 0,
-            output_bytes: 0,
-            header_bytes: None,
-            time_to_first_byte: None,
-            time_to_first_byte_in_ns: None,
-            time_to_response: None,
-            time_to_response_in_ns: None,
-        }
-    }
-
-    /// Set the name
-    pub fn set_name(mut self, name: Option<String>) -> Self {
-        self.name = name;
-        self
-    }
-
-    /// Set the bucket
-    pub fn set_bucket(mut self, bucket: Option<String>) -> Self {
-        self.bucket = bucket;
-        self
-    }
-
-    /// Set the object
-    pub fn set_object(mut self, object: Option<String>) -> Self {
-        self.object = object;
-        self
-    }
-
-    /// Set the objects
-    pub fn set_objects(mut self, objects: Vec<ObjectVersion>) -> Self {
-        self.objects = objects;
-        self
-    }
-
-    /// Set the status
-    pub fn set_status(mut self, status: Option<String>) -> Self {
-        self.status = status;
-        self
-    }
-
-    /// Set the status code
-    pub fn set_status_code(mut self, status_code: Option<i32>) -> Self {
-        self.status_code = status_code;
-        self
-    }
-
-    /// Set the input bytes
-    pub fn set_input_bytes(mut self, input_bytes: i64) -> Self {
-        self.input_bytes = input_bytes;
-        self
-    }
-
-    /// Set the output bytes
-    pub fn set_output_bytes(mut self, output_bytes: i64) -> Self {
-        self.output_bytes = output_bytes;
-        self
-    }
-
-    /// Set the header bytes
-    pub fn set_header_bytes(mut self, header_bytes: Option<i64>) -> Self {
-        self.header_bytes = header_bytes;
-        self
-    }
-
-    /// Set the time to first byte
-    pub fn set_time_to_first_byte(mut self, time_to_first_byte: Option<String>) -> Self {
-        self.time_to_first_byte = time_to_first_byte;
-        self
-    }
-
-    /// Set the time to first byte in nanoseconds
-    pub fn set_time_to_first_byte_in_ns(mut self, time_to_first_byte_in_ns: Option<String>) -> Self {
-        self.time_to_first_byte_in_ns = time_to_first_byte_in_ns;
-        self
-    }
-
-    /// Set the time to response
-    pub fn set_time_to_response(mut self, time_to_response: Option<String>) -> Self {
-        self.time_to_response = time_to_response;
-        self
-    }
-
-    /// Set the time to response in nanoseconds
-    pub fn set_time_to_response_in_ns(mut self, time_to_response_in_ns: Option<String>) -> Self {
-        self.time_to_response_in_ns = time_to_response_in_ns;
-        self
-    }
-}
-
-/// Entry - audit entry logs
-/// AuditLogEntry is used to define the structure of an audit log entry
-///
-/// The `AuditLogEntry` structure contains the following fields:
-/// - `base` - the base log entry
-/// - `version` - the version of the audit log entry
-/// - `deployment_id` - the deployment ID
-/// - `event` - the event
-/// - `entry_type` - the type of audit message
-/// - `api` - the API details
-/// - `remote_host` - the remote host
-/// - `user_agent` - the user agent
-/// - `req_path` - the request path
-/// - `req_host` - the request host
-/// - `req_claims` - the request claims
-/// - `req_query` - the request query
-/// - `req_header` - the request header
-/// - `resp_header` - the response header
-/// - `access_key` - the access key
-/// - `parent_user` - the parent user
-/// - `error` - the error
-///
-/// The `AuditLogEntry` structure contains the following methods:
-/// - `new` - create a new `AuditEntry` with default values
-/// - `new_with_values` - create a new `AuditEntry` with version, time, event and api details
-/// - `with_base` - set the base log entry
-/// - `set_version` - set the version
-/// - `set_deployment_id` - set the deployment ID
-/// - `set_event` - set the event
-/// - `set_entry_type` - set the entry type
-/// - `set_api` - set the API details
-/// - `set_remote_host` - set the remote host
-/// - `set_user_agent` - set the user agent
-/// - `set_req_path` - set the request path
-/// - `set_req_host` - set the request host
-/// - `set_req_claims` - set the request claims
-/// - `set_req_query` - set the request query
-/// - `set_req_header` - set the request header
-/// - `set_resp_header` - set the response header
-/// - `set_access_key` - set the access key
-/// - `set_parent_user` - set the parent user
-/// - `set_error` - set the error
-///
-/// # Example
-/// ```
-/// use rustfs_audit_logger::AuditLogEntry;
-/// use rustfs_audit_logger::ApiDetails;
-/// use std::collections::HashMap;
-///
-/// let entry = AuditLogEntry::new()
-///     .set_version("1.0".to_string())
-///     .set_deployment_id(Some("123".to_string()))
-///     .set_event("event".to_string())
-///     .set_entry_type(Some("type".to_string()))
-///     .set_api(ApiDetails::new())
-///     .set_remote_host(Some("remote-host".to_string()))
-///     .set_user_agent(Some("user-agent".to_string()))
-///     .set_req_path(Some("req-path".to_string()))
-///     .set_req_host(Some("req-host".to_string()))
-///     .set_req_claims(Some(HashMap::new()))
-///     .set_req_query(Some(HashMap::new()))
-///     .set_req_header(Some(HashMap::new()))
-///     .set_resp_header(Some(HashMap::new()))
-///     .set_access_key(Some("access-key".to_string()))
-///     .set_parent_user(Some("parent-user".to_string()))
-///     .set_error(Some("error".to_string()));
-#[derive(Debug, Serialize, Deserialize, Clone, Default)]
-pub struct AuditLogEntry {
-    #[serde(flatten)]
-    pub base: BaseLogEntry,
-    pub version: String,
-    #[serde(rename = "deploymentid", skip_serializing_if = "Option::is_none")]
-    pub deployment_id: Option<String>,
-    pub event: String,
-    // Class of audit message - S3, admin ops, bucket management
-    #[serde(rename = "type", skip_serializing_if = "Option::is_none")]
-    pub entry_type: Option<String>,
-    pub api: ApiDetails,
-    #[serde(rename = "remotehost", skip_serializing_if = "Option::is_none")]
-    pub remote_host: Option<String>,
-    #[serde(rename = "userAgent", skip_serializing_if = "Option::is_none")]
-    pub user_agent: Option<String>,
-    #[serde(rename = "requestPath", skip_serializing_if = "Option::is_none")]
-    pub req_path: Option<String>,
-    #[serde(rename = "requestHost", skip_serializing_if = "Option::is_none")]
-    pub req_host: Option<String>,
-    #[serde(rename = "requestClaims", skip_serializing_if = "Option::is_none")]
-    pub req_claims: Option<HashMap<String, Value>>,
-    #[serde(rename = "requestQuery", skip_serializing_if = "Option::is_none")]
-    pub req_query: Option<HashMap<String, String>>,
-    #[serde(rename = "requestHeader", skip_serializing_if = "Option::is_none")]
-    pub req_header: Option<HashMap<String, String>>,
-    #[serde(rename = "responseHeader", skip_serializing_if = "Option::is_none")]
-    pub resp_header: Option<HashMap<String, String>>,
-    #[serde(rename = "accessKey", skip_serializing_if = "Option::is_none")]
-    pub access_key: Option<String>,
-    #[serde(rename = "parentUser", skip_serializing_if = "Option::is_none")]
-    pub parent_user: Option<String>,
-    #[serde(rename = "error", skip_serializing_if = "Option::is_none")]
-    pub error: Option<String>,
-}
-
-impl AuditLogEntry {
-    /// Create a new `AuditEntry` with default values
-    pub fn new() -> Self {
-        AuditLogEntry {
-            base: BaseLogEntry::new(),
-            version: String::new(),
-            deployment_id: None,
-            event: String::new(),
-            entry_type: None,
-            api: ApiDetails::new(),
-            remote_host: None,
-            user_agent: None,
-            req_path: None,
-            req_host: None,
-            req_claims: None,
-            req_query: None,
-            req_header: None,
-            resp_header: None,
-            access_key: None,
-            parent_user: None,
-            error: None,
-        }
-    }
-
-    /// Create a new `AuditEntry` with version, time, event and api details
-    pub fn new_with_values(version: String, time: DateTime<Utc>, event: String, api: ApiDetails) -> Self {
-        let mut base = BaseLogEntry::new();
-        base.timestamp = time;
-
-        AuditLogEntry {
-            base,
-            version,
-            deployment_id: None,
-            event,
-            entry_type: None,
-            api,
-            remote_host: None,
-            user_agent: None,
-            req_path: None,
-            req_host: None,
-            req_claims: None,
-            req_query: None,
-            req_header: None,
-            resp_header: None,
-            access_key: None,
-            parent_user: None,
-            error: None,
-        }
-    }
-
-    /// Set the base log entry
-    pub fn with_base(mut self, base: BaseLogEntry) -> Self {
-        self.base = base;
-        self
-    }
-
-    /// Set the version
-    pub fn set_version(mut self, version: String) -> Self {
-        self.version = version;
-        self
-    }
-
-    /// Set the deployment ID
-    pub fn set_deployment_id(mut self, deployment_id: Option<String>) -> Self {
-        self.deployment_id = deployment_id;
-        self
-    }
-
-    /// Set the event
-    pub fn set_event(mut self, event: String) -> Self {
-        self.event = event;
-        self
-    }
-
-    /// Set the entry type
-    pub fn set_entry_type(mut self, entry_type: Option<String>) -> Self {
-        self.entry_type = entry_type;
-        self
-    }
-
-    /// Set the API details
-    pub fn set_api(mut self, api: ApiDetails) -> Self {
-        self.api = api;
-        self
-    }
-
-    /// Set the remote host
-    pub fn set_remote_host(mut self, remote_host: Option<String>) -> Self {
-        self.remote_host = remote_host;
-        self
-    }
-
-    /// Set the user agent
-    pub fn set_user_agent(mut self, user_agent: Option<String>) -> Self {
-        self.user_agent = user_agent;
-        self
-    }
-
-    /// Set the request path
-    pub fn set_req_path(mut self, req_path: Option<String>) -> Self {
-        self.req_path = req_path;
-        self
-    }
-
-    /// Set the request host
-    pub fn set_req_host(mut self, req_host: Option<String>) -> Self {
-        self.req_host = req_host;
-        self
-    }
-
-    /// Set the request claims
-    pub fn set_req_claims(mut self, req_claims: Option<HashMap<String, Value>>) -> Self {
-        self.req_claims = req_claims;
-        self
-    }
-
-    /// Set the request query
-    pub fn set_req_query(mut self, req_query: Option<HashMap<String, String>>) -> Self {
-        self.req_query = req_query;
-        self
-    }
-
-    /// Set the request header
-    pub fn set_req_header(mut self, req_header: Option<HashMap<String, String>>) -> Self {
-        self.req_header = req_header;
-        self
-    }
-
-    /// Set the response header
-    pub fn set_resp_header(mut self, resp_header: Option<HashMap<String, String>>) -> Self {
-        self.resp_header = resp_header;
-        self
-    }
-
-    /// Set the access key
-    pub fn set_access_key(mut self, access_key: Option<String>) -> Self {
-        self.access_key = access_key;
-        self
-    }
-
-    /// Set the parent user
-    pub fn set_parent_user(mut self, parent_user: Option<String>) -> Self {
-        self.parent_user = parent_user;
-        self
-    }
-
-    /// Set the error
-    pub fn set_error(mut self, error: Option<String>) -> Self {
-        self.error = error;
-        self
-    }
-}
-
-impl LogRecord for AuditLogEntry {
-    fn to_json(&self) -> String {
-        serde_json::to_string(self).unwrap_or_else(|_| String::from("{}"))
-    }
-
-    fn get_timestamp(&self) -> DateTime<Utc> {
-        self.base.timestamp
-    }
-}

crates/audit-logger/src/entry/base.rs

@@ -1,108 +0,0 @@
-// Copyright 2024 RustFS Team
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-#![allow(dead_code)]
-
-use chrono::{DateTime, Utc};
-use serde::{Deserialize, Serialize};
-use serde_json::Value;
-use std::collections::HashMap;
-
-/// Base log entry structure shared by all log types
-/// This structure is used to serialize log entries to JSON
-/// and send them to the log sinks
-/// This structure is also used to deserialize log entries from JSON
-/// This structure is also used to store log entries in the database
-/// This structure is also used to query log entries from the database
-///
-/// The `BaseLogEntry` structure contains the following fields:
-/// - `timestamp` - the timestamp of the log entry
-/// - `request_id` - the request ID of the log entry
-/// - `message` - the message of the log entry
-/// - `tags` - the tags of the log entry
-///
-/// The `BaseLogEntry` structure contains the following methods:
-/// - `new` - create a new `BaseLogEntry` with default values
-/// - `message` - set the message
-/// - `request_id` - set the request ID
-/// - `tags` - set the tags
-/// - `timestamp` - set the timestamp
-///
-/// # Example
-/// ```
-/// use rustfs_audit_logger::BaseLogEntry;
-/// use chrono::{DateTime, Utc};
-/// use std::collections::HashMap;
-///
-/// let timestamp = Utc::now();
-/// let request = Some("req-123".to_string());
-/// let message = Some("This is a log message".to_string());
-/// let tags = Some(HashMap::new());
-///
-/// let entry = BaseLogEntry::new()
-///     .timestamp(timestamp)
-///     .request_id(request)
-///     .message(message)
-///     .tags(tags);
-/// ```
-#[derive(Debug, Clone, Serialize, Deserialize, Eq, PartialEq, Default)]
-pub struct BaseLogEntry {
-    #[serde(rename = "time")]
-    pub timestamp: DateTime<Utc>,
-
-    #[serde(rename = "requestID", skip_serializing_if = "Option::is_none")]
-    pub request_id: Option<String>,
-
-    #[serde(rename = "message", skip_serializing_if = "Option::is_none")]
-    pub message: Option<String>,
-
-    #[serde(rename = "tags", skip_serializing_if = "Option::is_none")]
-    pub tags: Option<HashMap<String, Value>>,
-}
-
-impl BaseLogEntry {
-    /// Create a new BaseLogEntry with default values
-    pub fn new() -> Self {
-        BaseLogEntry {
-            timestamp: Utc::now(),
-            request_id: None,
-            message: None,
-            tags: None,
-        }
-    }
-
-    /// Set the message
-    pub fn message(mut self, message: Option<String>) -> Self {
-        self.message = message;
-        self
-    }
-
-    /// Set the request ID
-    pub fn request_id(mut self, request_id: Option<String>) -> Self {
-        self.request_id = request_id;
-        self
-    }
-
-    /// Set the tags
-    pub fn tags(mut self, tags: Option<HashMap<String, Value>>) -> Self {
-        self.tags = tags;
-        self
-    }
-
-    /// Set the timestamp
-    pub fn timestamp(mut self, timestamp: DateTime<Utc>) -> Self {
-        self.timestamp = timestamp;
-        self
-    }
-}

crates/audit-logger/src/entry/mod.rs

@@ -1,159 +0,0 @@
-// Copyright 2024 RustFS Team
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-#![allow(dead_code)]
-pub(crate) mod args;
-pub(crate) mod audit;
-pub(crate) mod base;
-pub(crate) mod unified;
-
-use serde::de::Error;
-use serde::{Deserialize, Deserializer, Serialize, Serializer};
-use tracing_core::Level;
-
-/// ObjectVersion is used across multiple modules
-#[derive(Debug, Clone, Serialize, Deserialize, Eq, PartialEq)]
-pub struct ObjectVersion {
-    #[serde(rename = "name")]
-    pub object_name: String,
-    #[serde(rename = "versionId", skip_serializing_if = "Option::is_none")]
-    pub version_id: Option<String>,
-}
-
-impl ObjectVersion {
-    /// Create a new ObjectVersion object
-    pub fn new() -> Self {
-        ObjectVersion {
-            object_name: String::new(),
-            version_id: None,
-        }
-    }
-
-    /// Create a new ObjectVersion with object name
-    pub fn new_with_object_name(object_name: String) -> Self {
-        ObjectVersion {
-            object_name,
-            version_id: None,
-        }
-    }
-
-    /// Set the object name
-    pub fn set_object_name(mut self, object_name: String) -> Self {
-        self.object_name = object_name;
-        self
-    }
-
-    /// Set the version ID
-    pub fn set_version_id(mut self, version_id: Option<String>) -> Self {
-        self.version_id = version_id;
-        self
-    }
-}
-
-impl Default for ObjectVersion {
-    fn default() -> Self {
-        Self::new()
-    }
-}
-
-/// Log kind/level enum
-#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq, Default)]
-pub enum LogKind {
-    #[serde(rename = "INFO")]
-    #[default]
-    Info,
-    #[serde(rename = "WARNING")]
-    Warning,
-    #[serde(rename = "ERROR")]
-    Error,
-    #[serde(rename = "FATAL")]
-    Fatal,
-}
-
-/// Trait for types that can be serialized to JSON and have a timestamp
-/// This trait is used by `ServerLogEntry` to convert the log entry to JSON
-/// and get the timestamp of the log entry
-/// This trait is implemented by `ServerLogEntry`
-///
-/// # Example
-/// ```
-/// use rustfs_audit_logger::LogRecord;
-/// use chrono::{DateTime, Utc};
-/// use rustfs_audit_logger::ServerLogEntry;
-/// use tracing_core::Level;
-///
-/// let log_entry = ServerLogEntry::new(Level::INFO, "api_handler".to_string());
-/// let json = log_entry.to_json();
-/// let timestamp = log_entry.get_timestamp();
-/// ```
-pub trait LogRecord {
-    fn to_json(&self) -> String;
-    fn get_timestamp(&self) -> chrono::DateTime<chrono::Utc>;
-}
-
-/// Wrapper for `tracing_core::Level` to implement `Serialize` and `Deserialize`
-/// for `ServerLogEntry`
-/// This is necessary because `tracing_core::Level` does not implement `Serialize`
-/// and `Deserialize`
-/// This is a workaround to allow `ServerLogEntry` to be serialized and deserialized
-/// using `serde`
-///
-/// # Example
-/// ```
-/// use rustfs_audit_logger::SerializableLevel;
-/// use tracing_core::Level;
-///
-/// let level = Level::INFO;
-/// let serializable_level = SerializableLevel::from(level);
-/// ```
-#[derive(Debug, Clone, PartialEq, Eq)]
-pub struct SerializableLevel(pub Level);
-
-impl From<Level> for SerializableLevel {
-    fn from(level: Level) -> Self {
-        SerializableLevel(level)
-    }
-}
-
-impl From<SerializableLevel> for Level {
-    fn from(serializable_level: SerializableLevel) -> Self {
-        serializable_level.0
-    }
-}
-
-impl Serialize for SerializableLevel {
-    fn serialize<S>(&self, serializer: S) -> Result<S::Ok, S::Error>
-    where
-        S: Serializer,
-    {
-        serializer.serialize_str(self.0.as_str())
-    }
-}
-
-impl<'de> Deserialize<'de> for SerializableLevel {
-    fn deserialize<D>(deserializer: D) -> Result<Self, D::Error>
-    where
-        D: Deserializer<'de>,
-    {
-        let s = String::deserialize(deserializer)?;
-        match s.as_str() {
-            "TRACE" => Ok(SerializableLevel(Level::TRACE)),
-            "DEBUG" => Ok(SerializableLevel(Level::DEBUG)),
-            "INFO" => Ok(SerializableLevel(Level::INFO)),
-            "WARN" => Ok(SerializableLevel(Level::WARN)),
-            "ERROR" => Ok(SerializableLevel(Level::ERROR)),
-            _ => Err(D::Error::custom("unknown log level")),
-        }
-    }
-}

crates/audit-logger/src/entry/unified.rs

@@ -1,266 +0,0 @@
-// Copyright 2024 RustFS Team
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-#![allow(dead_code)]
-
-use crate::{AuditLogEntry, BaseLogEntry, LogKind, LogRecord, SerializableLevel};
-use chrono::{DateTime, Utc};
-use serde::{Deserialize, Serialize};
-use tracing_core::Level;
-
-/// Server log entry with structured fields
-/// ServerLogEntry is used to log structured log entries from the server
-///
-/// The `ServerLogEntry` structure contains the following fields:
-/// - `base` - the base log entry
-/// - `level` - the log level
-/// - `source` - the source of the log entry
-/// - `user_id` - the user ID
-/// - `fields` - the structured fields of the log entry
-///
-/// The `ServerLogEntry` structure contains the following methods:
-/// - `new` - create a new `ServerLogEntry` with specified level and source
-/// - `with_base` - set the base log entry
-/// - `user_id` - set the user ID
-/// - `fields` - set the fields
-/// - `add_field` - add a field
-///
-/// # Example
-/// ```
-/// use rustfs_audit_logger::ServerLogEntry;
-/// use tracing_core::Level;
-///
-/// let entry = ServerLogEntry::new(Level::INFO, "test_module".to_string())
-///    .user_id(Some("user-456".to_string()))
-///   .add_field("operation".to_string(), "login".to_string());
-/// ```
-#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq)]
-pub struct ServerLogEntry {
-    #[serde(flatten)]
-    pub base: BaseLogEntry,
-
-    pub level: SerializableLevel,
-    pub source: String,
-
-    #[serde(rename = "userId", skip_serializing_if = "Option::is_none")]
-    pub user_id: Option<String>,
-
-    #[serde(skip_serializing_if = "Vec::is_empty", default)]
-    pub fields: Vec<(String, String)>,
-}
-
-impl ServerLogEntry {
-    /// Create a new ServerLogEntry with specified level and source
-    pub fn new(level: Level, source: String) -> Self {
-        ServerLogEntry {
-            base: BaseLogEntry::new(),
-            level: SerializableLevel(level),
-            source,
-            user_id: None,
-            fields: Vec::new(),
-        }
-    }
-
-    /// Set the base log entry
-    pub fn with_base(mut self, base: BaseLogEntry) -> Self {
-        self.base = base;
-        self
-    }
-
-    /// Set the user ID
-    pub fn user_id(mut self, user_id: Option<String>) -> Self {
-        self.user_id = user_id;
-        self
-    }
-
-    /// Set fields
-    pub fn fields(mut self, fields: Vec<(String, String)>) -> Self {
-        self.fields = fields;
-        self
-    }
-
-    /// Add a field
-    pub fn add_field(mut self, key: String, value: String) -> Self {
-        self.fields.push((key, value));
-        self
-    }
-}
-
-impl LogRecord for ServerLogEntry {
-    fn to_json(&self) -> String {
-        serde_json::to_string(self).unwrap_or_else(|_| String::from("{}"))
-    }
-
-    fn get_timestamp(&self) -> DateTime<Utc> {
-        self.base.timestamp
-    }
-}
-
-/// Console log entry structure
-/// ConsoleLogEntry is used to log console log entries
-/// The `ConsoleLogEntry` structure contains the following fields:
-/// - `base` - the base log entry
-/// - `level` - the log level
-/// - `console_msg` - the console message
-/// - `node_name` - the node name
-/// - `err` - the error message
-///
-/// The `ConsoleLogEntry` structure contains the following methods:
-/// - `new` - create a new `ConsoleLogEntry`
-/// - `new_with_console_msg` - create a new `ConsoleLogEntry` with console message and node name
-/// - `with_base` - set the base log entry
-/// - `set_level` - set the log level
-/// - `set_node_name` - set the node name
-/// - `set_console_msg` - set the console message
-/// - `set_err` - set the error message
-///
-/// # Example
-/// ```
-/// use rustfs_audit_logger::ConsoleLogEntry;
-///
-/// let entry = ConsoleLogEntry::new_with_console_msg("Test message".to_string(), "node-123".to_string());
-/// ```
-#[derive(Debug, Clone, Serialize, Deserialize)]
-pub struct ConsoleLogEntry {
-    #[serde(flatten)]
-    pub base: BaseLogEntry,
-
-    pub level: LogKind,
-    pub console_msg: String,
-    pub node_name: String,
-
-    #[serde(skip)]
-    pub err: Option<String>,
-}
-
-impl ConsoleLogEntry {
-    /// Create a new ConsoleLogEntry
-    pub fn new() -> Self {
-        ConsoleLogEntry {
-            base: BaseLogEntry::new(),
-            level: LogKind::Info,
-            console_msg: String::new(),
-            node_name: String::new(),
-            err: None,
-        }
-    }
-
-    /// Create a new ConsoleLogEntry with console message and node name
-    pub fn new_with_console_msg(console_msg: String, node_name: String) -> Self {
-        ConsoleLogEntry {
-            base: BaseLogEntry::new(),
-            level: LogKind::Info,
-            console_msg,
-            node_name,
-            err: None,
-        }
-    }
-
-    /// Set the base log entry
-    pub fn with_base(mut self, base: BaseLogEntry) -> Self {
-        self.base = base;
-        self
-    }
-
-    /// Set the log level
-    pub fn set_level(mut self, level: LogKind) -> Self {
-        self.level = level;
-        self
-    }
-
-    /// Set the node name
-    pub fn set_node_name(mut self, node_name: String) -> Self {
-        self.node_name = node_name;
-        self
-    }
-
-    /// Set the console message
-    pub fn set_console_msg(mut self, console_msg: String) -> Self {
-        self.console_msg = console_msg;
-        self
-    }
-
-    /// Set the error message
-    pub fn set_err(mut self, err: Option<String>) -> Self {
-        self.err = err;
-        self
-    }
-}
-
-impl Default for ConsoleLogEntry {
-    fn default() -> Self {
-        Self::new()
-    }
-}
-
-impl LogRecord for ConsoleLogEntry {
-    fn to_json(&self) -> String {
-        serde_json::to_string(self).unwrap_or_else(|_| String::from("{}"))
-    }
-
-    fn get_timestamp(&self) -> DateTime<Utc> {
-        self.base.timestamp
-    }
-}
-
-/// Unified log entry type
-/// UnifiedLogEntry is used to log different types of log entries
-///
-/// The `UnifiedLogEntry` enum contains the following variants:
-/// - `Server` - a server log entry
-/// - `Audit` - an audit log entry
-/// - `Console` - a console log entry
-///
-/// The `UnifiedLogEntry` enum contains the following methods:
-/// - `to_json` - convert the log entry to JSON
-/// - `get_timestamp` - get the timestamp of the log entry
-///
-/// # Example
-/// ```
-/// use rustfs_audit_logger::{UnifiedLogEntry, ServerLogEntry};
-/// use tracing_core::Level;
-///
-/// let server_entry = ServerLogEntry::new(Level::INFO, "test_module".to_string());
-/// let unified = UnifiedLogEntry::Server(server_entry);
-/// ```
-#[derive(Debug, Clone, Serialize, Deserialize)]
-#[serde(tag = "type")]
-pub enum UnifiedLogEntry {
-    #[serde(rename = "server")]
-    Server(ServerLogEntry),
-
-    #[serde(rename = "audit")]
-    Audit(Box<AuditLogEntry>),
-
-    #[serde(rename = "console")]
-    Console(ConsoleLogEntry),
-}
-
-impl LogRecord for UnifiedLogEntry {
-    fn to_json(&self) -> String {
-        match self {
-            UnifiedLogEntry::Server(entry) => entry.to_json(),
-            UnifiedLogEntry::Audit(entry) => entry.to_json(),
-            UnifiedLogEntry::Console(entry) => entry.to_json(),
-        }
-    }
-
-    fn get_timestamp(&self) -> DateTime<Utc> {
-        match self {
-            UnifiedLogEntry::Server(entry) => entry.get_timestamp(),
-            UnifiedLogEntry::Audit(entry) => entry.get_timestamp(),
-            UnifiedLogEntry::Console(entry) => entry.get_timestamp(),
-        }
-    }
-}

crates/audit-logger/src/lib.rs

@@ -1,8 +0,0 @@
-mod entry;
-mod logger;
-
-pub use entry::args::Args;
-pub use entry::audit::{ApiDetails, AuditLogEntry};
-pub use entry::base::BaseLogEntry;
-pub use entry::unified::{ConsoleLogEntry, ServerLogEntry, UnifiedLogEntry};
-pub use entry::{LogKind, LogRecord, ObjectVersion, SerializableLevel};

crates/audit-logger/src/logger/dispatch.rs

@@ -1,13 +0,0 @@
-//  Copyright 2024 RustFS Team
-//
-//  Licensed under the Apache License, Version 2.0 (the "License");
-//  you may not use this file except in compliance with the License.
-//  You may obtain a copy of the License at
-//
-//      http://www.apache.org/licenses/LICENSE-2.0
-//
-//  Unless required by applicable law or agreed to in writing, software
-//  distributed under the License is distributed on an "AS IS" BASIS,
-//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-//  See the License for the specific language governing permissions and
-//  limitations under the License.

crates/audit-logger/src/logger/entry.rs

@@ -1,108 +0,0 @@
-//  Copyright 2024 RustFS Team
-//
-//  Licensed under the Apache License, Version 2.0 (the "License");
-//  you may not use this file except in compliance with the License.
-//  You may obtain a copy of the License at
-//
-//      http://www.apache.org/licenses/LICENSE-2.0
-//
-//  Unless required by applicable law or agreed to in writing, software
-//  distributed under the License is distributed on an "AS IS" BASIS,
-//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-//  See the License for the specific language governing permissions and
-//  limitations under the License.
-
-#![allow(dead_code)]
-
-use chrono::{DateTime, Utc};
-use serde::Serialize;
-use std::collections::HashMap;
-use uuid::Uuid;
-
-///A Trait for a log entry that can be serialized and sent
-pub trait Loggable: Serialize + Send + Sync + 'static {
-    fn to_json(&self) -> Result<String, serde_json::Error> {
-        serde_json::to_string(self)
-    }
-}
-
-/// Standard log entries
-#[derive(Serialize, Debug)]
-#[serde(rename_all = "camelCase")]
-pub struct LogEntry {
-    pub deployment_id: String,
-    pub level: String,
-    pub message: String,
-    #[serde(skip_serializing_if = "Option::is_none")]
-    pub trace: Option<Trace>,
-    pub time: DateTime<Utc>,
-    pub request_id: String,
-}
-
-impl Loggable for LogEntry {}
-
-/// Audit log entry
-#[derive(Serialize, Debug)]
-#[serde(rename_all = "camelCase")]
-pub struct AuditEntry {
-    pub version: String,
-    pub deployment_id: String,
-    pub time: DateTime<Utc>,
-    pub trigger: String,
-    pub api: ApiDetails,
-    pub remote_host: String,
-    pub request_id: String,
-    pub user_agent: String,
-    pub access_key: String,
-    #[serde(skip_serializing_if = "HashMap::is_empty")]
-    pub tags: HashMap<String, String>,
-}
-
-impl Loggable for AuditEntry {}
-
-#[derive(Serialize, Debug)]
-#[serde(rename_all = "camelCase")]
-pub struct Trace {
-    pub message: String,
-    pub source: Vec<String>,
-    #[serde(skip_serializing_if = "HashMap::is_empty")]
-    pub variables: HashMap<String, String>,
-}
-
-#[derive(Serialize, Debug)]
-#[serde(rename_all = "camelCase")]
-pub struct ApiDetails {
-    pub name: String,
-    pub bucket: String,
-    pub object: String,
-    pub status: String,
-    pub status_code: u16,
-    pub time_to_first_byte: String,
-    pub time_to_response: String,
-}
-
-// Helper functions to create entries
-impl AuditEntry {
-    pub fn new(api_name: &str, bucket: &str, object: &str) -> Self {
-        AuditEntry {
-            version: "1".to_string(),
-            deployment_id: "global-deployment-id".to_string(),
-            time: Utc::now(),
-            trigger: "incoming".to_string(),
-            api: ApiDetails {
-                name: api_name.to_string(),
-                bucket: bucket.to_string(),
-                object: object.to_string(),
-                status: "OK".to_string(),
-                status_code: 200,
-                time_to_first_byte: "10ms".to_string(),
-                time_to_response: "50ms".to_string(),
-            },
-            remote_host: "127.0.0.1".to_string(),
-            request_id: Uuid::new_v4().to_string(),
-            user_agent: "Rust-Client/1.0".to_string(),
-            access_key: "minioadmin".to_string(),
-            tags: HashMap::new(),
-        }
-    }
-}

crates/audit-logger/src/logger/factory.rs

@@ -1,13 +0,0 @@
-//  Copyright 2024 RustFS Team
-//
-//  Licensed under the Apache License, Version 2.0 (the "License");
-//  you may not use this file except in compliance with the License.
-//  You may obtain a copy of the License at
-//
-//      http://www.apache.org/licenses/LICENSE-2.0
-//
-//  Unless required by applicable law or agreed to in writing, software
-//  distributed under the License is distributed on an "AS IS" BASIS,
-//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-//  See the License for the specific language governing permissions and
-//  limitations under the License.

crates/audit-logger/src/logger/mod.rs

@@ -1,36 +0,0 @@
-//  Copyright 2024 RustFS Team
-//
-//  Licensed under the Apache License, Version 2.0 (the "License");
-//  you may not use this file except in compliance with the License.
-//  You may obtain a copy of the License at
-//
-//      http://www.apache.org/licenses/LICENSE-2.0
-//
-//  Unless required by applicable law or agreed to in writing, software
-//  distributed under the License is distributed on an "AS IS" BASIS,
-//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-//  See the License for the specific language governing permissions and
-//  limitations under the License.
-
-#![allow(dead_code)]
-
-pub mod config;
-pub mod dispatch;
-pub mod entry;
-pub mod factory;
-
-use async_trait::async_trait;
-use std::error::Error;
-
-/// General Log Target Trait
-#[async_trait]
-pub trait Target: Send + Sync {
-    /// Send a single logizable entry
-    async fn send(&self, entry: Box<Self>) -> Result<(), Box<dyn Error + Send>>;
-
-    /// Returns the unique name of the target
-    fn name(&self) -> &str;
-
-    /// Close target gracefully, ensuring all buffered logs are processed
-    async fn shutdown(&self);
-}

crates/audit/Cargo.toml

@@ -13,32 +13,31 @@
 # limitations under the License.
 
 [package]
-name = "rustfs-audit-logger"
+name = "rustfs-audit"
 edition.workspace = true
 license.workspace = true
 repository.workspace = true
 rust-version.workspace = true
 version.workspace = true
 homepage.workspace = true
-description = "Audit logging system for RustFS, providing detailed logging of file operations and system events."
-documentation = "https://docs.rs/audit-logger/latest/audit_logger/"
-keywords = ["audit", "logging", "file-operations", "system-events", "RustFS"]
-categories = ["web-programming", "development-tools::profiling", "asynchronous", "api-bindings", "development-tools::debugging"]
+description = "Audit target management system for RustFS, providing multi-target fan-out and hot reload capabilities."
+documentation = "https://docs.rs/rustfs-audit/latest/rustfs_audit/"
+keywords = ["audit", "target", "management", "fan-out", "RustFS"]
+categories = ["web-programming", "development-tools", "asynchronous", "api-bindings"]
 
 [dependencies]
 rustfs-targets = { workspace = true }
-async-trait = { workspace = true }
+rustfs-config = { workspace = true, features = ["audit", "constants"] }
+rustfs-ecstore = { workspace = true }
 chrono = { workspace = true }
-reqwest = { workspace = true }
+futures = { workspace = true }
 serde = { workspace = true }
 serde_json = { workspace = true }
-tracing = { workspace = true, features = ["std", "attributes"] }
-tracing-core = { workspace = true }
-tokio = { workspace = true, features = ["sync", "fs", "rt-multi-thread", "rt", "time", "macros"] }
-url = { workspace = true }
-uuid = { workspace = true }
 thiserror = { workspace = true }
-figment = { version = "0.10", features = ["json", "env"] }
+tokio = { workspace = true, features = ["sync", "fs", "rt-multi-thread", "rt", "time", "macros"] }
+tracing = { workspace = true, features = ["std", "attributes"] }
+url = { workspace = true }
+rumqttc = { workspace = true }
 
 [lints]
 workspace = true

crates/audit/README.md

@@ -0,0 +1,124 @@
+# rustfs-audit
+
+**Audit Target Management System for RustFS**
+
+`rustfs-audit` is a comprehensive audit logging system designed for RustFS. It provides multi-target fan-out, hot reload
+capabilities, and rich observability features for distributed storage and event-driven systems.
+
+## Features
+
+- **Multi-Target Fan-Out:** Dispatch audit logs to multiple targets (e.g., Webhook, MQTT) concurrently.
+- **Hot Reload:** Dynamically reload configuration and update targets without downtime.
+- **Observability:** Collect metrics such as EPS (Events Per Second), average latency, error rate, and target success
+  rate.
+- **Performance Validation:** Validate system performance against requirements and receive optimization recommendations.
+- **Extensible Registry:** Manage audit targets with add, remove, enable, disable, and upsert operations.
+- **Global Singleton:** Easy-to-use global audit system and logger.
+- **Async & Thread-Safe:** Built on Tokio and Rust async primitives for high concurrency.
+
+## Getting Started
+
+### Add Dependency
+
+Add to your `Cargo.toml`:
+
+```toml
+[dependencies]
+rustfs-audit = "0.1"
+```
+
+### Basic Usage
+
+#### Initialize and Start Audit System
+
+```rust
+use rustfs_audit::{start_audit_system, AuditLogger};
+use rustfs_ecstore::config::Config;
+
+#[tokio::main]
+async fn main() {
+    let config = Config::load("path/to/config.toml").await.unwrap();
+    start_audit_system(config).await.unwrap();
+}
+```
+
+#### Log an Audit Entry
+
+```rust
+use rustfs_audit::{AuditEntry, AuditLogger, ApiDetails};
+use chrono::Utc;
+use rustfs_targets::EventName;
+
+let entry = AuditEntry::new(
+"v1".to_string(),
+Some("deployment-123".to_string()),
+Some("siteA".to_string()),
+Utc::now(),
+EventName::ObjectCreatedPut,
+Some("type".to_string()),
+"trigger".to_string(),
+ApiDetails::default (),
+);
+
+AuditLogger::log(entry).await;
+```
+
+#### Observability & Metrics
+
+```rust
+use rustfs_audit::{get_metrics_report, validate_performance};
+
+let report = get_metrics_report().await;
+println!("{}", report.format());
+
+let validation = validate_performance().await;
+println!("{}", validation.format());
+```
+
+## Configuration
+
+Targets are configured via TOML files and environment variables. Supported target types:
+
+- **Webhook**
+- **MQTT**
+
+Environment variables override file configuration.
+See [docs.rs/rustfs-audit](https://docs.rs/rustfs-audit/latest/rustfs_audit/) for details.
+
+## API Overview
+
+- `AuditSystem`: Main system for managing targets and dispatching logs.
+- `AuditRegistry`: Registry for audit targets.
+- `AuditEntry`: Audit log entry structure.
+- `ApiDetails`: API call details for audit logs.
+- `AuditLogger`: Global logger singleton.
+- `AuditMetrics`, `AuditMetricsReport`: Metrics and reporting.
+- `PerformanceValidation`: Performance validation and recommendations.
+
+## Observability
+
+- **Metrics:** EPS, average latency, error rate, target success rate, processed/failed events, config reloads, system
+  starts.
+- **Validation:** Checks if EPS ≥ 3000, latency ≤ 30ms, error rate ≤ 1%. Provides actionable recommendations.
+
+## Contributing
+
+Issues and PRs are welcome!  
+See [docs.rs/rustfs-audit](https://docs.rs/rustfs-audit/latest/rustfs_audit/) for detailed developer documentation.
+
+## License
+
+Apache License 2.0
+
+## Documentation
+
+For detailed API documentation, refer to source code comments
+and [docs.rs documentation](https://docs.rs/rustfs-audit/latest/rustfs_audit/).
+
+---
+
+**Note:**  
+This crate is designed for use within the RustFS ecosystem and may depend on other RustFS crates such as
+`rustfs-targets`, `rustfs-config`, and `rustfs-ecstore`.  
+For integration examples and advanced usage, see the [docs.rs](https://docs.rs/rustfs-audit/latest/rustfs_audit/)
+documentation.

crates/audit/src/entity.rs

@@ -0,0 +1,390 @@
+// Copyright 2024 RustFS Team
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+use chrono::{DateTime, Utc};
+use rustfs_targets::EventName;
+use serde::{Deserialize, Serialize};
+use serde_json::Value;
+use std::collections::HashMap;
+
+/// Trait for types that can be serialized to JSON and have a timestamp
+pub trait LogRecord {
+    /// Serialize the record to a JSON string
+    fn to_json(&self) -> String;
+    /// Get the timestamp of the record
+    fn get_timestamp(&self) -> chrono::DateTime<chrono::Utc>;
+}
+
+/// ObjectVersion represents an object version with key and versionId
+#[derive(Debug, Clone, Serialize, Deserialize, PartialEq, Eq, Default)]
+pub struct ObjectVersion {
+    #[serde(rename = "objectName")]
+    pub object_name: String,
+    #[serde(rename = "versionId", skip_serializing_if = "Option::is_none")]
+    pub version_id: Option<String>,
+}
+
+impl ObjectVersion {
+    /// Set the object name (chainable)
+    pub fn set_object_name(&mut self, name: String) -> &mut Self {
+        self.object_name = name;
+        self
+    }
+    /// Set the version ID (chainable)
+    pub fn set_version_id(&mut self, version_id: Option<String>) -> &mut Self {
+        self.version_id = version_id;
+        self
+    }
+}
+
+/// ApiDetails contains API information for the audit entry
+#[derive(Debug, Clone, Serialize, Deserialize, Default)]
+pub struct ApiDetails {
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub name: Option<String>,
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub bucket: Option<String>,
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub object: Option<String>,
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub objects: Option<Vec<ObjectVersion>>,
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub status: Option<String>,
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub status_code: Option<i32>,
+    #[serde(rename = "rx", skip_serializing_if = "Option::is_none")]
+    pub input_bytes: Option<i64>,
+    #[serde(rename = "tx", skip_serializing_if = "Option::is_none")]
+    pub output_bytes: Option<i64>,
+    #[serde(rename = "txHeaders", skip_serializing_if = "Option::is_none")]
+    pub header_bytes: Option<i64>,
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub time_to_first_byte: Option<String>,
+    #[serde(rename = "timeToFirstByteInNS", skip_serializing_if = "Option::is_none")]
+    pub time_to_first_byte_in_ns: Option<String>,
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub time_to_response: Option<String>,
+    #[serde(rename = "timeToResponseInNS", skip_serializing_if = "Option::is_none")]
+    pub time_to_response_in_ns: Option<String>,
+}
+
+impl ApiDetails {
+    /// Set API name (chainable)
+    pub fn set_name(&mut self, name: Option<String>) -> &mut Self {
+        self.name = name;
+        self
+    }
+    /// Set bucket name (chainable)
+    pub fn set_bucket(&mut self, bucket: Option<String>) -> &mut Self {
+        self.bucket = bucket;
+        self
+    }
+    /// Set object name (chainable)
+    pub fn set_object(&mut self, object: Option<String>) -> &mut Self {
+        self.object = object;
+        self
+    }
+    /// Set objects list (chainable)
+    pub fn set_objects(&mut self, objects: Option<Vec<ObjectVersion>>) -> &mut Self {
+        self.objects = objects;
+        self
+    }
+    /// Set status (chainable)
+    pub fn set_status(&mut self, status: Option<String>) -> &mut Self {
+        self.status = status;
+        self
+    }
+    /// Set status code (chainable)
+    pub fn set_status_code(&mut self, code: Option<i32>) -> &mut Self {
+        self.status_code = code;
+        self
+    }
+    /// Set input bytes (chainable)
+    pub fn set_input_bytes(&mut self, bytes: Option<i64>) -> &mut Self {
+        self.input_bytes = bytes;
+        self
+    }
+    /// Set output bytes (chainable)
+    pub fn set_output_bytes(&mut self, bytes: Option<i64>) -> &mut Self {
+        self.output_bytes = bytes;
+        self
+    }
+    /// Set header bytes (chainable)
+    pub fn set_header_bytes(&mut self, bytes: Option<i64>) -> &mut Self {
+        self.header_bytes = bytes;
+        self
+    }
+    /// Set time to first byte (chainable)
+    pub fn set_time_to_first_byte(&mut self, t: Option<String>) -> &mut Self {
+        self.time_to_first_byte = t;
+        self
+    }
+    /// Set time to first byte in nanoseconds (chainable)
+    pub fn set_time_to_first_byte_in_ns(&mut self, t: Option<String>) -> &mut Self {
+        self.time_to_first_byte_in_ns = t;
+        self
+    }
+    /// Set time to response (chainable)
+    pub fn set_time_to_response(&mut self, t: Option<String>) -> &mut Self {
+        self.time_to_response = t;
+        self
+    }
+    /// Set time to response in nanoseconds (chainable)
+    pub fn set_time_to_response_in_ns(&mut self, t: Option<String>) -> &mut Self {
+        self.time_to_response_in_ns = t;
+        self
+    }
+}
+
+/// AuditEntry represents an audit log entry
+#[derive(Debug, Clone, Serialize, Deserialize, Default)]
+pub struct AuditEntry {
+    pub version: String,
+    #[serde(rename = "deploymentid", skip_serializing_if = "Option::is_none")]
+    pub deployment_id: Option<String>,
+    #[serde(rename = "siteName", skip_serializing_if = "Option::is_none")]
+    pub site_name: Option<String>,
+    pub time: DateTime<Utc>,
+    pub event: EventName,
+    #[serde(rename = "type", skip_serializing_if = "Option::is_none")]
+    pub entry_type: Option<String>,
+    pub trigger: String,
+    pub api: ApiDetails,
+    #[serde(rename = "remotehost", skip_serializing_if = "Option::is_none")]
+    pub remote_host: Option<String>,
+    #[serde(rename = "requestID", skip_serializing_if = "Option::is_none")]
+    pub request_id: Option<String>,
+    #[serde(rename = "userAgent", skip_serializing_if = "Option::is_none")]
+    pub user_agent: Option<String>,
+    #[serde(rename = "requestPath", skip_serializing_if = "Option::is_none")]
+    pub req_path: Option<String>,
+    #[serde(rename = "requestHost", skip_serializing_if = "Option::is_none")]
+    pub req_host: Option<String>,
+    #[serde(rename = "requestNode", skip_serializing_if = "Option::is_none")]
+    pub req_node: Option<String>,
+    #[serde(rename = "requestClaims", skip_serializing_if = "Option::is_none")]
+    pub req_claims: Option<HashMap<String, Value>>,
+    #[serde(rename = "requestQuery", skip_serializing_if = "Option::is_none")]
+    pub req_query: Option<HashMap<String, String>>,
+    #[serde(rename = "requestHeader", skip_serializing_if = "Option::is_none")]
+    pub req_header: Option<HashMap<String, String>>,
+    #[serde(rename = "responseHeader", skip_serializing_if = "Option::is_none")]
+    pub resp_header: Option<HashMap<String, String>>,
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub tags: Option<HashMap<String, Value>>,
+    #[serde(rename = "accessKey", skip_serializing_if = "Option::is_none")]
+    pub access_key: Option<String>,
+    #[serde(rename = "parentUser", skip_serializing_if = "Option::is_none")]
+    pub parent_user: Option<String>,
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub error: Option<String>,
+}
+
+impl AuditEntry {
+    /// Create a new AuditEntry with required fields
+    #[allow(clippy::too_many_arguments)]
+    pub fn new(
+        version: String,
+        deployment_id: Option<String>,
+        site_name: Option<String>,
+        time: DateTime<Utc>,
+        event: EventName,
+        entry_type: Option<String>,
+        trigger: String,
+        api: ApiDetails,
+    ) -> Self {
+        AuditEntry {
+            version,
+            deployment_id,
+            site_name,
+            time,
+            event,
+            entry_type,
+            trigger,
+            api,
+            remote_host: None,
+            request_id: None,
+            user_agent: None,
+            req_path: None,
+            req_host: None,
+            req_node: None,
+            req_claims: None,
+            req_query: None,
+            req_header: None,
+            resp_header: None,
+            tags: None,
+            access_key: None,
+            parent_user: None,
+            error: None,
+        }
+    }
+
+    /// Set version (chainable)
+    pub fn set_version(&mut self, version: String) -> &mut Self {
+        self.version = version;
+        self
+    }
+    /// Set deployment ID (chainable)
+    pub fn set_deployment_id(&mut self, id: Option<String>) -> &mut Self {
+        self.deployment_id = id;
+        self
+    }
+    /// Set site name (chainable)
+    pub fn set_site_name(&mut self, name: Option<String>) -> &mut Self {
+        self.site_name = name;
+        self
+    }
+    /// Set time (chainable)
+    pub fn set_time(&mut self, time: DateTime<Utc>) -> &mut Self {
+        self.time = time;
+        self
+    }
+    /// Set event (chainable)
+    pub fn set_event(&mut self, event: EventName) -> &mut Self {
+        self.event = event;
+        self
+    }
+    /// Set entry type (chainable)
+    pub fn set_entry_type(&mut self, entry_type: Option<String>) -> &mut Self {
+        self.entry_type = entry_type;
+        self
+    }
+    /// Set trigger (chainable)
+    pub fn set_trigger(&mut self, trigger: String) -> &mut Self {
+        self.trigger = trigger;
+        self
+    }
+    /// Set API details (chainable)
+    pub fn set_api(&mut self, api: ApiDetails) -> &mut Self {
+        self.api = api;
+        self
+    }
+    /// Set remote host (chainable)
+    pub fn set_remote_host(&mut self, host: Option<String>) -> &mut Self {
+        self.remote_host = host;
+        self
+    }
+    /// Set request ID (chainable)
+    pub fn set_request_id(&mut self, id: Option<String>) -> &mut Self {
+        self.request_id = id;
+        self
+    }
+    /// Set user agent (chainable)
+    pub fn set_user_agent(&mut self, agent: Option<String>) -> &mut Self {
+        self.user_agent = agent;
+        self
+    }
+    /// Set request path (chainable)
+    pub fn set_req_path(&mut self, path: Option<String>) -> &mut Self {
+        self.req_path = path;
+        self
+    }
+    /// Set request host (chainable)
+    pub fn set_req_host(&mut self, host: Option<String>) -> &mut Self {
+        self.req_host = host;
+        self
+    }
+    /// Set request node (chainable)
+    pub fn set_req_node(&mut self, node: Option<String>) -> &mut Self {
+        self.req_node = node;
+        self
+    }
+    /// Set request claims (chainable)
+    pub fn set_req_claims(&mut self, claims: Option<HashMap<String, Value>>) -> &mut Self {
+        self.req_claims = claims;
+        self
+    }
+    /// Set request query (chainable)
+    pub fn set_req_query(&mut self, query: Option<HashMap<String, String>>) -> &mut Self {
+        self.req_query = query;
+        self
+    }
+    /// Set request header (chainable)
+    pub fn set_req_header(&mut self, header: Option<HashMap<String, String>>) -> &mut Self {
+        self.req_header = header;
+        self
+    }
+    /// Set response header (chainable)
+    pub fn set_resp_header(&mut self, header: Option<HashMap<String, String>>) -> &mut Self {
+        self.resp_header = header;
+        self
+    }
+    /// Set tags (chainable)
+    pub fn set_tags(&mut self, tags: Option<HashMap<String, Value>>) -> &mut Self {
+        self.tags = tags;
+        self
+    }
+    /// Set access key (chainable)
+    pub fn set_access_key(&mut self, key: Option<String>) -> &mut Self {
+        self.access_key = key;
+        self
+    }
+    /// Set parent user (chainable)
+    pub fn set_parent_user(&mut self, user: Option<String>) -> &mut Self {
+        self.parent_user = user;
+        self
+    }
+    /// Set error message (chainable)
+    pub fn set_error(&mut self, error: Option<String>) -> &mut Self {
+        self.error = error;
+        self
+    }
+
+    /// Build AuditEntry from context or parameters (example, can be extended)
+    pub fn from_context(
+        version: String,
+        deployment_id: Option<String>,
+        time: DateTime<Utc>,
+        event: EventName,
+        trigger: String,
+        api: ApiDetails,
+        tags: Option<HashMap<String, Value>>,
+    ) -> Self {
+        AuditEntry {
+            version,
+            deployment_id,
+            site_name: None,
+            time,
+            event,
+            entry_type: None,
+            trigger,
+            api,
+            remote_host: None,
+            request_id: None,
+            user_agent: None,
+            req_path: None,
+            req_host: None,
+            req_node: None,
+            req_claims: None,
+            req_query: None,
+            req_header: None,
+            resp_header: None,
+            tags,
+            access_key: None,
+            parent_user: None,
+            error: None,
+        }
+    }
+}
+
+impl LogRecord for AuditEntry {
+    /// Serialize AuditEntry to JSON string
+    fn to_json(&self) -> String {
+        serde_json::to_string(self).unwrap_or_else(|_| String::from("{}"))
+    }
+    /// Get the timestamp of the audit entry
+    fn get_timestamp(&self) -> DateTime<Utc> {
+        self.time
+    }
+}

crates/audit/src/error.rs

@@ -0,0 +1,55 @@
+//  Copyright 2024 RustFS Team
+//
+//  Licensed under the Apache License, Version 2.0 (the "License");
+//  you may not use this file except in compliance with the License.
+//  You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+//  Unless required by applicable law or agreed to in writing, software
+//  distributed under the License is distributed on an "AS IS" BASIS,
+//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+//  See the License for the specific language governing permissions and
+//  limitations under the License.
+
+use thiserror::Error;
+
+/// Result type for audit operations
+pub type AuditResult<T> = Result<T, AuditError>;
+
+/// Errors that can occur during audit operations
+#[derive(Error, Debug)]
+pub enum AuditError {
+    #[error("Configuration error: {0}")]
+    Configuration(String),
+
+    #[error("config not loaded")]
+    ConfigNotLoaded,
+
+    #[error("Target error: {0}")]
+    Target(#[from] rustfs_targets::TargetError),
+
+    #[error("System not initialized: {0}")]
+    NotInitialized(String),
+
+    #[error("System already initialized")]
+    AlreadyInitialized,
+
+    #[error("Failed to save configuration: {0}")]
+    SaveConfig(String),
+
+    #[error("Failed to load configuration: {0}")]
+    LoadConfig(String),
+
+    #[error("Serialization error: {0}")]
+    Serialization(#[from] serde_json::Error),
+
+    #[error("I/O error: {0}")]
+    Io(#[from] std::io::Error),
+
+    #[error("Join error: {0}")]
+    Join(#[from] tokio::task::JoinError),
+
+    #[error("Server storage not initialized: {0}")]
+    ServerNotInitialized(String),
+}

crates/audit/src/global.rs

@@ -0,0 +1,124 @@
+//  Copyright 2024 RustFS Team
+//
+//  Licensed under the Apache License, Version 2.0 (the "License");
+//  you may not use this file except in compliance with the License.
+//  You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+//  Unless required by applicable law or agreed to in writing, software
+//  distributed under the License is distributed on an "AS IS" BASIS,
+//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+//  See the License for the specific language governing permissions and
+//  limitations under the License.
+
+use crate::{AuditEntry, AuditResult, AuditSystem};
+use rustfs_ecstore::config::Config;
+use std::sync::{Arc, OnceLock};
+use tracing::{error, warn};
+
+/// Global audit system instance
+static AUDIT_SYSTEM: OnceLock<Arc<AuditSystem>> = OnceLock::new();
+
+/// Initialize the global audit system
+pub fn init_audit_system() -> Arc<AuditSystem> {
+    AUDIT_SYSTEM.get_or_init(|| Arc::new(AuditSystem::new())).clone()
+}
+
+/// Get the global audit system instance
+pub fn audit_system() -> Option<Arc<AuditSystem>> {
+    AUDIT_SYSTEM.get().cloned()
+}
+
+/// Start the global audit system with configuration
+pub async fn start_audit_system(config: Config) -> AuditResult<()> {
+    let system = init_audit_system();
+    system.start(config).await
+}
+
+/// Stop the global audit system
+pub async fn stop_audit_system() -> AuditResult<()> {
+    if let Some(system) = audit_system() {
+        system.close().await
+    } else {
+        warn!("Audit system not initialized, cannot stop");
+        Ok(())
+    }
+}
+
+/// Pause the global audit system
+pub async fn pause_audit_system() -> AuditResult<()> {
+    if let Some(system) = audit_system() {
+        system.pause().await
+    } else {
+        warn!("Audit system not initialized, cannot pause");
+        Ok(())
+    }
+}
+
+/// Resume the global audit system
+pub async fn resume_audit_system() -> AuditResult<()> {
+    if let Some(system) = audit_system() {
+        system.resume().await
+    } else {
+        warn!("Audit system not initialized, cannot resume");
+        Ok(())
+    }
+}
+
+/// Dispatch an audit log entry to all targets
+pub async fn dispatch_audit_log(entry: Arc<AuditEntry>) -> AuditResult<()> {
+    if let Some(system) = audit_system() {
+        if system.is_running().await {
+            system.dispatch(entry).await
+        } else {
+            // System not running, just drop the log entry without error
+            Ok(())
+        }
+    } else {
+        // System not initialized, just drop the log entry without error
+        Ok(())
+    }
+}
+
+/// Reload the global audit system configuration
+pub async fn reload_audit_config(config: Config) -> AuditResult<()> {
+    if let Some(system) = audit_system() {
+        system.reload_config(config).await
+    } else {
+        warn!("Audit system not initialized, cannot reload config");
+        Ok(())
+    }
+}
+
+/// Check if the global audit system is running
+pub async fn is_audit_system_running() -> bool {
+    if let Some(system) = audit_system() {
+        system.is_running().await
+    } else {
+        false
+    }
+}
+
+/// AuditLogger singleton for easy access
+pub struct AuditLogger;
+
+impl AuditLogger {
+    /// Log an audit entry
+    pub async fn log(entry: AuditEntry) {
+        if let Err(e) = dispatch_audit_log(Arc::new(entry)).await {
+            error!(error = %e, "Failed to dispatch audit log entry");
+        }
+    }
+
+    /// Check if audit logging is enabled
+    pub async fn is_enabled() -> bool {
+        is_audit_system_running().await
+    }
+
+    /// Get singleton instance
+    pub fn instance() -> &'static Self {
+        static INSTANCE: AuditLogger = AuditLogger;
+        &INSTANCE
+    }
+}

crates/audit/src/lib.rs

@@ -0,0 +1,33 @@
+//  Copyright 2024 RustFS Team
+//
+//  Licensed under the Apache License, Version 2.0 (the "License");
+//  you may not use this file except in compliance with the License.
+//  You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+//  Unless required by applicable law or agreed to in writing, software
+//  distributed under the License is distributed on an "AS IS" BASIS,
+//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+//  See the License for the specific language governing permissions and
+//  limitations under the License.
+
+//! RustFS Audit System
+//!
+//! This crate provides a comprehensive audit logging system with multi-target fan-out capabilities,
+//! configuration management, and hot reload functionality. It is modeled after the notify system
+//! but specifically designed for audit logging requirements.
+
+pub mod entity;
+pub mod error;
+pub mod global;
+pub mod observability;
+pub mod registry;
+pub mod system;
+
+pub use entity::{ApiDetails, AuditEntry, LogRecord, ObjectVersion};
+pub use error::{AuditError, AuditResult};
+pub use global::*;
+pub use observability::{AuditMetrics, AuditMetricsReport, PerformanceValidation};
+pub use registry::AuditRegistry;
+pub use system::AuditSystem;

crates/audit/src/observability.rs

@@ -0,0 +1,365 @@
+//  Copyright 2024 RustFS Team
+//
+//  Licensed under the Apache License, Version 2.0 (the "License");
+//  you may not use this file except in compliance with the License.
+//  You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+//  Unless required by applicable law or agreed to in writing, software
+//  distributed under the License is distributed on an "AS IS" BASIS,
+//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+//  See the License for the specific language governing permissions and
+//  limitations under the License.
+
+//! Observability and metrics for the audit system
+//!
+//! This module provides comprehensive observability features including:
+//! - Performance metrics (EPS, latency)
+//! - Target health monitoring  
+//! - Configuration change tracking
+//! - Error rate monitoring
+//! - Queue depth monitoring
+
+use std::sync::atomic::{AtomicU64, Ordering};
+use std::sync::{Arc, OnceLock};
+use std::time::{Duration, Instant};
+use tokio::sync::RwLock;
+use tracing::info;
+
+/// Metrics collector for audit system observability
+#[derive(Debug)]
+pub struct AuditMetrics {
+    // Performance metrics
+    total_events_processed: AtomicU64,
+    total_events_failed: AtomicU64,
+    total_dispatch_time_ns: AtomicU64,
+
+    // Target metrics
+    target_success_count: AtomicU64,
+    target_failure_count: AtomicU64,
+
+    // System metrics
+    config_reload_count: AtomicU64,
+    system_start_count: AtomicU64,
+
+    // Performance tracking
+    last_reset_time: Arc<RwLock<Instant>>,
+}
+
+impl Default for AuditMetrics {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
+impl AuditMetrics {
+    /// Creates a new metrics collector
+    pub fn new() -> Self {
+        Self {
+            total_events_processed: AtomicU64::new(0),
+            total_events_failed: AtomicU64::new(0),
+            total_dispatch_time_ns: AtomicU64::new(0),
+            target_success_count: AtomicU64::new(0),
+            target_failure_count: AtomicU64::new(0),
+            config_reload_count: AtomicU64::new(0),
+            system_start_count: AtomicU64::new(0),
+            last_reset_time: Arc::new(RwLock::new(Instant::now())),
+        }
+    }
+
+    /// Records a successful event dispatch
+    pub fn record_event_success(&self, dispatch_time: Duration) {
+        self.total_events_processed.fetch_add(1, Ordering::Relaxed);
+        self.total_dispatch_time_ns
+            .fetch_add(dispatch_time.as_nanos() as u64, Ordering::Relaxed);
+    }
+
+    /// Records a failed event dispatch
+    pub fn record_event_failure(&self, dispatch_time: Duration) {
+        self.total_events_failed.fetch_add(1, Ordering::Relaxed);
+        self.total_dispatch_time_ns
+            .fetch_add(dispatch_time.as_nanos() as u64, Ordering::Relaxed);
+    }
+
+    /// Records a successful target operation
+    pub fn record_target_success(&self) {
+        self.target_success_count.fetch_add(1, Ordering::Relaxed);
+    }
+
+    /// Records a failed target operation
+    pub fn record_target_failure(&self) {
+        self.target_failure_count.fetch_add(1, Ordering::Relaxed);
+    }
+
+    /// Records a configuration reload
+    pub fn record_config_reload(&self) {
+        self.config_reload_count.fetch_add(1, Ordering::Relaxed);
+        info!("Audit configuration reloaded");
+    }
+
+    /// Records a system start
+    pub fn record_system_start(&self) {
+        self.system_start_count.fetch_add(1, Ordering::Relaxed);
+        info!("Audit system started");
+    }
+
+    /// Gets the current events per second (EPS)
+    pub async fn get_events_per_second(&self) -> f64 {
+        let reset_time = *self.last_reset_time.read().await;
+        let elapsed = reset_time.elapsed();
+        let total_events = self.total_events_processed.load(Ordering::Relaxed) + self.total_events_failed.load(Ordering::Relaxed);
+
+        if elapsed.as_secs_f64() > 0.0 {
+            total_events as f64 / elapsed.as_secs_f64()
+        } else {
+            0.0
+        }
+    }
+
+    /// Gets the average dispatch latency in milliseconds
+    pub fn get_average_latency_ms(&self) -> f64 {
+        let total_events = self.total_events_processed.load(Ordering::Relaxed) + self.total_events_failed.load(Ordering::Relaxed);
+        let total_time_ns = self.total_dispatch_time_ns.load(Ordering::Relaxed);
+
+        if total_events > 0 {
+            (total_time_ns as f64 / total_events as f64) / 1_000_000.0 // Convert ns to ms
+        } else {
+            0.0
+        }
+    }
+
+    /// Gets the error rate as a percentage
+    pub fn get_error_rate(&self) -> f64 {
+        let total_events = self.total_events_processed.load(Ordering::Relaxed) + self.total_events_failed.load(Ordering::Relaxed);
+        let failed_events = self.total_events_failed.load(Ordering::Relaxed);
+
+        if total_events > 0 {
+            (failed_events as f64 / total_events as f64) * 100.0
+        } else {
+            0.0
+        }
+    }
+
+    /// Gets target success rate as a percentage
+    pub fn get_target_success_rate(&self) -> f64 {
+        let total_ops = self.target_success_count.load(Ordering::Relaxed) + self.target_failure_count.load(Ordering::Relaxed);
+        let success_ops = self.target_success_count.load(Ordering::Relaxed);
+
+        if total_ops > 0 {
+            (success_ops as f64 / total_ops as f64) * 100.0
+        } else {
+            100.0 // No operations = 100% success rate
+        }
+    }
+
+    /// Resets all metrics and timing
+    pub async fn reset(&self) {
+        self.total_events_processed.store(0, Ordering::Relaxed);
+        self.total_events_failed.store(0, Ordering::Relaxed);
+        self.total_dispatch_time_ns.store(0, Ordering::Relaxed);
+        self.target_success_count.store(0, Ordering::Relaxed);
+        self.target_failure_count.store(0, Ordering::Relaxed);
+        self.config_reload_count.store(0, Ordering::Relaxed);
+        self.system_start_count.store(0, Ordering::Relaxed);
+
+        let mut reset_time = self.last_reset_time.write().await;
+        *reset_time = Instant::now();
+
+        info!("Audit metrics reset");
+    }
+
+    /// Generates a comprehensive metrics report
+    pub async fn generate_report(&self) -> AuditMetricsReport {
+        AuditMetricsReport {
+            events_per_second: self.get_events_per_second().await,
+            average_latency_ms: self.get_average_latency_ms(),
+            error_rate_percent: self.get_error_rate(),
+            target_success_rate_percent: self.get_target_success_rate(),
+            total_events_processed: self.total_events_processed.load(Ordering::Relaxed),
+            total_events_failed: self.total_events_failed.load(Ordering::Relaxed),
+            config_reload_count: self.config_reload_count.load(Ordering::Relaxed),
+            system_start_count: self.system_start_count.load(Ordering::Relaxed),
+        }
+    }
+
+    /// Validates performance requirements
+    pub async fn validate_performance_requirements(&self) -> PerformanceValidation {
+        let eps = self.get_events_per_second().await;
+        let avg_latency_ms = self.get_average_latency_ms();
+        let error_rate = self.get_error_rate();
+
+        let mut validation = PerformanceValidation {
+            meets_eps_requirement: eps >= 3000.0,
+            meets_latency_requirement: avg_latency_ms <= 30.0,
+            meets_error_rate_requirement: error_rate <= 1.0, // Less than 1% error rate
+            current_eps: eps,
+            current_latency_ms: avg_latency_ms,
+            current_error_rate: error_rate,
+            recommendations: Vec::new(),
+        };
+
+        // Generate recommendations
+        if !validation.meets_eps_requirement {
+            validation.recommendations.push(format!(
+                "EPS ({eps:.0}) is below requirement (3000). Consider optimizing target dispatch or adding more target instances."
+            ));
+        }
+
+        if !validation.meets_latency_requirement {
+            validation.recommendations.push(format!(
+                "Average latency ({avg_latency_ms:.2}ms) exceeds requirement (30ms). Consider optimizing target responses or increasing timeout values."
+            ));
+        }
+
+        if !validation.meets_error_rate_requirement {
+            validation.recommendations.push(format!(
+                "Error rate ({error_rate:.2}%) exceeds recommendation (1%). Check target connectivity and configuration."
+            ));
+        }
+
+        if validation.meets_eps_requirement && validation.meets_latency_requirement && validation.meets_error_rate_requirement {
+            validation
+                .recommendations
+                .push("All performance requirements are met.".to_string());
+        }
+
+        validation
+    }
+}
+
+/// Comprehensive metrics report
+#[derive(Debug, Clone)]
+pub struct AuditMetricsReport {
+    pub events_per_second: f64,
+    pub average_latency_ms: f64,
+    pub error_rate_percent: f64,
+    pub target_success_rate_percent: f64,
+    pub total_events_processed: u64,
+    pub total_events_failed: u64,
+    pub config_reload_count: u64,
+    pub system_start_count: u64,
+}
+
+impl AuditMetricsReport {
+    /// Formats the report as a human-readable string
+    pub fn format(&self) -> String {
+        format!(
+            "Audit System Metrics Report:\n\
+             Events per Second: {:.2}\n\
+             Average Latency: {:.2}ms\n\
+             Error Rate: {:.2}%\n\
+             Target Success Rate: {:.2}%\n\
+             Total Events Processed: {}\n\
+             Total Events Failed: {}\n\
+             Configuration Reloads: {}\n\
+             System Starts: {}",
+            self.events_per_second,
+            self.average_latency_ms,
+            self.error_rate_percent,
+            self.target_success_rate_percent,
+            self.total_events_processed,
+            self.total_events_failed,
+            self.config_reload_count,
+            self.system_start_count
+        )
+    }
+}
+
+/// Performance validation results
+#[derive(Debug, Clone)]
+pub struct PerformanceValidation {
+    pub meets_eps_requirement: bool,
+    pub meets_latency_requirement: bool,
+    pub meets_error_rate_requirement: bool,
+    pub current_eps: f64,
+    pub current_latency_ms: f64,
+    pub current_error_rate: f64,
+    pub recommendations: Vec<String>,
+}
+
+impl PerformanceValidation {
+    /// Checks if all performance requirements are met
+    pub fn all_requirements_met(&self) -> bool {
+        self.meets_eps_requirement && self.meets_latency_requirement && self.meets_error_rate_requirement
+    }
+
+    /// Formats the validation as a human-readable string
+    pub fn format(&self) -> String {
+        let status = if self.all_requirements_met() { "✅ PASS" } else { "❌ FAIL" };
+
+        let mut result = format!(
+            "Performance Requirements Validation: {}\n\
+             EPS Requirement (≥3000): {} ({:.2})\n\
+             Latency Requirement (≤30ms): {} ({:.2}ms)\n\
+             Error Rate Requirement (≤1%): {} ({:.2}%)\n\
+             \nRecommendations:",
+            status,
+            if self.meets_eps_requirement { "✅" } else { "❌" },
+            self.current_eps,
+            if self.meets_latency_requirement { "✅" } else { "❌" },
+            self.current_latency_ms,
+            if self.meets_error_rate_requirement { "✅" } else { "❌" },
+            self.current_error_rate
+        );
+
+        for rec in &self.recommendations {
+            result.push_str(&format!("\n• {rec}"));
+        }
+
+        result
+    }
+}
+
+/// Global metrics instance
+static GLOBAL_METRICS: OnceLock<Arc<AuditMetrics>> = OnceLock::new();
+
+/// Get or initialize the global metrics instance
+pub fn global_metrics() -> Arc<AuditMetrics> {
+    GLOBAL_METRICS.get_or_init(|| Arc::new(AuditMetrics::new())).clone()
+}
+
+/// Record a successful audit event dispatch
+pub fn record_audit_success(dispatch_time: Duration) {
+    global_metrics().record_event_success(dispatch_time);
+}
+
+/// Record a failed audit event dispatch
+pub fn record_audit_failure(dispatch_time: Duration) {
+    global_metrics().record_event_failure(dispatch_time);
+}
+
+/// Record a successful target operation
+pub fn record_target_success() {
+    global_metrics().record_target_success();
+}
+
+/// Record a failed target operation
+pub fn record_target_failure() {
+    global_metrics().record_target_failure();
+}
+
+/// Record a configuration reload
+pub fn record_config_reload() {
+    global_metrics().record_config_reload();
+}
+
+/// Record a system start
+pub fn record_system_start() {
+    global_metrics().record_system_start();
+}
+
+/// Get the current metrics report
+pub async fn get_metrics_report() -> AuditMetricsReport {
+    global_metrics().generate_report().await
+}
+
+/// Validate performance requirements
+pub async fn validate_performance() -> PerformanceValidation {
+    global_metrics().validate_performance_requirements().await
+}
+
+/// Reset all metrics
+pub async fn reset_metrics() {
+    global_metrics().reset().await;
+}

crates/audit/src/registry.rs

@@ -0,0 +1,482 @@
+//  Copyright 2024 RustFS Team
+//
+//  Licensed under the Apache License, Version 2.0 (the "License");
+//  you may not use this file except in compliance with the License.
+//  You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+//  Unless required by applicable law or agreed to in writing, software
+//  distributed under the License is distributed on an "AS IS" BASIS,
+//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+//  See the License for the specific language governing permissions and
+//  limitations under the License.
+
+use crate::{AuditEntry, AuditError, AuditResult};
+use futures::{StreamExt, stream::FuturesUnordered};
+use rustfs_config::{
+    DEFAULT_DELIMITER, ENABLE_KEY, ENV_PREFIX, MQTT_BROKER, MQTT_KEEP_ALIVE_INTERVAL, MQTT_PASSWORD, MQTT_QOS, MQTT_QUEUE_DIR,
+    MQTT_QUEUE_LIMIT, MQTT_RECONNECT_INTERVAL, MQTT_TOPIC, MQTT_USERNAME, WEBHOOK_AUTH_TOKEN, WEBHOOK_BATCH_SIZE,
+    WEBHOOK_CLIENT_CERT, WEBHOOK_CLIENT_KEY, WEBHOOK_ENDPOINT, WEBHOOK_HTTP_TIMEOUT, WEBHOOK_MAX_RETRY, WEBHOOK_QUEUE_DIR,
+    WEBHOOK_QUEUE_LIMIT, WEBHOOK_RETRY_INTERVAL, audit::AUDIT_ROUTE_PREFIX,
+};
+use rustfs_ecstore::config::{Config, KVS};
+use rustfs_targets::{
+    Target, TargetError,
+    target::{ChannelTargetType, TargetType, mqtt::MQTTArgs, webhook::WebhookArgs},
+};
+use std::collections::{HashMap, HashSet};
+use std::sync::Arc;
+use std::time::Duration;
+use tracing::{debug, error, info, warn};
+use url::Url;
+
+/// Registry for managing audit targets
+pub struct AuditRegistry {
+    /// Storage for created targets
+    targets: HashMap<String, Box<dyn Target<AuditEntry> + Send + Sync>>,
+}
+
+impl Default for AuditRegistry {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
+impl AuditRegistry {
+    /// Creates a new AuditRegistry
+    pub fn new() -> Self {
+        Self { targets: HashMap::new() }
+    }
+
+    /// Creates all audit targets from system configuration and environment variables.
+    /// This method processes the creation of each target concurrently as follows:
+    /// 1. Iterate through supported target types (webhook, mqtt).
+    /// 2. For each type, resolve its configuration from file and environment variables.
+    /// 3. Identify all target instance IDs that need to be created.
+    /// 4. Merge configurations with precedence: ENV > file instance > file default.
+    /// 5. Create async tasks for enabled instances.
+    /// 6. Execute tasks concurrently and collect successful targets.
+    /// 7. Persist successful configurations back to system storage.
+    pub async fn create_targets_from_config(
+        &mut self,
+        config: &Config,
+    ) -> AuditResult<Vec<Box<dyn Target<AuditEntry> + Send + Sync>>> {
+        // Collect only environment variables with the relevant prefix to reduce memory usage
+        let all_env: Vec<(String, String)> = std::env::vars().filter(|(key, _)| key.starts_with(ENV_PREFIX)).collect();
+
+        // A collection of asynchronous tasks for concurrently executing target creation
+        let mut tasks = FuturesUnordered::new();
+        // let final_config = config.clone();
+
+        // Record the defaults for each segment so that the segment can eventually be rebuilt
+        let mut section_defaults: HashMap<String, KVS> = HashMap::new();
+
+        // Supported target types for audit
+        let target_types = vec![ChannelTargetType::Webhook.as_str(), ChannelTargetType::Mqtt.as_str()];
+
+        // 1. Traverse all target types and process them
+        for target_type in target_types {
+            let span = tracing::Span::current();
+            span.record("target_type", target_type);
+            info!(target_type = %target_type, "Starting audit target type processing");
+
+            // 2. Prepare the configuration source
+            let section_name = format!("{AUDIT_ROUTE_PREFIX}{target_type}").to_lowercase();
+            let file_configs = config.0.get(&section_name).cloned().unwrap_or_default();
+            let default_cfg = file_configs.get(DEFAULT_DELIMITER).cloned().unwrap_or_default();
+            debug!(?default_cfg, "Retrieved default configuration");
+
+            // Save defaults for eventual write back
+            section_defaults.insert(section_name.clone(), default_cfg.clone());
+
+            // Get valid fields for the target type
+            let valid_fields = match target_type {
+                "webhook" => get_webhook_valid_fields(),
+                "mqtt" => get_mqtt_valid_fields(),
+                _ => {
+                    warn!(target_type = %target_type, "Unknown target type, skipping");
+                    continue;
+                }
+            };
+            debug!(?valid_fields, "Retrieved valid configuration fields");
+
+            // 3. Resolve instance IDs and configuration overrides from environment variables
+            let mut instance_ids_from_env = HashSet::new();
+            let mut env_overrides: HashMap<String, HashMap<String, String>> = HashMap::new();
+
+            for (env_key, env_value) in &all_env {
+                let audit_prefix = format!("{ENV_PREFIX}{AUDIT_ROUTE_PREFIX}{target_type}").to_uppercase();
+                if !env_key.starts_with(&audit_prefix) {
+                    continue;
+                }
+
+                let suffix = &env_key[audit_prefix.len()..];
+                if suffix.is_empty() {
+                    continue;
+                }
+
+                // Parse field and instance from suffix (FIELD_INSTANCE or FIELD)
+                let (field_name, instance_id) = if let Some(last_underscore) = suffix.rfind('_') {
+                    let potential_field = &suffix[1..last_underscore]; // Skip leading _
+                    let potential_instance = &suffix[last_underscore + 1..];
+
+                    // Check if the part before the last underscore is a valid field
+                    if valid_fields.contains(&potential_field.to_lowercase()) {
+                        (potential_field.to_lowercase(), potential_instance.to_lowercase())
+                    } else {
+                        // Treat the entire suffix as field name with default instance
+                        (suffix[1..].to_lowercase(), DEFAULT_DELIMITER.to_string())
+                    }
+                } else {
+                    // No underscore, treat as field with default instance
+                    (suffix[1..].to_lowercase(), DEFAULT_DELIMITER.to_string())
+                };
+
+                if valid_fields.contains(&field_name) {
+                    if instance_id != DEFAULT_DELIMITER {
+                        instance_ids_from_env.insert(instance_id.clone());
+                    }
+                    env_overrides
+                        .entry(instance_id)
+                        .or_default()
+                        .insert(field_name, env_value.clone());
+                } else {
+                    debug!(
+                        env_key = %env_key,
+                        field_name = %field_name,
+                        "Ignoring environment variable field not found in valid fields for target type {}",
+                        target_type
+                    );
+                }
+            }
+            debug!(?env_overrides, "Completed environment variable analysis");
+
+            // 4. Determine all instance IDs that need to be processed
+            let mut all_instance_ids: HashSet<String> =
+                file_configs.keys().filter(|k| *k != DEFAULT_DELIMITER).cloned().collect();
+            all_instance_ids.extend(instance_ids_from_env);
+            debug!(?all_instance_ids, "Determined all instance IDs");
+
+            // 5. Merge configurations and create tasks for each instance
+            for id in all_instance_ids {
+                // 5.1. Merge configuration, priority: Environment variables > File instance > File default
+                let mut merged_config = default_cfg.clone();
+
+                // Apply file instance configuration if available
+                if let Some(file_instance_cfg) = file_configs.get(&id) {
+                    merged_config.extend(file_instance_cfg.clone());
+                }
+
+                // Apply environment variable overrides
+                if let Some(env_instance_cfg) = env_overrides.get(&id) {
+                    let mut kvs_from_env = KVS::new();
+                    for (k, v) in env_instance_cfg {
+                        kvs_from_env.insert(k.clone(), v.clone());
+                    }
+                    merged_config.extend(kvs_from_env);
+                }
+                debug!(instance_id = %id, ?merged_config, "Completed configuration merge");
+
+                // 5.2. Check if the instance is enabled
+                let enabled = merged_config
+                    .lookup(ENABLE_KEY)
+                    .map(|v| parse_enable_value(&v))
+                    .unwrap_or(false);
+
+                if enabled {
+                    info!(instance_id = %id, "Creating audit target");
+
+                    // Create task for concurrent execution
+                    let target_type_clone = target_type.to_string();
+                    let id_clone = id.clone();
+                    let merged_config_arc = Arc::new(merged_config.clone());
+                    let task = tokio::spawn(async move {
+                        let result = create_audit_target(&target_type_clone, &id_clone, &merged_config_arc).await;
+                        (target_type_clone, id_clone, result, merged_config_arc)
+                    });
+
+                    tasks.push(task);
+
+                    // Update final config with successful instance
+                    // final_config.0.entry(section_name.clone()).or_default().insert(id, merged_config);
+                } else {
+                    info!(instance_id = %id, "Skipping disabled audit target, will be removed from final configuration");
+                    // Remove disabled target from final configuration
+                    // final_config.0.entry(section_name.clone()).or_default().remove(&id);
+                }
+            }
+        }
+
+        // 6. Concurrently execute all creation tasks and collect results
+        let mut successful_targets = Vec::new();
+        let mut successful_configs = Vec::new();
+        while let Some(task_result) = tasks.next().await {
+            match task_result {
+                Ok((target_type, id, result, kvs_arc)) => match result {
+                    Ok(target) => {
+                        info!(target_type = %target_type, instance_id = %id, "Created audit target successfully");
+                        successful_targets.push(target);
+                        successful_configs.push((target_type, id, kvs_arc));
+                    }
+                    Err(e) => {
+                        error!(target_type = %target_type, instance_id = %id, error = %e, "Failed to create audit target");
+                    }
+                },
+                Err(e) => {
+                    error!(error = %e, "Task execution failed");
+                }
+            }
+        }
+
+        // Rebuild in pieces based on "default items + successful instances" and overwrite writeback to ensure that deleted/disabled instances will not be "resurrected"
+        if !successful_configs.is_empty() || !section_defaults.is_empty() {
+            info!("Prepare to rebuild and save target configurations to the system configuration...");
+
+            // Aggregate successful instances into segments
+            let mut successes_by_section: HashMap<String, HashMap<String, KVS>> = HashMap::new();
+            for (target_type, id, kvs) in successful_configs {
+                let section_name = format!("{AUDIT_ROUTE_PREFIX}{target_type}").to_lowercase();
+                successes_by_section
+                    .entry(section_name)
+                    .or_default()
+                    .insert(id.to_lowercase(), (*kvs).clone());
+            }
+
+            let mut new_config = config.clone();
+
+            // Collection of segments that need to be processed: Collect all segments where default items exist or where successful instances exist
+            let mut sections: HashSet<String> = HashSet::new();
+            sections.extend(section_defaults.keys().cloned());
+            sections.extend(successes_by_section.keys().cloned());
+
+            for section_name in sections {
+                let mut section_map: HashMap<String, KVS> = HashMap::new();
+
+                // The default entry (if present) is written back to `_`
+                if let Some(default_cfg) = section_defaults.get(&section_name) {
+                    if !default_cfg.is_empty() {
+                        section_map.insert(DEFAULT_DELIMITER.to_string(), default_cfg.clone());
+                    }
+                }
+
+                // Successful instance write back
+                if let Some(instances) = successes_by_section.get(&section_name) {
+                    for (id, kvs) in instances {
+                        section_map.insert(id.clone(), kvs.clone());
+                    }
+                }
+
+                // Empty segments are removed and non-empty segments are replaced as a whole.
+                if section_map.is_empty() {
+                    new_config.0.remove(&section_name);
+                } else {
+                    new_config.0.insert(section_name, section_map);
+                }
+            }
+
+            // 7. Save the new configuration to the system
+            let Some(store) = rustfs_ecstore::new_object_layer_fn() else {
+                return Err(AuditError::ServerNotInitialized(
+                    "Failed to save target configuration: server storage not initialized".to_string(),
+                ));
+            };
+
+            match rustfs_ecstore::config::com::save_server_config(store, &new_config).await {
+                Ok(_) => info!("New audit configuration saved to system successfully"),
+                Err(e) => {
+                    error!(error = %e, "Failed to save new audit configuration");
+                    return Err(AuditError::SaveConfig(e.to_string()));
+                }
+            }
+        }
+        Ok(successful_targets)
+    }
+
+    /// Adds a target to the registry
+    pub fn add_target(&mut self, id: String, target: Box<dyn Target<AuditEntry> + Send + Sync>) {
+        self.targets.insert(id, target);
+    }
+
+    /// Removes a target from the registry
+    pub fn remove_target(&mut self, id: &str) -> Option<Box<dyn Target<AuditEntry> + Send + Sync>> {
+        self.targets.remove(id)
+    }
+
+    /// Gets a target from the registry
+    pub fn get_target(&self, id: &str) -> Option<&(dyn Target<AuditEntry> + Send + Sync)> {
+        self.targets.get(id).map(|t| t.as_ref())
+    }
+
+    /// Lists all target IDs
+    pub fn list_targets(&self) -> Vec<String> {
+        self.targets.keys().cloned().collect()
+    }
+
+    /// Closes all targets and clears the registry
+    pub async fn close_all(&mut self) -> AuditResult<()> {
+        let mut errors = Vec::new();
+
+        for (id, target) in self.targets.drain() {
+            if let Err(e) = target.close().await {
+                error!(target_id = %id, error = %e, "Failed to close audit target");
+                errors.push(e);
+            }
+        }
+
+        if !errors.is_empty() {
+            return Err(AuditError::Target(errors.into_iter().next().unwrap()));
+        }
+
+        Ok(())
+    }
+}
+
+/// Creates an audit target based on type and configuration
+async fn create_audit_target(
+    target_type: &str,
+    id: &str,
+    config: &KVS,
+) -> Result<Box<dyn Target<AuditEntry> + Send + Sync>, TargetError> {
+    match target_type {
+        val if val == ChannelTargetType::Webhook.as_str() => {
+            let args = parse_webhook_args(id, config)?;
+            let target = rustfs_targets::target::webhook::WebhookTarget::new(id.to_string(), args)?;
+            Ok(Box::new(target))
+        }
+        val if val == ChannelTargetType::Mqtt.as_str() => {
+            let args = parse_mqtt_args(id, config)?;
+            let target = rustfs_targets::target::mqtt::MQTTTarget::new(id.to_string(), args)?;
+            Ok(Box::new(target))
+        }
+        _ => Err(TargetError::Configuration(format!("Unknown target type: {target_type}"))),
+    }
+}
+
+/// Gets valid field names for webhook configuration
+fn get_webhook_valid_fields() -> HashSet<String> {
+    vec![
+        ENABLE_KEY.to_string(),
+        WEBHOOK_ENDPOINT.to_string(),
+        WEBHOOK_AUTH_TOKEN.to_string(),
+        WEBHOOK_CLIENT_CERT.to_string(),
+        WEBHOOK_CLIENT_KEY.to_string(),
+        WEBHOOK_BATCH_SIZE.to_string(),
+        WEBHOOK_QUEUE_LIMIT.to_string(),
+        WEBHOOK_QUEUE_DIR.to_string(),
+        WEBHOOK_MAX_RETRY.to_string(),
+        WEBHOOK_RETRY_INTERVAL.to_string(),
+        WEBHOOK_HTTP_TIMEOUT.to_string(),
+    ]
+    .into_iter()
+    .collect()
+}
+
+/// Gets valid field names for MQTT configuration
+fn get_mqtt_valid_fields() -> HashSet<String> {
+    vec![
+        ENABLE_KEY.to_string(),
+        MQTT_BROKER.to_string(),
+        MQTT_TOPIC.to_string(),
+        MQTT_USERNAME.to_string(),
+        MQTT_PASSWORD.to_string(),
+        MQTT_QOS.to_string(),
+        MQTT_KEEP_ALIVE_INTERVAL.to_string(),
+        MQTT_RECONNECT_INTERVAL.to_string(),
+        MQTT_QUEUE_DIR.to_string(),
+        MQTT_QUEUE_LIMIT.to_string(),
+    ]
+    .into_iter()
+    .collect()
+}
+
+/// Parses webhook arguments from KVS configuration
+fn parse_webhook_args(_id: &str, config: &KVS) -> Result<WebhookArgs, TargetError> {
+    let endpoint = config
+        .lookup(WEBHOOK_ENDPOINT)
+        .filter(|s| !s.is_empty())
+        .ok_or_else(|| TargetError::Configuration("webhook endpoint is required".to_string()))?;
+
+    let endpoint_url =
+        Url::parse(&endpoint).map_err(|e| TargetError::Configuration(format!("invalid webhook endpoint URL: {e}")))?;
+
+    let args = WebhookArgs {
+        enable: true, // Already validated as enabled
+        endpoint: endpoint_url,
+        auth_token: config.lookup(WEBHOOK_AUTH_TOKEN).unwrap_or_default(),
+        queue_dir: config.lookup(WEBHOOK_QUEUE_DIR).unwrap_or_default(),
+        queue_limit: config
+            .lookup(WEBHOOK_QUEUE_LIMIT)
+            .and_then(|s| s.parse().ok())
+            .unwrap_or(100000),
+        client_cert: config.lookup(WEBHOOK_CLIENT_CERT).unwrap_or_default(),
+        client_key: config.lookup(WEBHOOK_CLIENT_KEY).unwrap_or_default(),
+        target_type: TargetType::AuditLog,
+    };
+
+    args.validate()?;
+    Ok(args)
+}
+
+/// Parses MQTT arguments from KVS configuration  
+fn parse_mqtt_args(_id: &str, config: &KVS) -> Result<MQTTArgs, TargetError> {
+    let broker = config
+        .lookup(MQTT_BROKER)
+        .filter(|s| !s.is_empty())
+        .ok_or_else(|| TargetError::Configuration("MQTT broker is required".to_string()))?;
+
+    let broker_url = Url::parse(&broker).map_err(|e| TargetError::Configuration(format!("invalid MQTT broker URL: {e}")))?;
+
+    let topic = config
+        .lookup(MQTT_TOPIC)
+        .filter(|s| !s.is_empty())
+        .ok_or_else(|| TargetError::Configuration("MQTT topic is required".to_string()))?;
+
+    let qos = config
+        .lookup(MQTT_QOS)
+        .and_then(|s| s.parse::<u8>().ok())
+        .and_then(|q| match q {
+            0 => Some(rumqttc::QoS::AtMostOnce),
+            1 => Some(rumqttc::QoS::AtLeastOnce),
+            2 => Some(rumqttc::QoS::ExactlyOnce),
+            _ => None,
+        })
+        .unwrap_or(rumqttc::QoS::AtLeastOnce);
+
+    let args = MQTTArgs {
+        enable: true, // Already validated as enabled
+        broker: broker_url,
+        topic,
+        qos,
+        username: config.lookup(MQTT_USERNAME).unwrap_or_default(),
+        password: config.lookup(MQTT_PASSWORD).unwrap_or_default(),
+        max_reconnect_interval: parse_duration(&config.lookup(MQTT_RECONNECT_INTERVAL).unwrap_or_else(|| "5s".to_string()))
+            .unwrap_or(Duration::from_secs(5)),
+        keep_alive: parse_duration(&config.lookup(MQTT_KEEP_ALIVE_INTERVAL).unwrap_or_else(|| "60s".to_string()))
+            .unwrap_or(Duration::from_secs(60)),
+        queue_dir: config.lookup(MQTT_QUEUE_DIR).unwrap_or_default(),
+        queue_limit: config.lookup(MQTT_QUEUE_LIMIT).and_then(|s| s.parse().ok()).unwrap_or(100000),
+        target_type: TargetType::AuditLog,
+    };
+
+    args.validate()?;
+    Ok(args)
+}
+
+/// Parses enable value from string
+fn parse_enable_value(value: &str) -> bool {
+    matches!(value.to_lowercase().as_str(), "1" | "on" | "true" | "yes")
+}
+
+/// Parses duration from string (e.g., "3s", "5m")
+fn parse_duration(s: &str) -> Option<Duration> {
+    if let Some(stripped) = s.strip_suffix('s') {
+        stripped.parse::<u64>().ok().map(Duration::from_secs)
+    } else if let Some(stripped) = s.strip_suffix('m') {
+        stripped.parse::<u64>().ok().map(|m| Duration::from_secs(m * 60))
+    } else if let Some(stripped) = s.strip_suffix("ms") {
+        stripped.parse::<u64>().ok().map(Duration::from_millis)
+    } else {
+        s.parse::<u64>().ok().map(Duration::from_secs)
+    }
+}

crates/audit/src/system.rs

@@ -0,0 +1,600 @@
+//  Copyright 2024 RustFS Team
+//
+//  Licensed under the Apache License, Version 2.0 (the "License");
+//  you may not use this file except in compliance with the License.
+//  You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+//  Unless required by applicable law or agreed to in writing, software
+//  distributed under the License is distributed on an "AS IS" BASIS,
+//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+//  See the License for the specific language governing permissions and
+//  limitations under the License.
+
+use crate::{AuditEntry, AuditError, AuditRegistry, AuditResult, observability};
+use rustfs_ecstore::config::Config;
+use rustfs_targets::{
+    StoreError, Target, TargetError,
+    store::{Key, Store},
+    target::EntityTarget,
+};
+use std::sync::Arc;
+use tokio::sync::{Mutex, RwLock};
+use tracing::{error, info, warn};
+
+/// State of the audit system
+#[derive(Debug, Clone, PartialEq, Eq)]
+pub enum AuditSystemState {
+    Stopped,
+    Starting,
+    Running,
+    Paused,
+    Stopping,
+}
+
+/// Main audit system that manages target lifecycle and audit log dispatch
+#[derive(Clone)]
+pub struct AuditSystem {
+    registry: Arc<Mutex<AuditRegistry>>,
+    state: Arc<RwLock<AuditSystemState>>,
+    config: Arc<RwLock<Option<Config>>>,
+}
+
+impl Default for AuditSystem {
+    fn default() -> Self {
+        Self::new()
+    }
+}
+
+impl AuditSystem {
+    /// Creates a new audit system
+    pub fn new() -> Self {
+        Self {
+            registry: Arc::new(Mutex::new(AuditRegistry::new())),
+            state: Arc::new(RwLock::new(AuditSystemState::Stopped)),
+            config: Arc::new(RwLock::new(None)),
+        }
+    }
+
+    /// Starts the audit system with the given configuration
+    pub async fn start(&self, config: Config) -> AuditResult<()> {
+        let mut state = self.state.write().await;
+
+        match *state {
+            AuditSystemState::Running => {
+                return Err(AuditError::AlreadyInitialized);
+            }
+            AuditSystemState::Starting => {
+                warn!("Audit system is already starting");
+                return Ok(());
+            }
+            _ => {}
+        }
+
+        *state = AuditSystemState::Starting;
+        drop(state);
+
+        info!("Starting audit system");
+
+        // Record system start
+        observability::record_system_start();
+
+        // Store configuration
+        {
+            let mut config_guard = self.config.write().await;
+            *config_guard = Some(config.clone());
+        }
+
+        // Create targets from configuration
+        let mut registry = self.registry.lock().await;
+        match registry.create_targets_from_config(&config).await {
+            Ok(targets) => {
+                info!(target_count = targets.len(), "Created audit targets successfully");
+
+                // Initialize all targets
+                for target in targets {
+                    let target_id = target.id().to_string();
+                    if let Err(e) = target.init().await {
+                        error!(target_id = %target_id, error = %e, "Failed to initialize audit target");
+                    } else {
+                        // After successful initialization, if enabled and there is a store, start the send from storage task
+                        if target.is_enabled() {
+                            if let Some(store) = target.store() {
+                                info!(target_id = %target_id, "Start audit stream processing for target");
+                                let store_clone: Box<dyn Store<EntityTarget<AuditEntry>, Error = StoreError, Key = Key> + Send> =
+                                    store.boxed_clone();
+                                let target_arc: Arc<dyn Target<AuditEntry> + Send + Sync> = Arc::from(target.clone_dyn());
+                                self.start_audit_stream_with_batching(store_clone, target_arc);
+                                info!(target_id = %target_id, "Audit stream processing started");
+                            } else {
+                                info!(target_id = %target_id, "No store configured, skip audit stream processing");
+                            }
+                        } else {
+                            info!(target_id = %target_id, "Target disabled, skip audit stream processing");
+                        }
+                        registry.add_target(target_id, target);
+                    }
+                }
+
+                // Update state to running
+                let mut state = self.state.write().await;
+                *state = AuditSystemState::Running;
+                info!("Audit system started successfully");
+                Ok(())
+            }
+            Err(e) => {
+                error!(error = %e, "Failed to create audit targets");
+                let mut state = self.state.write().await;
+                *state = AuditSystemState::Stopped;
+                Err(e)
+            }
+        }
+    }
+
+    /// Pauses the audit system
+    pub async fn pause(&self) -> AuditResult<()> {
+        let mut state = self.state.write().await;
+
+        match *state {
+            AuditSystemState::Running => {
+                *state = AuditSystemState::Paused;
+                info!("Audit system paused");
+                Ok(())
+            }
+            AuditSystemState::Paused => {
+                warn!("Audit system is already paused");
+                Ok(())
+            }
+            _ => Err(AuditError::Configuration("Cannot pause audit system in current state".to_string())),
+        }
+    }
+
+    /// Resumes the audit system
+    pub async fn resume(&self) -> AuditResult<()> {
+        let mut state = self.state.write().await;
+
+        match *state {
+            AuditSystemState::Paused => {
+                *state = AuditSystemState::Running;
+                info!("Audit system resumed");
+                Ok(())
+            }
+            AuditSystemState::Running => {
+                warn!("Audit system is already running");
+                Ok(())
+            }
+            _ => Err(AuditError::Configuration("Cannot resume audit system in current state".to_string())),
+        }
+    }
+
+    /// Stops the audit system and closes all targets
+    pub async fn close(&self) -> AuditResult<()> {
+        let mut state = self.state.write().await;
+
+        match *state {
+            AuditSystemState::Stopped => {
+                warn!("Audit system is already stopped");
+                return Ok(());
+            }
+            AuditSystemState::Stopping => {
+                warn!("Audit system is already stopping");
+                return Ok(());
+            }
+            _ => {}
+        }
+
+        *state = AuditSystemState::Stopping;
+        drop(state);
+
+        info!("Stopping audit system");
+
+        // Close all targets
+        let mut registry = self.registry.lock().await;
+        if let Err(e) = registry.close_all().await {
+            error!(error = %e, "Failed to close some audit targets");
+        }
+
+        // Update state to stopped
+        let mut state = self.state.write().await;
+        *state = AuditSystemState::Stopped;
+
+        // Clear configuration
+        let mut config_guard = self.config.write().await;
+        *config_guard = None;
+
+        info!("Audit system stopped");
+        Ok(())
+    }
+
+    /// Gets the current state of the audit system
+    pub async fn get_state(&self) -> AuditSystemState {
+        self.state.read().await.clone()
+    }
+
+    /// Checks if the audit system is running
+    pub async fn is_running(&self) -> bool {
+        matches!(*self.state.read().await, AuditSystemState::Running)
+    }
+
+    /// Dispatches an audit log entry to all active targets
+    pub async fn dispatch(&self, entry: Arc<AuditEntry>) -> AuditResult<()> {
+        let start_time = std::time::Instant::now();
+
+        let state = self.state.read().await;
+
+        match *state {
+            AuditSystemState::Running => {
+                // Continue with dispatch
+                info!("Dispatching audit log entry");
+            }
+            AuditSystemState::Paused => {
+                // Skip dispatch when paused
+                return Ok(());
+            }
+            _ => {
+                // Don't dispatch when not running
+                return Err(AuditError::NotInitialized("Audit system is not running".to_string()));
+            }
+        }
+        drop(state);
+
+        let registry = self.registry.lock().await;
+        let target_ids = registry.list_targets();
+
+        if target_ids.is_empty() {
+            warn!("No audit targets configured for dispatch");
+            return Ok(());
+        }
+
+        // Dispatch to all targets concurrently
+        let mut tasks = Vec::new();
+
+        for target_id in target_ids {
+            if let Some(target) = registry.get_target(&target_id) {
+                let entry_clone = Arc::clone(&entry);
+                let target_id_clone = target_id.clone();
+
+                // Create EntityTarget for the audit log entry
+                let entity_target = EntityTarget {
+                    object_name: entry.api.name.clone().unwrap_or_default(),
+                    bucket_name: entry.api.bucket.clone().unwrap_or_default(),
+                    event_name: rustfs_targets::EventName::ObjectCreatedPut, // Default, should be derived from entry
+                    data: (*entry_clone).clone(),
+                };
+
+                let task = async move {
+                    let result = target.save(Arc::new(entity_target)).await;
+                    (target_id_clone, result)
+                };
+
+                tasks.push(task);
+            }
+        }
+
+        // Execute all dispatch tasks
+        let results = futures::future::join_all(tasks).await;
+
+        let mut errors = Vec::new();
+        let mut success_count = 0;
+
+        for (target_id, result) in results {
+            match result {
+                Ok(_) => {
+                    success_count += 1;
+                    observability::record_target_success();
+                }
+                Err(e) => {
+                    error!(target_id = %target_id, error = %e, "Failed to dispatch audit log to target");
+                    errors.push(e);
+                    observability::record_target_failure();
+                }
+            }
+        }
+
+        let dispatch_time = start_time.elapsed();
+
+        if errors.is_empty() {
+            observability::record_audit_success(dispatch_time);
+        } else {
+            observability::record_audit_failure(dispatch_time);
+            // Log errors but don't fail the entire dispatch
+            warn!(
+                error_count = errors.len(),
+                success_count = success_count,
+                "Some audit targets failed to receive log entry"
+            );
+        }
+
+        Ok(())
+    }
+
+    pub async fn dispatch_batch(&self, entries: Vec<Arc<AuditEntry>>) -> AuditResult<()> {
+        let start_time = std::time::Instant::now();
+
+        let state = self.state.read().await;
+        if *state != AuditSystemState::Running {
+            return Err(AuditError::NotInitialized("Audit system is not running".to_string()));
+        }
+        drop(state);
+
+        let registry = self.registry.lock().await;
+        let target_ids = registry.list_targets();
+
+        if target_ids.is_empty() {
+            warn!("No audit targets configured for batch dispatch");
+            return Ok(());
+        }
+
+        let mut tasks = Vec::new();
+        for target_id in target_ids {
+            if let Some(target) = registry.get_target(&target_id) {
+                let entries_clone: Vec<_> = entries.iter().map(Arc::clone).collect();
+                let target_id_clone = target_id.clone();
+
+                let task = async move {
+                    let mut success_count = 0;
+                    let mut errors = Vec::new();
+                    for entry in entries_clone {
+                        let entity_target = EntityTarget {
+                            object_name: entry.api.name.clone().unwrap_or_default(),
+                            bucket_name: entry.api.bucket.clone().unwrap_or_default(),
+                            event_name: rustfs_targets::EventName::ObjectCreatedPut,
+                            data: (*entry).clone(),
+                        };
+                        match target.save(Arc::new(entity_target)).await {
+                            Ok(_) => success_count += 1,
+                            Err(e) => errors.push(e),
+                        }
+                    }
+                    (target_id_clone, success_count, errors)
+                };
+                tasks.push(task);
+            }
+        }
+
+        let results = futures::future::join_all(tasks).await;
+        let mut total_success = 0;
+        let mut total_errors = 0;
+        for (_target_id, success_count, errors) in results {
+            total_success += success_count;
+            total_errors += errors.len();
+            for e in errors {
+                error!("Batch dispatch error: {:?}", e);
+            }
+        }
+
+        let dispatch_time = start_time.elapsed();
+        info!(
+            "Batch dispatched {} entries, success: {}, errors: {}, time: {:?}",
+            entries.len(),
+            total_success,
+            total_errors,
+            dispatch_time
+        );
+
+        Ok(())
+    }
+
+    // New: Audit flow background tasks, based on send_from_store, including retries and exponential backoffs
+    fn start_audit_stream_with_batching(
+        &self,
+        store: Box<dyn Store<EntityTarget<AuditEntry>, Error = StoreError, Key = Key> + Send>,
+        target: Arc<dyn Target<AuditEntry> + Send + Sync>,
+    ) {
+        let state = self.state.clone();
+
+        tokio::spawn(async move {
+            use std::time::Duration;
+            use tokio::time::sleep;
+
+            info!("Starting audit stream for target: {}", target.id());
+
+            const MAX_RETRIES: usize = 5;
+            const BASE_RETRY_DELAY: Duration = Duration::from_secs(2);
+
+            loop {
+                match *state.read().await {
+                    AuditSystemState::Running | AuditSystemState::Paused | AuditSystemState::Starting => {}
+                    _ => {
+                        info!("Audit stream stopped for target: {}", target.id());
+                        break;
+                    }
+                }
+
+                let keys: Vec<Key> = store.list();
+                if keys.is_empty() {
+                    sleep(Duration::from_millis(500)).await;
+                    continue;
+                }
+
+                for key in keys {
+                    let mut retries = 0usize;
+                    let mut success = false;
+
+                    while retries < MAX_RETRIES && !success {
+                        match target.send_from_store(key.clone()).await {
+                            Ok(_) => {
+                                info!("Successfully sent audit entry, target: {}, key: {}", target.id(), key.to_string());
+                                observability::record_target_success();
+                                success = true;
+                            }
+                            Err(e) => {
+                                match &e {
+                                    TargetError::NotConnected => {
+                                        warn!("Target {} not connected, retrying...", target.id());
+                                    }
+                                    TargetError::Timeout(_) => {
+                                        warn!("Timeout sending to target {}, retrying...", target.id());
+                                    }
+                                    _ => {
+                                        error!("Permanent error for target {}: {}", target.id(), e);
+                                        observability::record_target_failure();
+                                        break;
+                                    }
+                                }
+                                retries += 1;
+                                let backoff = BASE_RETRY_DELAY * (1 << retries);
+                                sleep(backoff).await;
+                            }
+                        }
+                    }
+
+                    if retries >= MAX_RETRIES && !success {
+                        warn!("Max retries exceeded for key {}, target: {}, skipping", key.to_string(), target.id());
+                        observability::record_target_failure();
+                    }
+                }
+
+                sleep(Duration::from_millis(100)).await;
+            }
+        });
+    }
+
+    /// Enables a specific target
+    pub async fn enable_target(&self, target_id: &str) -> AuditResult<()> {
+        // This would require storing enabled/disabled state per target
+        // For now, just check if target exists
+        let registry = self.registry.lock().await;
+        if registry.get_target(target_id).is_some() {
+            info!(target_id = %target_id, "Target enabled");
+            Ok(())
+        } else {
+            Err(AuditError::Configuration(format!("Target not found: {target_id}")))
+        }
+    }
+
+    /// Disables a specific target
+    pub async fn disable_target(&self, target_id: &str) -> AuditResult<()> {
+        // This would require storing enabled/disabled state per target
+        // For now, just check if target exists
+        let registry = self.registry.lock().await;
+        if registry.get_target(target_id).is_some() {
+            info!(target_id = %target_id, "Target disabled");
+            Ok(())
+        } else {
+            Err(AuditError::Configuration(format!("Target not found: {target_id}")))
+        }
+    }
+
+    /// Removes a target from the system
+    pub async fn remove_target(&self, target_id: &str) -> AuditResult<()> {
+        let mut registry = self.registry.lock().await;
+        if let Some(target) = registry.remove_target(target_id) {
+            if let Err(e) = target.close().await {
+                error!(target_id = %target_id, error = %e, "Failed to close removed target");
+            }
+            info!(target_id = %target_id, "Target removed");
+            Ok(())
+        } else {
+            Err(AuditError::Configuration(format!("Target not found: {target_id}")))
+        }
+    }
+
+    /// Updates or inserts a target
+    pub async fn upsert_target(&self, target_id: String, target: Box<dyn Target<AuditEntry> + Send + Sync>) -> AuditResult<()> {
+        let mut registry = self.registry.lock().await;
+
+        // Initialize the target
+        if let Err(e) = target.init().await {
+            return Err(AuditError::Target(e));
+        }
+
+        // Remove existing target if present
+        if let Some(old_target) = registry.remove_target(&target_id) {
+            if let Err(e) = old_target.close().await {
+                error!(target_id = %target_id, error = %e, "Failed to close old target during upsert");
+            }
+        }
+
+        registry.add_target(target_id.clone(), target);
+        info!(target_id = %target_id, "Target upserted");
+        Ok(())
+    }
+
+    /// Lists all targets
+    pub async fn list_targets(&self) -> Vec<String> {
+        let registry = self.registry.lock().await;
+        registry.list_targets()
+    }
+
+    /// Gets information about a specific target
+    pub async fn get_target(&self, target_id: &str) -> Option<String> {
+        let registry = self.registry.lock().await;
+        registry.get_target(target_id).map(|target| target.id().to_string())
+    }
+
+    /// Reloads configuration and updates targets
+    pub async fn reload_config(&self, new_config: Config) -> AuditResult<()> {
+        info!("Reloading audit system configuration");
+
+        // Record config reload
+        observability::record_config_reload();
+
+        // Store new configuration
+        {
+            let mut config_guard = self.config.write().await;
+            *config_guard = Some(new_config.clone());
+        }
+
+        // Close all existing targets
+        let mut registry = self.registry.lock().await;
+        if let Err(e) = registry.close_all().await {
+            error!(error = %e, "Failed to close existing targets during reload");
+        }
+
+        // Create new targets from updated configuration
+        match registry.create_targets_from_config(&new_config).await {
+            Ok(targets) => {
+                info!(target_count = targets.len(), "Reloaded audit targets successfully");
+
+                // Initialize all new targets
+                for target in targets {
+                    let target_id = target.id().to_string();
+                    if let Err(e) = target.init().await {
+                        error!(target_id = %target_id, error = %e, "Failed to initialize reloaded audit target");
+                    } else {
+                        // Same starts the storage stream after a heavy load
+                        if target.is_enabled() {
+                            if let Some(store) = target.store() {
+                                info!(target_id = %target_id, "Start audit stream processing for target (reload)");
+                                let store_clone: Box<dyn Store<EntityTarget<AuditEntry>, Error = StoreError, Key = Key> + Send> =
+                                    store.boxed_clone();
+                                let target_arc: Arc<dyn Target<AuditEntry> + Send + Sync> = Arc::from(target.clone_dyn());
+                                self.start_audit_stream_with_batching(store_clone, target_arc);
+                                info!(target_id = %target_id, "Audit stream processing started (reload)");
+                            } else {
+                                info!(target_id = %target_id, "No store configured, skip audit stream processing (reload)");
+                            }
+                        } else {
+                            info!(target_id = %target_id, "Target disabled, skip audit stream processing (reload)");
+                        }
+                        registry.add_target(target.id().to_string(), target);
+                    }
+                }
+
+                info!("Audit configuration reloaded successfully");
+                Ok(())
+            }
+            Err(e) => {
+                error!(error = %e, "Failed to reload audit configuration");
+                Err(e)
+            }
+        }
+    }
+
+    /// Gets current audit system metrics
+    pub async fn get_metrics(&self) -> observability::AuditMetricsReport {
+        observability::get_metrics_report().await
+    }
+
+    /// Validates system performance against requirements
+    pub async fn validate_performance(&self) -> observability::PerformanceValidation {
+        observability::validate_performance().await
+    }
+
+    /// Resets all metrics
+    pub async fn reset_metrics(&self) {
+        observability::reset_metrics().await;
+    }
+}

crates/audit/tests/config_parsing_test.rs

@@ -0,0 +1,219 @@
+//  Copyright 2024 RustFS Team
+//
+//  Licensed under the Apache License, Version 2.0 (the "License");
+//  you may not use this file except in compliance with the License.
+//  You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+//  Unless required by applicable law or agreed to in writing, software
+//  distributed under the License is distributed on an "AS IS" BASIS,
+//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+//  See the License for the specific language governing permissions and
+//  limitations under the License.
+
+//! Tests for audit configuration parsing and validation
+
+use rustfs_ecstore::config::KVS;
+
+#[test]
+fn test_webhook_valid_fields() {
+    let expected_fields = vec![
+        "enable",
+        "endpoint",
+        "auth_token",
+        "client_cert",
+        "client_key",
+        "batch_size",
+        "queue_size",
+        "queue_dir",
+        "max_retry",
+        "retry_interval",
+        "http_timeout",
+    ];
+
+    // This tests the webhook configuration fields we support
+    for field in expected_fields {
+        // Basic validation that field names are consistent
+        assert!(!field.is_empty());
+        assert!(!field.contains(" "));
+    }
+}
+
+#[test]
+fn test_mqtt_valid_fields() {
+    let expected_fields = vec![
+        "enable",
+        "broker",
+        "topic",
+        "username",
+        "password",
+        "qos",
+        "keep_alive_interval",
+        "reconnect_interval",
+        "queue_dir",
+        "queue_limit",
+    ];
+
+    // This tests the MQTT configuration fields we support
+    for field in expected_fields {
+        // Basic validation that field names are consistent
+        assert!(!field.is_empty());
+        assert!(!field.contains(" "));
+    }
+}
+
+#[test]
+fn test_config_section_names() {
+    // Test audit route prefix and section naming
+    let webhook_section = "audit_webhook";
+    let mqtt_section = "audit_mqtt";
+
+    assert_eq!(webhook_section, "audit_webhook");
+    assert_eq!(mqtt_section, "audit_mqtt");
+
+    // Verify section names follow expected pattern
+    assert!(webhook_section.starts_with("audit_"));
+    assert!(mqtt_section.starts_with("audit_"));
+}
+
+#[test]
+fn test_environment_variable_parsing() {
+    // Test environment variable prefix patterns
+    let env_prefix = "RUSTFS_";
+    let audit_webhook_prefix = format!("{env_prefix}AUDIT_WEBHOOK_");
+    let audit_mqtt_prefix = format!("{env_prefix}AUDIT_MQTT_");
+
+    assert_eq!(audit_webhook_prefix, "RUSTFS_AUDIT_WEBHOOK_");
+    assert_eq!(audit_mqtt_prefix, "RUSTFS_AUDIT_MQTT_");
+
+    // Test instance parsing
+    let example_env_var = "RUSTFS_AUDIT_WEBHOOK_ENABLE_PRIMARY";
+    assert!(example_env_var.starts_with(&audit_webhook_prefix));
+
+    let suffix = &example_env_var[audit_webhook_prefix.len()..];
+    assert_eq!(suffix, "ENABLE_PRIMARY");
+
+    // Parse field and instance
+    if let Some(last_underscore) = suffix.rfind('_') {
+        let field = &suffix[..last_underscore];
+        let instance = &suffix[last_underscore + 1..];
+        assert_eq!(field, "ENABLE");
+        assert_eq!(instance, "PRIMARY");
+    }
+}
+
+#[test]
+fn test_configuration_merge() {
+    // Test configuration merging precedence: ENV > file instance > file default
+    let mut default_config = KVS::new();
+    default_config.insert("enable".to_string(), "off".to_string());
+    default_config.insert("endpoint".to_string(), "http://default".to_string());
+
+    let mut instance_config = KVS::new();
+    instance_config.insert("endpoint".to_string(), "http://instance".to_string());
+
+    let mut env_config = KVS::new();
+    env_config.insert("enable".to_string(), "on".to_string());
+
+    // Simulate merge: default < instance < env
+    let mut merged = default_config.clone();
+    merged.extend(instance_config);
+    merged.extend(env_config);
+
+    // Verify merge results
+    assert_eq!(merged.lookup("enable"), Some("on".to_string()));
+    assert_eq!(merged.lookup("endpoint"), Some("http://instance".to_string()));
+}
+
+#[test]
+fn test_duration_parsing_formats() {
+    let test_cases = vec![
+        ("3s", Some(3)),
+        ("5m", Some(300)),   // 5 minutes = 300 seconds
+        ("1000ms", Some(1)), // 1000ms = 1 second
+        ("60", Some(60)),    // Default to seconds
+        ("invalid", None),
+        ("", None),
+    ];
+
+    for (input, expected_seconds) in test_cases {
+        let result = parse_duration_test(input);
+        match (result, expected_seconds) {
+            (Some(duration), Some(expected)) => {
+                assert_eq!(duration.as_secs(), expected, "Failed for input: {input}");
+            }
+            (None, None) => {
+                // Both None, test passes
+            }
+            _ => {
+                panic!("Mismatch for input: {input}, got: {result:?}, expected: {expected_seconds:?}");
+            }
+        }
+    }
+}
+
+// Helper function for duration parsing (extracted from registry.rs logic)
+fn parse_duration_test(s: &str) -> Option<std::time::Duration> {
+    use std::time::Duration;
+
+    if let Some(stripped) = s.strip_suffix("ms") {
+        stripped.parse::<u64>().ok().map(Duration::from_millis)
+    } else if let Some(stripped) = s.strip_suffix('s') {
+        stripped.parse::<u64>().ok().map(Duration::from_secs)
+    } else if let Some(stripped) = s.strip_suffix('m') {
+        stripped.parse::<u64>().ok().map(|m| Duration::from_secs(m * 60))
+    } else {
+        s.parse::<u64>().ok().map(Duration::from_secs)
+    }
+}
+
+#[test]
+fn test_url_validation() {
+    use url::Url;
+
+    let valid_urls = vec![
+        "http://localhost:3020/webhook",
+        "https://api.example.com/audit",
+        "mqtt://broker.example.com:1883",
+        "tcp://localhost:1883",
+    ];
+
+    let invalid_urls = [
+        "",
+        "not-a-url",
+        "http://",
+        "ftp://unsupported.com", // Not invalid, but might not be supported
+    ];
+
+    for url_str in valid_urls {
+        let result = Url::parse(url_str);
+        assert!(result.is_ok(), "Valid URL should parse: {url_str}");
+    }
+
+    for url_str in &invalid_urls[..3] {
+        // Skip the ftp one as it's technically valid
+        let result = Url::parse(url_str);
+        assert!(result.is_err(), "Invalid URL should not parse: {url_str}");
+    }
+}
+
+#[test]
+fn test_qos_parsing() {
+    // Test QoS level parsing for MQTT
+    let test_cases = vec![
+        ("0", Some(0)),
+        ("1", Some(1)),
+        ("2", Some(2)),
+        ("3", None), // Invalid QoS level
+        ("invalid", None),
+    ];
+
+    for (input, expected) in test_cases {
+        let result = input.parse::<u8>().ok().and_then(|q| match q {
+            0..=2 => Some(q),
+            _ => None,
+        });
+        assert_eq!(result, expected, "Failed for QoS input: {input}");
+    }
+}

crates/audit/tests/integration_test.rs

@@ -0,0 +1,108 @@
+//  Copyright 2024 RustFS Team
+//
+//  Licensed under the Apache License, Version 2.0 (the "License");
+//  you may not use this file except in compliance with the License.
+//  You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+//  Unless required by applicable law or agreed to in writing, software
+//  distributed under the License is distributed on an "AS IS" BASIS,
+//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+//  See the License for the specific language governing permissions and
+//  limitations under the License.
+
+use rustfs_audit::*;
+use rustfs_ecstore::config::{Config, KVS};
+use std::collections::HashMap;
+
+#[tokio::test]
+async fn test_audit_system_creation() {
+    let system = AuditSystem::new();
+    let state = system.get_state().await;
+    assert_eq!(state, rustfs_audit::system::AuditSystemState::Stopped);
+}
+
+#[tokio::test]
+async fn test_audit_registry_creation() {
+    let registry = AuditRegistry::new();
+    let targets = registry.list_targets();
+    assert!(targets.is_empty());
+}
+
+#[tokio::test]
+async fn test_config_parsing_webhook() {
+    let mut config = Config(HashMap::new());
+    let mut audit_webhook_section = HashMap::new();
+
+    // Create default configuration
+    let mut default_kvs = KVS::new();
+    default_kvs.insert("enable".to_string(), "on".to_string());
+    default_kvs.insert("endpoint".to_string(), "http://localhost:3020/webhook".to_string());
+
+    audit_webhook_section.insert("_".to_string(), default_kvs);
+    config.0.insert("audit_webhook".to_string(), audit_webhook_section);
+
+    let mut registry = AuditRegistry::new();
+
+    // This should not fail even if server storage is not initialized
+    // as it's an integration test
+    let result = registry.create_targets_from_config(&config).await;
+
+    // We expect this to fail due to server storage not being initialized
+    // but the parsing should work correctly
+    match result {
+        Err(AuditError::ServerNotInitialized(_)) => {
+            // This is expected in test environment
+        }
+        Err(e) => {
+            // Other errors might indicate parsing issues
+            println!("Unexpected error: {e}");
+        }
+        Ok(_) => {
+            // Unexpected success in test environment without server storage
+        }
+    }
+}
+
+#[test]
+fn test_event_name_parsing() {
+    use rustfs_targets::EventName;
+
+    // Test basic event name parsing
+    let event = EventName::parse("s3:ObjectCreated:Put").unwrap();
+    assert_eq!(event, EventName::ObjectCreatedPut);
+
+    let event = EventName::parse("s3:ObjectAccessed:*").unwrap();
+    assert_eq!(event, EventName::ObjectAccessedAll);
+
+    // Test event name expansion
+    let expanded = EventName::ObjectCreatedAll.expand();
+    assert!(expanded.contains(&EventName::ObjectCreatedPut));
+    assert!(expanded.contains(&EventName::ObjectCreatedPost));
+
+    // Test event name mask
+    let mask = EventName::ObjectCreatedPut.mask();
+    assert!(mask > 0);
+}
+
+#[test]
+fn test_enable_value_parsing() {
+    // Test different enable value formats
+    let test_cases = vec![
+        ("1", true),
+        ("on", true),
+        ("true", true),
+        ("yes", true),
+        ("0", false),
+        ("off", false),
+        ("false", false),
+        ("no", false),
+        ("invalid", false),
+    ];
+
+    for (input, expected) in test_cases {
+        let result = matches!(input.to_lowercase().as_str(), "1" | "on" | "true" | "yes");
+        assert_eq!(result, expected, "Failed for input: {input}");
+    }
+}

crates/audit/tests/observability_test.rs

@@ -0,0 +1,276 @@
+//  Copyright 2024 RustFS Team
+//
+//  Licensed under the Apache License, Version 2.0 (the "License");
+//  you may not use this file except in compliance with the License.
+//  You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+//  Unless required by applicable law or agreed to in writing, software
+//  distributed under the License is distributed on an "AS IS" BASIS,
+//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+//  See the License for the specific language governing permissions and
+//  limitations under the License.
+
+//! Tests for audit system observability and metrics
+
+use rustfs_audit::observability::*;
+use std::time::Duration;
+
+#[tokio::test]
+async fn test_metrics_collection() {
+    let metrics = AuditMetrics::new();
+
+    // Initially all metrics should be zero
+    let report = metrics.generate_report().await;
+    assert_eq!(report.total_events_processed, 0);
+    assert_eq!(report.total_events_failed, 0);
+    assert_eq!(report.events_per_second, 0.0);
+
+    // Record some events
+    metrics.record_event_success(Duration::from_millis(10));
+    metrics.record_event_success(Duration::from_millis(20));
+    metrics.record_event_failure(Duration::from_millis(30));
+
+    // Check updated metrics
+    let report = metrics.generate_report().await;
+    assert_eq!(report.total_events_processed, 2);
+    assert_eq!(report.total_events_failed, 1);
+    assert_eq!(report.error_rate_percent, 33.33333333333333); // 1/3 * 100
+    assert_eq!(report.average_latency_ms, 20.0); // (10+20+30)/3
+}
+
+#[tokio::test]
+async fn test_target_metrics() {
+    let metrics = AuditMetrics::new();
+
+    // Record target operations
+    metrics.record_target_success();
+    metrics.record_target_success();
+    metrics.record_target_failure();
+
+    let success_rate = metrics.get_target_success_rate();
+    assert_eq!(success_rate, 66.66666666666666); // 2/3 * 100
+}
+
+#[tokio::test]
+async fn test_performance_validation_pass() {
+    let metrics = AuditMetrics::new();
+
+    // Simulate high EPS with low latency
+    for _ in 0..5000 {
+        metrics.record_event_success(Duration::from_millis(5));
+    }
+
+    // Small delay to make EPS calculation meaningful
+    tokio::time::sleep(Duration::from_millis(1)).await;
+
+    let validation = metrics.validate_performance_requirements().await;
+
+    // Should meet latency requirement
+    assert!(validation.meets_latency_requirement, "Latency requirement should be met");
+    assert!(validation.current_latency_ms <= 30.0);
+
+    // Should meet error rate requirement (no failures)
+    assert!(validation.meets_error_rate_requirement, "Error rate requirement should be met");
+    assert_eq!(validation.current_error_rate, 0.0);
+}
+
+#[tokio::test]
+async fn test_performance_validation_fail() {
+    let metrics = AuditMetrics::new();
+
+    // Simulate high latency
+    metrics.record_event_success(Duration::from_millis(50)); // Above 30ms requirement
+    metrics.record_event_failure(Duration::from_millis(60));
+
+    let validation = metrics.validate_performance_requirements().await;
+
+    // Should fail latency requirement
+    assert!(!validation.meets_latency_requirement, "Latency requirement should fail");
+    assert!(validation.current_latency_ms > 30.0);
+
+    // Should fail error rate requirement
+    assert!(!validation.meets_error_rate_requirement, "Error rate requirement should fail");
+    assert!(validation.current_error_rate > 1.0);
+
+    // Should have recommendations
+    assert!(!validation.recommendations.is_empty());
+}
+
+#[tokio::test]
+async fn test_global_metrics() {
+    // Test global metrics functions
+    record_audit_success(Duration::from_millis(10));
+    record_audit_failure(Duration::from_millis(20));
+    record_target_success();
+    record_target_failure();
+    record_config_reload();
+    record_system_start();
+
+    let report = get_metrics_report().await;
+    assert!(report.total_events_processed > 0);
+    assert!(report.total_events_failed > 0);
+    assert!(report.config_reload_count > 0);
+    assert!(report.system_start_count > 0);
+
+    // Reset metrics
+    reset_metrics().await;
+
+    let report_after_reset = get_metrics_report().await;
+    assert_eq!(report_after_reset.total_events_processed, 0);
+    assert_eq!(report_after_reset.total_events_failed, 0);
+}
+
+#[test]
+fn test_metrics_report_formatting() {
+    let report = AuditMetricsReport {
+        events_per_second: 1500.5,
+        average_latency_ms: 25.75,
+        error_rate_percent: 0.5,
+        target_success_rate_percent: 99.5,
+        total_events_processed: 10000,
+        total_events_failed: 50,
+        config_reload_count: 3,
+        system_start_count: 1,
+    };
+
+    let formatted = report.format();
+    assert!(formatted.contains("1500.50")); // EPS
+    assert!(formatted.contains("25.75")); // Latency
+    assert!(formatted.contains("0.50")); // Error rate
+    assert!(formatted.contains("99.50")); // Success rate
+    assert!(formatted.contains("10000")); // Events processed
+    assert!(formatted.contains("50")); // Events failed
+}
+
+#[test]
+fn test_performance_validation_formatting() {
+    let validation = PerformanceValidation {
+        meets_eps_requirement: false,
+        meets_latency_requirement: true,
+        meets_error_rate_requirement: true,
+        current_eps: 2500.0,
+        current_latency_ms: 15.0,
+        current_error_rate: 0.1,
+        recommendations: vec![
+            "EPS too low, consider optimization".to_string(),
+            "Latency is good".to_string(),
+        ],
+    };
+
+    let formatted = validation.format();
+    assert!(formatted.contains("❌ FAIL")); // Should show fail
+    assert!(formatted.contains("2500.00")); // Current EPS
+    assert!(formatted.contains("15.00")); // Current latency  
+    assert!(formatted.contains("0.10")); // Current error rate
+    assert!(formatted.contains("EPS too low")); // Recommendation
+    assert!(formatted.contains("Latency is good")); // Recommendation
+}
+
+#[test]
+fn test_performance_validation_all_pass() {
+    let validation = PerformanceValidation {
+        meets_eps_requirement: true,
+        meets_latency_requirement: true,
+        meets_error_rate_requirement: true,
+        current_eps: 5000.0,
+        current_latency_ms: 10.0,
+        current_error_rate: 0.01,
+        recommendations: vec!["All requirements met".to_string()],
+    };
+
+    assert!(validation.all_requirements_met());
+
+    let formatted = validation.format();
+    assert!(formatted.contains("✅ PASS")); // Should show pass
+    assert!(formatted.contains("All requirements met"));
+}
+
+#[tokio::test]
+async fn test_eps_calculation() {
+    let metrics = AuditMetrics::new();
+
+    // Record events
+    for _ in 0..100 {
+        metrics.record_event_success(Duration::from_millis(1));
+    }
+
+    // Small delay to allow EPS calculation
+    tokio::time::sleep(Duration::from_millis(10)).await;
+
+    let eps = metrics.get_events_per_second().await;
+
+    // Should have some EPS value > 0
+    assert!(eps > 0.0, "EPS should be greater than 0");
+
+    // EPS should be reasonable (events / time)
+    // With 100 events in ~10ms, should be very high
+    assert!(eps > 1000.0, "EPS should be high for short time period");
+}
+
+#[test]
+fn test_error_rate_calculation() {
+    let metrics = AuditMetrics::new();
+
+    // No events - should be 0% error rate
+    assert_eq!(metrics.get_error_rate(), 0.0);
+
+    // Record 7 successes, 3 failures = 30% error rate
+    for _ in 0..7 {
+        metrics.record_event_success(Duration::from_millis(1));
+    }
+    for _ in 0..3 {
+        metrics.record_event_failure(Duration::from_millis(1));
+    }
+
+    let error_rate = metrics.get_error_rate();
+    assert_eq!(error_rate, 30.0);
+}
+
+#[test]
+fn test_target_success_rate_calculation() {
+    let metrics = AuditMetrics::new();
+
+    // No operations - should be 100% success rate
+    assert_eq!(metrics.get_target_success_rate(), 100.0);
+
+    // Record 8 successes, 2 failures = 80% success rate
+    for _ in 0..8 {
+        metrics.record_target_success();
+    }
+    for _ in 0..2 {
+        metrics.record_target_failure();
+    }
+
+    let success_rate = metrics.get_target_success_rate();
+    assert_eq!(success_rate, 80.0);
+}
+
+#[tokio::test]
+async fn test_metrics_reset() {
+    let metrics = AuditMetrics::new();
+
+    // Record some data
+    metrics.record_event_success(Duration::from_millis(10));
+    metrics.record_target_success();
+    metrics.record_config_reload();
+    metrics.record_system_start();
+
+    // Verify data exists
+    let report_before = metrics.generate_report().await;
+    assert!(report_before.total_events_processed > 0);
+    assert!(report_before.config_reload_count > 0);
+    assert!(report_before.system_start_count > 0);
+
+    // Reset
+    metrics.reset().await;
+
+    // Verify data is reset
+    let report_after = metrics.generate_report().await;
+    assert_eq!(report_after.total_events_processed, 0);
+    assert_eq!(report_after.total_events_failed, 0);
+    // Note: config_reload_count and system_start_count are reset to 0 as well
+    assert_eq!(report_after.config_reload_count, 0);
+    assert_eq!(report_after.system_start_count, 0);
+}

crates/audit/tests/performance_test.rs

@@ -0,0 +1,320 @@
+//  Copyright 2024 RustFS Team
+//
+//  Licensed under the Apache License, Version 2.0 (the "License");
+//  you may not use this file except in compliance with the License.
+//  You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+//  Unless required by applicable law or agreed to in writing, software
+//  distributed under the License is distributed on an "AS IS" BASIS,
+//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+//  See the License for the specific language governing permissions and
+//  limitations under the License.
+
+//! Performance and observability tests for audit system
+
+use rustfs_audit::*;
+use std::sync::Arc;
+use std::time::{Duration, Instant};
+use tokio::time::timeout;
+
+#[tokio::test]
+async fn test_audit_system_startup_performance() {
+    // Test that audit system starts within reasonable time
+    let system = AuditSystem::new();
+    let start = Instant::now();
+
+    // Create minimal config for testing
+    let config = rustfs_ecstore::config::Config(std::collections::HashMap::new());
+
+    // System should start quickly even with empty config
+    let _result = timeout(Duration::from_secs(5), system.start(config)).await;
+    let elapsed = start.elapsed();
+
+    println!("Audit system startup took: {elapsed:?}");
+
+    // Should complete within 5 seconds
+    assert!(elapsed < Duration::from_secs(5), "Startup took too long: {elapsed:?}");
+
+    // Clean up
+    let _ = system.close().await;
+}
+
+#[tokio::test]
+async fn test_concurrent_target_creation() {
+    // Test that multiple targets can be created concurrently
+    let mut registry = AuditRegistry::new();
+
+    // Create config with multiple webhook instances
+    let mut config = rustfs_ecstore::config::Config(std::collections::HashMap::new());
+    let mut webhook_section = std::collections::HashMap::new();
+
+    // Create multiple instances for concurrent creation test
+    for i in 1..=5 {
+        let mut kvs = rustfs_ecstore::config::KVS::new();
+        kvs.insert("enable".to_string(), "on".to_string());
+        kvs.insert("endpoint".to_string(), format!("http://localhost:302{i}/webhook"));
+        webhook_section.insert(format!("instance_{i}"), kvs);
+    }
+
+    config.0.insert("audit_webhook".to_string(), webhook_section);
+
+    let start = Instant::now();
+
+    // This will fail due to server storage not being initialized, but we can measure timing
+    let result = registry.create_targets_from_config(&config).await;
+    let elapsed = start.elapsed();
+
+    println!("Concurrent target creation took: {elapsed:?}");
+
+    // Should complete quickly even with multiple targets
+    assert!(elapsed < Duration::from_secs(10), "Target creation took too long: {elapsed:?}");
+
+    // Verify it fails with expected error (server not initialized)
+    match result {
+        Err(AuditError::ServerNotInitialized(_)) => {
+            // Expected in test environment
+        }
+        Err(e) => {
+            println!("Unexpected error during concurrent creation: {e}");
+        }
+        Ok(_) => {
+            println!("Unexpected success in test environment");
+        }
+    }
+}
+
+#[tokio::test]
+async fn test_audit_log_dispatch_performance() {
+    let system = AuditSystem::new();
+
+    // Create minimal config
+    let config = rustfs_ecstore::config::Config(HashMap::new());
+    let start_result = system.start(config).await;
+    if start_result.is_err() {
+        println!("AuditSystem failed to start: {start_result:?}");
+        return; // Alternatively: assert!(false, "AuditSystem failed to start");
+    }
+
+    use chrono::Utc;
+    use rustfs_targets::EventName;
+    use serde_json::json;
+    use std::collections::HashMap;
+    let id = 1;
+
+    let mut req_header = HashMap::new();
+    req_header.insert("authorization".to_string(), format!("Bearer test-token-{id}"));
+    req_header.insert("content-type".to_string(), "application/octet-stream".to_string());
+
+    let mut resp_header = HashMap::new();
+    resp_header.insert("x-response".to_string(), "ok".to_string());
+
+    let mut tags = HashMap::new();
+    tags.insert(format!("tag-{id}"), json!("sample"));
+
+    let mut req_query = HashMap::new();
+    req_query.insert("id".to_string(), id.to_string());
+
+    let api_details = ApiDetails {
+        name: Some("PutObject".to_string()),
+        bucket: Some("test-bucket".to_string()),
+        object: Some(format!("test-object-{id}")),
+        status: Some("success".to_string()),
+        status_code: Some(200),
+        input_bytes: Some(1024),
+        output_bytes: Some(0),
+        header_bytes: Some(128),
+        time_to_first_byte: Some("1ms".to_string()),
+        time_to_first_byte_in_ns: Some("1000000".to_string()),
+        time_to_response: Some("2ms".to_string()),
+        time_to_response_in_ns: Some("2000000".to_string()),
+        ..Default::default()
+    };
+    // Create sample audit log entry
+    let audit_entry = AuditEntry {
+        version: "1".to_string(),
+        deployment_id: Some(format!("test-deployment-{id}")),
+        site_name: Some("test-site".to_string()),
+        time: Utc::now(),
+        event: EventName::ObjectCreatedPut,
+        entry_type: Some("object".to_string()),
+        trigger: "api".to_string(),
+        api: api_details,
+        remote_host: Some("127.0.0.1".to_string()),
+        request_id: Some(format!("test-request-{id}")),
+        user_agent: Some("test-agent".to_string()),
+        req_path: Some(format!("/test-bucket/test-object-{id}")),
+        req_host: Some("test-host".to_string()),
+        req_node: Some("node-1".to_string()),
+        req_claims: None,
+        req_query: Some(req_query),
+        req_header: Some(req_header),
+        resp_header: Some(resp_header),
+        tags: Some(tags),
+        access_key: Some(format!("AKIA{id}")),
+        parent_user: Some(format!("parent-{id}")),
+        error: None,
+    };
+
+    let start = Instant::now();
+
+    // Dispatch audit log (should be fast since no targets are configured)
+    let result = system.dispatch(Arc::new(audit_entry)).await;
+    let elapsed = start.elapsed();
+
+    println!("Audit log dispatch took: {elapsed:?}");
+
+    // Should be very fast (sub-millisecond for no targets)
+    assert!(elapsed < Duration::from_millis(100), "Dispatch took too long: {elapsed:?}");
+
+    // Should succeed even with no targets
+    assert!(result.is_ok(), "Dispatch should succeed with no targets");
+
+    // Clean up
+    let _ = system.close().await;
+}
+
+#[tokio::test]
+async fn test_system_state_transitions() {
+    let system = AuditSystem::new();
+
+    // Initial state should be stopped
+    assert_eq!(system.get_state().await, rustfs_audit::system::AuditSystemState::Stopped);
+
+    // Start system
+    let config = rustfs_ecstore::config::Config(std::collections::HashMap::new());
+    let start_result = system.start(config).await;
+
+    // Should be running (or failed due to server storage)
+    let state = system.get_state().await;
+    match start_result {
+        Ok(_) => {
+            assert_eq!(state, rustfs_audit::system::AuditSystemState::Running);
+        }
+        Err(_) => {
+            // Expected in test environment due to server storage not being initialized
+            assert_eq!(state, rustfs_audit::system::AuditSystemState::Stopped);
+        }
+    }
+
+    // Clean up
+    let _ = system.close().await;
+    assert_eq!(system.get_state().await, rustfs_audit::system::AuditSystemState::Stopped);
+}
+
+#[test]
+fn test_event_name_mask_performance() {
+    use rustfs_targets::EventName;
+
+    // Test that event name mask calculation is efficient
+    let events = vec![
+        EventName::ObjectCreatedPut,
+        EventName::ObjectAccessedGet,
+        EventName::ObjectRemovedDelete,
+        EventName::ObjectCreatedAll,
+        EventName::Everything,
+    ];
+
+    let start = Instant::now();
+
+    // Calculate masks for many events
+    for _ in 0..1000 {
+        for event in &events {
+            let _mask = event.mask();
+        }
+    }
+
+    let elapsed = start.elapsed();
+    println!("Event mask calculation (5000 ops) took: {elapsed:?}");
+
+    // Should be very fast
+    assert!(elapsed < Duration::from_millis(100), "Mask calculation too slow: {elapsed:?}");
+}
+
+#[test]
+fn test_event_name_expansion_performance() {
+    use rustfs_targets::EventName;
+
+    // Test that event name expansion is efficient
+    let compound_events = vec![
+        EventName::ObjectCreatedAll,
+        EventName::ObjectAccessedAll,
+        EventName::ObjectRemovedAll,
+        EventName::Everything,
+    ];
+
+    let start = Instant::now();
+
+    // Expand events many times
+    for _ in 0..1000 {
+        for event in &compound_events {
+            let _expanded = event.expand();
+        }
+    }
+
+    let elapsed = start.elapsed();
+    println!("Event expansion (4000 ops) took: {elapsed:?}");
+
+    // Should be very fast
+    assert!(elapsed < Duration::from_millis(100), "Expansion too slow: {elapsed:?}");
+}
+
+#[tokio::test]
+async fn test_registry_operations_performance() {
+    let registry = AuditRegistry::new();
+
+    let start = Instant::now();
+
+    // Test basic registry operations
+    for _ in 0..1000 {
+        let targets = registry.list_targets();
+        let _target = registry.get_target("nonexistent");
+        assert!(targets.is_empty());
+    }
+
+    let elapsed = start.elapsed();
+    println!("Registry operations (2000 ops) took: {elapsed:?}");
+
+    // Should be very fast for empty registry
+    assert!(elapsed < Duration::from_millis(100), "Registry ops too slow: {elapsed:?}");
+}
+
+// Performance requirements validation
+#[test]
+fn test_performance_requirements() {
+    // According to requirements: ≥ 3k EPS/node; P99 < 30ms (default)
+
+    // These are synthetic tests since we can't actually achieve 3k EPS
+    // without real server storage and network targets, but we can validate
+    // that our core algorithms are efficient enough
+
+    let start = Instant::now();
+
+    // Simulate processing 3000 events worth of operations
+    for i in 0..3000 {
+        // Simulate event name parsing and processing
+        let _event_id = format!("s3:ObjectCreated:Put_{i}");
+        let _timestamp = chrono::Utc::now().to_rfc3339();
+
+        // Simulate basic audit entry creation overhead
+        let _entry_size = 512; // bytes
+        let _processing_time = std::time::Duration::from_nanos(100); // simulated
+    }
+
+    let elapsed = start.elapsed();
+    let eps = 3000.0 / elapsed.as_secs_f64();
+
+    println!("Simulated 3000 events in {elapsed:?} ({eps:.0} EPS)");
+
+    // Our core processing should easily handle 3k EPS worth of CPU overhead
+    // The actual EPS limit will be determined by network I/O to targets
+    assert!(eps > 10000.0, "Core processing too slow for 3k EPS target: {eps} EPS");
+
+    // P99 latency requirement: < 30ms
+    // For core processing, we should be much faster than this
+    let avg_latency = elapsed / 3000;
+    println!("Average processing latency: {avg_latency:?}");
+
+    assert!(avg_latency < Duration::from_millis(1), "Processing latency too high: {avg_latency:?}");
+}

crates/audit/tests/system_integration_test.rs

@@ -0,0 +1,373 @@
+//  Copyright 2024 RustFS Team
+//
+//  Licensed under the Apache License, Version 2.0 (the "License");
+//  you may not use this file except in compliance with the License.
+//  You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+//  Unless required by applicable law or agreed to in writing, software
+//  distributed under the License is distributed on an "AS IS" BASIS,
+//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+//  See the License for the specific language governing permissions and
+//  limitations under the License.
+
+//! Comprehensive integration tests for the complete audit system
+
+use rustfs_audit::*;
+use rustfs_ecstore::config::{Config, KVS};
+use std::collections::HashMap;
+use std::sync::Arc;
+use std::time::Duration;
+
+#[tokio::test]
+async fn test_complete_audit_system_lifecycle() {
+    // Test the complete lifecycle of the audit system
+    let system = AuditSystem::new();
+
+    // 1. Initial state should be stopped
+    assert_eq!(system.get_state().await, system::AuditSystemState::Stopped);
+    assert!(!system.is_running().await);
+
+    // 2. Start with empty config (will fail due to no server storage in test)
+    let config = Config(HashMap::new());
+    let start_result = system.start(config).await;
+
+    // Should fail in test environment but state handling should work
+    match start_result {
+        Err(AuditError::ServerNotInitialized(_)) => {
+            // Expected in test environment
+            assert_eq!(system.get_state().await, system::AuditSystemState::Stopped);
+        }
+        Ok(_) => {
+            // If it somehow succeeds, verify running state
+            assert_eq!(system.get_state().await, system::AuditSystemState::Running);
+            assert!(system.is_running().await);
+
+            // Test pause/resume
+            system.pause().await.expect("Should pause successfully");
+            assert_eq!(system.get_state().await, system::AuditSystemState::Paused);
+
+            system.resume().await.expect("Should resume successfully");
+            assert_eq!(system.get_state().await, system::AuditSystemState::Running);
+        }
+        Err(e) => {
+            panic!("Unexpected error: {e}");
+        }
+    }
+
+    // 3. Test close
+    system.close().await.expect("Should close successfully");
+    assert_eq!(system.get_state().await, system::AuditSystemState::Stopped);
+    assert!(!system.is_running().await);
+}
+
+#[tokio::test]
+async fn test_audit_system_with_metrics() {
+    let system = AuditSystem::new();
+
+    // Reset metrics for clean test
+    system.reset_metrics().await;
+
+    // Try to start system (will fail but should record metrics)
+    let config = Config(HashMap::new());
+    let _ = system.start(config).await; // Ignore result
+
+    // Check metrics
+    let metrics = system.get_metrics().await;
+    assert!(metrics.system_start_count > 0, "Should have recorded system start attempt");
+
+    // Test performance validation
+    let validation = system.validate_performance().await;
+    assert!(validation.current_eps >= 0.0);
+    assert!(validation.current_latency_ms >= 0.0);
+    assert!(validation.current_error_rate >= 0.0);
+}
+
+#[tokio::test]
+async fn test_audit_log_dispatch_with_no_targets() {
+    let system = AuditSystem::new();
+
+    // Create sample audit entry
+    let audit_entry = create_sample_audit_entry();
+
+    // Try to dispatch with no targets (should succeed but do nothing)
+    let result = system.dispatch(Arc::new(audit_entry)).await;
+
+    // Should succeed even with no targets configured
+    match result {
+        Ok(_) => {
+            // Success expected
+        }
+        Err(AuditError::NotInitialized(_)) => {
+            // Also acceptable since system not running
+        }
+        Err(e) => {
+            panic!("Unexpected error: {e}");
+        }
+    }
+}
+
+#[tokio::test]
+async fn test_global_audit_functions() {
+    use rustfs_audit::*;
+
+    // Test global functions
+    let system = init_audit_system();
+    assert!(system.get_state().await == system::AuditSystemState::Stopped);
+
+    // Test audit logging function (should not panic even if system not running)
+    let entry = create_sample_audit_entry();
+    let result = dispatch_audit_log(Arc::new(entry)).await;
+    assert!(result.is_ok(), "Dispatch should succeed even with no running system");
+
+    // Test system status
+    assert!(!is_audit_system_running().await);
+
+    // Test AuditLogger singleton
+    let _logger = AuditLogger::instance();
+    assert!(!AuditLogger::is_enabled().await);
+
+    // Test logging (should not panic)
+    let entry = create_sample_audit_entry();
+    AuditLogger::log(entry).await; // Should not panic
+}
+
+#[tokio::test]
+async fn test_config_parsing_with_multiple_instances() {
+    let mut registry = AuditRegistry::new();
+
+    // Create config with multiple webhook instances
+    let mut config = Config(HashMap::new());
+    let mut webhook_section = HashMap::new();
+
+    // Default instance
+    let mut default_kvs = KVS::new();
+    default_kvs.insert("enable".to_string(), "off".to_string());
+    default_kvs.insert("endpoint".to_string(), "http://default.example.com/audit".to_string());
+    webhook_section.insert("_".to_string(), default_kvs);
+
+    // Primary instance
+    let mut primary_kvs = KVS::new();
+    primary_kvs.insert("enable".to_string(), "on".to_string());
+    primary_kvs.insert("endpoint".to_string(), "http://primary.example.com/audit".to_string());
+    primary_kvs.insert("auth_token".to_string(), "primary-token-123".to_string());
+    webhook_section.insert("primary".to_string(), primary_kvs);
+
+    // Secondary instance
+    let mut secondary_kvs = KVS::new();
+    secondary_kvs.insert("enable".to_string(), "on".to_string());
+    secondary_kvs.insert("endpoint".to_string(), "http://secondary.example.com/audit".to_string());
+    secondary_kvs.insert("auth_token".to_string(), "secondary-token-456".to_string());
+    webhook_section.insert("secondary".to_string(), secondary_kvs);
+
+    config.0.insert("audit_webhook".to_string(), webhook_section);
+
+    // Try to create targets from config
+    let result = registry.create_targets_from_config(&config).await;
+
+    // Should fail due to server storage not initialized, but parsing should work
+    match result {
+        Err(AuditError::ServerNotInitialized(_)) => {
+            // Expected - parsing worked but save failed
+        }
+        Err(e) => {
+            println!("Config parsing error: {e}");
+            // Other errors might indicate parsing issues, but not necessarily failures
+        }
+        Ok(_) => {
+            // Unexpected success in test environment
+            println!("Unexpected success - server storage somehow available");
+        }
+    }
+}
+
+// #[tokio::test]
+// async fn test_environment_variable_precedence() {
+//     // Test that environment variables override config file settings
+//     // This test validates the ENV > file instance > file default precedence
+//     // Set some test environment variables
+//     std::env::set_var("RUSTFS_AUDIT_WEBHOOK_ENABLE_TEST", "on");
+//     std::env::set_var("RUSTFS_AUDIT_WEBHOOK_ENDPOINT_TEST", "http://env.example.com/audit");
+//     std::env::set_var("RUSTFS_AUDIT_WEBHOOK_AUTH_TOKEN_TEST", "env-token");
+//     let mut registry = AuditRegistry::new();
+//
+//     // Create config that should be overridden by env vars
+//     let mut config = Config(HashMap::new());
+//     let mut webhook_section = HashMap::new();
+//
+//     let mut test_kvs = KVS::new();
+//     test_kvs.insert("enable".to_string(), "off".to_string()); // Should be overridden
+//     test_kvs.insert("endpoint".to_string(), "http://file.example.com/audit".to_string()); // Should be overridden
+//     test_kvs.insert("batch_size".to_string(), "10".to_string()); // Should remain from file
+//     webhook_section.insert("test".to_string(), test_kvs);
+//
+//     config.0.insert("audit_webhook".to_string(), webhook_section);
+//
+//     // Try to create targets - should use env vars for endpoint/enable, file for batch_size
+//     let result = registry.create_targets_from_config(&config).await;
+//     // Clean up env vars
+//     std::env::remove_var("RUSTFS_AUDIT_WEBHOOK_ENABLE_TEST");
+//     std::env::remove_var("RUSTFS_AUDIT_WEBHOOK_ENDPOINT_TEST");
+//     std::env::remove_var("RUSTFS_AUDIT_WEBHOOK_AUTH_TOKEN_TEST");
+//     // Should fail due to server storage, but precedence logic should work
+//     match result {
+//         Err(AuditError::ServerNotInitialized(_)) => {
+//             // Expected - precedence parsing worked but save failed
+//         }
+//         Err(e) => {
+//             println!("Environment precedence test error: {}", e);
+//         }
+//         Ok(_) => {
+//             println!("Unexpected success in environment precedence test");
+//         }
+//     }
+// }
+
+#[test]
+fn test_target_type_validation() {
+    use rustfs_targets::target::TargetType;
+
+    // Test that TargetType::AuditLog is properly defined
+    let audit_type = TargetType::AuditLog;
+    assert_eq!(audit_type.as_str(), "audit_log");
+
+    let notify_type = TargetType::NotifyEvent;
+    assert_eq!(notify_type.as_str(), "notify_event");
+
+    // Test that they are different
+    assert_ne!(audit_type.as_str(), notify_type.as_str());
+}
+
+#[tokio::test]
+async fn test_concurrent_operations() {
+    let system = AuditSystem::new();
+
+    // Test concurrent state checks
+    let mut tasks = Vec::new();
+
+    for i in 0..10 {
+        let system_clone = system.clone();
+        let task = tokio::spawn(async move {
+            let state = system_clone.get_state().await;
+            let is_running = system_clone.is_running().await;
+            (i, state, is_running)
+        });
+        tasks.push(task);
+    }
+
+    // All tasks should complete without panic
+    for task in tasks {
+        let (i, state, is_running) = task.await.expect("Task should complete");
+        assert_eq!(state, system::AuditSystemState::Stopped);
+        assert!(!is_running);
+        println!("Task {i} completed successfully");
+    }
+}
+
+#[tokio::test]
+async fn test_performance_under_load() {
+    use std::time::Instant;
+
+    let system = AuditSystem::new();
+
+    // Test multiple rapid dispatch calls
+    let start = Instant::now();
+    let mut tasks = Vec::new();
+
+    for i in 0..100 {
+        let system_clone = system.clone();
+        let entry = Arc::new(create_sample_audit_entry_with_id(i));
+
+        let task = tokio::spawn(async move { system_clone.dispatch(entry).await });
+        tasks.push(task);
+    }
+
+    // Wait for all dispatches to complete
+    let mut success_count = 0;
+    let mut error_count = 0;
+
+    for task in tasks {
+        match task.await.expect("Task should complete") {
+            Ok(_) => success_count += 1,
+            Err(_) => error_count += 1,
+        }
+    }
+
+    let elapsed = start.elapsed();
+    println!("100 concurrent dispatches took: {elapsed:?}");
+    println!("Successes: {success_count}, Errors: {error_count}");
+
+    // Should complete reasonably quickly
+    assert!(elapsed < Duration::from_secs(5), "Concurrent operations took too long");
+
+    // All should either succeed (if targets available) or fail consistently
+    assert_eq!(success_count + error_count, 100);
+}
+
+// Helper functions
+
+fn create_sample_audit_entry() -> AuditEntry {
+    create_sample_audit_entry_with_id(0)
+}
+
+fn create_sample_audit_entry_with_id(id: u32) -> AuditEntry {
+    use chrono::Utc;
+    use rustfs_targets::EventName;
+    use serde_json::json;
+    use std::collections::HashMap;
+
+    let mut req_header = HashMap::new();
+    req_header.insert("authorization".to_string(), format!("Bearer test-token-{id}"));
+    req_header.insert("content-type".to_string(), "application/octet-stream".to_string());
+
+    let mut resp_header = HashMap::new();
+    resp_header.insert("x-response".to_string(), "ok".to_string());
+
+    let mut tags = HashMap::new();
+    tags.insert(format!("tag-{id}"), json!("sample"));
+
+    let mut req_query = HashMap::new();
+    req_query.insert("id".to_string(), id.to_string());
+
+    let api_details = ApiDetails {
+        name: Some("PutObject".to_string()),
+        bucket: Some("test-bucket".to_string()),
+        object: Some(format!("test-object-{id}")),
+        status: Some("success".to_string()),
+        status_code: Some(200),
+        input_bytes: Some(1024),
+        output_bytes: Some(0),
+        header_bytes: Some(128),
+        time_to_first_byte: Some("1ms".to_string()),
+        time_to_first_byte_in_ns: Some("1000000".to_string()),
+        time_to_response: Some("2ms".to_string()),
+        time_to_response_in_ns: Some("2000000".to_string()),
+        ..Default::default()
+    };
+
+    AuditEntry {
+        version: "1".to_string(),
+        deployment_id: Some(format!("test-deployment-{id}")),
+        site_name: Some("test-site".to_string()),
+        time: Utc::now(),
+        event: EventName::ObjectCreatedPut,
+        entry_type: Some("object".to_string()),
+        trigger: "api".to_string(),
+        api: api_details,
+        remote_host: Some("127.0.0.1".to_string()),
+        request_id: Some(format!("test-request-{id}")),
+        user_agent: Some("test-agent".to_string()),
+        req_path: Some(format!("/test-bucket/test-object-{id}")),
+        req_host: Some("test-host".to_string()),
+        req_node: Some("node-1".to_string()),
+        req_claims: None,
+        req_query: Some(req_query),
+        req_header: Some(req_header),
+        resp_header: Some(resp_header),
+        tags: Some(tags),
+        access_key: Some(format!("AKIA{id}")),
+        parent_user: Some(format!("parent-{id}")),
+        error: None,
+    }
+}

crates/common/Cargo.toml

@@ -28,7 +28,6 @@ categories = ["web-programming", "development-tools", "data-structures"]
 workspace = true
 
 [dependencies]
-lazy_static = { workspace = true}
 tokio = { workspace = true }
 tonic = { workspace = true }
 uuid = { workspace = true }

crates/common/src/bucket_stats.rs

@@ -12,9 +12,9 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+use crate::last_minute::{self};
 use std::collections::HashMap;
 
-use crate::last_minute::{self};
 pub struct ReplicationLatency {
     // Delays for single and multipart PUT requests
     upload_histogram: last_minute::LastMinuteHistogram,

crates/common/src/data_usage.rs

@@ -14,10 +14,10 @@
 
 use path_clean::PathClean;
 use serde::{Deserialize, Serialize};
-use std::hash::{DefaultHasher, Hash, Hasher};
-use std::path::Path;
 use std::{
     collections::{HashMap, HashSet},
+    hash::{DefaultHasher, Hash, Hasher},
+    path::Path,
     time::SystemTime,
 };
 
@@ -144,6 +144,20 @@ pub struct DataUsageInfo {
     pub buckets_usage: HashMap<String, BucketUsageInfo>,
     /// Deprecated kept here for backward compatibility reasons
     pub bucket_sizes: HashMap<String, u64>,
+    /// Per-disk snapshot information when available
+    #[serde(default)]
+    pub disk_usage_status: Vec<DiskUsageStatus>,
+}
+
+/// Metadata describing the status of a disk-level data usage snapshot.
+#[derive(Debug, Default, Clone, Serialize, Deserialize)]
+pub struct DiskUsageStatus {
+    pub disk_id: String,
+    pub pool_index: Option<usize>,
+    pub set_index: Option<usize>,
+    pub disk_index: Option<usize>,
+    pub last_update: Option<SystemTime>,
+    pub snapshot_exists: bool,
 }
 
 /// Size summary for a single object or group of objects
@@ -1127,6 +1141,8 @@ impl DataUsageInfo {
             }
         }
 
+        self.disk_usage_status.extend(other.disk_usage_status.iter().cloned());
+
         // Recalculate totals
         self.calculate_totals();
 

crates/common/src/globals.rs

@@ -16,7 +16,6 @@
 
 use std::collections::HashMap;
 use std::sync::LazyLock;
-
 use tokio::sync::RwLock;
 use tonic::transport::Channel;
 

crates/common/src/heal_channel.rs

@@ -18,7 +18,7 @@ use std::{
     fmt::{self, Display},
     sync::OnceLock,
 };
-use tokio::sync::mpsc;
+use tokio::sync::{broadcast, mpsc};
 use uuid::Uuid;
 
 pub const HEAL_DELETE_DANGLING: bool = true;
@@ -85,19 +85,14 @@ impl Display for DriveState {
     }
 }
 
-#[derive(Clone, Copy, Debug, Serialize, Deserialize, PartialEq, Eq)]
+#[derive(Clone, Copy, Debug, Default, Serialize, Deserialize, PartialEq, Eq)]
 pub enum HealScanMode {
     Unknown,
+    #[default]
     Normal,
     Deep,
 }
 
-impl Default for HealScanMode {
-    fn default() -> Self {
-        Self::Normal
-    }
-}
-
 #[derive(Clone, Copy, Debug, Default, Serialize, Deserialize)]
 pub struct HealOpts {
     pub recursive: bool,
@@ -175,11 +170,12 @@ pub struct HealChannelResponse {
 }
 
 /// Heal priority
-#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+#[derive(Debug, Default, Clone, Copy, PartialEq, Eq)]
 pub enum HealChannelPriority {
     /// Low priority
     Low,
     /// Normal priority
+    #[default]
     Normal,
     /// High priority
     High,
@@ -187,12 +183,6 @@ pub enum HealChannelPriority {
     Critical,
 }
 
-impl Default for HealChannelPriority {
-    fn default() -> Self {
-        Self::Normal
-    }
-}
-
 /// Heal channel sender
 pub type HealChannelSender = mpsc::UnboundedSender<HealChannelCommand>;
 
@@ -202,6 +192,11 @@ pub type HealChannelReceiver = mpsc::UnboundedReceiver<HealChannelCommand>;
 /// Global heal channel sender
 static GLOBAL_HEAL_CHANNEL_SENDER: OnceLock<HealChannelSender> = OnceLock::new();
 
+type HealResponseSender = broadcast::Sender<HealChannelResponse>;
+
+/// Global heal response broadcaster
+static GLOBAL_HEAL_RESPONSE_SENDER: OnceLock<HealResponseSender> = OnceLock::new();
+
 /// Initialize global heal channel
 pub fn init_heal_channel() -> HealChannelReceiver {
     let (tx, rx) = mpsc::unbounded_channel();
@@ -228,6 +223,23 @@ pub async fn send_heal_command(command: HealChannelCommand) -> Result<(), String
     }
 }
 
+fn heal_response_sender() -> &'static HealResponseSender {
+    GLOBAL_HEAL_RESPONSE_SENDER.get_or_init(|| {
+        let (tx, _rx) = broadcast::channel(1024);
+        tx
+    })
+}
+
+/// Publish a heal response to subscribers.
+pub fn publish_heal_response(response: HealChannelResponse) -> Result<(), broadcast::error::SendError<HealChannelResponse>> {
+    heal_response_sender().send(response).map(|_| ())
+}
+
+/// Subscribe to heal responses.
+pub fn subscribe_heal_responses() -> broadcast::Receiver<HealChannelResponse> {
+    heal_response_sender().subscribe()
+}
+
 /// Send heal start request
 pub async fn send_heal_request(request: HealChannelRequest) -> Result<(), String> {
     send_heal_command(HealChannelCommand::Start(request)).await
@@ -425,3 +437,20 @@ pub async fn send_heal_disk(set_disk_id: String, priority: Option<HealChannelPri
     };
     send_heal_request(req).await
 }
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[tokio::test]
+    async fn heal_response_broadcast_reaches_subscriber() {
+        let mut receiver = subscribe_heal_responses();
+        let response = create_heal_response("req-1".to_string(), true, None, None);
+
+        publish_heal_response(response.clone()).expect("publish should succeed");
+
+        let received = receiver.recv().await.expect("should receive heal response");
+        assert_eq!(received.request_id, response.request_id);
+        assert!(received.success);
+    }
+}

crates/common/src/last_minute.rs

@@ -27,11 +27,11 @@ struct TimedAction {
 #[allow(dead_code)]
 impl TimedAction {
     // Avg returns the average time spent on the action.
-    pub fn avg(&self) -> Option<std::time::Duration> {
+    pub fn avg(&self) -> Option<Duration> {
         if self.count == 0 {
             return None;
         }
-        Some(std::time::Duration::from_nanos(self.acc_time / self.count))
+        Some(Duration::from_nanos(self.acc_time / self.count))
     }
 
     // AvgBytes returns the average bytes processed.
@@ -860,7 +860,7 @@ impl LastMinuteHistogram {
         }
     }
 
-    pub fn add(&mut self, size: i64, t: std::time::Duration) {
+    pub fn add(&mut self, size: i64, t: Duration) {
         let index = size_to_tag(size);
         self.histogram[index].add(&t);
     }

crates/common/src/metrics.rs

@@ -12,23 +12,21 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+use crate::last_minute::{AccElem, LastMinuteLatency};
 use chrono::{DateTime, Utc};
-use lazy_static::lazy_static;
 use rustfs_madmin::metrics::ScannerMetrics as M_ScannerMetrics;
 use std::{
     collections::HashMap,
     fmt::Display,
     pin::Pin,
     sync::{
-        Arc,
+        Arc, OnceLock,
         atomic::{AtomicU64, Ordering},
     },
     time::{Duration, SystemTime},
 };
 use tokio::sync::{Mutex, RwLock};
 
-use crate::last_minute::{AccElem, LastMinuteLatency};
-
 #[derive(Debug, Clone, Copy, PartialEq, Eq)]
 pub enum IlmAction {
     NoneAction = 0,
@@ -73,8 +71,10 @@ impl Display for IlmAction {
     }
 }
 
-lazy_static! {
-    pub static ref globalMetrics: Arc<Metrics> = Arc::new(Metrics::new());
+pub static GLOBAL_METRICS: OnceLock<Arc<Metrics>> = OnceLock::new();
+
+pub fn global_metrics() -> &'static Arc<Metrics> {
+    GLOBAL_METRICS.get_or_init(|| Arc::new(Metrics::new()))
 }
 
 #[derive(Clone, Debug, PartialEq, PartialOrd)]
@@ -294,13 +294,13 @@ impl Metrics {
             let duration = SystemTime::now().duration_since(start_time).unwrap_or_default();
 
             // Update operation count
-            globalMetrics.operations[metric].fetch_add(1, Ordering::Relaxed);
+            global_metrics().operations[metric].fetch_add(1, Ordering::Relaxed);
 
             // Update latency for realtime metrics (spawn async task for this)
             if (metric) < Metric::LastRealtime as usize {
                 let metric_index = metric;
                 tokio::spawn(async move {
-                    globalMetrics.latency[metric_index].add(duration).await;
+                    global_metrics().latency[metric_index].add(duration).await;
                 });
             }
 
@@ -319,13 +319,13 @@ impl Metrics {
             let duration = SystemTime::now().duration_since(start_time).unwrap_or_default();
 
             // Update operation count
-            globalMetrics.operations[metric].fetch_add(1, Ordering::Relaxed);
+            global_metrics().operations[metric].fetch_add(1, Ordering::Relaxed);
 
             // Update latency for realtime metrics with size (spawn async task)
             if (metric) < Metric::LastRealtime as usize {
                 let metric_index = metric;
                 tokio::spawn(async move {
-                    globalMetrics.latency[metric_index].add_size(duration, size).await;
+                    global_metrics().latency[metric_index].add_size(duration, size).await;
                 });
             }
         }
@@ -339,13 +339,13 @@ impl Metrics {
             let duration = SystemTime::now().duration_since(start_time).unwrap_or_default();
 
             // Update operation count
-            globalMetrics.operations[metric].fetch_add(1, Ordering::Relaxed);
+            global_metrics().operations[metric].fetch_add(1, Ordering::Relaxed);
 
             // Update latency for realtime metrics (spawn async task)
             if (metric) < Metric::LastRealtime as usize {
                 let metric_index = metric;
                 tokio::spawn(async move {
-                    globalMetrics.latency[metric_index].add(duration).await;
+                    global_metrics().latency[metric_index].add(duration).await;
                 });
             }
         }
@@ -360,13 +360,13 @@ impl Metrics {
                 let duration = SystemTime::now().duration_since(start_time).unwrap_or_default();
 
                 // Update operation count
-                globalMetrics.operations[metric].fetch_add(count as u64, Ordering::Relaxed);
+                global_metrics().operations[metric].fetch_add(count as u64, Ordering::Relaxed);
 
                 // Update latency for realtime metrics (spawn async task)
                 if (metric) < Metric::LastRealtime as usize {
                     let metric_index = metric;
                     tokio::spawn(async move {
-                        globalMetrics.latency[metric_index].add(duration).await;
+                        global_metrics().latency[metric_index].add(duration).await;
                     });
                 }
             })
@@ -384,8 +384,8 @@ impl Metrics {
             Box::new(move || {
                 let duration = SystemTime::now().duration_since(start).unwrap_or(Duration::from_secs(0));
                 tokio::spawn(async move {
-                    globalMetrics.actions[a_clone].fetch_add(versions, Ordering::Relaxed);
-                    globalMetrics.actions_latency[a_clone].add(duration).await;
+                    global_metrics().actions[a_clone].fetch_add(versions, Ordering::Relaxed);
+                    global_metrics().actions_latency[a_clone].add(duration).await;
                 });
             })
         })
@@ -395,11 +395,11 @@ impl Metrics {
     pub async fn inc_time(metric: Metric, duration: Duration) {
         let metric = metric as usize;
         // Update operation count
-        globalMetrics.operations[metric].fetch_add(1, Ordering::Relaxed);
+        global_metrics().operations[metric].fetch_add(1, Ordering::Relaxed);
 
         // Update latency for realtime metrics
         if (metric) < Metric::LastRealtime as usize {
-            globalMetrics.latency[metric].add(duration).await;
+            global_metrics().latency[metric].add(duration).await;
         }
     }
 
@@ -501,7 +501,7 @@ pub fn current_path_updater(disk: &str, initial: &str) -> (UpdateCurrentPathFn,
     let tracker_clone = Arc::clone(&tracker);
     let disk_clone = disk_name.clone();
     tokio::spawn(async move {
-        globalMetrics.current_paths.write().await.insert(disk_clone, tracker_clone);
+        global_metrics().current_paths.write().await.insert(disk_clone, tracker_clone);
     });
 
     let update_fn = {
@@ -520,7 +520,7 @@ pub fn current_path_updater(disk: &str, initial: &str) -> (UpdateCurrentPathFn,
         Arc::new(move || -> Pin<Box<dyn std::future::Future<Output = ()> + Send>> {
             let disk_name = disk_name.clone();
             Box::pin(async move {
-                globalMetrics.current_paths.write().await.remove(&disk_name);
+                global_metrics().current_paths.write().await.remove(&disk_name);
             })
         })
     };

crates/config/Cargo.toml

@@ -36,4 +36,4 @@ audit = ["dep:const-str", "constants"]
 constants = ["dep:const-str"]
 notify = ["dep:const-str", "constants"]
 observability = ["constants"]
-
+opa = ["constants"]

crates/config/src/audit/mod.rs

@@ -13,19 +13,24 @@
 //  limitations under the License.
 
 //! Audit configuration module
-//! //! This module defines the configuration for audit systems, including
-//! webhook and other audit-related settings.
+//! This module defines the configuration for audit systems, including
+//! webhook and MQTT audit-related settings.
+
+mod mqtt;
+mod webhook;
+
+pub use mqtt::*;
+pub use webhook::*;
+
+use crate::DEFAULT_DELIMITER;
+// --- Audit subsystem identifiers ---
+pub const AUDIT_PREFIX: &str = "audit";
+
+pub const AUDIT_ROUTE_PREFIX: &str = const_str::concat!(AUDIT_PREFIX, DEFAULT_DELIMITER);
+
 pub const AUDIT_WEBHOOK_SUB_SYS: &str = "audit_webhook";
+pub const AUDIT_MQTT_SUB_SYS: &str = "mqtt_webhook";
 
 pub const AUDIT_STORE_EXTENSION: &str = ".audit";
-
-pub const WEBHOOK_ENDPOINT: &str = "endpoint";
-pub const WEBHOOK_AUTH_TOKEN: &str = "auth_token";
-pub const WEBHOOK_CLIENT_CERT: &str = "client_cert";
-pub const WEBHOOK_CLIENT_KEY: &str = "client_key";
-pub const WEBHOOK_BATCH_SIZE: &str = "batch_size";
-pub const WEBHOOK_QUEUE_SIZE: &str = "queue_size";
-pub const WEBHOOK_QUEUE_DIR: &str = "queue_dir";
-pub const WEBHOOK_MAX_RETRY: &str = "max_retry";
-pub const WEBHOOK_RETRY_INTERVAL: &str = "retry_interval";
-pub const WEBHOOK_HTTP_TIMEOUT: &str = "http_timeout";
+#[allow(dead_code)]
+pub const AUDIT_SUB_SYSTEMS: &[&str] = &[AUDIT_MQTT_SUB_SYS, AUDIT_WEBHOOK_SUB_SYS];

crates/config/src/audit/mqtt.rs

@@ -0,0 +1,54 @@
+//  Copyright 2024 RustFS Team
+//
+//  Licensed under the Apache License, Version 2.0 (the "License");
+//  you may not use this file except in compliance with the License.
+//  You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+//  Unless required by applicable law or agreed to in writing, software
+//  distributed under the License is distributed on an "AS IS" BASIS,
+//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+//  See the License for the specific language governing permissions and
+//  limitations under the License.
+
+// MQTT Environment Variables
+pub const ENV_AUDIT_MQTT_ENABLE: &str = "RUSTFS_AUDIT_MQTT_ENABLE";
+pub const ENV_AUDIT_MQTT_BROKER: &str = "RUSTFS_AUDIT_MQTT_BROKER";
+pub const ENV_AUDIT_MQTT_TOPIC: &str = "RUSTFS_AUDIT_MQTT_TOPIC";
+pub const ENV_AUDIT_MQTT_QOS: &str = "RUSTFS_AUDIT_MQTT_QOS";
+pub const ENV_AUDIT_MQTT_USERNAME: &str = "RUSTFS_AUDIT_MQTT_USERNAME";
+pub const ENV_AUDIT_MQTT_PASSWORD: &str = "RUSTFS_AUDIT_MQTT_PASSWORD";
+pub const ENV_AUDIT_MQTT_RECONNECT_INTERVAL: &str = "RUSTFS_AUDIT_MQTT_RECONNECT_INTERVAL";
+pub const ENV_AUDIT_MQTT_KEEP_ALIVE_INTERVAL: &str = "RUSTFS_AUDIT_MQTT_KEEP_ALIVE_INTERVAL";
+pub const ENV_AUDIT_MQTT_QUEUE_DIR: &str = "RUSTFS_AUDIT_MQTT_QUEUE_DIR";
+pub const ENV_AUDIT_MQTT_QUEUE_LIMIT: &str = "RUSTFS_AUDIT_MQTT_QUEUE_LIMIT";
+
+/// A list of all valid configuration keys for an MQTT target.
+pub const ENV_AUDIT_MQTT_KEYS: &[&str; 10] = &[
+    ENV_AUDIT_MQTT_ENABLE,
+    ENV_AUDIT_MQTT_BROKER,
+    ENV_AUDIT_MQTT_TOPIC,
+    ENV_AUDIT_MQTT_QOS,
+    ENV_AUDIT_MQTT_USERNAME,
+    ENV_AUDIT_MQTT_PASSWORD,
+    ENV_AUDIT_MQTT_RECONNECT_INTERVAL,
+    ENV_AUDIT_MQTT_KEEP_ALIVE_INTERVAL,
+    ENV_AUDIT_MQTT_QUEUE_DIR,
+    ENV_AUDIT_MQTT_QUEUE_LIMIT,
+];
+
+/// A list of all valid configuration keys for an MQTT target.
+pub const AUDIT_MQTT_KEYS: &[&str] = &[
+    crate::ENABLE_KEY,
+    crate::MQTT_BROKER,
+    crate::MQTT_TOPIC,
+    crate::MQTT_QOS,
+    crate::MQTT_USERNAME,
+    crate::MQTT_PASSWORD,
+    crate::MQTT_RECONNECT_INTERVAL,
+    crate::MQTT_KEEP_ALIVE_INTERVAL,
+    crate::MQTT_QUEUE_DIR,
+    crate::MQTT_QUEUE_LIMIT,
+    crate::COMMENT_KEY,
+];

crates/config/src/audit/webhook.rs

@@ -0,0 +1,45 @@
+//  Copyright 2024 RustFS Team
+//
+//  Licensed under the Apache License, Version 2.0 (the "License");
+//  you may not use this file except in compliance with the License.
+//  You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+//  Unless required by applicable law or agreed to in writing, software
+//  distributed under the License is distributed on an "AS IS" BASIS,
+//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+//  See the License for the specific language governing permissions and
+//  limitations under the License.
+
+// Webhook Environment Variables
+pub const ENV_AUDIT_WEBHOOK_ENABLE: &str = "RUSTFS_AUDIT_WEBHOOK_ENABLE";
+pub const ENV_AUDIT_WEBHOOK_ENDPOINT: &str = "RUSTFS_AUDIT_WEBHOOK_ENDPOINT";
+pub const ENV_AUDIT_WEBHOOK_AUTH_TOKEN: &str = "RUSTFS_AUDIT_WEBHOOK_AUTH_TOKEN";
+pub const ENV_AUDIT_WEBHOOK_QUEUE_LIMIT: &str = "RUSTFS_AUDIT_WEBHOOK_QUEUE_LIMIT";
+pub const ENV_AUDIT_WEBHOOK_QUEUE_DIR: &str = "RUSTFS_AUDIT_WEBHOOK_QUEUE_DIR";
+pub const ENV_AUDIT_WEBHOOK_CLIENT_CERT: &str = "RUSTFS_AUDIT_WEBHOOK_CLIENT_CERT";
+pub const ENV_AUDIT_WEBHOOK_CLIENT_KEY: &str = "RUSTFS_AUDIT_WEBHOOK_CLIENT_KEY";
+
+/// List of all environment variable keys for a webhook target.
+pub const ENV_AUDIT_WEBHOOK_KEYS: &[&str; 7] = &[
+    ENV_AUDIT_WEBHOOK_ENABLE,
+    ENV_AUDIT_WEBHOOK_ENDPOINT,
+    ENV_AUDIT_WEBHOOK_AUTH_TOKEN,
+    ENV_AUDIT_WEBHOOK_QUEUE_LIMIT,
+    ENV_AUDIT_WEBHOOK_QUEUE_DIR,
+    ENV_AUDIT_WEBHOOK_CLIENT_CERT,
+    ENV_AUDIT_WEBHOOK_CLIENT_KEY,
+];
+
+/// A list of all valid configuration keys for a webhook target.
+pub const AUDIT_WEBHOOK_KEYS: &[&str] = &[
+    crate::ENABLE_KEY,
+    crate::WEBHOOK_ENDPOINT,
+    crate::WEBHOOK_AUTH_TOKEN,
+    crate::WEBHOOK_QUEUE_LIMIT,
+    crate::WEBHOOK_QUEUE_DIR,
+    crate::WEBHOOK_CLIENT_CERT,
+    crate::WEBHOOK_CLIENT_KEY,
+    crate::COMMENT_KEY,
+];

crates/config/src/constants/app.rs

@@ -21,12 +21,12 @@ pub const APP_NAME: &str = "RustFS";
 /// Application version
 /// Default value: 1.0.0
 /// Environment variable: RUSTFS_VERSION
-pub const VERSION: &str = "0.0.1";
+pub const VERSION: &str = "1.0.0";
 
 /// Default configuration logger level
-/// Default value: info
+/// Default value: error
 /// Environment variable: RUSTFS_LOG_LEVEL
-pub const DEFAULT_LOG_LEVEL: &str = "info";
+pub const DEFAULT_LOG_LEVEL: &str = "error";
 
 /// Default configuration use stdout
 /// Default value: false
@@ -40,22 +40,15 @@ pub const SAMPLE_RATIO: f64 = 1.0;
 pub const METER_INTERVAL: u64 = 30;
 
 /// Default configuration service version
-/// Default value: 0.0.1
-pub const SERVICE_VERSION: &str = "0.0.1";
+/// Default value: 1.0.0
+/// Environment variable: RUSTFS_OBS_SERVICE_VERSION
+/// Uses the same value as VERSION constant
+pub const SERVICE_VERSION: &str = "1.0.0";
 
 /// Default configuration environment
 /// Default value: production
 pub const ENVIRONMENT: &str = "production";
 
-/// maximum number of connections
-/// This is the maximum number of connections that the server will accept.
-/// This is used to limit the number of connections to the server.
-pub const MAX_CONNECTIONS: usize = 100;
-/// timeout for connections
-/// This is the timeout for connections to the server.
-/// This is used to limit the time that a connection can be open.
-pub const DEFAULT_TIMEOUT_MS: u64 = 3000;
-
 /// Default Access Key
 /// Default value: rustfsadmin
 /// Environment variable: RUSTFS_ACCESS_KEY
@@ -126,12 +119,6 @@ pub const DEFAULT_LOG_FILENAME: &str = "rustfs";
 /// Default value: rustfs.log
 pub const DEFAULT_OBS_LOG_FILENAME: &str = concat!(DEFAULT_LOG_FILENAME, "");
 
-/// Default sink file log file for rustfs
-/// This is the default sink file log file for rustfs.
-/// It is used to store the logs of the application.
-/// Default value: rustfs-sink.log
-pub const DEFAULT_SINK_FILE_LOG_FILE: &str = concat!(DEFAULT_LOG_FILENAME, "-sink.log");
-
 /// Default log directory for rustfs
 /// This is the default log directory for rustfs.
 /// It is used to store the logs of the application.
@@ -151,7 +138,7 @@ pub const DEFAULT_LOG_ROTATION_SIZE_MB: u64 = 100;
 /// It is used to rotate the logs of the application.
 /// Default value: hour, eg: day,hour,minute,second
 /// Environment variable: RUSTFS_OBS_LOG_ROTATION_TIME
-pub const DEFAULT_LOG_ROTATION_TIME: &str = "day";
+pub const DEFAULT_LOG_ROTATION_TIME: &str = "hour";
 
 /// Default log keep files for rustfs
 /// This is the default log keep files for rustfs.
@@ -160,15 +147,19 @@ pub const DEFAULT_LOG_ROTATION_TIME: &str = "day";
 /// Environment variable: RUSTFS_OBS_LOG_KEEP_FILES
 pub const DEFAULT_LOG_KEEP_FILES: u16 = 30;
 
-/// This is the external address for rustfs to access endpoint (used in Docker deployments).
-/// This should match the mapped host port when using Docker port mapping.
-/// Example: ":9020" when mapping host port 9020 to container port 9000.
-/// Default value: DEFAULT_ADDRESS
-/// Environment variable: RUSTFS_EXTERNAL_ADDRESS
-/// Command line argument: --external-address
-/// Example: RUSTFS_EXTERNAL_ADDRESS=":9020"
-/// Example: --external-address ":9020"
-pub const ENV_EXTERNAL_ADDRESS: &str = "RUSTFS_EXTERNAL_ADDRESS";
+/// Default log local logging enabled for rustfs
+/// This is the default log local logging enabled for rustfs.
+/// It is used to enable or disable local logging of the application.
+/// Default value: false
+/// Environment variable: RUSTFS_OBS_LOGL_STDOUT_ENABLED
+pub const DEFAULT_OBS_LOG_STDOUT_ENABLED: bool = false;
+
+/// Constant representing 1 Kibibyte (1024 bytes)
+/// Default value: 1024
+pub const KI_B: usize = 1024;
+/// Constant representing 1 Mebibyte (1024 * 1024 bytes)
+/// Default value: 1048576
+pub const MI_B: usize = 1024 * 1024;
 
 #[cfg(test)]
 mod tests {
@@ -180,16 +171,16 @@ mod tests {
         assert_eq!(APP_NAME, "RustFS");
         assert!(!APP_NAME.contains(' '), "App name should not contain spaces");
 
-        assert_eq!(VERSION, "0.0.1");
+        assert_eq!(VERSION, "1.0.0");
 
-        assert_eq!(SERVICE_VERSION, "0.0.1");
+        assert_eq!(SERVICE_VERSION, "1.0.0");
         assert_eq!(VERSION, SERVICE_VERSION, "Version and service version should be consistent");
     }
 
     #[test]
     fn test_logging_constants() {
         // Test logging related constants
-        assert_eq!(DEFAULT_LOG_LEVEL, "info");
+        assert_eq!(DEFAULT_LOG_LEVEL, "error");
         assert!(
             ["trace", "debug", "info", "warn", "error"].contains(&DEFAULT_LOG_LEVEL),
             "Log level should be a valid tracing level"
@@ -210,14 +201,6 @@ mod tests {
         );
     }
 
-    #[test]
-    fn test_connection_constants() {
-        // Test connection related constants
-        assert_eq!(MAX_CONNECTIONS, 100);
-
-        assert_eq!(DEFAULT_TIMEOUT_MS, 3000);
-    }
-
     #[test]
     fn test_security_constants() {
         // Test security related constants
@@ -320,8 +303,8 @@ mod tests {
         // assert!(DEFAULT_TIMEOUT_MS < u64::MAX, "Timeout should be reasonable");
 
         // These are const non-zero values, so zero checks are redundant
-        // assert!(DEFAULT_PORT != 0, "Default port should not be zero");
-        // assert!(DEFAULT_CONSOLE_PORT != 0, "Console port should not be zero");
+        assert_ne!(DEFAULT_PORT, 0, "Default port should not be zero");
+        assert_ne!(DEFAULT_CONSOLE_PORT, 0, "Console port should not be zero");
     }
 
     #[test]

crates/config/src/constants/console.rs

@@ -79,3 +79,13 @@ pub const ENV_CONSOLE_AUTH_TIMEOUT: &str = "RUSTFS_CONSOLE_AUTH_TIMEOUT";
 /// Example: RUSTFS_CONSOLE_AUTH_TIMEOUT=3600
 /// Example: --console-auth-timeout 3600
 pub const DEFAULT_CONSOLE_AUTH_TIMEOUT: u64 = 3600;
+
+/// Toggle update check
+/// It controls whether to check for newer versions of rustfs
+/// Default value: true
+/// Environment variable: RUSTFS_CHECK_UPDATE
+/// Example: RUSTFS_CHECK_UPDATE=false
+pub const ENV_UPDATE_CHECK: &str = "RUSTFS_CHECK_UPDATE";
+
+/// Default value for update toggle
+pub const DEFAULT_UPDATE_CHECK: bool = true;

crates/config/src/constants/mod.rs

@@ -15,4 +15,7 @@
 pub(crate) mod app;
 pub(crate) mod console;
 pub(crate) mod env;
+pub(crate) mod profiler;
+pub(crate) mod runtime;
+pub(crate) mod targets;
 pub(crate) mod tls;

crates/config/src/constants/profiler.rs

@@ -0,0 +1,41 @@
+// Copyright 2024 RustFS Team
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+pub const ENV_ENABLE_PROFILING: &str = "RUSTFS_ENABLE_PROFILING";
+
+// CPU profiling
+pub const ENV_CPU_MODE: &str = "RUSTFS_PROF_CPU_MODE"; // off|continuous|periodic
+pub const ENV_CPU_FREQ: &str = "RUSTFS_PROF_CPU_FREQ";
+pub const ENV_CPU_INTERVAL_SECS: &str = "RUSTFS_PROF_CPU_INTERVAL_SECS";
+pub const ENV_CPU_DURATION_SECS: &str = "RUSTFS_PROF_CPU_DURATION_SECS";
+
+// Memory profiling (jemalloc)
+pub const ENV_MEM_PERIODIC: &str = "RUSTFS_PROF_MEM_PERIODIC";
+pub const ENV_MEM_INTERVAL_SECS: &str = "RUSTFS_PROF_MEM_INTERVAL_SECS";
+
+// Output directory
+pub const ENV_OUTPUT_DIR: &str = "RUSTFS_PROF_OUTPUT_DIR";
+
+// Defaults
+pub const DEFAULT_ENABLE_PROFILING: bool = false;
+
+pub const DEFAULT_CPU_MODE: &str = "off";
+pub const DEFAULT_CPU_FREQ: usize = 100;
+pub const DEFAULT_CPU_INTERVAL_SECS: u64 = 300;
+pub const DEFAULT_CPU_DURATION_SECS: u64 = 60;
+
+pub const DEFAULT_MEM_PERIODIC: bool = false;
+pub const DEFAULT_MEM_INTERVAL_SECS: u64 = 300;
+
+pub const DEFAULT_OUTPUT_DIR: &str = ".";

crates/config/src/constants/runtime.rs

@@ -0,0 +1,41 @@
+//  Copyright 2024 RustFS Team
+//
+//  Licensed under the Apache License, Version 2.0 (the "License");
+//  you may not use this file except in compliance with the License.
+//  You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+//  Unless required by applicable law or agreed to in writing, software
+//  distributed under the License is distributed on an "AS IS" BASIS,
+//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+//  See the License for the specific language governing permissions and
+//  limitations under the License.
+
+use crate::MI_B;
+
+// Tokio runtime ENV keys
+pub const ENV_WORKER_THREADS: &str = "RUSTFS_RUNTIME_WORKER_THREADS";
+pub const ENV_MAX_BLOCKING_THREADS: &str = "RUSTFS_RUNTIME_MAX_BLOCKING_THREADS";
+pub const ENV_THREAD_PRINT_ENABLED: &str = "RUSTFS_RUNTIME_THREAD_PRINT_ENABLED";
+pub const ENV_THREAD_STACK_SIZE: &str = "RUSTFS_RUNTIME_THREAD_STACK_SIZE";
+pub const ENV_THREAD_KEEP_ALIVE: &str = "RUSTFS_RUNTIME_THREAD_KEEP_ALIVE";
+pub const ENV_GLOBAL_QUEUE_INTERVAL: &str = "RUSTFS_RUNTIME_GLOBAL_QUEUE_INTERVAL";
+pub const ENV_THREAD_NAME: &str = "RUSTFS_RUNTIME_THREAD_NAME";
+pub const ENV_MAX_IO_EVENTS_PER_TICK: &str = "RUSTFS_RUNTIME_MAX_IO_EVENTS_PER_TICK";
+pub const ENV_RNG_SEED: &str = "RUSTFS_RUNTIME_RNG_SEED";
+/// Event polling interval
+pub const ENV_EVENT_INTERVAL: &str = "RUSTFS_RUNTIME_EVENT_INTERVAL";
+
+// Default values for Tokio runtime
+pub const DEFAULT_WORKER_THREADS: usize = 16;
+pub const DEFAULT_MAX_BLOCKING_THREADS: usize = 1024;
+pub const DEFAULT_THREAD_PRINT_ENABLED: bool = false;
+pub const DEFAULT_THREAD_STACK_SIZE: usize = MI_B; // 1 MiB
+pub const DEFAULT_THREAD_KEEP_ALIVE: u64 = 60; // seconds
+pub const DEFAULT_GLOBAL_QUEUE_INTERVAL: u32 = 31;
+pub const DEFAULT_THREAD_NAME: &str = "rustfs-worker";
+pub const DEFAULT_MAX_IO_EVENTS_PER_TICK: usize = 1024;
+/// Event polling default (Tokio default 61)
+pub const DEFAULT_EVENT_INTERVAL: u32 = 61;
+pub const DEFAULT_RNG_SEED: Option<u64> = None; // None means random

crates/config/src/constants/targets.rs

@@ -0,0 +1,34 @@
+//  Copyright 2024 RustFS Team
+//
+//  Licensed under the Apache License, Version 2.0 (the "License");
+//  you may not use this file except in compliance with the License.
+//  You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+//  Unless required by applicable law or agreed to in writing, software
+//  distributed under the License is distributed on an "AS IS" BASIS,
+//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+//  See the License for the specific language governing permissions and
+//  limitations under the License.
+
+pub const WEBHOOK_ENDPOINT: &str = "endpoint";
+pub const WEBHOOK_AUTH_TOKEN: &str = "auth_token";
+pub const WEBHOOK_CLIENT_CERT: &str = "client_cert";
+pub const WEBHOOK_CLIENT_KEY: &str = "client_key";
+pub const WEBHOOK_BATCH_SIZE: &str = "batch_size";
+pub const WEBHOOK_QUEUE_LIMIT: &str = "queue_limit";
+pub const WEBHOOK_QUEUE_DIR: &str = "queue_dir";
+pub const WEBHOOK_MAX_RETRY: &str = "max_retry";
+pub const WEBHOOK_RETRY_INTERVAL: &str = "retry_interval";
+pub const WEBHOOK_HTTP_TIMEOUT: &str = "http_timeout";
+
+pub const MQTT_BROKER: &str = "broker";
+pub const MQTT_TOPIC: &str = "topic";
+pub const MQTT_QOS: &str = "qos";
+pub const MQTT_USERNAME: &str = "username";
+pub const MQTT_PASSWORD: &str = "password";
+pub const MQTT_RECONNECT_INTERVAL: &str = "reconnect_interval";
+pub const MQTT_KEEP_ALIVE_INTERVAL: &str = "keep_alive_interval";
+pub const MQTT_QUEUE_DIR: &str = "queue_dir";
+pub const MQTT_QUEUE_LIMIT: &str = "queue_limit";

crates/config/src/lib.rs

@@ -21,6 +21,12 @@ pub use constants::console::*;
 #[cfg(feature = "constants")]
 pub use constants::env::*;
 #[cfg(feature = "constants")]
+pub use constants::profiler::*;
+#[cfg(feature = "constants")]
+pub use constants::runtime::*;
+#[cfg(feature = "constants")]
+pub use constants::targets::*;
+#[cfg(feature = "constants")]
 pub use constants::tls::*;
 #[cfg(feature = "audit")]
 pub mod audit;
@@ -28,3 +34,5 @@ pub mod audit;
 pub mod notify;
 #[cfg(feature = "observability")]
 pub mod observability;
+#[cfg(feature = "opa")]
+pub mod opa;

crates/config/src/notify/mod.rs

@@ -22,12 +22,14 @@ pub use mqtt::*;
 pub use store::*;
 pub use webhook::*;
 
+use crate::DEFAULT_DELIMITER;
+
 // --- Configuration Constants ---
 pub const DEFAULT_TARGET: &str = "1";
 
 pub const NOTIFY_PREFIX: &str = "notify";
 
-pub const NOTIFY_ROUTE_PREFIX: &str = const_str::concat!(NOTIFY_PREFIX, "_");
+pub const NOTIFY_ROUTE_PREFIX: &str = const_str::concat!(NOTIFY_PREFIX, DEFAULT_DELIMITER);
 
 #[allow(dead_code)]
 pub const NOTIFY_SUB_SYSTEMS: &[&str] = &[NOTIFY_MQTT_SUB_SYS, NOTIFY_WEBHOOK_SUB_SYS];

crates/config/src/notify/mqtt.rs

@@ -12,55 +12,42 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use crate::{COMMENT_KEY, ENABLE_KEY};
-
-// MQTT Keys
-pub const MQTT_BROKER: &str = "broker";
-pub const MQTT_TOPIC: &str = "topic";
-pub const MQTT_QOS: &str = "qos";
-pub const MQTT_USERNAME: &str = "username";
-pub const MQTT_PASSWORD: &str = "password";
-pub const MQTT_RECONNECT_INTERVAL: &str = "reconnect_interval";
-pub const MQTT_KEEP_ALIVE_INTERVAL: &str = "keep_alive_interval";
-pub const MQTT_QUEUE_DIR: &str = "queue_dir";
-pub const MQTT_QUEUE_LIMIT: &str = "queue_limit";
-
 /// A list of all valid configuration keys for an MQTT target.
 pub const NOTIFY_MQTT_KEYS: &[&str] = &[
-    ENABLE_KEY,
-    MQTT_BROKER,
-    MQTT_TOPIC,
-    MQTT_QOS,
-    MQTT_USERNAME,
-    MQTT_PASSWORD,
-    MQTT_RECONNECT_INTERVAL,
-    MQTT_KEEP_ALIVE_INTERVAL,
-    MQTT_QUEUE_DIR,
-    MQTT_QUEUE_LIMIT,
-    COMMENT_KEY,
+    crate::ENABLE_KEY,
+    crate::MQTT_BROKER,
+    crate::MQTT_TOPIC,
+    crate::MQTT_QOS,
+    crate::MQTT_USERNAME,
+    crate::MQTT_PASSWORD,
+    crate::MQTT_RECONNECT_INTERVAL,
+    crate::MQTT_KEEP_ALIVE_INTERVAL,
+    crate::MQTT_QUEUE_DIR,
+    crate::MQTT_QUEUE_LIMIT,
+    crate::COMMENT_KEY,
 ];
 
 // MQTT Environment Variables
-pub const ENV_MQTT_ENABLE: &str = "RUSTFS_NOTIFY_MQTT_ENABLE";
-pub const ENV_MQTT_BROKER: &str = "RUSTFS_NOTIFY_MQTT_BROKER";
-pub const ENV_MQTT_TOPIC: &str = "RUSTFS_NOTIFY_MQTT_TOPIC";
-pub const ENV_MQTT_QOS: &str = "RUSTFS_NOTIFY_MQTT_QOS";
-pub const ENV_MQTT_USERNAME: &str = "RUSTFS_NOTIFY_MQTT_USERNAME";
-pub const ENV_MQTT_PASSWORD: &str = "RUSTFS_NOTIFY_MQTT_PASSWORD";
-pub const ENV_MQTT_RECONNECT_INTERVAL: &str = "RUSTFS_NOTIFY_MQTT_RECONNECT_INTERVAL";
-pub const ENV_MQTT_KEEP_ALIVE_INTERVAL: &str = "RUSTFS_NOTIFY_MQTT_KEEP_ALIVE_INTERVAL";
-pub const ENV_MQTT_QUEUE_DIR: &str = "RUSTFS_NOTIFY_MQTT_QUEUE_DIR";
-pub const ENV_MQTT_QUEUE_LIMIT: &str = "RUSTFS_NOTIFY_MQTT_QUEUE_LIMIT";
+pub const ENV_NOTIFY_MQTT_ENABLE: &str = "RUSTFS_NOTIFY_MQTT_ENABLE";
+pub const ENV_NOTIFY_MQTT_BROKER: &str = "RUSTFS_NOTIFY_MQTT_BROKER";
+pub const ENV_NOTIFY_MQTT_TOPIC: &str = "RUSTFS_NOTIFY_MQTT_TOPIC";
+pub const ENV_NOTIFY_MQTT_QOS: &str = "RUSTFS_NOTIFY_MQTT_QOS";
+pub const ENV_NOTIFY_MQTT_USERNAME: &str = "RUSTFS_NOTIFY_MQTT_USERNAME";
+pub const ENV_NOTIFY_MQTT_PASSWORD: &str = "RUSTFS_NOTIFY_MQTT_PASSWORD";
+pub const ENV_NOTIFY_MQTT_RECONNECT_INTERVAL: &str = "RUSTFS_NOTIFY_MQTT_RECONNECT_INTERVAL";
+pub const ENV_NOTIFY_MQTT_KEEP_ALIVE_INTERVAL: &str = "RUSTFS_NOTIFY_MQTT_KEEP_ALIVE_INTERVAL";
+pub const ENV_NOTIFY_MQTT_QUEUE_DIR: &str = "RUSTFS_NOTIFY_MQTT_QUEUE_DIR";
+pub const ENV_NOTIFY_MQTT_QUEUE_LIMIT: &str = "RUSTFS_NOTIFY_MQTT_QUEUE_LIMIT";
 
 pub const ENV_NOTIFY_MQTT_KEYS: &[&str; 10] = &[
-    ENV_MQTT_ENABLE,
-    ENV_MQTT_BROKER,
-    ENV_MQTT_TOPIC,
-    ENV_MQTT_QOS,
-    ENV_MQTT_USERNAME,
-    ENV_MQTT_PASSWORD,
-    ENV_MQTT_RECONNECT_INTERVAL,
-    ENV_MQTT_KEEP_ALIVE_INTERVAL,
-    ENV_MQTT_QUEUE_DIR,
-    ENV_MQTT_QUEUE_LIMIT,
+    ENV_NOTIFY_MQTT_ENABLE,
+    ENV_NOTIFY_MQTT_BROKER,
+    ENV_NOTIFY_MQTT_TOPIC,
+    ENV_NOTIFY_MQTT_QOS,
+    ENV_NOTIFY_MQTT_USERNAME,
+    ENV_NOTIFY_MQTT_PASSWORD,
+    ENV_NOTIFY_MQTT_RECONNECT_INTERVAL,
+    ENV_NOTIFY_MQTT_KEEP_ALIVE_INTERVAL,
+    ENV_NOTIFY_MQTT_QUEUE_DIR,
+    ENV_NOTIFY_MQTT_QUEUE_LIMIT,
 ];

crates/config/src/notify/webhook.rs

@@ -12,43 +12,33 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-use crate::{COMMENT_KEY, ENABLE_KEY};
-
-// Webhook Keys
-pub const WEBHOOK_ENDPOINT: &str = "endpoint";
-pub const WEBHOOK_AUTH_TOKEN: &str = "auth_token";
-pub const WEBHOOK_QUEUE_LIMIT: &str = "queue_limit";
-pub const WEBHOOK_QUEUE_DIR: &str = "queue_dir";
-pub const WEBHOOK_CLIENT_CERT: &str = "client_cert";
-pub const WEBHOOK_CLIENT_KEY: &str = "client_key";
-
 /// A list of all valid configuration keys for a webhook target.
 pub const NOTIFY_WEBHOOK_KEYS: &[&str] = &[
-    ENABLE_KEY,
-    WEBHOOK_ENDPOINT,
-    WEBHOOK_AUTH_TOKEN,
-    WEBHOOK_QUEUE_LIMIT,
-    WEBHOOK_QUEUE_DIR,
-    WEBHOOK_CLIENT_CERT,
-    WEBHOOK_CLIENT_KEY,
-    COMMENT_KEY,
+    crate::ENABLE_KEY,
+    crate::WEBHOOK_ENDPOINT,
+    crate::WEBHOOK_AUTH_TOKEN,
+    crate::WEBHOOK_QUEUE_LIMIT,
+    crate::WEBHOOK_QUEUE_DIR,
+    crate::WEBHOOK_CLIENT_CERT,
+    crate::WEBHOOK_CLIENT_KEY,
+    crate::COMMENT_KEY,
 ];
 
 // Webhook Environment Variables
-pub const ENV_WEBHOOK_ENABLE: &str = "RUSTFS_NOTIFY_WEBHOOK_ENABLE";
-pub const ENV_WEBHOOK_ENDPOINT: &str = "RUSTFS_NOTIFY_WEBHOOK_ENDPOINT";
-pub const ENV_WEBHOOK_AUTH_TOKEN: &str = "RUSTFS_NOTIFY_WEBHOOK_AUTH_TOKEN";
-pub const ENV_WEBHOOK_QUEUE_LIMIT: &str = "RUSTFS_NOTIFY_WEBHOOK_QUEUE_LIMIT";
-pub const ENV_WEBHOOK_QUEUE_DIR: &str = "RUSTFS_NOTIFY_WEBHOOK_QUEUE_DIR";
-pub const ENV_WEBHOOK_CLIENT_CERT: &str = "RUSTFS_NOTIFY_WEBHOOK_CLIENT_CERT";
-pub const ENV_WEBHOOK_CLIENT_KEY: &str = "RUSTFS_NOTIFY_WEBHOOK_CLIENT_KEY";
+pub const ENV_NOTIFY_WEBHOOK_ENABLE: &str = "RUSTFS_NOTIFY_WEBHOOK_ENABLE";
+pub const ENV_NOTIFY_WEBHOOK_ENDPOINT: &str = "RUSTFS_NOTIFY_WEBHOOK_ENDPOINT";
+pub const ENV_NOTIFY_WEBHOOK_AUTH_TOKEN: &str = "RUSTFS_NOTIFY_WEBHOOK_AUTH_TOKEN";
+pub const ENV_NOTIFY_WEBHOOK_QUEUE_LIMIT: &str = "RUSTFS_NOTIFY_WEBHOOK_QUEUE_LIMIT";
+pub const ENV_NOTIFY_WEBHOOK_QUEUE_DIR: &str = "RUSTFS_NOTIFY_WEBHOOK_QUEUE_DIR";
+pub const ENV_NOTIFY_WEBHOOK_CLIENT_CERT: &str = "RUSTFS_NOTIFY_WEBHOOK_CLIENT_CERT";
+pub const ENV_NOTIFY_WEBHOOK_CLIENT_KEY: &str = "RUSTFS_NOTIFY_WEBHOOK_CLIENT_KEY";
 
 pub const ENV_NOTIFY_WEBHOOK_KEYS: &[&str; 7] = &[
-    ENV_WEBHOOK_ENABLE,
-    ENV_WEBHOOK_ENDPOINT,
-    ENV_WEBHOOK_AUTH_TOKEN,
-    ENV_WEBHOOK_QUEUE_LIMIT,
-    ENV_WEBHOOK_QUEUE_DIR,
-    ENV_WEBHOOK_CLIENT_CERT,
-    ENV_WEBHOOK_CLIENT_KEY,
+    ENV_NOTIFY_WEBHOOK_ENABLE,
+    ENV_NOTIFY_WEBHOOK_ENDPOINT,
+    ENV_NOTIFY_WEBHOOK_AUTH_TOKEN,
+    ENV_NOTIFY_WEBHOOK_QUEUE_LIMIT,
+    ENV_NOTIFY_WEBHOOK_QUEUE_DIR,
+    ENV_NOTIFY_WEBHOOK_CLIENT_CERT,
+    ENV_NOTIFY_WEBHOOK_CLIENT_KEY,
 ];

crates/config/src/observability/config.rs

@@ -1,35 +0,0 @@
-// Copyright 2024 RustFS Team
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-// Observability Keys
-
-pub const ENV_OBS_ENDPOINT: &str = "RUSTFS_OBS_ENDPOINT";
-pub const ENV_OBS_USE_STDOUT: &str = "RUSTFS_OBS_USE_STDOUT";
-pub const ENV_OBS_SAMPLE_RATIO: &str = "RUSTFS_OBS_SAMPLE_RATIO";
-pub const ENV_OBS_METER_INTERVAL: &str = "RUSTFS_OBS_METER_INTERVAL";
-pub const ENV_OBS_SERVICE_NAME: &str = "RUSTFS_OBS_SERVICE_NAME";
-pub const ENV_OBS_SERVICE_VERSION: &str = "RUSTFS_OBS_SERVICE_VERSION";
-pub const ENV_OBS_ENVIRONMENT: &str = "RUSTFS_OBS_ENVIRONMENT";
-pub const ENV_OBS_LOGGER_LEVEL: &str = "RUSTFS_OBS_LOGGER_LEVEL";
-pub const ENV_OBS_LOCAL_LOGGING_ENABLED: &str = "RUSTFS_OBS_LOCAL_LOGGING_ENABLED";
-pub const ENV_OBS_LOG_DIRECTORY: &str = "RUSTFS_OBS_LOG_DIRECTORY";
-pub const ENV_OBS_LOG_FILENAME: &str = "RUSTFS_OBS_LOG_FILENAME";
-pub const ENV_OBS_LOG_ROTATION_SIZE_MB: &str = "RUSTFS_OBS_LOG_ROTATION_SIZE_MB";
-pub const ENV_OBS_LOG_ROTATION_TIME: &str = "RUSTFS_OBS_LOG_ROTATION_TIME";
-pub const ENV_OBS_LOG_KEEP_FILES: &str = "RUSTFS_OBS_LOG_KEEP_FILES";
-
-pub const ENV_AUDIT_LOGGER_QUEUE_CAPACITY: &str = "RUSTFS_AUDIT_LOGGER_QUEUE_CAPACITY";
-
-// Default values for observability configuration
-pub const DEFAULT_AUDIT_LOGGER_QUEUE_CAPACITY: usize = 10000;

crates/config/src/observability/file.rs

@@ -1,28 +0,0 @@
-// Copyright 2024 RustFS Team
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-// RUSTFS_SINKS_FILE_PATH
-pub const ENV_SINKS_FILE_PATH: &str = "RUSTFS_SINKS_FILE_PATH";
-// RUSTFS_SINKS_FILE_BUFFER_SIZE
-pub const ENV_SINKS_FILE_BUFFER_SIZE: &str = "RUSTFS_SINKS_FILE_BUFFER_SIZE";
-// RUSTFS_SINKS_FILE_FLUSH_INTERVAL_MS
-pub const ENV_SINKS_FILE_FLUSH_INTERVAL_MS: &str = "RUSTFS_SINKS_FILE_FLUSH_INTERVAL_MS";
-// RUSTFS_SINKS_FILE_FLUSH_THRESHOLD
-pub const ENV_SINKS_FILE_FLUSH_THRESHOLD: &str = "RUSTFS_SINKS_FILE_FLUSH_THRESHOLD";
-
-pub const DEFAULT_SINKS_FILE_BUFFER_SIZE: usize = 8192;
-
-pub const DEFAULT_SINKS_FILE_FLUSH_INTERVAL_MS: u64 = 1000;
-
-pub const DEFAULT_SINKS_FILE_FLUSH_THRESHOLD: usize = 100;

crates/config/src/observability/kafka.rs

@@ -1,27 +0,0 @@
-// Copyright 2024 RustFS Team
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-// RUSTFS_SINKS_KAFKA_BROKERS
-pub const ENV_SINKS_KAFKA_BROKERS: &str = "RUSTFS_SINKS_KAFKA_BROKERS";
-pub const ENV_SINKS_KAFKA_TOPIC: &str = "RUSTFS_SINKS_KAFKA_TOPIC";
-// batch_size
-pub const ENV_SINKS_KAFKA_BATCH_SIZE: &str = "RUSTFS_SINKS_KAFKA_BATCH_SIZE";
-// batch_timeout_ms
-pub const ENV_SINKS_KAFKA_BATCH_TIMEOUT_MS: &str = "RUSTFS_SINKS_KAFKA_BATCH_TIMEOUT_MS";
-
-// brokers
-pub const DEFAULT_SINKS_KAFKA_BROKERS: &str = "localhost:9092";
-pub const DEFAULT_SINKS_KAFKA_TOPIC: &str = "rustfs-sinks";
-pub const DEFAULT_SINKS_KAFKA_BATCH_SIZE: usize = 100;
-pub const DEFAULT_SINKS_KAFKA_BATCH_TIMEOUT_MS: u64 = 1000;

crates/config/src/observability/mod.rs

@@ -12,12 +12,79 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-mod config;
-mod file;
-mod kafka;
-mod webhook;
+// Observability Keys
 
-pub use config::*;
-pub use file::*;
-pub use kafka::*;
-pub use webhook::*;
+pub const ENV_OBS_ENDPOINT: &str = "RUSTFS_OBS_ENDPOINT";
+pub const ENV_OBS_USE_STDOUT: &str = "RUSTFS_OBS_USE_STDOUT";
+pub const ENV_OBS_SAMPLE_RATIO: &str = "RUSTFS_OBS_SAMPLE_RATIO";
+pub const ENV_OBS_METER_INTERVAL: &str = "RUSTFS_OBS_METER_INTERVAL";
+pub const ENV_OBS_SERVICE_NAME: &str = "RUSTFS_OBS_SERVICE_NAME";
+pub const ENV_OBS_SERVICE_VERSION: &str = "RUSTFS_OBS_SERVICE_VERSION";
+pub const ENV_OBS_ENVIRONMENT: &str = "RUSTFS_OBS_ENVIRONMENT";
+pub const ENV_OBS_LOGGER_LEVEL: &str = "RUSTFS_OBS_LOGGER_LEVEL";
+pub const ENV_OBS_LOG_STDOUT_ENABLED: &str = "RUSTFS_OBS_LOG_STDOUT_ENABLED";
+pub const ENV_OBS_LOG_DIRECTORY: &str = "RUSTFS_OBS_LOG_DIRECTORY";
+pub const ENV_OBS_LOG_FILENAME: &str = "RUSTFS_OBS_LOG_FILENAME";
+pub const ENV_OBS_LOG_ROTATION_SIZE_MB: &str = "RUSTFS_OBS_LOG_ROTATION_SIZE_MB";
+pub const ENV_OBS_LOG_ROTATION_TIME: &str = "RUSTFS_OBS_LOG_ROTATION_TIME";
+pub const ENV_OBS_LOG_KEEP_FILES: &str = "RUSTFS_OBS_LOG_KEEP_FILES";
+
+/// Log pool capacity for async logging
+pub const ENV_OBS_LOG_POOL_CAPA: &str = "RUSTFS_OBS_LOG_POOL_CAPA";
+
+/// Log message capacity for async logging
+pub const ENV_OBS_LOG_MESSAGE_CAPA: &str = "RUSTFS_OBS_LOG_MESSAGE_CAPA";
+
+/// Log flush interval in milliseconds for async logging
+pub const ENV_OBS_LOG_FLUSH_MS: &str = "RUSTFS_OBS_LOG_FLUSH_MS";
+
+/// Default values for log pool
+pub const DEFAULT_OBS_LOG_POOL_CAPA: usize = 10240;
+
+/// Default values for message capacity
+pub const DEFAULT_OBS_LOG_MESSAGE_CAPA: usize = 32768;
+
+/// Default values for flush interval in milliseconds
+pub const DEFAULT_OBS_LOG_FLUSH_MS: u64 = 200;
+
+/// Default values for observability configuration
+// ### Supported Environment Values
+// - `production` - Secure file-only logging
+// - `development` - Full debugging with stdout
+// - `test` - Test environment with stdout support
+// - `staging` - Staging environment with stdout support
+pub const DEFAULT_OBS_ENVIRONMENT_PRODUCTION: &str = "production";
+pub const DEFAULT_OBS_ENVIRONMENT_DEVELOPMENT: &str = "development";
+pub const DEFAULT_OBS_ENVIRONMENT_TEST: &str = "test";
+pub const DEFAULT_OBS_ENVIRONMENT_STAGING: &str = "staging";
+
+#[cfg(test)]
+mod tests {
+    use super::*;
+
+    #[test]
+    fn test_env_keys() {
+        assert_eq!(ENV_OBS_ENDPOINT, "RUSTFS_OBS_ENDPOINT");
+        assert_eq!(ENV_OBS_USE_STDOUT, "RUSTFS_OBS_USE_STDOUT");
+        assert_eq!(ENV_OBS_SAMPLE_RATIO, "RUSTFS_OBS_SAMPLE_RATIO");
+        assert_eq!(ENV_OBS_METER_INTERVAL, "RUSTFS_OBS_METER_INTERVAL");
+        assert_eq!(ENV_OBS_SERVICE_NAME, "RUSTFS_OBS_SERVICE_NAME");
+        assert_eq!(ENV_OBS_SERVICE_VERSION, "RUSTFS_OBS_SERVICE_VERSION");
+        assert_eq!(ENV_OBS_ENVIRONMENT, "RUSTFS_OBS_ENVIRONMENT");
+        assert_eq!(ENV_OBS_LOGGER_LEVEL, "RUSTFS_OBS_LOGGER_LEVEL");
+        assert_eq!(ENV_OBS_LOG_STDOUT_ENABLED, "RUSTFS_OBS_LOG_STDOUT_ENABLED");
+        assert_eq!(ENV_OBS_LOG_DIRECTORY, "RUSTFS_OBS_LOG_DIRECTORY");
+        assert_eq!(ENV_OBS_LOG_FILENAME, "RUSTFS_OBS_LOG_FILENAME");
+        assert_eq!(ENV_OBS_LOG_ROTATION_SIZE_MB, "RUSTFS_OBS_LOG_ROTATION_SIZE_MB");
+        assert_eq!(ENV_OBS_LOG_ROTATION_TIME, "RUSTFS_OBS_LOG_ROTATION_TIME");
+        assert_eq!(ENV_OBS_LOG_KEEP_FILES, "RUSTFS_OBS_LOG_KEEP_FILES");
+    }
+
+    #[test]
+    fn test_default_values() {
+        assert_eq!(DEFAULT_OBS_ENVIRONMENT_PRODUCTION, "production");
+        assert_eq!(DEFAULT_OBS_ENVIRONMENT_DEVELOPMENT, "development");
+        assert_eq!(DEFAULT_OBS_ENVIRONMENT_TEST, "test");
+        assert_eq!(DEFAULT_OBS_ENVIRONMENT_STAGING, "staging");
+    }
+}

crates/config/src/observability/webhook.rs

@@ -1,28 +0,0 @@
-// Copyright 2024 RustFS Team
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//     http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-// RUSTFS_SINKS_WEBHOOK_ENDPOINT
-pub const ENV_SINKS_WEBHOOK_ENDPOINT: &str = "RUSTFS_SINKS_WEBHOOK_ENDPOINT";
-// RUSTFS_SINKS_WEBHOOK_AUTH_TOKEN
-pub const ENV_SINKS_WEBHOOK_AUTH_TOKEN: &str = "RUSTFS_SINKS_WEBHOOK_AUTH_TOKEN";
-// max_retries
-pub const ENV_SINKS_WEBHOOK_MAX_RETRIES: &str = "RUSTFS_SINKS_WEBHOOK_MAX_RETRIES";
-// retry_delay_ms
-pub const ENV_SINKS_WEBHOOK_RETRY_DELAY_MS: &str = "RUSTFS_SINKS_WEBHOOK_RETRY_DELAY_MS";
-
-// Default values for webhook sink configuration
-pub const DEFAULT_SINKS_WEBHOOK_ENDPOINT: &str = "http://localhost:8080";
-pub const DEFAULT_SINKS_WEBHOOK_AUTH_TOKEN: &str = "";
-pub const DEFAULT_SINKS_WEBHOOK_MAX_RETRIES: usize = 3;
-pub const DEFAULT_SINKS_WEBHOOK_RETRY_DELAY_MS: u64 = 100;

crates/config/src/opa/mod.rs

@@ -12,18 +12,10 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-#![allow(dead_code)]
+//opa env vars
+pub const ENV_POLICY_PLUGIN_OPA_URL: &str = "RUSTFS_POLICY_PLUGIN_URL";
+pub const ENV_POLICY_PLUGIN_AUTH_TOKEN: &str = "RUSTFS_POLICY_PLUGIN_AUTH_TOKEN";
 
-// Default value function
-fn default_batch_size() -> usize {
-    10
-}
-fn default_queue_size() -> usize {
-    10000
-}
-fn default_max_retry() -> u32 {
-    5
-}
-fn default_retry_interval() -> std::time::Duration {
-    std::time::Duration::from_secs(3)
-}
+pub const ENV_POLICY_PLUGIN_KEYS: &[&str] = &[ENV_POLICY_PLUGIN_OPA_URL, ENV_POLICY_PLUGIN_AUTH_TOKEN];
+
+pub const POLICY_PLUGIN_SUB_SYS: &str = "policy_plugin";

crates/crypto/src/encdec/tests.rs

@@ -226,7 +226,7 @@ fn test_password_variations() -> Result<(), crate::Error> {
         b"12345".as_slice(),            // Numeric
         b"!@#$%^&*()".as_slice(),       // Special characters
         b"\x00\x01\x02\x03".as_slice(), // Binary password
-        "密码测试".as_bytes(),          // Unicode password
+        "пароль тест".as_bytes(),       // Unicode password
         &[0xFF; 64],                    // Long binary password
     ];