fix: extract release notes template to external file to resolve YAML syntax error (#143 )

fix: add missing OSSUTIL_BIN variable in linux case branch (#141 )
* fix: improve ossutil install logic in GitHub Actions workflow * wip * wip * fix: add missing OSSUTIL_BIN variable in linux case branch
2026-01-17 09:40:32 +00:00 · 2025-07-09 23:07:10 +08:00 · 2025-07-09 22:36:37 +08:00 · 2025-07-09 21:37:38 +08:00 · 2025-07-09 21:04:10 +08:00 · 2025-07-09 20:51:42 +08:00
5 changed files with 124 additions and 97 deletions
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -203,7 +203,7 @@ jobs:
        run: |
          PACKAGE_NAME="rustfs-${{ matrix.target }}"

-                              # Create zip packages for all platforms
+          # Create zip packages for all platforms
          # Ensure zip is available
          if ! command -v zip &> /dev/null; then
            if [[ "${{ matrix.os }}" == "ubuntu-latest" ]]; then
@@ -234,14 +234,40 @@ jobs:
          OSS_ENDPOINT: https://oss-cn-beijing.aliyuncs.com
        run: |
          # Install ossutil (platform-specific)
+          OSSUTIL_VERSION="2.1.1"
          case "${{ matrix.platform }}" in
-            linux|macos)
-              sudo -v ; curl https://gosspublic.alicdn.com/ossutil/install.sh | sudo bash
+            linux)
+              if [[ "$(uname -m)" == "arm64" ]]; then
+                ARCH="arm64"
+              else
+                ARCH="amd64"
+              fi
+              OSSUTIL_ZIP="ossutil-${OSSUTIL_VERSION}-linux-${ARCH}.zip"
+              OSSUTIL_DIR="ossutil-${OSSUTIL_VERSION}-linux-${ARCH}"
+
+              curl -o "$OSSUTIL_ZIP" "https://gosspublic.alicdn.com/ossutil/v2/${OSSUTIL_VERSION}/${OSSUTIL_ZIP}"
+              unzip "$OSSUTIL_ZIP"
+              mv "${OSSUTIL_DIR}/ossutil" /usr/local/bin/
+              rm -rf "$OSSUTIL_DIR" "$OSSUTIL_ZIP"
+              chmod +x /usr/local/bin/ossutil
+              OSSUTIL_BIN=ossutil
+              ;;
+            macos)
+              if [[ "$(uname -m)" == "arm64" ]]; then
+                ARCH="arm64"
+              else
+                ARCH="amd64"
+              fi
+              OSSUTIL_ZIP="ossutil-${OSSUTIL_VERSION}-mac-${ARCH}.zip"
+              OSSUTIL_DIR="ossutil-${OSSUTIL_VERSION}-mac-${ARCH}"
+
+              curl -o "$OSSUTIL_ZIP" "https://gosspublic.alicdn.com/ossutil/v2/${OSSUTIL_VERSION}/${OSSUTIL_ZIP}"
+              unzip "$OSSUTIL_ZIP"
+              mv "${OSSUTIL_DIR}/ossutil" /usr/local/bin/
+              rm -rf "$OSSUTIL_DIR" "$OSSUTIL_ZIP"
+              chmod +x /usr/local/bin/ossutil
              OSSUTIL_BIN=ossutil
              ;;
-            # windows)
-            #   暂不支持 Windows ossutil
-            #   ;;
          esac

          # Upload the package file directly to OSS
@@ -255,7 +281,6 @@ jobs:
            $OSSUTIL_BIN cp latest.json oss://rustfs-version/latest.json --force
          fi

-
  # Release management
  release:
    name: GitHub Release
@@ -379,89 +404,14 @@ jobs:
              ORIGINAL_NOTES="Release ${VERSION_CLEAN}"
            fi

-            # Create comprehensive release notes
-            cat > enhanced_notes.md << EOF
-            ## RustFS ${VERSION_CLEAN}
-
-            ${ORIGINAL_NOTES}
-
-            ---
-
-            ### 🚀 Quick Download
-
-            **Linux (Static Binaries - No Dependencies):**
-            \`\`\`bash
-            # x86_64 (Intel/AMD)
-            curl -LO https://github.com/rustfs/rustfs/releases/download/${VERSION}/rustfs-x86_64-unknown-linux-musl.zip
-            unzip rustfs-x86_64-unknown-linux-musl.zip
-            sudo mv rustfs /usr/local/bin/
-
-            # ARM64 (Graviton, Apple Silicon VMs)
-            curl -LO https://github.com/rustfs/rustfs/releases/download/${VERSION}/rustfs-aarch64-unknown-linux-musl.zip
-            unzip rustfs-aarch64-unknown-linux-musl.zip
-            sudo mv rustfs /usr/local/bin/
-            \`\`\`
-
-            **macOS:**
-            \`\`\`bash
-            # Apple Silicon (M1/M2/M3)
-            curl -LO https://github.com/rustfs/rustfs/releases/download/${VERSION}/rustfs-aarch64-apple-darwin.zip
-            unzip rustfs-aarch64-apple-darwin.zip
-            sudo mv rustfs /usr/local/bin/
-
-            # Intel
-            curl -LO https://github.com/rustfs/rustfs/releases/download/${VERSION}/rustfs-x86_64-apple-darwin.zip
-            unzip rustfs-x86_64-apple-darwin.zip
-            sudo mv rustfs /usr/local/bin/
-            \`\`\`
-
-            ### 📁 Available Downloads
-
-            | Platform | Architecture | File | Description |
-            |----------|-------------|------|-------------|
-            | Linux | x86_64 | \`rustfs-x86_64-unknown-linux-musl.zip\` | Static binary, no dependencies |
-            | Linux | ARM64 | \`rustfs-aarch64-unknown-linux-musl.zip\` | Static binary, no dependencies |
-            | macOS | Apple Silicon | \`rustfs-aarch64-apple-darwin.zip\` | Native binary, ZIP archive |
-            | macOS | Intel | \`rustfs-x86_64-apple-darwin.zip\` | Native binary, ZIP archive |
-
-            ### 🔐 Verification
-
-            Download checksums and verify your download:
-            \`\`\`bash
-            # Download checksums
-            curl -LO https://github.com/rustfs/rustfs/releases/download/${VERSION}/SHA256SUMS
-
-            # Verify (Linux)
-            sha256sum -c SHA256SUMS --ignore-missing
-
-            # Verify (macOS)
-            shasum -a 256 -c SHA256SUMS --ignore-missing
-            \`\`\`
-
-            ### 🛠️ System Requirements
-
-            - **Linux**: Any distribution with glibc 2.17+ (CentOS 7+, Ubuntu 16.04+)
-            - **macOS**: 10.15+ (Catalina or later)
-            - **Windows**: Windows 10 version 1809 or later
-
-            ### 📚 Documentation
-
-            - [Installation Guide](https://github.com/rustfs/rustfs#installation)
-            - [Quick Start](https://github.com/rustfs/rustfs#quick-start)
-            - [Configuration](https://github.com/rustfs/rustfs/blob/main/docs/)
-            - [API Documentation](https://docs.rs/rustfs)
-
-            ### 🆘 Support
-
-            - 🐛 [Report Issues](https://github.com/rustfs/rustfs/issues)
-            - 💬 [Community Discussions](https://github.com/rustfs/rustfs/discussions)
-            - 📖 [Documentation](https://github.com/rustfs/rustfs/tree/main/docs)
-            EOF
+            # Use external template file and substitute variables
+            sed -e "s/\${VERSION}/$VERSION/g" \
+                -e "s/\${VERSION_CLEAN}/$VERSION_CLEAN/g" \
+                -e "s/\${ORIGINAL_NOTES}/$(echo "$ORIGINAL_NOTES" | sed 's/[[\.*^$()+?{|]/\\&/g')/g" \
+                .github/workflows/release-notes-template.md > enhanced_notes.md

            # Update the release with enhanced notes
            gh release edit "$VERSION" --notes-file enhanced_notes.md
          else
            echo "Release $VERSION already has custom notes, skipping update to preserve manual edits"
          fi
-
-
--- a/.github/workflows/release-notes-template.md
+++ b/.github/workflows/release-notes-template.md
@@ -0,0 +1,78 @@
+## RustFS ${VERSION_CLEAN}
+
+${ORIGINAL_NOTES}
+
+---
+
+### 🚀 Quick Download
+
+**Linux (Static Binaries - No Dependencies):**
+
+```bash
+# x86_64 (Intel/AMD)
+curl -LO https://github.com/rustfs/rustfs/releases/download/${VERSION}/rustfs-x86_64-unknown-linux-musl.zip
+unzip rustfs-x86_64-unknown-linux-musl.zip
+sudo mv rustfs /usr/local/bin/
+
+# ARM64 (Graviton, Apple Silicon VMs)
+curl -LO https://github.com/rustfs/rustfs/releases/download/${VERSION}/rustfs-aarch64-unknown-linux-musl.zip
+unzip rustfs-aarch64-unknown-linux-musl.zip
+sudo mv rustfs /usr/local/bin/
+```
+
+**macOS:**
+
+```bash
+# Apple Silicon (M1/M2/M3)
+curl -LO https://github.com/rustfs/rustfs/releases/download/${VERSION}/rustfs-aarch64-apple-darwin.zip
+unzip rustfs-aarch64-apple-darwin.zip
+sudo mv rustfs /usr/local/bin/
+
+# Intel
+curl -LO https://github.com/rustfs/rustfs/releases/download/${VERSION}/rustfs-x86_64-apple-darwin.zip
+unzip rustfs-x86_64-apple-darwin.zip
+sudo mv rustfs /usr/local/bin/
+```
+
+### 📁 Available Downloads
+
+| Platform | Architecture | File | Description |
+|----------|-------------|------|-------------|
+| Linux | x86_64 | `rustfs-x86_64-unknown-linux-musl.zip` | Static binary, no dependencies |
+| Linux | ARM64 | `rustfs-aarch64-unknown-linux-musl.zip` | Static binary, no dependencies |
+| macOS | Apple Silicon | `rustfs-aarch64-apple-darwin.zip` | Native binary, ZIP archive |
+| macOS | Intel | `rustfs-x86_64-apple-darwin.zip` | Native binary, ZIP archive |
+
+### 🔐 Verification
+
+Download checksums and verify your download:
+
+```bash
+# Download checksums
+curl -LO https://github.com/rustfs/rustfs/releases/download/${VERSION}/SHA256SUMS
+
+# Verify (Linux)
+sha256sum -c SHA256SUMS --ignore-missing
+
+# Verify (macOS)
+shasum -a 256 -c SHA256SUMS --ignore-missing
+```
+
+### 🛠️ System Requirements
+
+- **Linux**: Any distribution with glibc 2.17+ (CentOS 7+, Ubuntu 16.04+)
+- **macOS**: 10.15+ (Catalina or later)
+- **Windows**: Windows 10 version 1809 or later
+
+### 📚 Documentation
+
+- [Installation Guide](https://github.com/rustfs/rustfs#installation)
+- [Quick Start](https://github.com/rustfs/rustfs#quick-start)
+- [Configuration](https://github.com/rustfs/rustfs/blob/main/docs/)
+- [API Documentation](https://docs.rs/rustfs)
+
+### 🆘 Support
+
+- 🐛 [Report Issues](https://github.com/rustfs/rustfs/issues)
+- 💬 [Community Discussions](https://github.com/rustfs/rustfs/discussions)
+- 📖 [Documentation](https://github.com/rustfs/rustfs/tree/main/docs)
--- a/5
+++ b/5
@@ -21,10 +21,9 @@ RUN apk add -U --no-cache \
    unzip


-RUN curl -Lo /tmp/rustfs.zip https://dl.rustfs.com/artifacts/rustfs/rustfs-release-x86_64-unknown-linux-musl.latest.zip && \
+RUN curl -Lo /tmp/rustfs.zip https://dl.rustfs.com/artifacts/rustfs/rustfs-x86_64-unknown-linux-musl.zip && \
    unzip -o /tmp/rustfs.zip -d /tmp && \
-    tar -xzf /tmp/rustfs-x86_64-unknown-linux-musl.tar.gz -C /tmp && \
-    mv /tmp/rustfs-x86_64-unknown-linux-musl/bin/rustfs /rustfs && \
+    mv /tmp/rustfs /rustfs && \
    chmod +x /rustfs && \
    rm -rf /tmp/*

--- a/crates/ecstore/src/disk/local.rs
+++ b/crates/ecstore/src/disk/local.rs
@@ -145,8 +145,8 @@ impl Debug for LocalDisk {
 impl LocalDisk {
    pub async fn new(ep: &Endpoint, cleanup: bool) -> Result<Self> {
        debug!("Creating local disk");
-        let root = match fs::canonicalize(ep.get_file_path()).await {
-            Ok(path) => path,
+        let root = match PathBuf::from(ep.get_file_path()).absolutize() {
+            Ok(path) => path.into_owned(),
            Err(e) => {
                if e.kind() == ErrorKind::NotFound {
                    return Err(DiskError::VolumeNotFound);
--- a/crates/ecstore/src/store.rs
+++ b/crates/ecstore/src/store.rs
@@ -2508,14 +2508,14 @@ fn check_object_name_for_length_and_slash(bucket: &str, object: &str) -> Result<

    #[cfg(target_os = "windows")]
    {
-        if object.contains('\\')
-            || object.contains(':')
+        if object.contains(':')
            || object.contains('*')
            || object.contains('?')
            || object.contains('"')
            || object.contains('|')
            || object.contains('<')
            || object.contains('>')
+        // || object.contains('\\')
        {
            return Err(StorageError::ObjectNameInvalid(bucket.to_owned(), object.to_owned()));
        }
@@ -2549,9 +2549,9 @@ fn check_bucket_and_object_names(bucket: &str, object: &str) -> Result<()> {
        return Err(StorageError::ObjectNameInvalid(bucket.to_string(), object.to_string()));
    }

-    if cfg!(target_os = "windows") && object.contains('\\') {
-        return Err(StorageError::ObjectNameInvalid(bucket.to_string(), object.to_string()));
-    }
+    // if cfg!(target_os = "windows") && object.contains('\\') {
+    //     return Err(StorageError::ObjectNameInvalid(bucket.to_string(), object.to_string()));
+    // }

    Ok(())
 }
Author	SHA1	Message	Date
安正超	7d5fc87002	fix: extract release notes template to external file to resolve YAML syntax error (#143 )	2025-07-09 23:07:10 +08:00
安正超	13130e9dd4	fix: add missing OSSUTIL_BIN variable in linux case branch (#141 ) * fix: improve ossutil install logic in GitHub Actions workflow * wip * wip * fix: add missing OSSUTIL_BIN variable in linux case branch	2025-07-09 22:36:37 +08:00
安正超	1061ce11a3	fix: improve ossutil install logic in GitHub Actions workflow (#139 ) * fix: improve ossutil install logic in GitHub Actions workflow * wip * wip	2025-07-09 21:37:38 +08:00
loverustfs	9f9a74000d	Fix dockerfile link error (#138 ) * fix unzip error * fix url change error fix url change error	2025-07-09 21:04:10 +08:00
shiro.lee	d1863018df	Merge pull request #137 from shiroleeee/windows_start fix: troubleshooting startup failure in Windows System	2025-07-09 20:51:42 +08:00
shiro	166080aac8	fix: troubleshooting startup failure in Windows System	2025-07-09 20:32:20 +08:00