From 8ef61ae35e0ecfae9c5a5ae914c4ecd8b579b9a1 Mon Sep 17 00:00:00 2001 From: Stefan Melmuk <509385+stefan0xC@users.noreply.github.com> Date: Tue, 24 Jun 2025 07:30:03 +0200 Subject: [PATCH] Updated Using custom website icons (markdown) --- Using-custom-website-icons.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Using-custom-website-icons.md b/Using-custom-website-icons.md index 0c0f3d0..a2828f9 100644 --- a/Using-custom-website-icons.md +++ b/Using-custom-website-icons.md @@ -20,7 +20,7 @@ If setting `ICON_CACHE_TTL=0` is not an option for you (because you want to get > [!IMPORTANT] By default `ICON_CACHE_TTL` is set to 2592000 seconds so if you don't disable expiration or regularly update the modification time any manually placed icon will be ignored and possible overwritten after 30 days. -If fetching an icon fails (for whatever reason), Vaultwarden will create a `.miss` file in the `ICON_CACHE_FOLDER` and not try fetching an icon again and instead serve an fallback icon instead. The miss file is removed automatically on a new request when the miss file has expired. (Expired in this case means its age is larger than `ICON_CACHE_NEGTTL` seconds which defaults to 3 days.) +If fetching an icon fails (for whatever reason), Vaultwarden will create an (empty) `.miss` file for that domain (e.g. `data/icon_cache/en.wikipedia.org.png.miss`) in the `ICON_CACHE_FOLDER` and not try fetching an icon again for `ICON_CACHE_NEGTTL` and instead serve an fallback icon instead. The miss file is removed automatically on a new request once the miss file has expired. (Expired in this case means its age is larger than `ICON_CACHE_NEGTTL` seconds which defaults to 3 days.) > [!IMPORTANT] As long as there is an `.miss` file (that has not yet expired) Vaultwarden will always serve the fallback icon even if there is a valid icon. So remove the corresponding miss file for any custom icon you have created or which modification time you have updated. @@ -29,4 +29,6 @@ As long as there is an `.miss` file (that has not yet expired) Vaultwarden will If you have not disabled icon download (`DISABLE_ICON_DOWNLOAD`) Vaultwardens `internal` icon service will download the requested icon from a given resource. This is done using a network request to the given domain / ip (disregarding the port). If your Vaultwarden server cannot make outgoing requests (e.g. because of missing internet access) downloading new icons will not work. -By default, Vaultwarden will also [block certain IP ranges](https://github.com/dani-garcia/vaultwarden/blob/9059437c35e35ab8eb7d1d4716bf13eec0a4ee64/src/util.rs#L776-L819) which it considers non-global (i.e. your private network) due to security concerns. You can also further configure which hosts Vaultwarden should block additionally by specifying a `HTTP_REQUEST_BLOCK_REGEX`. \ No newline at end of file +By default, Vaultwarden will also [block certain IP ranges](https://github.com/dani-garcia/vaultwarden/blob/9059437c35e35ab8eb7d1d4716bf13eec0a4ee64/src/util.rs#L776-L819) which it considers non-global (i.e. your private network) due to security concerns. You can also further configure which hosts Vaultwarden should block additionally by specifying a `HTTP_REQUEST_BLOCK_REGEX`. + +If you set `ICON_CACHE_NEGTTL=0` you disable the expiration of the miss indicator which means that Vaultwarden will always serve the default fallback icon for the given domain. \ No newline at end of file