From c0441b2412c4d6493f18e33d791604947e478c47 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=AE=89=E6=AD=A3=E8=B6=85?= Date: Fri, 11 Jul 2025 23:12:58 +0800 Subject: [PATCH] fix: resolve GitHub Actions workflow validation errors in docker.yml (#179) * fix: resolve GitHub Actions workflow validation errors in docker.yml - Fix usage of secrets context in conditional expressions - Add environment variables to build-docker and create-manifest jobs - Replace 'secrets.DOCKERHUB_USERNAME' with 'env.DOCKERHUB_USERNAME' in if conditions - Maintain secure handling of Docker Hub credentials through proper env context * Update .github/workflows/docker.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- .github/workflows/docker.yml | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index 7aab6727..bd59ea78 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -160,6 +160,9 @@ jobs: if: needs.build-check.outputs.should_build == 'true' runs-on: ubuntu-latest timeout-minutes: 60 + env: + DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }} + DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }} strategy: fail-fast: false matrix: @@ -190,11 +193,11 @@ jobs: uses: docker/setup-qemu-action@v3 - name: Login to Docker Hub - if: needs.build-check.outputs.should_push == 'true' && secrets.DOCKERHUB_USERNAME != '' + if: needs.build-check.outputs.should_push == 'true' && env.DOCKERHUB_USERNAME != '' && env.DOCKERHUB_TOKEN != '' uses: docker/login-action@v3 with: - username: ${{ secrets.DOCKERHUB_USERNAME }} - password: ${{ secrets.DOCKERHUB_TOKEN }} + username: ${{ env.DOCKERHUB_USERNAME }} + password: ${{ env.DOCKERHUB_TOKEN }} - name: Login to GitHub Container Registry if: needs.build-check.outputs.should_push == 'true' @@ -326,13 +329,16 @@ jobs: needs: [build-check, build-docker] if: needs.build-check.outputs.should_push == 'true' && needs.build-check.outputs.create_latest == 'true' && needs.build-check.outputs.build_type == 'release' runs-on: ubuntu-latest + env: + DOCKERHUB_USERNAME: ${{ secrets.DOCKERHUB_USERNAME }} + DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }} steps: - name: Login to Docker Hub - if: secrets.DOCKERHUB_USERNAME != '' + if: env.DOCKERHUB_USERNAME != '' uses: docker/login-action@v3 with: - username: ${{ secrets.DOCKERHUB_USERNAME }} - password: ${{ secrets.DOCKERHUB_TOKEN }} + username: ${{ env.DOCKERHUB_USERNAME }} + password: ${{ env.DOCKERHUB_TOKEN }} - name: Login to GitHub Container Registry uses: docker/login-action@v3